[PATCH 0/6] PPP Patches v3

Tue Mar 23 10:16:50 PDT 2010

On Mon, 22 Mar 2010 23:45:14 -0700
Marcel Holtmann <marcel at holtmann.org> wrote:

> please try to keep the code flow inside the functions as simple as
> possible. Otherwise things like this happen.

One suggestion I have for the future is to actually send your patches
to the mailing list for review, even if you've already committed them.
I can understand just committing things without public review for
expediency, but having many eyes looking at things can help as well.