[PATCH 1/2] ppp: allow empty secret for chap challenge
Kristen Carlson Accardi
kristen at linux.intel.com
Fri Mar 26 21:36:49 PDT 2010
Just do a checksum over the identifier if we have an empty password
for our chap secret.
---
gatchat/ppp_auth.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/gatchat/ppp_auth.c b/gatchat/ppp_auth.c
index 6c3913e..95b2f96 100644
--- a/gatchat/ppp_auth.c
+++ b/gatchat/ppp_auth.c
@@ -83,7 +83,8 @@ static void chap_process_challenge(struct auth_data *auth, guint8 *packet)
if (!checksum)
return;
g_checksum_update(checksum, &header->identifier, 1);
- g_checksum_update(checksum, (guchar *) secret, strlen(secret));
+ if (secret)
+ g_checksum_update(checksum, (guchar *) secret, strlen(secret));
g_checksum_update(checksum, &header->data[1], header->data[0]);
/* transmit a response packet */
--
1.6.6.1
More information about the ofono
mailing list