[PATCH 3/4] gatchat: Emit notification when command is sent to modem.

[andrzej zaborowski]

Hi,

On 30 April 2010 07:48, Marcel Holtmann <marcel at holtmann.org> wrote:
>> So I'm fine with the implementation but the name needs work.  Can we use
>> g_at_chat_send_with_submit_notify? Or maybe g_at_chat_send_full, similar to
>> how GLib does it.
>>
>> Perhaps enabling submit_notification for a given command after it has been
>> submitted with g_at_chat_send?
>>
>> e.g. g_at_chat_set_submit_notify(GAtChat *chat, guint command,
>> GAtSubmitNotifyFunc sent, gpointer user_data, GDestroyNotify notify);
>
> I am not a huge fan of the _full() stuff, but it is actually pretty nice
> for the cases where 99% of users don't care. And this seems to be one of
> them. The send_with_submit_notify() is way too long.
>
> Maybe g_at_chat_send_and_notify() is an acceptable simple version for
> this or just g_at_chat_submit() and g_at_chat_send() to keep these
> versions apart.

Here's a patch to add a g_at_chat_set_submit_notify function that
modifies an already submitted command.  Removing the destroy callback
from g_at_chat_send would require changing all the many uses of it.

Regards,
Andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-gatchat-Emit-notification-when-command-is-sent-to-m.patch
Type: text/x-patch
Size: 2935 bytes
Desc: not available
URL: <http://lists.ofono.org/pipermail/ofono/attachments/20100503/b215062b/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-sim-poll-Count-timeout-from-the-moment-STATUS-is-se.patch
Type: text/x-patch
Size: 1526 bytes
Desc: not available
URL: <http://lists.ofono.org/pipermail/ofono/attachments/20100503/b215062b/attachment-0001.bin>