[PATCH] ppp: transition phase to DEAD when lcp finishes

[Kristen Carlson Accardi]

On Mon, 10 May 2010 09:21:37 -0500
Denis Kenzior <denkenz at gmail.com> wrote:

> Hi Kristen,
> 
> > change the state to DEAD when lcp finishes.  This prevents us from
> > calling our disconnect function again if we are already dead.  
> 
> I'm curious under what circumstances tlf gets called on LCP when we're already 
> down?

A timeout after sending a terminate ack causes a tlf and switches us
to the STOPPED state.  disconnect function is called at tlf, and 
disconnect reason correctly set.  Then, our read watcher is destroyed and
we signal down (transitions us to state STARTING) and close (calls tlf
and transitions us to INITIAL).  Disconnect function is called with
disconnect reason set to link dead.