[PATCH 06/11] Made it possible to ask for status report via SendMessage method parameters. True=status report on, false=off.

Denis Kenzior denkenz at gmail.com
Thu May 27 04:51:55 PDT 2010


Hi Aki,

> > -	{ "SendMessage",	"ss",	"",		sms_send_message,
> > +	{ "SendMessage",	"ssb",	"",		sms_send_message,
> >  							G_DBUS_METHOD_FLAG_ASYNC },
> >  	{ }
> >  };
> 
> I don't like this being an argument to SendMessage(). I think it needs
> to be exposed, but as a property instead. Is there a use case for
> setting this per message? I think majority of current phones either
> provide a global setting for this, or set it on by default.
> 

I agree, we should expose this as the 'UseDeliveryReports' property on 
SmsManager or alternatively use a global oFono setting read at startup.

Regards,
-Denis


More information about the ofono mailing list