[PATCH 01/11] In drivers/atmodem/sms.c:at_cmgl_cpms_cb() there is a temporary fix for Siemens TC65. If AT+CMGL=4 is sent to TC65, the AT command queue jams.
Denis Kenzior
denkenz at gmail.com
Fri May 28 09:48:28 PDT 2010
Hi Pasi,
> From: Pasi Miettinen <pasi.miettinen at ixonos.com>
>
> ---
> drivers/atmodem/sms.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
Please keep the header to less than 50 characters. Include the meat of the
description in the commit description itself or the comment in the code.
> diff --git a/drivers/atmodem/sms.c b/drivers/atmodem/sms.c
> index 8049df6..27de77b 100644
> --- a/drivers/atmodem/sms.c
> +++ b/drivers/atmodem/sms.c
> @@ -544,6 +544,10 @@ static void at_cmgl_cb(gboolean ok, GAtResult *result,
> gpointer user_data)
>
> static void at_cmgl_cpms_cb(gboolean ok, GAtResult *result, gpointer
> user_data) {
> +
> + DBG("PASS AT+CMGL=4!!!");
> + return;
> +
Please use the vendor quirks facility. See drivers/atmodem/vendor.h and the
various uses of it in plugins/ and drivers/atmodem. You might have to create
a proper modem driver for the TC65.
Regards,
-Denis
More information about the ofono
mailing list