[PATCH 07/11] Removed Siemens TC65 specific code.
Denis Kenzior
denkenz at gmail.com
Fri May 28 10:15:54 PDT 2010
Hi Pasi,
> From: Pasi Miettinen <pasi.miettinen at ixonos.com>
>
> ---
> drivers/atmodem/sms.c | 3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/atmodem/sms.c b/drivers/atmodem/sms.c
> index a1c885b..adaf4f2 100644
> --- a/drivers/atmodem/sms.c
> +++ b/drivers/atmodem/sms.c
> @@ -561,9 +561,6 @@ static void at_cmgl_cpms_cb(gboolean ok, GAtResult
> *result, gpointer user_data) struct ofono_sms *sms = req->sms;
> struct sms_data *data = ofono_sms_get_data(sms);
>
> - DBG("PASS AT+CMGL=4!!!");
> - return;
> -
> if (!ok) {
> ofono_error("Initial CPMS request failed");
> at_cmgl_done(sms);
>
In the future please don't send patches where one patch adds a piece of code
and a later patch removes it. It is very confusing :)
git rebase --interactive is very helpful tool for restructuring / re-ordering
your patches for submission.
Regards,
-Denis
More information about the ofono
mailing list