February 2021 - connman

by KeithG

Group, I am back. When I tested it last time a couple weeks ago, it worked. When I tested it again yesterday, it failed. I do not know what happened, so I 'started over' to see if I can pinpoint what needs to happen to get connman to reconnect when a wifi SSID is restarted. I am running a Raspberry Pi3b+ with Arch Linux with its onboard brcmfmac adapter. I have a connman git compiled version 1.38.r79.g69e9e250 and iwd r5193.a8768e3 which is later than 1.11 and has specific fixes for the brcmfmac. I have tried later brcmfmac firmware and a later driver with the same result so I have reverted and am using the driver and firmware that ships with arch linux. I wiped all configs from /var/lib/connman and iwd and restarted as a test. My main.conf for connman has only 3 edits from the blank one provided in the package: PreferredTechnologies = ethernet,wifi AllowHostnameUpdates = false AlwaysConnectedTechnologies = ethernet,wifi My iwd main.conf is: [General] UseDefaultInterface=true We create a *.config file and restart the device to configure the wireless. The config file we create has these lines: [global] Description=DHCP PSK Wi-Fi network configuration for network (SSID) "spg3", with SSID hex value "73706733" [service_73706733] Type=wifi SSID=73706733 Security=psk Passphrase=password Hidden=false When it reboots, if we check the connman service, it looks like this: # connmanctl services wifi_b827eb52ccd0_73706733_managed_psk /net/connman/service/wifi_b827eb52ccd0_73706733_managed_psk Type = wifi Security = [ psk ] State = online Strength = 48 Favorite = True Immutable = True AutoConnect = True Name = spg3 Ethernet = [ Method=auto, Interface=wlan0, Address=B8:27:EB:52:CC:D0, MTU=1500 ] IPv4 = [ Method=dhcp, Address=192.168.2.41, Netmask=255.255.255.0, Gateway=192.168.2.1 ] IPv4.Configuration = [ Method=dhcp ] IPv6 = [ Method=auto, Address=fd21:98c8:1d28:0:ba27:ebff:fe52:ccd0, PrefixLength=64, Privacy=disabled ] IPv6.Configuration = [ Method=auto, Address=fd21:98c8:1d28::41, PrefixLength=64, Privacy=disabled ] Nameservers = [ 2600:1700:4320:6caf:ba27:ebff:fe0b:9be6, 192.168.2.3, 2600:1700:4320:6caf:ba27:ebff:fe0b:9be6 ] Nameservers.Configuration = [ ] Timeservers = [ ] Timeservers.Configuration = [ ] Domains = [ lan ] Domains.Configuration = [ ] Proxy = [ Method=direct ] Proxy.Configuration = [ ] mDNS = False mDNS.Configuration = False Provider = [ ] but the iwctl shows this: # iwctl known-networks spg3 show Known Network: spg3 -------------------------------------------------------------------------------- Settable Property Value -------------------------------------------------------------------------------- Name spg3 Hidden * AutoConnect no I cannot change this through the iwctl interface: # iwctl known-networks spg3 set-property AutoConnect true # iwctl known-networks spg3 show Known Network: spg3 -------------------------------------------------------------------------------- Settable Property Value -------------------------------------------------------------------------------- Name spg3 Hidden * AutoConnect no If I force a disconnect by rebooting, restarting the radio or disconnecting from the router UI, the same thing happens as before. The disconnection happens and no scanning occurs and it will never reconnect. The journal shows the deletion of the interface addresses and iwd-monitor or connman-monitor shows no activity. I restart iwd, and it immediately reconnects. If I check the iwctl now, it shows "AutoConnect yes", so it appears it gets fixed when iwd was restarted: # iwctl known-networks spg3 show Known Network: spg3 -------------------------------------------------------------------------------- Settable Property Value -------------------------------------------------------------------------------- Name spg3 Hidden * AutoConnect yes If I try this again, by restarting the radio on the router, I get the same response in the journal. no scanning ever occurs. if I look at monitor-iwd, monitor-connman or the journalctl no scanning happens. I have verified that iwd works fine in standalone mode (internal dhcp) or with dhcpcd. If I perform the same test, it reconnects in < 2 minutes every time. Also in the log it shows that iwd starts scanning very soon after it is disconnected and finds the SSID and reconnects (like all my other wifi devices). I really want connman to work for this project and especially now that tethering works with the brcmfmac driver. What can I do to log or help to figure out what is going on? Keith

2 days, 17 hours

2
1
0 / 0

Re: [PATCH] service: Add online to ready transition feature

by Daniel Wagner

Hi Emmanuel, On Mon, Feb 15, 2021 at 04:56:50PM +0000, VAUTRIN Emmanuel (Canal Plus Prestataire) wrote: > WARNING: Experimental feature!!! > Global config option, which allows keeping calling the online check > request to guarantee that end-to-end connectivity is still successful. > If not, the default service transitions to READY state, enabling another > service to become the default one, in replacement. Can you resend, maybe attach it, as the patch seemed to be whitespace damaged. I wanted to test it for a while :) Thanks, Daniel

2 weeks, 1 day

1
1
0 / 0

RE: DBus connection to VPN in 1.39

by VAUTRIN Emmanuel (Canal Plus Prestataire)

Hello Andrew, Have you tried with the latest version? It is possible that the commit "wifi: Check valid network in disconnect callback" fixes your problem, introduced by "wifi: Always disconnect connection completely", between 1.38 & 1.39. Best Regards, Emmanuel De : Andrew Bibb <ajbibb(a)outlook.com> Envoyé : samedi 27 février 2021 14:58 À : connman(a)lists.01.org <connman(a)lists.01.org> Objet : DBus connection to VPN in 1.39 I've run across a problem that I think is DBus related in version 1.39. I can provision a VPN service without issue. I can also manually connect and disconnect from the newly provisioned service without issue using the Services Connect() and Services Disconnect() methods. When I then try to use the Services SetProperty(AutoConnect) method on the VPN service the following error is returned "Message recipient disconnected from message bus without replying". Trying with connmanctl config --autoconnect results in the same error. This used to work so to check I downgraded Connman from 1.39 to 1.38 and after doing that I can toggle AutoConnect for VPN on and off without issue using the Services SetProperty(AutoConnect) method. This is on an Arch Linux system so the thing I don't know is if it is Arch related or Connman related. If this is something at the Connman end I'll do what I can to help. I really don't know C, but I'll try. Thank you Andrew Bibb _______________________________________________ connman mailing list -- connman(a)lists.01.org To unsubscribe send an email to connman-leave(a)lists.01.org

1 month, 1 week

1
0
0 / 0

DBus connection to VPN in 1.39

by Andrew Bibb

I've run across a problem that I think is DBus related in version 1.39. I can provision a VPN service without issue. I can also manually connect and disconnect from the newly provisioned service without issue using the Services Connect() and Services Disconnect() methods. When I then try to use the Services SetProperty(AutoConnect) method on the VPN service the following error is returned "Message recipient disconnected from message bus without replying". Trying with connmanctl config --autoconnect results in the same error. This used to work so to check I downgraded Connman from 1.39 to 1.38 and after doing that I can toggle AutoConnect for VPN on and off without issue using the Services SetProperty(AutoConnect) method. This is on an Arch Linux system so the thing I don't know is if it is Arch related or Connman related. If this is something at the Connman end I'll do what I can to help. I really don't know C, but I'll try. Thank you Andrew Bibb

1 month, 1 week

1
0
0 / 0

[PATCH] service: Fix integer type for online check interval

by Daniel Wagner

Make all online check interval varables unsigned int to avoid comparing int with unsinged int. --- src/service.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/service.c b/src/service.c index 99a52022b80b..dfb5a93c22ec 100644 --- a/src/service.c +++ b/src/service.c @@ -136,8 +136,8 @@ struct connman_service { bool wps; bool wps_advertizing; guint online_timeout; - int online_check_interval_ipv4; - int online_check_interval_ipv6; + unsigned int online_check_interval_ipv4; + unsigned int online_check_interval_ipv6; bool do_split_routing; bool new_service; bool hidden_service; @@ -6260,7 +6260,7 @@ int __connman_service_online_check_failed(struct connman_service *service, enum connman_ipconfig_type type) { GSourceFunc redo_func; - int *interval; + unsigned int *interval; if (type == CONNMAN_IPCONFIG_TYPE_IPV4) { interval = &service->online_check_interval_ipv4; -- 2.30.1

1 month, 2 weeks

1
1
0 / 0

[PATCH] service: Add online to ready transition feature

by VAUTRIN Emmanuel (Canal Plus Prestataire)

WARNING: Experimental feature!!! Global config option, which allows keeping calling the online check request to guarantee that end-to-end connectivity is still successful. If not, the default service transitions to READY state, enabling another service to become the default one, in replacement. --- doc/connman.conf.5.in | 13 +++++++++++++ src/connman.h | 5 +++-- src/main.c | 15 +++++++++++++++ src/main.conf | 12 ++++++++++++ src/service.c | 27 +++++++++++++++++++++++---- src/wispr.c | 19 ++++++++++++------- 6 files changed, 78 insertions(+), 13 deletions(-) diff --git a/doc/connman.conf.5.in b/doc/connman.conf.5.in index 19e6e0c0950d..2e06b3ef1f3c 100644 --- a/doc/connman.conf.5.in +++ b/doc/connman.conf.5.in @@ -175,6 +175,19 @@ between OnlineCheckInitialInterval and OnlineCheckMaxInterval. Default range is [1, 12], corresponding to the following intervals, in seconds: 1, 4, 9, 16, 25, 36, 49, 64, 81, 100, 121 and 144. .TP +.BI EnableOnlineToReadyTransition=true\ \fR|\fB\ false +WARNING: Experimental feature!!! +In addition to EnableOnlineCheck setting, enable or disable use of HTTP GET +to detect the loss of end-to-end connectivity. +If this setting is false, when the default service transitions to ONLINE +state, the HTTP GET request is no more called until next cycle, initiated +by a transition of the default service to DISCONNECT state. +If this setting is true, the HTTP GET request keeps beeing called to guarantee +that end-to-end connectivity is still successful. If not, the default service +will transition to READY state, enabling another service to become the +default one, in replacement. +Default value is false. +.TP .BI AutoConnectRoamingServices=true\ \fR|\fB\ false Automatically connect roaming services. This is not recommended unless you know you won't have any billing problem. diff --git a/src/connman.h b/src/connman.h index a43a6b8bcd7a..59a78d9a666b 100644 --- a/src/connman.h +++ b/src/connman.h @@ -729,8 +729,9 @@ int __connman_service_set_mdns(struct connman_service *service, void __connman_service_set_string(struct connman_service *service, const char *key, const char *value); -int __connman_service_online_check_failed(struct connman_service *service, - enum connman_ipconfig_type type); +void __connman_service_online_check(struct connman_service *service, + enum connman_ipconfig_type type, + bool success); int __connman_service_ipconfig_indicate_state(struct connman_service *service, enum connman_service_state new_state, enum connman_ipconfig_type type); diff --git a/src/main.c b/src/main.c index 6835241525e2..8bd44ba18027 100644 --- a/src/main.c +++ b/src/main.c @@ -96,6 +96,7 @@ static struct { bool enable_6to4; char *vendor_class_id; bool enable_online_check; + bool enable_online_to_ready_transition; unsigned int online_check_initial_interval; unsigned int online_check_max_interval; bool auto_connect_roaming_services; @@ -120,6 +121,7 @@ static struct { .enable_6to4 = false, .vendor_class_id = NULL, .enable_online_check = true, + .enable_online_to_ready_transition = false, .online_check_initial_interval = DEFAULT_ONLINE_CHECK_INITIAL_INTERVAL, .online_check_max_interval = DEFAULT_ONLINE_CHECK_MAX_INTERVAL, .auto_connect_roaming_services = false, @@ -145,6 +147,7 @@ static struct { #define CONF_ENABLE_6TO4 "Enable6to4" #define CONF_VENDOR_CLASS_ID "VendorClassID" #define CONF_ENABLE_ONLINE_CHECK "EnableOnlineCheck" +#define CONF_ENABLE_ONLINE_TO_READY_TRANSITION "EnableOnlineToReadyTransition" #define CONF_ONLINE_CHECK_INITIAL_INTERVAL "OnlineCheckInitialInterval" #define CONF_ONLINE_CHECK_MAX_INTERVAL "OnlineCheckMaxInterval" #define CONF_AUTO_CONNECT_ROAMING_SERVICES "AutoConnectRoamingServices" @@ -170,6 +173,7 @@ static const char *supported_options[] = { CONF_ENABLE_6TO4, CONF_VENDOR_CLASS_ID, CONF_ENABLE_ONLINE_CHECK, + CONF_ENABLE_ONLINE_TO_READY_TRANSITION, CONF_ONLINE_CHECK_INITIAL_INTERVAL, CONF_ONLINE_CHECK_MAX_INTERVAL, CONF_AUTO_CONNECT_ROAMING_SERVICES, @@ -474,6 +478,14 @@ static void parse_config(GKeyFile *config) g_clear_error(&error); + boolean = __connman_config_get_bool(config, "General", + CONF_ENABLE_ONLINE_TO_READY_TRANSITION, &error); + if (!error) { + connman_settings.enable_online_to_ready_transition = boolean; + } + + g_clear_error(&error); + integer = g_key_file_get_integer(config, "General", CONF_ONLINE_CHECK_INITIAL_INTERVAL, &error); if (!error && integer >= 0) @@ -729,6 +741,9 @@ bool connman_setting_get_bool(const char *key) if (g_str_equal(key, CONF_ENABLE_ONLINE_CHECK)) return connman_settings.enable_online_check; + if (g_str_equal(key, CONF_ENABLE_ONLINE_TO_READY_TRANSITION)) + return connman_settings.enable_online_to_ready_transition; + if (g_str_equal(key, CONF_AUTO_CONNECT_ROAMING_SERVICES)) return connman_settings.auto_connect_roaming_services; diff --git a/src/main.conf b/src/main.conf index 83cd20f6159d..7065a3203d3a 100644 --- a/src/main.conf +++ b/src/main.conf @@ -134,6 +134,18 @@ # OnlineCheckInitialInterval = 1 # OnlineCheckMaxInterval = 12 +# WARNING: Experimental feature!!! +# In addition to EnableOnlineCheck setting, enable or disable use of HTTP GET +# to detect the loss of end-to-end connectivity. +# If this setting is false, when the default service transitions to ONLINE +# state, the HTTP GET request is no more called until next cycle, initiated +# by a transition of the default service to DISCONNECT state. +# If this setting is true, the HTTP GET request keeps beeing called to guarantee +# that end-to-end connectivity is still successful. If not, the default service +# will transition to READY state, enabling another service to become the +# default one, in replacement. +# EnableOnlineToReadyTransition = false + # List of technologies with AutoConnect = true which are always connected # regardless of PreferredTechnologies setting. Default value is empty and # will connect a technology only if it is at a higher preference than any diff --git a/src/service.c b/src/service.c index 99a52022b80b..c330700d61c8 100644 --- a/src/service.c +++ b/src/service.c @@ -54,6 +54,7 @@ static unsigned int autoconnect_id = 0; static unsigned int vpn_autoconnect_id = 0; static struct connman_service *current_default = NULL; static bool services_dirty = false; +static bool enable_online_to_ready_transition = false; static unsigned int online_check_initial_interval = 0; static unsigned int online_check_max_interval = 0; @@ -1450,6 +1451,8 @@ static void start_online_check(struct connman_service *service, "Default service remains in READY state."); return; } + enable_online_to_ready_transition = + connman_setting_get_bool("EnableOnlineToReadyTransition"); online_check_initial_interval = connman_setting_get_uint("OnlineCheckInitialInterval"); online_check_max_interval = @@ -6256,11 +6259,13 @@ static gboolean redo_wispr_ipv6(gpointer user_data) return FALSE; } -int __connman_service_online_check_failed(struct connman_service *service, - enum connman_ipconfig_type type) +void __connman_service_online_check(struct connman_service *service, + enum connman_ipconfig_type type, + bool success) { GSourceFunc redo_func; int *interval; + enum connman_service_state current_state; if (type == CONNMAN_IPCONFIG_TYPE_IPV4) { interval = &service->online_check_interval_ipv4; @@ -6270,6 +6275,22 @@ int __connman_service_online_check_failed(struct connman_service *service, redo_func = redo_wispr_ipv6; } + if(!enable_online_to_ready_transition) + goto redo_func; + + if (success) { + *interval = online_check_max_interval; + } else { + current_state = service->state; + downgrade_state(service); + if (current_state != service->state) + *interval = online_check_initial_interval; + if (service != connman_service_get_default()) { + return; + } + } + +redo_func: DBG("service %p type %s interval %d", service, __connman_ipconfig_type2string(type), *interval); @@ -6281,8 +6302,6 @@ int __connman_service_online_check_failed(struct connman_service *service, */ if (*interval < online_check_max_interval) (*interval)++; - - return EAGAIN; } int __connman_service_ipconfig_indicate_state(struct connman_service *service, diff --git a/src/wispr.c b/src/wispr.c index b107f9291ac4..27f5dc13f4a2 100644 --- a/src/wispr.c +++ b/src/wispr.c @@ -96,6 +96,8 @@ static bool wispr_portal_web_result(GWebResult *result, gpointer user_data); static GHashTable *wispr_portal_list = NULL; +static bool enable_online_to_ready_transition = false; + static void connman_wispr_message_init(struct connman_wispr_message *msg) { DBG(""); @@ -450,10 +452,14 @@ static void portal_manage_status(GWebResult *result, &str)) connman_info("Client-Timezone: %s", str); - free_connman_wispr_portal_context(wp_context); + if (!enable_online_to_ready_transition) + free_connman_wispr_portal_context(wp_context); __connman_service_ipconfig_indicate_state(service, CONNMAN_SERVICE_STATE_ONLINE, type); + + if (enable_online_to_ready_transition) + __connman_service_online_check(service, type, true); } static bool wispr_route_request(const char *address, int ai_family, @@ -773,12 +779,8 @@ static bool wispr_portal_web_result(GWebResult *result, gpointer user_data) goto done; case 400: case 404: - if (__connman_service_online_check_failed(wp_context->service, - wp_context->type) == 0) { - wispr_portal_error(wp_context); - free_connman_wispr_portal_context(wp_context); - return false; - } + __connman_service_online_check(wp_context->service, + wp_context->type, false); break; case 505: @@ -1029,6 +1031,9 @@ int __connman_wispr_init(void) g_direct_equal, NULL, free_connman_wispr_portal); + enable_online_to_ready_transition = + connman_setting_get_bool("EnableOnlineToReadyTransition"); + return 0; } -- 2.25.1

1 month, 3 weeks

1
0
0 / 0

Re: [PATCH] service: Revert GetProperties deprecation

by Daniel Wagner

On Mon, Feb 15, 2021 at 09:29:52AM +0000, VAUTRIN Emmanuel (Canal Plus Prestataire) wrote: > The commentary "Use the Manager.GetServices() method instead." > can be misunderstood, as it does not mention that the client shall > only do one initial call to GetServices and trigger PropertyChanged or > ServicesChanged signals to update a local Services properties database. > For project matter, we will continue to use the GetProperties(), by our side, > but the patch is irrelevant. Ah, yes, the documentation could indeed be a bit more clearer on how to use it.... added the todo list....

1 month, 3 weeks

1
0
0 / 0

Re: [PATCH] service: Revert GetProperties deprecation

by Daniel Wagner

Hi Emmanuel, On Fri, Feb 12, 2021 at 06:52:10PM +0000, VAUTRIN Emmanuel (Canal Plus Prestataire) wrote: > Service GetProperties method is perfect to retrieve properties of a > single service and needs to be restored, to avoid processing and > transferring big amount of data that will be useless in this case. The reason GetProperty is marked as deprecated is that you don't need it with GetProperties(). Your client should use GetProperties() once at boot up to get the complete state and then just listen to properties change events. The problem using GetProperty() is that the client gets easily out of sync with the states. Daniel

1 month, 3 weeks

2
1
0 / 0

Re: [PATCH 1/2] service: Add online check interval config options

by Daniel Wagner

On Fri, Feb 05, 2021 at 08:52:54PM +0000, VAUTRIN Emmanuel (Canal Plus Prestataire) wrote: > Global config options, which allow to set the range of intervals > between two online check requests. > When an online check request fails, another one is triggered after a > longer interval. The intervals follow the power of two series of numbers > between OnlineCheckInitialInterval and OnlineCheckMaxInterval. > Default range is [1, 12], corresponding to the following intervals, in > seconds: 1, 4, 9, 16, 25, 36, 49, 64, 81, 100, 121 and 144. Patch applied. Thanks, Daniel

1 month, 3 weeks

1
0
0 / 0

Re: [PATCH] wifi: Reset disconnecting status of any network

by Daniel Wagner

On Wed, Feb 10, 2021 at 08:25:49AM +0000, VAUTRIN Emmanuel (Canal Plus Prestataire) wrote: > To avoid staying stuck in "Operation aborted" error state when > connecting, the disconnecting status shall be reset by each disconnect > callback, whatever network is involved, even if not previously > connected. > > Fixes: dd86f09107e8 ("wifi: Always disconnect connection completely") Patch applied. Thanks, Daniel

1 month, 3 weeks

1
0
0 / 0

2021

2020

2019

2018

2017

2016

2015

connman February 2021