Returning -1 in a function with bool as return value is the same as returning true. Change to false to indicate error if inet_aton() fails. --- I tried sending this a few weeks ago but it didn't seem to reach the mailing list, perhaps because I wasn't subscribed? src/inet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/inet.c b/src/inet.c index 0d3f0d21..28cdb961 100644 --- a/src/inet.c +++ b/src/inet.c @@ -1080,7 +1080,7 @@ bool connman_inet_compare_subnet(int index, const char *host) return false; if (inet_aton(host, &_host_addr) == 0) - return -1; + return false; host_addr = _host_addr.s_addr; sk = socket(PF_INET, SOCK_DGRAM | SOCK_CLOEXEC, 0); -- 2.19.1