10:20 a.m.
Set LANG and LC_ALL to C locale for each task used to run VPN processes.
This ensures that no translations are used.
The user for running VPN process can be changed with DACPrivileges
configuration (see commit 171989601a7a4fadafda20a7e6d30e9ada3fb516). If
the user is changed to other than what connman is ran with a specific
language may have been set. Plugins relying on correct output would fail in
such case.
---
vpn/plugins/vpn.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/vpn/plugins/vpn.c b/vpn/plugins/vpn.c
index eef8550e..16946c80 100644
--- a/vpn/plugins/vpn.c
+++ b/vpn/plugins/vpn.c
@@ -624,6 +624,15 @@ static int vpn_connect(struct vpn_provider *provider,
goto exist_err;
}
+ /*
+ * Change to use C locale, some VPN plugins use screen scraping for
+ * error parsing. To be on the safe side, set both LANG and LC_ALL.
+ * This is required especially when the VPN processes are ran using
+ * user other than root.
+ */
+ connman_task_add_variable(data->task,"LANG", "C");
+ connman_task_add_variable(data->task,"LC_ALL", "C");
+
ret = vpn_driver_data->vpn_driver->connect(provider, data->task,
data->if_name, cb, dbus_sender,
user_data);
--
2.20.1
10:28 a.m.
I suspect this is going to break anything using non-ASCII passwords. OpenConnect is not
designed to be screen-scraped. As discussed, it has interfaces which *are* designed to be
used in this circumstance.
On 24 October 2019 11:20:23 BST, Jussi Laakkonen <jussi.laakkonen(a)jolla.com> wrote:
Set LANG and LC_ALL to C locale for each task used to run VPN
processes.
This ensures that no translations are used.
The user for running VPN process can be changed with DACPrivileges
configuration (see commit 171989601a7a4fadafda20a7e6d30e9ada3fb516). If
the user is changed to other than what connman is ran with a specific
language may have been set. Plugins relying on correct output would
fail in
such case.
---
vpn/plugins/vpn.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/vpn/plugins/vpn.c b/vpn/plugins/vpn.c
index eef8550e..16946c80 100644
--- a/vpn/plugins/vpn.c
+++ b/vpn/plugins/vpn.c
@@ -624,6 +624,15 @@ static int vpn_connect(struct vpn_provider
*provider,
goto exist_err;
}
+ /*
+ * Change to use C locale, some VPN plugins use screen scraping for
+ * error parsing. To be on the safe side, set both LANG and LC_ALL.
+ * This is required especially when the VPN processes are ran using
+ * user other than root.
+ */
+ connman_task_add_variable(data->task,"LANG", "C");
+ connman_task_add_variable(data->task,"LC_ALL", "C");
+
ret = vpn_driver_data->vpn_driver->connect(provider, data->task,
data->if_name, cb, dbus_sender,
user_data);
--
2.20.1
_______________________________________________
connman mailing list -- connman(a)lists.01.org
To unsubscribe send an email to connman-leave(a)lists.01.org
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
10:34 a.m.
New subject: [PATCH] vpn: Set to use C locale with tasks used for running VPN
processes
Hi David,
On 10/24/19 1:28 PM, David Woodhouse wrote:
I suspect this is going to break anything using non-ASCII passwords.
OpenConnect is not designed to be screen-scraped. As discussed, it has
interfaces which *are* designed to be used in this circumstance.
Thanks for raising this concern. It may be indeed that this should be
applied only for the VPNC plugin, as it clearly states that content is
to be in ASCII mode. I thought I get best input here. Thanks.
I'll change this to set the LANG/LC_ALL only with VPNC plugin. The
OpenConnect change is in the works as we speak.
BR,
Jussi
11 a.m.
New subject: [PATCH v2] vpnc: Set to use C locale prior to running the task
Set LANG and LC_ALL to C locale for the VPNC process. This ensures that
no translations are used. VPNC relies on errors printed to stderr, and
having translated content makes plugin fail. All VPNC options are ASCII
string according to specifiation.
The user for running VPN process can be changed with DACPrivileges
configuration (see commit 171989601a7a4fadafda20a7e6d30e9ada3fb516). If
the user is changed to other than what connman is ran with a specific
language may have been set.
---
Changes since V2:
* Set LANG and LC_ALL only for VPNC plugin. It may be too risky to set
this for all plugins by default, hence the potential breakage of non-
ASCII passwords noted by David Woodhouse.
vpn/plugins/vpnc.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/vpn/plugins/vpnc.c b/vpn/plugins/vpnc.c
index 8927a6f7..632e680f 100644
--- a/vpn/plugins/vpnc.c
+++ b/vpn/plugins/vpnc.c
@@ -450,6 +450,15 @@ static int run_connect(struct vc_private_data *data)
DBG("provider %p task %p interface %s user_data %p", provider, task,
if_name, data->user_data);
+ /*
+ * Change to use C locale, options should be in ASCII according to
+ * documentation. To be on the safe side, set both LANG and LC_ALL.
+ * This is required especially when the VPNC processe is ran using an
+ * user other than root.
+ */
+ connman_task_add_variable(task,"LANG", "C");
+ connman_task_add_variable(task,"LC_ALL", "C");
+
connman_task_add_argument(task, "--non-inter", NULL);
connman_task_add_argument(task, "--no-detach", NULL);
--
2.20.1
10:28 a.m.
New subject: [PATCH v2] vpnc: Set to use C locale prior to running the task
Hi Jussi,
On Thu, Oct 24, 2019 at 02:00:30PM +0300, Jussi Laakkonen wrote:
Set LANG and LC_ALL to C locale for the VPNC process. This ensures
that
no translations are used. VPNC relies on errors printed to stderr, and
having translated content makes plugin fail. All VPNC options are ASCII
string according to specifiation.
The user for running VPN process can be changed with DACPrivileges
configuration (see commit 171989601a7a4fadafda20a7e6d30e9ada3fb516). If
the user is changed to other than what connman is ran with a specific
language may have been set.
---
Changes since V2:
* Set LANG and LC_ALL only for VPNC plugin. It may be too risky to set
this for all plugins by default, hence the potential breakage of non-
ASCII passwords noted by David Woodhouse.
Patch applied.
Thanks,
Daniel
485
days inactive
494
days old
4 comments
3 participants
participants (3)
-
Daniel Wagner -
David Woodhouse -
Jussi Laakkonen