10:28 p.m.
he issue has been discovered during work on other issue
https://lists.01.org/pipermail/connman/2018-November/023085.html
If connman does ACTIVE scan without adding a list of SSIDs
interface_scan_params() in gsupplicant/supplicant.c calls
supplicant_dbus_dict_append_array(&dict, "SSIDs",
DBUS_TYPE_STRING,
append_ssids,
data->scan_params);
which creates an empty entry for "SSIDs" without anything inside.
This dbus msg goes to wpa supplicant to dbus/dbus_new_handles.c to
wpas_dbus_handler_scan() which calls wpas_dbus_get_scan_ssids() because
there is an entry "SSIDs".
Unfortunately wpas_dbus_get_scan_ssids() fails with an error.
Here are my logs:
Nov 17 03:09:10 LogiCircle daemon.debug wpa_supplicant[344]:
wpas_dbus_get_scan_ssids[dbus]: ssids must be an array of arrays of bytes
Nov 17 03:09:10 LogiCircle daemon.debug wpa_supplicant[344]:
wpas_dbus_get_scan_ssids[dbus]: ssids must be an array of arrays of bytes
Nov 17 03:09:10 LogiCircle daemon.debug wpa_supplicant[344]:
wpas_dbus_get_scan_ssids[dbus]: ssids must be an array of arrays of bytes
Nov 17 03:17:06 LogiCircle daemon.debug wpa_supplicant[344]:
wpas_dbus_get_scan_ssids[dbus]: ssids must be an array of arrays of bytes
Nov 17 03:17:06 LogiCircle daemon.debug wpa_supplicant[344]:
wpas_dbus_get_scan_ssids[dbus]: ssids must be an array of arrays of bytes
Nov 17 03:17:06 LogiCircle daemon.debug wpa_supplicant[344]:
wpas_dbus_get_scan_ssids[dbus]: ssids must be an array of arrays of bytes
The patch below is very simple. If there is no SSID in scan_parameters do
not create "SSIDs". The adjacent function supplicant_add_scan_frequency()
does such verification and does not create any empty "Channels".
==============================
diff --git a/gsupplicant/supplicant.c b/gsupplicant/supplicant.c
index 0cb621b9..92941c63 100644
--- a/gsupplicant/supplicant.c
+++ b/gsupplicant/supplicant.c
@@ -4241,11 +4241,13 @@ static void interface_scan_params(DBusMessageIter
*iter, void *user_data)
supplicant_dbus_dict_append_basic(&dict, "Type",
DBUS_TYPE_STRING, &type);
- supplicant_dbus_dict_append_array(&dict, "SSIDs",
- DBUS_TYPE_STRING,
- append_ssids,
- data->scan_params);
+ if (data->scan_params->ssids) {
+ supplicant_dbus_dict_append_array(&dict, "SSIDs",
+ DBUS_TYPE_STRING,
+ append_ssids,
+ data->scan_params);
+ }
supplicant_add_scan_frequency(&dict, add_scan_frequencies,
data->scan_params);
} else
PS. I sent this patch from other unregistered email. I hope there is not
going to be any duplicate.
5:42 a.m.
Hi,
On Tue, Nov 20, 2018 at 02:28:46PM -0800, Володимир Остап wrote:
he issue has been discovered during work on other issue
https://lists.01.org/pipermail/connman/2018-November/023085.html
If connman does ACTIVE scan without adding a list of SSIDs
interface_scan_params() in gsupplicant/supplicant.c calls
supplicant_dbus_dict_append_array(&dict, "SSIDs",
DBUS_TYPE_STRING,
append_ssids,
data->scan_params);
which creates an empty entry for "SSIDs" without anything inside.
This dbus msg goes to wpa supplicant to dbus/dbus_new_handles.c to
wpas_dbus_handler_scan() which calls wpas_dbus_get_scan_ssids() because
there is an entry "SSIDs".
Unfortunately wpas_dbus_get_scan_ssids() fails with an error.
Here are my logs:
Nov 17 03:09:10 LogiCircle daemon.debug wpa_supplicant[344]:
wpas_dbus_get_scan_ssids[dbus]: ssids must be an array of arrays of bytes
Nov 17 03:09:10 LogiCircle daemon.debug wpa_supplicant[344]:
wpas_dbus_get_scan_ssids[dbus]: ssids must be an array of arrays of bytes
Nov 17 03:09:10 LogiCircle daemon.debug wpa_supplicant[344]:
wpas_dbus_get_scan_ssids[dbus]: ssids must be an array of arrays of bytes
Nov 17 03:17:06 LogiCircle daemon.debug wpa_supplicant[344]:
wpas_dbus_get_scan_ssids[dbus]: ssids must be an array of arrays of bytes
Nov 17 03:17:06 LogiCircle daemon.debug wpa_supplicant[344]:
wpas_dbus_get_scan_ssids[dbus]: ssids must be an array of arrays of bytes
Nov 17 03:17:06 LogiCircle daemon.debug wpa_supplicant[344]:
wpas_dbus_get_scan_ssids[dbus]: ssids must be an array of arrays of bytes
The patch below is very simple. If there is no SSID in scan_parameters do
not create "SSIDs". The adjacent function supplicant_add_scan_frequency()
does such verification and does not create any empty "Channels".
Also add which wpa_supplicant version you used to test in the commit
message (see below what I mean with the commit message).
==============================
diff --git a/gsupplicant/supplicant.c b/gsupplicant/supplicant.c
index 0cb621b9..92941c63 100644
--- a/gsupplicant/supplicant.c
+++ b/gsupplicant/supplicant.c
@@ -4241,11 +4241,13 @@ static void interface_scan_params(DBusMessageIter
*iter, void *user_data)
supplicant_dbus_dict_append_basic(&dict, "Type",
DBUS_TYPE_STRING, &type);
- supplicant_dbus_dict_append_array(&dict, "SSIDs",
- DBUS_TYPE_STRING,
- append_ssids,
- data->scan_params);
+ if (data->scan_params->ssids) {
+ supplicant_dbus_dict_append_array(&dict, "SSIDs",
+ DBUS_TYPE_STRING,
+ append_ssids,
+ data->scan_params);
+ }
Okay, this looks good (obviously, except the whitespace damage)
supplicant_add_scan_frequency(&dict, add_scan_frequencies,
data->scan_params);
} else
PS. I sent this patch from other unregistered email. I hope there is not
going to be any duplicate.
No, all fine with this. In just you are sending HTML emails and your
patch can't be processed by me without starting editing myself
(reformating, writing a commit messages etc). Since I am already
pretty slow responding and handling emails from everyone I would like
to ask from you to make my life simpler by following the usual patch
submission processes.
Thanks,
Daniel
6:20 p.m.
New subject: [PATCH] Fix gsupplicant not to include empty entry "SSIDs" in dbus message to wpa_supplicant
To to an active wifi scan on all channels connman calls gsupplicant's
g_supplicant_interface_scan() with empty list of frequencies and empty
list of SSIDs. gsupplicant used to send an empty entry of "SSIDs" in this case.
Sending the empty entry "SSIDs" to wpa_supplicant 2.6 triggers an error in
wpas_dbus_get_scan_ssids() called from wpas_dbus_handler_scan().
The function does not expect the empty list and fails with the error:
"wpas_dbus_get_scan_ssids[dbus]: ssids must be an array of arrays of bytes"
---
gsupplicant/supplicant.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/gsupplicant/supplicant.c b/gsupplicant/supplicant.c
index be2deaa5..b814b320 100644
--- a/gsupplicant/supplicant.c
+++ b/gsupplicant/supplicant.c
@@ -4303,11 +4303,13 @@ static void interface_scan_params(DBusMessageIter *iter, void
*user_data)
supplicant_dbus_dict_append_basic(&dict, "Type",
DBUS_TYPE_STRING, &type);
- supplicant_dbus_dict_append_array(&dict, "SSIDs",
- DBUS_TYPE_STRING,
- append_ssids,
- data->scan_params);
+ if (data->scan_params->ssids) {
+ supplicant_dbus_dict_append_array(&dict, "SSIDs",
+ DBUS_TYPE_STRING,
+ append_ssids,
+ data->scan_params);
+ }
supplicant_add_scan_frequency(&dict, add_scan_frequencies,
data->scan_params);
} else
--
2.17.1
10:12 a.m.
New subject: [PATCH] Fix gsupplicant not to include empty entry "SSIDs" in dbus message to wpa_supplicant
Hi Volodymyr,
On 11.12.18 19:20, Volodymyr Ostap wrote:
To to an active wifi scan on all channels connman calls
gsupplicant's
g_supplicant_interface_scan() with empty list of frequencies and empty
list of SSIDs. gsupplicant used to send an empty entry of "SSIDs" in this
case.
Sending the empty entry "SSIDs" to wpa_supplicant 2.6 triggers an error in
wpas_dbus_get_scan_ssids() called from wpas_dbus_handler_scan().
The function does not expect the empty list and fails with the error:
"wpas_dbus_get_scan_ssids[dbus]: ssids must be an array of arrays of bytes"
Patch applied after slightly changing the commit message.
Thanks,
Daniel
9:25 p.m.
New subject: [PATCH] Fix gsupplicant not to include empty entry "SSIDs" in dbus message to wpa_supplicant
Thank you Daniel. It looks correct and better.
On Wed, Dec 12, 2018 at 2:12 AM Daniel Wagner <wagi(a)monom.org> wrote:
Hi Volodymyr,
On 11.12.18 19:20, Volodymyr Ostap wrote:
> To to an active wifi scan on all channels connman calls gsupplicant's
> g_supplicant_interface_scan() with empty list of frequencies and empty
> list of SSIDs. gsupplicant used to send an empty entry of "SSIDs" in this
case.
> Sending the empty entry "SSIDs" to wpa_supplicant 2.6 triggers an error
in
> wpas_dbus_get_scan_ssids() called from wpas_dbus_handler_scan().
> The function does not expect the empty list and fails with the error:
> "wpas_dbus_get_scan_ssids[dbus]: ssids must be an array of arrays of
bytes"
Patch applied after slightly changing the commit message.
Thanks,
Daniel
810
days inactive
832
days old
4 comments
3 participants
participants (3)
-
Daniel Wagner -
Volodymyr Ostap -
Володимир Остап