On 03/05/2019 12:56 PM, Michał Lowas-Rzechonek wrote:
On 03/05, Denis Kenzior wrote:
> Please, no top posting on this mailing list :)
Sorry! Most MUAs nowadays default to top posting, my bad for not paying
> So my initial response would be in a form of a bewildered question: "Why are
> we even talking about this?". The reason I ask is that we follow the
> Linux kernel coding style, which basically disallows most of the
> 'interesting' C99 features.
Didn't mean to offend. Since I submitted a patch and I'm probably going
to submit a few more, I wanted to know what to expect. I read the coding
style, but ELL doesn't mention -std=gnu89. I know it's probably
"obvious" to you guys, since you have a kernel background, but many
other projects have substantially different policies.
No, not at all, no offense taken. I was just incredulous that this
topic came up at all. The coding style does mention that we use the
Linux Kernel coding style, and if you study that one it becomes pretty
clear that all the 'fun' features of C99 aren't allowed. Also, if you
violate the coding standard, then I will also likely mention it during
the initial review ;)
> But since we are talking about this, let me formulate the official policy.
> We follow the same process as described in:
> So roughly speaking what this means is that the code should compile with
> -std=gnu89. C89 compliance is not an official policy or goal.
Fair enough, thank you for clarification!
It might be worth to mention this in doc/coding-style, so a next
clueless person doesn't repeat silly questions ;)
In this country they say: 'There are no silly questions'. Anyhow, point
taken and I've added a reference to the Linux Kernel 'programming
language process' document in commit:
Hopefully that makes things clearer.