9:13 a.m.
Even if it gets forced by compile flags in a future commit it's better
to avoid this char usage.
Reported-by: Natanael Copa
Tested-by: Natanael Copa
---
ell/utf8.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ell/utf8.c b/ell/utf8.c
index e9998f7..edc2fc0 100644
--- a/ell/utf8.c
+++ b/ell/utf8.c
@@ -93,7 +93,7 @@ LIB_EXPORT int l_utf8_get_codepoint(const char *str, size_t len, wchar_t
*cp)
if (len == 0)
return 0;
- if (str[0] > 0) {
+ if ((signed char) str[0] > 0) {
*cp = str[0];
return 1;
}
--
2.19.1
9:13 a.m.
New subject: [PATCH 2/2] unit: Define WAIT_ANY if necessary
WAIT_ANY is not POSIX and musl libc doesn't define it. Fix based on
http://git.yoctoproject.org/cgit/cgit.cgi/meta-virtualization/tree/recipe...
Reported-by: Natanael Copa
Tested-by: Natanael Copa
---
unit/test-dbus-message-fds.c | 4 ++++
unit/test-dbus-properties.c | 4 ++++
unit/test-dbus.c | 4 ++++
3 files changed, 12 insertions(+)
diff --git a/unit/test-dbus-message-fds.c b/unit/test-dbus-message-fds.c
index d6d0b38..6f68bae 100644
--- a/unit/test-dbus-message-fds.c
+++ b/unit/test-dbus-message-fds.c
@@ -37,6 +37,10 @@
#include <ell/ell.h>
#include "ell/dbus-private.h"
+#ifndef WAIT_ANY
+#define WAIT_ANY (-1) /* Any process */
+#endif
+
#define TEST_BUS_ADDRESS "unix:path=/tmp/ell-test-bus"
static pid_t dbus_daemon_pid = -1;
diff --git a/unit/test-dbus-properties.c b/unit/test-dbus-properties.c
index f91ba73..1844ec0 100644
--- a/unit/test-dbus-properties.c
+++ b/unit/test-dbus-properties.c
@@ -34,6 +34,10 @@
#include <ell/ell.h>
#include "ell/dbus-private.h"
+#ifndef WAIT_ANY
+#define WAIT_ANY (-1) /* Any process */
+#endif
+
#define TEST_BUS_ADDRESS "unix:path=/tmp/ell-test-bus"
static pid_t dbus_daemon_pid = -1;
diff --git a/unit/test-dbus.c b/unit/test-dbus.c
index d5bd8c5..67f0a7b 100644
--- a/unit/test-dbus.c
+++ b/unit/test-dbus.c
@@ -31,6 +31,10 @@
#include <ell/ell.h>
+#ifndef WAIT_ANY
+#define WAIT_ANY (-1) /* Any process */
+#endif
+
#define TEST_BUS_ADDRESS "unix:path=/tmp/ell-test-bus"
static pid_t dbus_daemon_pid = -1;
--
2.19.1
10:10 a.m.
Hi Andrew,
On 03/14/2019 07:13 PM, Andrew Zaborowski wrote:
Even if it gets forced by compile flags in a future commit it's
better
to avoid this char usage.
Reported-by: Natanael Copa
Tested-by: Natanael Copa
---
ell/utf8.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Both applied, thanks.
Regards,
-Denis
707
days inactive
713
days old
2 comments
2 participants
participants (2)
-
Andrew Zaborowski -
Denis Kenzior