10:50 a.m.
Ensure that directory is created before its written to
This can cause a build race in a highly parallelised build where a directory is not yet
created but
output file is being written using redirection e.g.
rst2man.py --strict --no-raw --no-generator --no-datestamp < ../git/monitor/iwmon.rst
> monitor/iwmon.1
/bin/sh: monitor/iwmon.1: No such file or directory
make[1]: *** [Makefile:3544: monitor/iwmon.1] Error 1
---
v2: create directory before emitting doc files into it
Makefile.am | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/Makefile.am b/Makefile.am
index 823b7d02..1bd0005c 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -626,8 +626,9 @@ SED_PROCESS = $(AM_V_GEN)$(MKDIR_P) $(dir $@) && $(SED) \
< $< > $@
if RUN_RST2MAN
-RST2MAN_PROCESS = $(AM_V_GEN)$(RST2MAN) --strict --no-raw --no-generator \
- --no-datestamp < $< > $@
+RST2MAN_PROCESS = $(AM_V_GEN)$(MKDIR_P) $(dir $@) && \
+ $(AM_V_GEN)$(RST2MAN) --strict --no-raw \
+ --no-generator --no-datestamp $< $@
else
RST2MAN_PROCESS = $(AM_V_GEN)test -f $@ || \
{ echo "Generated manual page $@ does not exist"; false; }
--
2.24.0
2:49 a.m.
New subject: [PATCH V2] Makefile.am: Avoid redirection of input and output
files
ping
On Tue, 2019-11-05 at 18:50 -0800, Khem Raj wrote:
Ensure that directory is created before its written to
This can cause a build race in a highly parallelised build where a
directory is not yet created but
output file is being written using redirection e.g.
rst2man.py --strict --no-raw --no-generator --no-datestamp <
../git/monitor/iwmon.rst > monitor/iwmon.1
/bin/sh: monitor/iwmon.1: No such file or directory
make[1]: *** [Makefile:3544: monitor/iwmon.1] Error 1
---
v2: create directory before emitting doc files into it
Makefile.am | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/Makefile.am b/Makefile.am
index 823b7d02..1bd0005c 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -626,8 +626,9 @@ SED_PROCESS = $(AM_V_GEN)$(MKDIR_P) $(dir $@) &&
$(SED) \
< $< > $@
if RUN_RST2MAN
-RST2MAN_PROCESS = $(AM_V_GEN)$(RST2MAN) --strict --no-raw --no-
generator \
- --no-datestamp < $< > $@
+RST2MAN_PROCESS = $(AM_V_GEN)$(MKDIR_P) $(dir $@) && \
+ $(AM_V_GEN)$(RST2MAN) --strict --no-raw \
+ --no-generator --no-datestamp $< $@
else
RST2MAN_PROCESS = $(AM_V_GEN)test -f $@ || \
{ echo "Generated manual page $@ does not exist";
false; }
1:45 a.m.
gentle ping
On Wed, Nov 13, 2019 at 10:49 AM Khem Raj <raj.khem(a)gmail.com> wrote:
>
> ping
>
> On Tue, 2019-11-05 at 18:50 -0800, Khem Raj wrote:
> > Ensure that directory is created before its written to
> >
> > This can cause a build race in a highly parallelised build where a
> > directory is not yet created but
> > output file is being written using redirection e.g.
> >
> > rst2man.py --strict --no-raw --no-generator --no-datestamp <
> > ../git/monitor/iwmon.rst > monitor/iwmon.1
> > /bin/sh: monitor/iwmon.1: No such file or directory
> > make[1]: *** [Makefile:3544: monitor/iwmon.1] Error 1
> >
> > ---
> > v2: create directory before emitting doc files into it
> >
> > Makefile.am | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/Makefile.am b/Makefile.am
> > index 823b7d02..1bd0005c 100644
> > --- a/Makefile.am
> > +++ b/Makefile.am
> > @@ -626,8 +626,9 @@ SED_PROCESS = $(AM_V_GEN)$(MKDIR_P) $(dir $@) &&
> > $(SED) \
> > < $< > $@
> >
> > if RUN_RST2MAN
> > -RST2MAN_PROCESS = $(AM_V_GEN)$(RST2MAN) --strict --no-raw --no-
> > generator \
> > - --no-datestamp < $< > $@
> > +RST2MAN_PROCESS = $(AM_V_GEN)$(MKDIR_P) $(dir $@) && \
> > + $(AM_V_GEN)$(RST2MAN) --strict --no-raw \
> > + --no-generator --no-datestamp $< $@
> > else
> > RST2MAN_PROCESS = $(AM_V_GEN)test -f $@ || \
> > { echo "Generated manual page $@ does not exist";
> > false; }
>
2:33 a.m.
New subject: [PATCH V2] Makefile.am: Avoid redirection of input and output
files
Hi Khem,
Ensure that directory is created before its written to
This can cause a build race in a highly parallelised build where a directory is not yet
created but
output file is being written using redirection e.g.
rst2man.py --strict --no-raw --no-generator --no-datestamp < ../git/monitor/iwmon.rst
> monitor/iwmon.1
/bin/sh: monitor/iwmon.1: No such file or directory
make[1]: *** [Makefile:3544: monitor/iwmon.1] Error 1
---
v2: create directory before emitting doc files into it
Makefile.am | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
sorry for looking at this so late, can you send me a version that applies to the latest
HEAD.
Regards
Marcel
3:23 a.m.
Hi Marcel
Sent a v3
On Fri, Mar 6, 2020 at 10:33 AM Marcel Holtmann <marcel(a)holtmann.org> wrote:
>
> Hi Khem,
>
> > Ensure that directory is created before its written to
> >
> > This can cause a build race in a highly parallelised build where a directory is
not yet created but
> > output file is being written using redirection e.g.
> >
> > rst2man.py --strict --no-raw --no-generator --no-datestamp <
../git/monitor/iwmon.rst > monitor/iwmon.1
> > /bin/sh: monitor/iwmon.1: No such file or directory
> > make[1]: *** [Makefile:3544: monitor/iwmon.1] Error 1
> >
> > ---
> > v2: create directory before emitting doc files into it
> >
> > Makefile.am | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
>
> sorry for looking at this so late, can you send me a version that applies to the
latest HEAD.
>
> Regards
>
> Marcel
>
464
days inactive
585
days old
4 comments
2 participants
participants (2)
-
Khem Raj -
Marcel Holtmann