Re: [PATCH v15 06/19] leds: lp50xx: Add the LP50XX family of the RGB LED driver
by kbuild test robot
Hi Dan,
I love your patch! Yet something to improve:
[auto build test ERROR on j.anaszewski-leds/for-next]
[also build test ERROR on v5.4-rc5 next-20191029]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Dan-Murphy/Multicolor-Framework/...
base: https://git.kernel.org/pub/scm/linux/kernel/git/j.anaszewski/linux-leds.git for-next
config: mips-allmodconfig (attached as .config)
compiler: mips-linux-gcc (GCC) 7.4.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=mips
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> drivers//leds/leds-lp50xx.c:360:27: error: initializer element is not constant
.lp50xx_regmap_config = lp5012_regmap_config,
^~~~~~~~~~~~~~~~~~~~
drivers//leds/leds-lp50xx.c:360:27: note: (near initialization for 'lp50xx_chip_info_tbl[0].lp50xx_regmap_config')
drivers//leds/leds-lp50xx.c:371:27: error: initializer element is not constant
.lp50xx_regmap_config = lp5012_regmap_config,
^~~~~~~~~~~~~~~~~~~~
drivers//leds/leds-lp50xx.c:371:27: note: (near initialization for 'lp50xx_chip_info_tbl[1].lp50xx_regmap_config')
drivers//leds/leds-lp50xx.c:382:27: error: initializer element is not constant
.lp50xx_regmap_config = lp5024_regmap_config,
^~~~~~~~~~~~~~~~~~~~
drivers//leds/leds-lp50xx.c:382:27: note: (near initialization for 'lp50xx_chip_info_tbl[2].lp50xx_regmap_config')
drivers//leds/leds-lp50xx.c:393:27: error: initializer element is not constant
.lp50xx_regmap_config = lp5024_regmap_config,
^~~~~~~~~~~~~~~~~~~~
drivers//leds/leds-lp50xx.c:393:27: note: (near initialization for 'lp50xx_chip_info_tbl[3].lp50xx_regmap_config')
drivers//leds/leds-lp50xx.c:404:27: error: initializer element is not constant
.lp50xx_regmap_config = lp5036_regmap_config,
^~~~~~~~~~~~~~~~~~~~
drivers//leds/leds-lp50xx.c:404:27: note: (near initialization for 'lp50xx_chip_info_tbl[4].lp50xx_regmap_config')
drivers//leds/leds-lp50xx.c:415:27: error: initializer element is not constant
.lp50xx_regmap_config = lp5036_regmap_config,
^~~~~~~~~~~~~~~~~~~~
drivers//leds/leds-lp50xx.c:415:27: note: (near initialization for 'lp50xx_chip_info_tbl[5].lp50xx_regmap_config')
vim +360 drivers//leds/leds-lp50xx.c
349
350 static const struct lp50xx_chip_info lp50xx_chip_info_tbl[] = {
351 [LP5009] = {
352 .model_id = LP5009,
353 .max_modules = LP5009_MAX_LED_MODULES,
354 .num_leds = LP5009_MAX_LEDS,
355 .led_brightness0_reg = LP5012_LED0_BRT,
356 .mix_out0_reg = LP5012_OUT0_CLR,
357 .bank_brt_reg = LP5012_BNK_BRT,
358 .bank_mix_reg = LP5012_BNKA_CLR,
359 .reset_reg = LP5012_RESET,
> 360 .lp50xx_regmap_config = lp5012_regmap_config,
361 },
362 [LP5012] = {
363 .model_id = LP5012,
364 .max_modules = LP5012_MAX_LED_MODULES,
365 .num_leds = LP5012_MAX_LEDS,
366 .led_brightness0_reg = LP5012_LED0_BRT,
367 .mix_out0_reg = LP5012_OUT0_CLR,
368 .bank_brt_reg = LP5012_BNK_BRT,
369 .bank_mix_reg = LP5012_BNKA_CLR,
370 .reset_reg = LP5012_RESET,
371 .lp50xx_regmap_config = lp5012_regmap_config,
372 },
373 [LP5018] = {
374 .model_id = LP5018,
375 .max_modules = LP5018_MAX_LED_MODULES,
376 .num_leds = LP5018_MAX_LEDS,
377 .led_brightness0_reg = LP5024_LED0_BRT,
378 .mix_out0_reg = LP5024_OUT0_CLR,
379 .bank_brt_reg = LP5024_BNK_BRT,
380 .bank_mix_reg = LP5024_BNKA_CLR,
381 .reset_reg = LP5024_RESET,
382 .lp50xx_regmap_config = lp5024_regmap_config,
383 },
384 [LP5024] = {
385 .model_id = LP5024,
386 .max_modules = LP5024_MAX_LED_MODULES,
387 .num_leds = LP5024_MAX_LEDS,
388 .led_brightness0_reg = LP5024_LED0_BRT,
389 .mix_out0_reg = LP5024_OUT0_CLR,
390 .bank_brt_reg = LP5024_BNK_BRT,
391 .bank_mix_reg = LP5024_BNKA_CLR,
392 .reset_reg = LP5024_RESET,
393 .lp50xx_regmap_config = lp5024_regmap_config,
394 },
395 [LP5030] = {
396 .model_id = LP5030,
397 .max_modules = LP5030_MAX_LED_MODULES,
398 .num_leds = LP5030_MAX_LEDS,
399 .led_brightness0_reg = LP5036_LED0_BRT,
400 .mix_out0_reg = LP5036_OUT0_CLR,
401 .bank_brt_reg = LP5036_BNK_BRT,
402 .bank_mix_reg = LP5036_BNKA_CLR,
403 .reset_reg = LP5036_RESET,
404 .lp50xx_regmap_config = lp5036_regmap_config,
405 },
406 [LP5036] = {
407 .model_id = LP5036,
408 .max_modules = LP5036_MAX_LED_MODULES,
409 .num_leds = LP5036_MAX_LEDS,
410 .led_brightness0_reg = LP5036_LED0_BRT,
411 .mix_out0_reg = LP5036_OUT0_CLR,
412 .bank_brt_reg = LP5036_BNK_BRT,
413 .bank_mix_reg = LP5036_BNKA_CLR,
414 .reset_reg = LP5036_RESET,
415 .lp50xx_regmap_config = lp5036_regmap_config,
416 },
417 };
418
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
7 months, 2 weeks
Re: [PATCH v3][RESEND] adp5061: Add support for battery charging enable
by kbuild test robot
Hi Alexandru,
I love your patch! Yet something to improve:
[auto build test ERROR on power-supply/for-next]
[cannot apply to v5.4-rc2 next-20191011]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Alexandru-Ardelean/adp5061-Add-s...
base: https://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply.git for-next
config: sparc64-allmodconfig (attached as .config)
compiler: sparc64-linux-gcc (GCC) 7.4.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=sparc64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
All error/warnings (new ones prefixed by >>):
In file included from include/linux/kobject.h:20:0,
from include/linux/module.h:17,
from drivers/power/supply/adp5061.c:9:
>> drivers/power/supply/adp5061.c:738:44: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
static DEVICE_ATTR(charging_enabled, 0644, adp5061_get_charging_enabled,
^
include/linux/sysfs.h:104:10: note: in definition of macro '__ATTR'
.show = _show, \
^~~~~
>> drivers/power/supply/adp5061.c:738:8: note: in expansion of macro 'DEVICE_ATTR'
static DEVICE_ATTR(charging_enabled, 0644, adp5061_get_charging_enabled,
^~~~~~~~~~~
drivers/power/supply/adp5061.c:738:44: note: (near initialization for 'dev_attr_charging_enabled.show')
static DEVICE_ATTR(charging_enabled, 0644, adp5061_get_charging_enabled,
^
include/linux/sysfs.h:104:10: note: in definition of macro '__ATTR'
.show = _show, \
^~~~~
>> drivers/power/supply/adp5061.c:738:8: note: in expansion of macro 'DEVICE_ATTR'
static DEVICE_ATTR(charging_enabled, 0644, adp5061_get_charging_enabled,
^~~~~~~~~~~
drivers/power/supply/adp5061.c:739:6: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
adp5061_set_charging_enabled);
^
include/linux/sysfs.h:105:11: note: in definition of macro '__ATTR'
.store = _store, \
^~~~~~
>> drivers/power/supply/adp5061.c:738:8: note: in expansion of macro 'DEVICE_ATTR'
static DEVICE_ATTR(charging_enabled, 0644, adp5061_get_charging_enabled,
^~~~~~~~~~~
drivers/power/supply/adp5061.c:739:6: note: (near initialization for 'dev_attr_charging_enabled.store')
adp5061_set_charging_enabled);
^
include/linux/sysfs.h:105:11: note: in definition of macro '__ATTR'
.store = _store, \
^~~~~~
>> drivers/power/supply/adp5061.c:738:8: note: in expansion of macro 'DEVICE_ATTR'
static DEVICE_ATTR(charging_enabled, 0644, adp5061_get_charging_enabled,
^~~~~~~~~~~
cc1: some warnings being treated as errors
vim +738 drivers/power/supply/adp5061.c
737
> 738 static DEVICE_ATTR(charging_enabled, 0644, adp5061_get_charging_enabled,
739 adp5061_set_charging_enabled);
740
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
11 months
[linux-next:master 6920/8210] trace_sched_wakeup.c:undefined reference to `return_address'
by kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 49afce6d47fe05ee01f1a41129b835fe4cca7eea
commit: 0b0617e5a610fe12b3e6ecd9d64b107dbd24a9ee [6920/8210] ARM: 8918/1: only build return_address() if needed
config: arm-bcm2835_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 7.4.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 0b0617e5a610fe12b3e6ecd9d64b107dbd24a9ee
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
kernel/trace/trace_sched_wakeup.o: In function `probe_wakeup':
>> trace_sched_wakeup.c:(.text+0x794): undefined reference to `return_address'
trace_sched_wakeup.c:(.text+0x7a0): undefined reference to `return_address'
kernel/trace/trace_sched_wakeup.o: In function `probe_wakeup_sched_switch':
trace_sched_wakeup.c:(.text+0x874): undefined reference to `return_address'
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
11 months
[drm-drm-intel:drm-intel-next-queued 1/1] drivers/gpu/drm/i915/i915_drv.c:1491:35: error: 'i915_selftest' undeclared
by kbuild test robot
tree: git://anongit.freedesktop.org/drm/drm-intel drm-intel-next-queued
head: 1629224324b6cab6f7f96e839c9b57b74cfd8349
commit: 1629224324b6cab6f7f96e839c9b57b74cfd8349 [1/1] drm/i915/lmem: add the fake lmem region
config: i386-defconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-14) 7.4.0
reproduce:
git checkout 1629224324b6cab6f7f96e839c9b57b74cfd8349
# save the attached .config to linux build tree
make ARCH=i386
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
drivers/gpu/drm/i915/i915_drv.c: In function 'i915_driver_probe':
>> drivers/gpu/drm/i915/i915_drv.c:1491:35: error: 'i915_selftest' undeclared (first use in this function)
if (INTEL_GEN(dev_priv) >= 9 && i915_selftest.live < 0 &&
^~~~~~~~~~~~~
drivers/gpu/drm/i915/i915_drv.c:1491:35: note: each undeclared identifier is reported only once for each function it appears in
vim +/i915_selftest +1491 drivers/gpu/drm/i915/i915_drv.c
1459
1460 /**
1461 * i915_driver_probe - setup chip and create an initial config
1462 * @pdev: PCI device
1463 * @ent: matching PCI ID entry
1464 *
1465 * The driver probe routine has to do several things:
1466 * - drive output discovery via intel_modeset_init()
1467 * - initialize the memory manager
1468 * - allocate initial config memory
1469 * - setup the DRM framebuffer with the allocated memory
1470 */
1471 int i915_driver_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
1472 {
1473 const struct intel_device_info *match_info =
1474 (struct intel_device_info *)ent->driver_data;
1475 struct drm_i915_private *dev_priv;
1476 int ret;
1477
1478 dev_priv = i915_driver_create(pdev, ent);
1479 if (IS_ERR(dev_priv))
1480 return PTR_ERR(dev_priv);
1481
1482 /* Disable nuclear pageflip by default on pre-ILK */
1483 if (!i915_modparams.nuclear_pageflip && match_info->gen < 5)
1484 dev_priv->drm.driver_features &= ~DRIVER_ATOMIC;
1485
1486 /*
1487 * Check if we support fake LMEM -- for now we only unleash this for
1488 * the live selftests(test-and-exit).
1489 */
1490 if (IS_ENABLED(CONFIG_DRM_I915_UNSTABLE_FAKE_LMEM)) {
> 1491 if (INTEL_GEN(dev_priv) >= 9 && i915_selftest.live < 0 &&
1492 i915_modparams.fake_lmem_start) {
1493 mkwrite_device_info(dev_priv)->memory_regions =
1494 REGION_SMEM | REGION_LMEM | REGION_STOLEN;
1495 mkwrite_device_info(dev_priv)->is_dgfx = true;
1496 GEM_BUG_ON(!HAS_LMEM(dev_priv));
1497 GEM_BUG_ON(!IS_DGFX(dev_priv));
1498 }
1499 }
1500
1501 ret = pci_enable_device(pdev);
1502 if (ret)
1503 goto out_fini;
1504
1505 ret = i915_driver_early_probe(dev_priv);
1506 if (ret < 0)
1507 goto out_pci_disable;
1508
1509 disable_rpm_wakeref_asserts(&dev_priv->runtime_pm);
1510
1511 i915_detect_vgpu(dev_priv);
1512
1513 ret = i915_driver_mmio_probe(dev_priv);
1514 if (ret < 0)
1515 goto out_runtime_pm_put;
1516
1517 ret = i915_driver_hw_probe(dev_priv);
1518 if (ret < 0)
1519 goto out_cleanup_mmio;
1520
1521 ret = i915_driver_modeset_probe(dev_priv);
1522 if (ret < 0)
1523 goto out_cleanup_hw;
1524
1525 i915_driver_register(dev_priv);
1526
1527 enable_rpm_wakeref_asserts(&dev_priv->runtime_pm);
1528
1529 i915_welcome_messages(dev_priv);
1530
1531 return 0;
1532
1533 out_cleanup_hw:
1534 i915_driver_hw_remove(dev_priv);
1535 intel_memory_regions_driver_release(dev_priv);
1536 i915_ggtt_driver_release(dev_priv);
1537 out_cleanup_mmio:
1538 i915_driver_mmio_release(dev_priv);
1539 out_runtime_pm_put:
1540 enable_rpm_wakeref_asserts(&dev_priv->runtime_pm);
1541 i915_driver_late_release(dev_priv);
1542 out_pci_disable:
1543 pci_disable_device(pdev);
1544 out_fini:
1545 i915_probe_error(dev_priv, "Device initialization failed (%d)\n", ret);
1546 i915_driver_destroy(dev_priv);
1547 return ret;
1548 }
1549
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
11 months
[linux-review:UPDATE-20191030-114108/Navid-Emamdoost/media-aspeed-video-Fix-memory-leaks-in-aspeed_video_probe/20191029-094840 1/1] drivers/media/platform/aspeed-video.c:1649:51: sparse: sparse: incorrect type in argument 1 (different base types)
by kbuild test robot
tree: https://github.com/0day-ci/linux/commits/UPDATE-20191030-114108/Navid-Ema...
head: 288254ab3cdfa3042ffe0d19f4345671b755659c
commit: 288254ab3cdfa3042ffe0d19f4345671b755659c [1/1] media: aspeed-video: Fix memory leaks in aspeed_video_probe
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-dirty
git checkout 288254ab3cdfa3042ffe0d19f4345671b755659c
make ARCH=x86_64 allmodconfig
make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
sparse warnings: (new ones prefixed by >>)
>> drivers/media/platform/aspeed-video.c:1649:51: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected struct device *dev @@ got ruct device *dev @@
>> drivers/media/platform/aspeed-video.c:1649:51: sparse: expected struct device *dev
>> drivers/media/platform/aspeed-video.c:1649:51: sparse: got unsigned long
>> drivers/media/platform/aspeed-video.c:1649:67: sparse: sparse: incorrect type in argument 2 (different base types) @@ expected unsigned long [usertype] size @@ got long [usertype] size @@
>> drivers/media/platform/aspeed-video.c:1649:67: sparse: expected unsigned long [usertype] size
>> drivers/media/platform/aspeed-video.c:1649:67: sparse: got restricted gfp_t
>> drivers/media/platform/aspeed-video.c:1649:50: sparse: sparse: not enough arguments for function devm_kzalloc
vim +1649 drivers/media/platform/aspeed-video.c
1644
1645 static int aspeed_video_probe(struct platform_device *pdev)
1646 {
1647 int rc;
1648 struct resource *res;
> 1649 struct aspeed_video *video = devm_kzalloc(sizeof(*video), GFP_KERNEL);
1650
1651 if (!video)
1652 return -ENOMEM;
1653
1654 video->frame_rate = 30;
1655 video->dev = &pdev->dev;
1656 spin_lock_init(&video->lock);
1657 mutex_init(&video->video_lock);
1658 init_waitqueue_head(&video->wait);
1659 INIT_DELAYED_WORK(&video->res_work, aspeed_video_resolution_work);
1660 INIT_LIST_HEAD(&video->buffers);
1661
1662 res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
1663
1664 video->base = devm_ioremap_resource(video->dev, res);
1665
1666 if (IS_ERR(video->base))
1667 return PTR_ERR(video->base);
1668
1669 rc = aspeed_video_init(video);
1670 if (rc)
1671 return rc;
1672
1673 rc = aspeed_video_setup_video(video);
1674 if (rc)
1675 return rc;
1676
1677 return 0;
1678 }
1679
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
11 months
[peterz-queue:sched/core 3/3] kernel/sched/rt.c:455:13: sparse: sparse: symbol 'rt_task_fits_capacity' was not declared. Should it be static?
by kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git sched/core
head: 3215b75b29c9a06ac1699503b8509b60cffdf038
commit: 3215b75b29c9a06ac1699503b8509b60cffdf038 [3/3] sched: rt: Make RT capacity aware
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-1-g8d04453-dirty
git checkout 3215b75b29c9a06ac1699503b8509b60cffdf038
make ARCH=x86_64 allmodconfig
make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
sparse warnings: (new ones prefixed by >>)
kernel/sched/rt.c:1715:9: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct sched_domain *[assigned] sd @@ got struct struct sched_domain *[assigned] sd @@
kernel/sched/rt.c:1715:9: sparse: expected struct sched_domain *[assigned] sd
kernel/sched/rt.c:1715:9: sparse: got struct sched_domain [noderef] <asn:4> *parent
>> kernel/sched/rt.c:455:13: sparse: sparse: symbol 'rt_task_fits_capacity' was not declared. Should it be static?
kernel/sched/sched.h:2031:17: sparse: sparse: context imbalance in 'find_lock_lowest_rq' - unexpected unlock
kernel/sched/rt.c:1901:9: sparse: sparse: context imbalance in 'push_rt_task' - unexpected unlock
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
11 months
[lkp] [+880 bytes kernel size regression] [i386-tinyconfig] [f04158a22d] perf: Allocate space in task_struct for pmu specific data
by kbuild test robot
FYI, we noticed a +880 bytes kernel size regression due to commit:
commit: f04158a22dfa771649f3a89beb30f9028db28c17 (perf: Allocate space in task_struct for pmu specific data)
Details as below (size data is obtained by `nm --size-sort vmlinux`):
8b2214ec: change Makefile
f04158a2: perf: Allocate space in task_struct for pmu specific data
+----------------------------+----------+----------+-------+
| symbol | 8b2214ec | f04158a2 | delta |
+----------------------------+----------+----------+-------+
| bzImage | 438720 | 439104 | 384 |
| nm.t.perf_event_alloc | 1595 | 1889 | 294 |
| nm.t.get_task_ctx_data_rcu | 0 | 176 | 176 |
| nm.t._free_event | 410 | 545 | 135 |
| nm.t.put_task_ctx_data_rcu | 0 | 112 | 112 |
| nm.T.perf_event_fork | 20 | 118 | 98 |
| nm.t.free_ctx_data | 0 | 19 | 19 |
| nm.T.perf_event_exit_task | 583 | 601 | 18 |
| nm.T.perf_event_init_task | 438 | 448 | 10 |
| nm.t.perf_read | 474 | 481 | 7 |
| nm.t.inherit_event | 357 | 362 | 5 |
| nm.t.find_get_context | 359 | 364 | 5 |
| nm.b.nr_task_data_events | 0 | 4 | 4 |
| nm.D.linux_banner | 119 | 118 | -1 |
| nm.t.kzalloc | 10 | 8 | -2 |
+----------------------------+----------+----------+-------+
Thanks,
Kbuild test robot
11 months
[android-common:android-3.18 4/5] fs//gfs2/glock.c:164:31: error: 'GLOF_LRU' undeclared; did you mean 'GLF_LRU'?
by kbuild test robot
tree: https://android.googlesource.com/kernel/common android-3.18
head: 092c072095517a63745da6ca04bcbbc0f71bf823
commit: 7b617c7a3be57fc05ea24ef4f146ff0980956454 [4/5] gfs2: Fix lru_count going negative
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 7.4.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 7b617c7a3be57fc05ea24ef4f146ff0980956454
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=xtensa
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
fs//gfs2/glock.c: In function 'gfs2_glock_add_to_lru':
>> fs//gfs2/glock.c:164:31: error: 'GLOF_LRU' undeclared (first use in this function); did you mean 'GLF_LRU'?
if (!(gl->gl_ops->go_flags & GLOF_LRU))
^~~~~~~~
GLF_LRU
fs//gfs2/glock.c:164:31: note: each undeclared identifier is reported only once for each function it appears in
vim +164 fs//gfs2/glock.c
160
161
162 void gfs2_glock_add_to_lru(struct gfs2_glock *gl)
163 {
> 164 if (!(gl->gl_ops->go_flags & GLOF_LRU))
165 return;
166
167 spin_lock(&lru_lock);
168
169 list_del(&gl->gl_lru);
170 list_add_tail(&gl->gl_lru, &lru_list);
171
172 if (!test_bit(GLF_LRU, &gl->gl_flags)) {
173 set_bit(GLF_LRU, &gl->gl_flags);
174 atomic_inc(&lru_count);
175 }
176
177 spin_unlock(&lru_lock);
178 }
179
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
11 months
[batman:batadv/net-next 4/5] net//batman-adv/soft-interface.c:233:3: error: 'fallthrough' undeclared
by kbuild test robot
tree: https://git.open-mesh.org/linux-merge.git batadv/net-next
head: 8a2a8331b462cc285c700c89ae8f61a434099919
commit: 4de3cfb7107d8dc89178465dc50b1259013a3dbc [4/5] batman-adv: Use 'fallthrough' pseudo keyword
config: i386-randconfig-b003-201943 (attached as .config)
compiler: gcc-7 (Debian 7.4.0-14) 7.4.0
reproduce:
git checkout 4de3cfb7107d8dc89178465dc50b1259013a3dbc
# save the attached .config to linux build tree
make ARCH=i386
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
net//batman-adv/soft-interface.c: In function 'batadv_interface_tx':
>> net//batman-adv/soft-interface.c:233:3: error: 'fallthrough' undeclared (first use in this function)
fallthrough;
^~~~~~~~~~~
net//batman-adv/soft-interface.c:233:3: note: each undeclared identifier is reported only once for each function it appears in
net//batman-adv/soft-interface.c: In function 'batadv_interface_rx':
net//batman-adv/soft-interface.c:458:3: error: 'fallthrough' undeclared (first use in this function)
fallthrough;
^~~~~~~~~~~
vim +/fallthrough +233 net//batman-adv/soft-interface.c
179
180 static netdev_tx_t batadv_interface_tx(struct sk_buff *skb,
181 struct net_device *soft_iface)
182 {
183 struct ethhdr *ethhdr;
184 struct batadv_priv *bat_priv = netdev_priv(soft_iface);
185 struct batadv_hard_iface *primary_if = NULL;
186 struct batadv_bcast_packet *bcast_packet;
187 static const u8 stp_addr[ETH_ALEN] = {0x01, 0x80, 0xC2, 0x00,
188 0x00, 0x00};
189 static const u8 ectp_addr[ETH_ALEN] = {0xCF, 0x00, 0x00, 0x00,
190 0x00, 0x00};
191 enum batadv_dhcp_recipient dhcp_rcp = BATADV_DHCP_NO;
192 u8 *dst_hint = NULL, chaddr[ETH_ALEN];
193 struct vlan_ethhdr *vhdr;
194 unsigned int header_len = 0;
195 int data_len = skb->len, ret;
196 unsigned long brd_delay = 1;
197 bool do_bcast = false, client_added;
198 unsigned short vid;
199 u32 seqno;
200 int gw_mode;
201 enum batadv_forw_mode forw_mode = BATADV_FORW_SINGLE;
202 struct batadv_orig_node *mcast_single_orig = NULL;
203 int network_offset = ETH_HLEN;
204 __be16 proto;
205
206 if (atomic_read(&bat_priv->mesh_state) != BATADV_MESH_ACTIVE)
207 goto dropped;
208
209 /* reset control block to avoid left overs from previous users */
210 memset(skb->cb, 0, sizeof(struct batadv_skb_cb));
211
212 netif_trans_update(soft_iface);
213 vid = batadv_get_vid(skb, 0);
214
215 skb_reset_mac_header(skb);
216 ethhdr = eth_hdr(skb);
217
218 proto = ethhdr->h_proto;
219
220 switch (ntohs(proto)) {
221 case ETH_P_8021Q:
222 if (!pskb_may_pull(skb, sizeof(*vhdr)))
223 goto dropped;
224 vhdr = vlan_eth_hdr(skb);
225 proto = vhdr->h_vlan_encapsulated_proto;
226
227 /* drop batman-in-batman packets to prevent loops */
228 if (proto != htons(ETH_P_BATMAN)) {
229 network_offset += VLAN_HLEN;
230 break;
231 }
232
> 233 fallthrough;
234 case ETH_P_BATMAN:
235 goto dropped;
236 }
237
238 skb_set_network_header(skb, network_offset);
239
240 if (batadv_bla_tx(bat_priv, skb, vid))
241 goto dropped;
242
243 /* skb->data might have been reallocated by batadv_bla_tx() */
244 ethhdr = eth_hdr(skb);
245
246 /* Register the client MAC in the transtable */
247 if (!is_multicast_ether_addr(ethhdr->h_source) &&
248 !batadv_bla_is_loopdetect_mac(ethhdr->h_source)) {
249 client_added = batadv_tt_local_add(soft_iface, ethhdr->h_source,
250 vid, skb->skb_iif,
251 skb->mark);
252 if (!client_added)
253 goto dropped;
254 }
255
256 /* Snoop address candidates from DHCPACKs for early DAT filling */
257 batadv_dat_snoop_outgoing_dhcp_ack(bat_priv, skb, proto, vid);
258
259 /* don't accept stp packets. STP does not help in meshes.
260 * better use the bridge loop avoidance ...
261 *
262 * The same goes for ECTP sent at least by some Cisco Switches,
263 * it might confuse the mesh when used with bridge loop avoidance.
264 */
265 if (batadv_compare_eth(ethhdr->h_dest, stp_addr))
266 goto dropped;
267
268 if (batadv_compare_eth(ethhdr->h_dest, ectp_addr))
269 goto dropped;
270
271 gw_mode = atomic_read(&bat_priv->gw.mode);
272 if (is_multicast_ether_addr(ethhdr->h_dest)) {
273 /* if gw mode is off, broadcast every packet */
274 if (gw_mode == BATADV_GW_MODE_OFF) {
275 do_bcast = true;
276 goto send;
277 }
278
279 dhcp_rcp = batadv_gw_dhcp_recipient_get(skb, &header_len,
280 chaddr);
281 /* skb->data may have been modified by
282 * batadv_gw_dhcp_recipient_get()
283 */
284 ethhdr = eth_hdr(skb);
285 /* if gw_mode is on, broadcast any non-DHCP message.
286 * All the DHCP packets are going to be sent as unicast
287 */
288 if (dhcp_rcp == BATADV_DHCP_NO) {
289 do_bcast = true;
290 goto send;
291 }
292
293 if (dhcp_rcp == BATADV_DHCP_TO_CLIENT)
294 dst_hint = chaddr;
295 else if ((gw_mode == BATADV_GW_MODE_SERVER) &&
296 (dhcp_rcp == BATADV_DHCP_TO_SERVER))
297 /* gateways should not forward any DHCP message if
298 * directed to a DHCP server
299 */
300 goto dropped;
301
302 send:
303 if (do_bcast && !is_broadcast_ether_addr(ethhdr->h_dest)) {
304 forw_mode = batadv_mcast_forw_mode(bat_priv, skb,
305 &mcast_single_orig);
306 if (forw_mode == BATADV_FORW_NONE)
307 goto dropped;
308
309 if (forw_mode == BATADV_FORW_SINGLE ||
310 forw_mode == BATADV_FORW_SOME)
311 do_bcast = false;
312 }
313 }
314
315 batadv_skb_set_priority(skb, 0);
316
317 /* ethernet packet should be broadcasted */
318 if (do_bcast) {
319 primary_if = batadv_primary_if_get_selected(bat_priv);
320 if (!primary_if)
321 goto dropped;
322
323 /* in case of ARP request, we do not immediately broadcasti the
324 * packet, instead we first wait for DAT to try to retrieve the
325 * correct ARP entry
326 */
327 if (batadv_dat_snoop_outgoing_arp_request(bat_priv, skb))
328 brd_delay = msecs_to_jiffies(ARP_REQ_DELAY);
329
330 if (batadv_skb_head_push(skb, sizeof(*bcast_packet)) < 0)
331 goto dropped;
332
333 bcast_packet = (struct batadv_bcast_packet *)skb->data;
334 bcast_packet->version = BATADV_COMPAT_VERSION;
335 bcast_packet->ttl = BATADV_TTL;
336
337 /* batman packet type: broadcast */
338 bcast_packet->packet_type = BATADV_BCAST;
339 bcast_packet->reserved = 0;
340
341 /* hw address of first interface is the orig mac because only
342 * this mac is known throughout the mesh
343 */
344 ether_addr_copy(bcast_packet->orig,
345 primary_if->net_dev->dev_addr);
346
347 /* set broadcast sequence number */
348 seqno = atomic_inc_return(&bat_priv->bcast_seqno);
349 bcast_packet->seqno = htonl(seqno);
350
351 batadv_add_bcast_packet_to_list(bat_priv, skb, brd_delay, true);
352
353 /* a copy is stored in the bcast list, therefore removing
354 * the original skb.
355 */
356 consume_skb(skb);
357
358 /* unicast packet */
359 } else {
360 /* DHCP packets going to a server will use the GW feature */
361 if (dhcp_rcp == BATADV_DHCP_TO_SERVER) {
362 ret = batadv_gw_out_of_range(bat_priv, skb);
363 if (ret)
364 goto dropped;
365 ret = batadv_send_skb_via_gw(bat_priv, skb, vid);
366 } else if (mcast_single_orig) {
367 ret = batadv_send_skb_unicast(bat_priv, skb,
368 BATADV_UNICAST, 0,
369 mcast_single_orig, vid);
370 } else if (forw_mode == BATADV_FORW_SOME) {
371 ret = batadv_mcast_forw_send(bat_priv, skb, vid);
372 } else {
373 if (batadv_dat_snoop_outgoing_arp_request(bat_priv,
374 skb))
375 goto dropped;
376
377 batadv_dat_snoop_outgoing_arp_reply(bat_priv, skb);
378
379 ret = batadv_send_skb_via_tt(bat_priv, skb, dst_hint,
380 vid);
381 }
382 if (ret != NET_XMIT_SUCCESS)
383 goto dropped_freed;
384 }
385
386 batadv_inc_counter(bat_priv, BATADV_CNT_TX);
387 batadv_add_counter(bat_priv, BATADV_CNT_TX_BYTES, data_len);
388 goto end;
389
390 dropped:
391 kfree_skb(skb);
392 dropped_freed:
393 batadv_inc_counter(bat_priv, BATADV_CNT_TX_DROPPED);
394 end:
395 if (mcast_single_orig)
396 batadv_orig_node_put(mcast_single_orig);
397 if (primary_if)
398 batadv_hardif_put(primary_if);
399 return NETDEV_TX_OK;
400 }
401
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
11 months
[android-common:android-3.18 4/5] fs/gfs2/glock.c:164:31: error: 'GLOF_LRU' undeclared
by kbuild test robot
tree: https://android.googlesource.com/kernel/common android-3.18
head: 092c072095517a63745da6ca04bcbbc0f71bf823
commit: 7b617c7a3be57fc05ea24ef4f146ff0980956454 [4/5] gfs2: Fix lru_count going negative
config: x86_64-rhel (attached as .config)
compiler: gcc-5 (Ubuntu 5.5.0-12ubuntu1) 5.5.0 20171010
reproduce:
git checkout 7b617c7a3be57fc05ea24ef4f146ff0980956454
# save the attached .config to linux build tree
make ARCH=x86_64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
fs/gfs2/glock.c: In function 'gfs2_glock_add_to_lru':
>> fs/gfs2/glock.c:164:31: error: 'GLOF_LRU' undeclared (first use in this function)
if (!(gl->gl_ops->go_flags & GLOF_LRU))
^
fs/gfs2/glock.c:164:31: note: each undeclared identifier is reported only once for each function it appears in
vim +/GLOF_LRU +164 fs/gfs2/glock.c
160
161
162 void gfs2_glock_add_to_lru(struct gfs2_glock *gl)
163 {
> 164 if (!(gl->gl_ops->go_flags & GLOF_LRU))
165 return;
166
167 spin_lock(&lru_lock);
168
169 list_del(&gl->gl_lru);
170 list_add_tail(&gl->gl_lru, &lru_list);
171
172 if (!test_bit(GLF_LRU, &gl->gl_flags)) {
173 set_bit(GLF_LRU, &gl->gl_flags);
174 atomic_inc(&lru_count);
175 }
176
177 spin_unlock(&lru_lock);
178 }
179
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
11 months