[morimoto-linux:fw-cleanup-2019-10-30-v1 200/458] sound/soc/rockchip/rockchip_max98090.c:230:47: error: 'struct snd_soc_pcm_runtime' has no member named 'codec_dai'
by kbuild test robot
tree: https://github.com/morimoto/linux fw-cleanup-2019-10-30-v1
head: b5641af479d4ce4b2f38151ac152a0095f71483b
commit: a5114be40d9a6c709dbfe986e59c8291fc0f02b8 [200/458] ASoC: soc-core: remove cpu_dai/codec_dai/cpu_dais/codec_dais
config: mips-allmodconfig (attached as .config)
compiler: mips-linux-gcc (GCC) 7.4.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout a5114be40d9a6c709dbfe986e59c8291fc0f02b8
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=mips
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
sound/soc/rockchip/rockchip_max98090.c: In function 'rk_hdmi_init':
>> sound/soc/rockchip/rockchip_max98090.c:230:47: error: 'struct snd_soc_pcm_runtime' has no member named 'codec_dai'
struct snd_soc_component *component = runtime->codec_dai->component;
^~
vim +230 sound/soc/rockchip/rockchip_max98090.c
bf2f64ea659406 Cheng-Yi Chiang 2019-10-28 226
bf2f64ea659406 Cheng-Yi Chiang 2019-10-28 227 static int rk_hdmi_init(struct snd_soc_pcm_runtime *runtime)
bf2f64ea659406 Cheng-Yi Chiang 2019-10-28 228 {
bf2f64ea659406 Cheng-Yi Chiang 2019-10-28 229 struct snd_soc_card *card = runtime->card;
bf2f64ea659406 Cheng-Yi Chiang 2019-10-28 @230 struct snd_soc_component *component = runtime->codec_dai->component;
bf2f64ea659406 Cheng-Yi Chiang 2019-10-28 231 int ret;
bf2f64ea659406 Cheng-Yi Chiang 2019-10-28 232
bf2f64ea659406 Cheng-Yi Chiang 2019-10-28 233 /* enable jack detection */
bf2f64ea659406 Cheng-Yi Chiang 2019-10-28 234 ret = snd_soc_card_jack_new(card, "HDMI Jack", SND_JACK_LINEOUT,
bf2f64ea659406 Cheng-Yi Chiang 2019-10-28 235 &rk_hdmi_jack, NULL, 0);
bf2f64ea659406 Cheng-Yi Chiang 2019-10-28 236 if (ret) {
bf2f64ea659406 Cheng-Yi Chiang 2019-10-28 237 dev_err(card->dev, "Can't new HDMI Jack %d\n", ret);
bf2f64ea659406 Cheng-Yi Chiang 2019-10-28 238 return ret;
bf2f64ea659406 Cheng-Yi Chiang 2019-10-28 239 }
bf2f64ea659406 Cheng-Yi Chiang 2019-10-28 240
bf2f64ea659406 Cheng-Yi Chiang 2019-10-28 241 return hdmi_codec_set_jack_detect(component, &rk_hdmi_jack);
bf2f64ea659406 Cheng-Yi Chiang 2019-10-28 242 }
bf2f64ea659406 Cheng-Yi Chiang 2019-10-28 243
:::::: The code at line 230 was first introduced by commit
:::::: bf2f64ea6594066081b0d30b128fa4947e83e737 ASoC: rockchip_max98090: Add HDMI jack support
:::::: TO: Cheng-Yi Chiang <cychiang(a)chromium.org>
:::::: CC: Mark Brown <broonie(a)kernel.org>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
1 year, 5 months
Re: drivers/usb/usbip/stub_rx.c:505 stub_recv_cmd_submit() error: uninitialized symbol 'nents'.
by Dan Carpenter
On Sat, Oct 26, 2019 at 11:41:41AM +0900, Suwan Kim wrote:
> On Thu, Oct 24, 2019 at 04:52:52PM -0600, shuah wrote:
> > On 10/24/19 1:45 PM, Dan Carpenter wrote:
> > > On Wed, Oct 23, 2019 at 04:11:20PM +0900, Suwan Kim wrote:
> > > > On Tue, Oct 22, 2019 at 12:28:39PM +0300, Dan Carpenter wrote:
> > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > > > > head: 7d194c2100ad2a6dded545887d02754948ca5241
> > > > > commit: ea44d190764b4422af4d1c29eaeb9e69e353b406 usbip: Implement SG support to vhci-hcd and stub driver
> > > > > date: 7 weeks ago
> > > > >
> > > > > If you fix the issue, kindly add following tag
> > > > > Reported-by: kbuild test robot <lkp(a)intel.com>
> > > > > Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com>
> > > > >
> > > > > New smatch warnings:
> > > > > drivers/usb/usbip/stub_rx.c:505 stub_recv_cmd_submit() error: uninitialized symbol 'nents'.
> > > > >
> > > > > Old smatch warnings:
> > > > > drivers/usb/usbip/stub_rx.c:450 stub_recv_xbuff() error: uninitialized symbol 'ret'.
>
> Here, ret is not initialized, meaning priv->num_urbs is 0.
> priv->urbs must be greater than zero.
> priv->num_urbs = 0 means nents is 0 (line 505)
>
> Dan, What is the relationship between old and new warnings?
> priv->num_urbs is set as value of "num_urbs" at stub_recv_cmd_submit()
> and "num_urbs" is initialized as 1 first. "num_urbs" will be reset
> only at the place where smatch new warnings happened (line 505).
>
> So, In my opinion, old smatch warnings should occur after the new
> smatch warnings. Does this look right to you?
I don't know exactly how the 0day bot runs Smatch. If you have cross
function analysis enabled then silencing the uninitialized "nents"
warning will also silence the uninitialized "ret" warning.
regards,
dan carpenter
1 year, 5 months
Re: [PATCH] fs: warn if stale pagecache is left after direct write
by kbuild test robot
Hi Konstantin,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v5.4-rc5 next-20191029]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Konstantin-Khlebnikov/fs-warn-if...
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 23fdb198ae81f47a574296dab5167c5e136a02ba
config: i386-tinyconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-14) 7.4.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
mm/filemap.c: In function 'generic_file_direct_write':
>> mm/filemap.c:3229:3: error: implicit declaration of function 'dio_warn_stale_pagecache'; did you mean 'truncate_pagecache'? [-Werror=implicit-function-declaration]
dio_warn_stale_pagecache(file);
^~~~~~~~~~~~~~~~~~~~~~~~
truncate_pagecache
cc1: some warnings being treated as errors
vim +3229 mm/filemap.c
3163
3164 ssize_t
3165 generic_file_direct_write(struct kiocb *iocb, struct iov_iter *from)
3166 {
3167 struct file *file = iocb->ki_filp;
3168 struct address_space *mapping = file->f_mapping;
3169 struct inode *inode = mapping->host;
3170 loff_t pos = iocb->ki_pos;
3171 ssize_t written;
3172 size_t write_len;
3173 pgoff_t end;
3174
3175 write_len = iov_iter_count(from);
3176 end = (pos + write_len - 1) >> PAGE_SHIFT;
3177
3178 if (iocb->ki_flags & IOCB_NOWAIT) {
3179 /* If there are pages to writeback, return */
3180 if (filemap_range_has_page(inode->i_mapping, pos,
3181 pos + write_len - 1))
3182 return -EAGAIN;
3183 } else {
3184 written = filemap_write_and_wait_range(mapping, pos,
3185 pos + write_len - 1);
3186 if (written)
3187 goto out;
3188 }
3189
3190 /*
3191 * After a write we want buffered reads to be sure to go to disk to get
3192 * the new data. We invalidate clean cached page from the region we're
3193 * about to write. We do this *before* the write so that we can return
3194 * without clobbering -EIOCBQUEUED from ->direct_IO().
3195 */
3196 written = invalidate_inode_pages2_range(mapping,
3197 pos >> PAGE_SHIFT, end);
3198 /*
3199 * If a page can not be invalidated, return 0 to fall back
3200 * to buffered write.
3201 */
3202 if (written) {
3203 if (written == -EBUSY)
3204 return 0;
3205 goto out;
3206 }
3207
3208 written = mapping->a_ops->direct_IO(iocb, from);
3209
3210 /*
3211 * Finally, try again to invalidate clean pages which might have been
3212 * cached by non-direct readahead, or faulted in by get_user_pages()
3213 * if the source of the write was an mmap'ed region of the file
3214 * we're writing. Either one is a pretty crazy thing to do,
3215 * so we don't support it 100%. If this invalidation
3216 * fails, tough, the write still worked...
3217 *
3218 * Most of the time we do not need this since dio_complete() will do
3219 * the invalidation for us. However there are some file systems that
3220 * do not end up with dio_complete() being called, so let's not break
3221 * them by removing it completely.
3222 *
3223 * Noticeable case is a blkdev_direct_IO().
3224 *
3225 * Skip invalidation for async writes or if mapping has no pages.
3226 */
3227 if (written > 0 && mapping->nrpages &&
3228 invalidate_inode_pages2_range(mapping, pos >> PAGE_SHIFT, end))
> 3229 dio_warn_stale_pagecache(file);
3230
3231 if (written > 0) {
3232 pos += written;
3233 write_len -= written;
3234 if (pos > i_size_read(inode) && !S_ISBLK(inode->i_mode)) {
3235 i_size_write(inode, pos);
3236 mark_inode_dirty(inode);
3237 }
3238 iocb->ki_pos = pos;
3239 }
3240 iov_iter_revert(from, write_len - iov_iter_count(from));
3241 out:
3242 return written;
3243 }
3244 EXPORT_SYMBOL(generic_file_direct_write);
3245
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
1 year, 5 months
[omap:droid4-pending-v5.4 18/26] include/linux/mfd/motorola-mdm.h:37:25: error: field 'gsm_dlci' has incomplete type
by kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap.git droid4-pending-v5.4
head: 3efaedc5ef6cde5bfde516b6db455b306b5ce5b7
commit: ded039eb975c1014181e2a2b6b16ae7ffabe7350 [18/26] mfd: motmdm: Add Motorola TS 27.010 serdev driver for devices like droid4
config: i386-randconfig-d002-201943 (attached as .config)
compiler: gcc-7 (Debian 7.4.0-14) 7.4.0
reproduce:
git checkout ded039eb975c1014181e2a2b6b16ae7ffabe7350
# save the attached .config to linux build tree
make ARCH=i386
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
In file included from <command-line>:0:0:
>> include/linux/mfd/motorola-mdm.h:37:25: error: field 'gsm_dlci' has incomplete type
struct gsm_serdev_dlci gsm_dlci;
^~~~~~~~
>> include/linux/mfd/motorola-mdm.h:38:19: error: field 'node' has incomplete type
struct list_head node;
^~~~
>> include/linux/mfd/motorola-mdm.h:39:2: error: unknown type name 'wait_queue_head_t'
wait_queue_head_t read_queue;
^~~~~~~~~~~~~~~~~
>> include/linux/mfd/motorola-mdm.h:40:15: error: field 'read_fifo' has incomplete type
struct kfifo read_fifo;
^~~~~~~~~
>> include/linux/mfd/motorola-mdm.h:42:2: error: unknown type name 'u16'
u16 id;
^~~
>> include/linux/mfd/motorola-mdm.h:45:8: error: unknown type name 'size_t'
size_t cmdlen,
^~~~~~
include/linux/mfd/motorola-mdm.h:46:28: error: unknown type name 'size_t'
unsigned char *rsp, size_t rsplen);
^~~~~~
include/linux/mfd/motorola-mdm.h:48:36: error: unknown type name 'size_t'
const unsigned char *buf, size_t len);
^~~~~~
include/linux/mfd/motorola-mdm.h:51:8: error: unknown type name 'size_t'
size_t len);
^~~~~~
include/linux/mfd/motorola-mdm.h:53:45: error: unknown type name 'size_t'
int cmdid, const unsigned char *buf, size_t count);
^~~~~~
>> include/linux/mfd/motorola-mdm.h:55:19: error: field 'list' has incomplete type
struct list_head list;
^~~~
include/linux/mfd/motorola-mdm.h:60:33: warning: 'struct device' declared inside parameter list will not be visible outside of this definition or declaration
int motmdm_register_dlci(struct device *dev, struct motmdm_dlci *mot_dlci);
^~~~~~
include/linux/mfd/motorola-mdm.h:61:36: warning: 'struct device' declared inside parameter list will not be visible outside of this definition or declaration
void motmdm_unregister_dlci(struct device *dev, struct motmdm_dlci *mot_dlci);
^~~~~~
include/linux/mfd/motorola-mdm.h:66:4: error: unknown type name 'size_t'
size_t cmdlen, unsigned char *rsp, size_t rsplen)
^~~~~~
include/linux/mfd/motorola-mdm.h:66:39: error: unknown type name 'size_t'
size_t cmdlen, unsigned char *rsp, size_t rsplen)
^~~~~~
include/linux/mfd/motorola-mdm.h:78:30: error: unknown type name 'size_t'
const unsigned char *buf, size_t count)
^~~~~~
vim +/gsm_dlci +37 include/linux/mfd/motorola-mdm.h
35
36 struct motmdm_dlci {
> 37 struct gsm_serdev_dlci gsm_dlci;
> 38 struct list_head node;
> 39 wait_queue_head_t read_queue;
> 40 struct kfifo read_fifo;
41 int line;
> 42 u16 id;
43 int (*send_command)(struct device *dev, struct motmdm_dlci *mot_dlci,
44 unsigned long timeout_ms, const unsigned char *cmd,
> 45 size_t cmdlen,
46 unsigned char *rsp, size_t rsplen);
47 int (*handle_command)(struct motmdm_dlci *mot_dlci, int id,
> 48 const unsigned char *buf, size_t len);
49 int (*receive_data)(struct motmdm_dlci *mot_dlci,
50 const unsigned char *buf,
51 size_t len);
52 int (*write)(struct device *dev, struct motmdm_dlci *mot_dlci,
53 int cmdid, const unsigned char *buf, size_t count);
54 int (*notify)(struct motmdm_dlci *mot_dlci, enum motmdm_state);
> 55 struct list_head list;
56 void *privdata; /* Do not use, internal data */
57 void *drvdata; /* Available for consumer drivers */
58 };
59
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
1 year, 5 months
[frank-w-bpi-r2-4.14:5.4-wifi 8/10] include/linux/module.h:128:42: error: redefinition of '__inittest'
by kbuild test robot
tree: https://github.com/frank-w/BPI-R2-4.14 5.4-wifi
head: 247c0a1b4c448f34c618955cc97411eaed06056a
commit: 06e271284ac3bbfa5caec89477f66c1caa765b75 [8/10] mt6625l: try to fix wakeup_source_prepare build-error
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 7.4.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 06e271284ac3bbfa5caec89477f66c1caa765b75
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
In file included from drivers/watchdog/mtk_wdt.c:26:0:
>> include/linux/module.h:128:42: error: redefinition of '__inittest'
static inline initcall_t __maybe_unused __inittest(void) \
^
include/linux/module.h:121:28: note: in expansion of macro 'module_init'
#define late_initcall(fn) module_init(fn)
^~~~~~~~~~~
drivers/watchdog/mtk_wdt.c:612:1: note: in expansion of macro 'late_initcall'
late_initcall(wk_proc_init);
^~~~~~~~~~~~~
include/linux/module.h:128:42: note: previous definition of '__inittest' was here
static inline initcall_t __maybe_unused __inittest(void) \
^
include/linux/device.h:1903:1: note: in expansion of macro 'module_init'
module_init(__driver##_init); \
^~~~~~~~~~~
include/linux/platform_device.h:238:2: note: in expansion of macro 'module_driver'
module_driver(__platform_driver, platform_driver_register, \
^~~~~~~~~~~~~
drivers/watchdog/mtk_wdt.c:523:1: note: in expansion of macro 'module_platform_driver'
module_platform_driver(mtk_wdt_driver);
^~~~~~~~~~~~~~~~~~~~~~
>> include/linux/module.h:130:6: error: redefinition of 'init_module'
int init_module(void) __copy(initfn) __attribute__((alias(#initfn)));
^
include/linux/module.h:121:28: note: in expansion of macro 'module_init'
#define late_initcall(fn) module_init(fn)
^~~~~~~~~~~
drivers/watchdog/mtk_wdt.c:612:1: note: in expansion of macro 'late_initcall'
late_initcall(wk_proc_init);
^~~~~~~~~~~~~
include/linux/module.h:130:6: note: previous definition of 'init_module' was here
int init_module(void) __copy(initfn) __attribute__((alias(#initfn)));
^
include/linux/device.h:1903:1: note: in expansion of macro 'module_init'
module_init(__driver##_init); \
^~~~~~~~~~~
include/linux/platform_device.h:238:2: note: in expansion of macro 'module_driver'
module_driver(__platform_driver, platform_driver_register, \
^~~~~~~~~~~~~
drivers/watchdog/mtk_wdt.c:523:1: note: in expansion of macro 'module_platform_driver'
module_platform_driver(mtk_wdt_driver);
^~~~~~~~~~~~~~~~~~~~~~
--
In file included from drivers//watchdog/mtk_wdt.c:26:0:
>> include/linux/module.h:128:42: error: redefinition of '__inittest'
static inline initcall_t __maybe_unused __inittest(void) \
^
include/linux/module.h:121:28: note: in expansion of macro 'module_init'
#define late_initcall(fn) module_init(fn)
^~~~~~~~~~~
drivers//watchdog/mtk_wdt.c:612:1: note: in expansion of macro 'late_initcall'
late_initcall(wk_proc_init);
^~~~~~~~~~~~~
include/linux/module.h:128:42: note: previous definition of '__inittest' was here
static inline initcall_t __maybe_unused __inittest(void) \
^
include/linux/device.h:1903:1: note: in expansion of macro 'module_init'
module_init(__driver##_init); \
^~~~~~~~~~~
include/linux/platform_device.h:238:2: note: in expansion of macro 'module_driver'
module_driver(__platform_driver, platform_driver_register, \
^~~~~~~~~~~~~
drivers//watchdog/mtk_wdt.c:523:1: note: in expansion of macro 'module_platform_driver'
module_platform_driver(mtk_wdt_driver);
^~~~~~~~~~~~~~~~~~~~~~
>> include/linux/module.h:130:6: error: redefinition of 'init_module'
int init_module(void) __copy(initfn) __attribute__((alias(#initfn)));
^
include/linux/module.h:121:28: note: in expansion of macro 'module_init'
#define late_initcall(fn) module_init(fn)
^~~~~~~~~~~
drivers//watchdog/mtk_wdt.c:612:1: note: in expansion of macro 'late_initcall'
late_initcall(wk_proc_init);
^~~~~~~~~~~~~
include/linux/module.h:130:6: note: previous definition of 'init_module' was here
int init_module(void) __copy(initfn) __attribute__((alias(#initfn)));
^
include/linux/device.h:1903:1: note: in expansion of macro 'module_init'
module_init(__driver##_init); \
^~~~~~~~~~~
include/linux/platform_device.h:238:2: note: in expansion of macro 'module_driver'
module_driver(__platform_driver, platform_driver_register, \
^~~~~~~~~~~~~
drivers//watchdog/mtk_wdt.c:523:1: note: in expansion of macro 'module_platform_driver'
module_platform_driver(mtk_wdt_driver);
^~~~~~~~~~~~~~~~~~~~~~
vim +/__inittest +128 include/linux/module.h
0fd972a7d91d6e Paul Gortmaker 2015-05-01 125
0fd972a7d91d6e Paul Gortmaker 2015-05-01 126 /* Each module must use one module_init(). */
0fd972a7d91d6e Paul Gortmaker 2015-05-01 127 #define module_init(initfn) \
1f318a8bafcfba Arnd Bergmann 2017-02-01 @128 static inline initcall_t __maybe_unused __inittest(void) \
0fd972a7d91d6e Paul Gortmaker 2015-05-01 129 { return initfn; } \
a6e60d84989fa0 Miguel Ojeda 2019-01-19 @130 int init_module(void) __copy(initfn) __attribute__((alias(#initfn)));
0fd972a7d91d6e Paul Gortmaker 2015-05-01 131
:::::: The code at line 128 was first introduced by commit
:::::: 1f318a8bafcfba9f0d623f4870c4e890fd22e659 modules: mark __inittest/__exittest as __maybe_unused
:::::: TO: Arnd Bergmann <arnd(a)arndb.de>
:::::: CC: Jessica Yu <jeyu(a)redhat.com>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
1 year, 5 months
[linux-review:UPDATE-20191030-114108/Navid-Emamdoost/media-aspeed-video-Fix-memory-leaks-in-aspeed_video_probe/20191029-094840 1/1] drivers/media/platform/aspeed-video.c:1649:31: error: too few arguments to function 'devm_kzalloc'
by kbuild test robot
tree: https://github.com/0day-ci/linux/commits/UPDATE-20191030-114108/Navid-Ema...
head: 288254ab3cdfa3042ffe0d19f4345671b755659c
commit: 288254ab3cdfa3042ffe0d19f4345671b755659c [1/1] media: aspeed-video: Fix memory leaks in aspeed_video_probe
config: sparc64-allmodconfig (attached as .config)
compiler: sparc64-linux-gcc (GCC) 7.4.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 288254ab3cdfa3042ffe0d19f4345671b755659c
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=sparc64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
All error/warnings (new ones prefixed by >>):
drivers/media/platform/aspeed-video.c: In function 'aspeed_video_probe':
>> drivers/media/platform/aspeed-video.c:1649:44: warning: passing argument 1 of 'devm_kzalloc' makes pointer from integer without a cast [-Wint-conversion]
struct aspeed_video *video = devm_kzalloc(sizeof(*video), GFP_KERNEL);
^~~~~~
In file included from drivers/media/platform/aspeed-video.c:7:0:
include/linux/device.h:917:21: note: expected 'struct device *' but argument is of type 'long unsigned int'
static inline void *devm_kzalloc(struct device *dev, size_t size, gfp_t gfp)
^~~~~~~~~~~~
>> drivers/media/platform/aspeed-video.c:1649:31: error: too few arguments to function 'devm_kzalloc'
struct aspeed_video *video = devm_kzalloc(sizeof(*video), GFP_KERNEL);
^~~~~~~~~~~~
In file included from drivers/media/platform/aspeed-video.c:7:0:
include/linux/device.h:917:21: note: declared here
static inline void *devm_kzalloc(struct device *dev, size_t size, gfp_t gfp)
^~~~~~~~~~~~
vim +/devm_kzalloc +1649 drivers/media/platform/aspeed-video.c
1644
1645 static int aspeed_video_probe(struct platform_device *pdev)
1646 {
1647 int rc;
1648 struct resource *res;
> 1649 struct aspeed_video *video = devm_kzalloc(sizeof(*video), GFP_KERNEL);
1650
1651 if (!video)
1652 return -ENOMEM;
1653
1654 video->frame_rate = 30;
1655 video->dev = &pdev->dev;
1656 spin_lock_init(&video->lock);
1657 mutex_init(&video->video_lock);
1658 init_waitqueue_head(&video->wait);
1659 INIT_DELAYED_WORK(&video->res_work, aspeed_video_resolution_work);
1660 INIT_LIST_HEAD(&video->buffers);
1661
1662 res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
1663
1664 video->base = devm_ioremap_resource(video->dev, res);
1665
1666 if (IS_ERR(video->base))
1667 return PTR_ERR(video->base);
1668
1669 rc = aspeed_video_init(video);
1670 if (rc)
1671 return rc;
1672
1673 rc = aspeed_video_setup_video(video);
1674 if (rc)
1675 return rc;
1676
1677 return 0;
1678 }
1679
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
1 year, 5 months
[linux-sof-driver:pr/1394 24/33] sound/soc/sof/intel/hda-stream.c:596:5: error: implicit declaration of function 'snd_sof_pcm_period_elapsed'; did you mean 'snd_pcm_period_elapsed'?
by kbuild test robot
tree: https://github.com/thesofproject/linux pr/1394
head: 91b47936d70bd1c2aeca4aa61fc8016fd3e92474
commit: 774d0dd30e70aad952229de498530c85d40e39e2 [24/33] ASoC: SOF: partition audio-specific parts from the SOF core
config: x86_64-sof-customedconfig-sof-defconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-14) 7.4.0
reproduce:
git checkout 774d0dd30e70aad952229de498530c85d40e39e2
# save the attached .config to linux build tree
make ARCH=x86_64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
Note: the linux-sof-driver/pr/1394 HEAD 91b47936d70bd1c2aeca4aa61fc8016fd3e92474 builds fine.
It only hurts bisectibility.
All errors (new ones prefixed by >>):
sound/soc/sof/intel/hda-stream.c: In function 'hda_dsp_stream_check':
>> sound/soc/sof/intel/hda-stream.c:596:5: error: implicit declaration of function 'snd_sof_pcm_period_elapsed'; did you mean 'snd_pcm_period_elapsed'? [-Werror=implicit-function-declaration]
snd_sof_pcm_period_elapsed(s->substream);
^~~~~~~~~~~~~~~~~~~~~~~~~~
snd_pcm_period_elapsed
cc1: some warnings being treated as errors
vim +596 sound/soc/sof/intel/hda-stream.c
4a7d41d609ab1d Liam Girdwood 2018-05-09 571
dec1616a8441ae Ranjani Sridharan 2019-06-05 572 static bool hda_dsp_stream_check(struct hdac_bus *bus, u32 status)
4a7d41d609ab1d Liam Girdwood 2018-05-09 573 {
4a7d41d609ab1d Liam Girdwood 2018-05-09 574 struct sof_intel_hda_dev *sof_hda = bus_to_sof_hda(bus);
0e24a0d4b3bf76 Keyon Jie 2019-04-17 575 struct hdac_stream *s;
dec1616a8441ae Ranjani Sridharan 2019-06-05 576 bool active = false;
4a7d41d609ab1d Liam Girdwood 2018-05-09 577 u32 sd_status;
4a7d41d609ab1d Liam Girdwood 2018-05-09 578
4a7d41d609ab1d Liam Girdwood 2018-05-09 579 list_for_each_entry(s, &bus->stream_list, list) {
dec1616a8441ae Ranjani Sridharan 2019-06-05 580 if (status & BIT(s->index) && s->opened) {
4a7d41d609ab1d Liam Girdwood 2018-05-09 581 sd_status = snd_hdac_stream_readb(s, SD_STS);
4a7d41d609ab1d Liam Girdwood 2018-05-09 582
4a7d41d609ab1d Liam Girdwood 2018-05-09 583 dev_vdbg(bus->dev, "stream %d status 0x%x\n",
4a7d41d609ab1d Liam Girdwood 2018-05-09 584 s->index, sd_status);
4a7d41d609ab1d Liam Girdwood 2018-05-09 585
dec1616a8441ae Ranjani Sridharan 2019-06-05 586 snd_hdac_stream_writeb(s, SD_STS, sd_status);
4a7d41d609ab1d Liam Girdwood 2018-05-09 587
dec1616a8441ae Ranjani Sridharan 2019-06-05 588 active = true;
4a7d41d609ab1d Liam Girdwood 2018-05-09 589 if (!s->substream ||
4a7d41d609ab1d Liam Girdwood 2018-05-09 590 !s->running ||
4a7d41d609ab1d Liam Girdwood 2018-05-09 591 (sd_status & SOF_HDA_CL_DMA_SD_INT_COMPLETE) == 0)
4a7d41d609ab1d Liam Girdwood 2018-05-09 592 continue;
4a7d41d609ab1d Liam Girdwood 2018-05-09 593
4a7d41d609ab1d Liam Girdwood 2018-05-09 594 /* Inform ALSA only in case not do that with IPC */
4a7d41d609ab1d Liam Girdwood 2018-05-09 595 if (sof_hda->no_ipc_position)
0e24a0d4b3bf76 Keyon Jie 2019-04-17 @596 snd_sof_pcm_period_elapsed(s->substream);
dec1616a8441ae Ranjani Sridharan 2019-06-05 597 }
dec1616a8441ae Ranjani Sridharan 2019-06-05 598 }
4a7d41d609ab1d Liam Girdwood 2018-05-09 599
dec1616a8441ae Ranjani Sridharan 2019-06-05 600 return active;
4a7d41d609ab1d Liam Girdwood 2018-05-09 601 }
dec1616a8441ae Ranjani Sridharan 2019-06-05 602
:::::: The code at line 596 was first introduced by commit
:::::: 0e24a0d4b3bf76ef4ab1700fe59bea34aa84f296 ASoC: SOF: Intel: use snd_sof_pcm_period_elapsed
:::::: TO: Keyon Jie <yang.jie(a)linux.intel.com>
:::::: CC: Pierre Bossart <pierre-louis.bossart(a)linux.intel.com>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
1 year, 5 months
Re: [PATCH v2 3/4] mtd: rawnand: Add support manufacturer specific suspend/resume operation
by kbuild test robot
Hi Mason,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v5.4-rc5 next-20191029]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Mason-Yang/mtd-rawnand-Add-suppo...
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 23fdb198ae81f47a574296dab5167c5e136a02ba
reproduce: make htmldocs
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
Warning: The Sphinx 'sphinx_rtd_theme' HTML theme was not found. Make sure you have the theme installed to produce pretty HTML output. Falling back to the default theme.
WARNING: dot(1) not found, for better output quality install graphviz from http://www.graphviz.org
WARNING: convert(1) not found, for SVG to PDF conversion install ImageMagick (https://www.imagemagick.org)
include/linux/w1.h:277: warning: Function parameter or member 'of_match_table' not described in 'w1_family'
include/linux/regulator/machine.h:196: warning: Function parameter or member 'max_uV_step' not described in 'regulation_constraints'
include/linux/regulator/driver.h:223: warning: Function parameter or member 'resume' not described in 'regulator_ops'
include/linux/lsm_hooks.h:1822: warning: Function parameter or member 'quotactl' not described in 'security_list_options'
include/linux/lsm_hooks.h:1822: warning: Function parameter or member 'quota_on' not described in 'security_list_options'
include/linux/lsm_hooks.h:1822: warning: Function parameter or member 'sb_free_mnt_opts' not described in 'security_list_options'
include/linux/lsm_hooks.h:1822: warning: Function parameter or member 'sb_eat_lsm_opts' not described in 'security_list_options'
include/linux/lsm_hooks.h:1822: warning: Function parameter or member 'sb_kern_mount' not described in 'security_list_options'
include/linux/lsm_hooks.h:1822: warning: Function parameter or member 'sb_show_options' not described in 'security_list_options'
include/linux/lsm_hooks.h:1822: warning: Function parameter or member 'sb_add_mnt_opt' not described in 'security_list_options'
include/linux/lsm_hooks.h:1822: warning: Function parameter or member 'd_instantiate' not described in 'security_list_options'
include/linux/lsm_hooks.h:1822: warning: Function parameter or member 'getprocattr' not described in 'security_list_options'
include/linux/lsm_hooks.h:1822: warning: Function parameter or member 'setprocattr' not described in 'security_list_options'
include/linux/lsm_hooks.h:1822: warning: Function parameter or member 'locked_down' not described in 'security_list_options'
include/linux/spi/spi.h:190: warning: Function parameter or member 'driver_override' not described in 'spi_device'
fs/posix_acl.c:647: warning: Function parameter or member 'inode' not described in 'posix_acl_update_mode'
fs/posix_acl.c:647: warning: Function parameter or member 'mode_p' not described in 'posix_acl_update_mode'
fs/posix_acl.c:647: warning: Function parameter or member 'acl' not described in 'posix_acl_update_mode'
drivers/gpio/gpiolib-of.c:92: warning: Excess function parameter 'dev' description in 'of_gpio_need_valid_mask'
include/linux/i2c.h:337: warning: Function parameter or member 'init_irq' not described in 'i2c_client'
>> include/linux/mtd/rawnand.h:1145: warning: Function parameter or member '_suspend' not described in 'nand_chip'
>> include/linux/mtd/rawnand.h:1145: warning: Function parameter or member '_resume' not described in 'nand_chip'
include/linux/mtd/rawnand.h:1145: warning: Function parameter or member '_lock' not described in 'nand_chip'
include/linux/mtd/rawnand.h:1145: warning: Function parameter or member '_unlock' not described in 'nand_chip'
drivers/mtd/nand/raw/nand_base.c:4370: warning: Function parameter or member 'ofs' not described in 'nand_lock'
drivers/mtd/nand/raw/nand_base.c:4370: warning: Function parameter or member 'len' not described in 'nand_lock'
drivers/mtd/nand/raw/nand_base.c:4384: warning: Function parameter or member 'ofs' not described in 'nand_unlock'
drivers/mtd/nand/raw/nand_base.c:4384: warning: Function parameter or member 'len' not described in 'nand_unlock'
drivers/usb/typec/bus.c:1: warning: 'typec_altmode_unregister_driver' not found
drivers/usb/typec/bus.c:1: warning: 'typec_altmode_register_driver' not found
drivers/usb/typec/class.c:1: warning: 'typec_altmode_unregister_notifier' not found
drivers/usb/typec/class.c:1: warning: 'typec_altmode_register_notifier' not found
lib/genalloc.c:1: warning: 'gen_pool_add_virt' not found
lib/genalloc.c:1: warning: 'gen_pool_alloc' not found
lib/genalloc.c:1: warning: 'gen_pool_free' not found
lib/genalloc.c:1: warning: 'gen_pool_alloc_algo' not found
Error: Cannot open file drivers/dma-buf/reservation.c
Error: Cannot open file drivers/dma-buf/reservation.c
Error: Cannot open file drivers/dma-buf/reservation.c
Error: Cannot open file include/linux/reservation.h
Error: Cannot open file include/linux/reservation.h
kernel/dma/coherent.c:1: warning: no structured comments found
include/linux/input/sparse-keymap.h:43: warning: Function parameter or member 'sw' not described in 'key_entry'
include/linux/skbuff.h:888: warning: Function parameter or member 'dev_scratch' not described in 'sk_buff'
include/linux/skbuff.h:888: warning: Function parameter or member 'list' not described in 'sk_buff'
include/linux/skbuff.h:888: warning: Function parameter or member 'ip_defrag_offset' not described in 'sk_buff'
include/linux/skbuff.h:888: warning: Function parameter or member 'skb_mstamp_ns' not described in 'sk_buff'
include/linux/skbuff.h:888: warning: Function parameter or member '__cloned_offset' not described in 'sk_buff'
include/linux/skbuff.h:888: warning: Function parameter or member 'head_frag' not described in 'sk_buff'
include/linux/skbuff.h:888: warning: Function parameter or member '__pkt_type_offset' not described in 'sk_buff'
include/linux/skbuff.h:888: warning: Function parameter or member 'encapsulation' not described in 'sk_buff'
include/linux/skbuff.h:888: warning: Function parameter or member 'encap_hdr_csum' not described in 'sk_buff'
include/linux/skbuff.h:888: warning: Function parameter or member 'csum_valid' not described in 'sk_buff'
include/linux/skbuff.h:888: warning: Function parameter or member '__pkt_vlan_present_offset' not described in 'sk_buff'
include/linux/skbuff.h:888: warning: Function parameter or member 'vlan_present' not described in 'sk_buff'
include/linux/skbuff.h:888: warning: Function parameter or member 'csum_complete_sw' not described in 'sk_buff'
include/linux/skbuff.h:888: warning: Function parameter or member 'csum_level' not described in 'sk_buff'
include/linux/skbuff.h:888: warning: Function parameter or member 'inner_protocol_type' not described in 'sk_buff'
include/linux/skbuff.h:888: warning: Function parameter or member 'remcsum_offload' not described in 'sk_buff'
include/linux/skbuff.h:888: warning: Function parameter or member 'sender_cpu' not described in 'sk_buff'
include/linux/skbuff.h:888: warning: Function parameter or member 'reserved_tailroom' not described in 'sk_buff'
include/linux/skbuff.h:888: warning: Function parameter or member 'inner_ipproto' not described in 'sk_buff'
include/net/sock.h:233: warning: Function parameter or member 'skc_addrpair' not described in 'sock_common'
include/net/sock.h:233: warning: Function parameter or member 'skc_portpair' not described in 'sock_common'
include/net/sock.h:233: warning: Function parameter or member 'skc_ipv6only' not described in 'sock_common'
include/net/sock.h:233: warning: Function parameter or member 'skc_net_refcnt' not described in 'sock_common'
include/net/sock.h:233: warning: Function parameter or member 'skc_v6_daddr' not described in 'sock_common'
include/net/sock.h:233: warning: Function parameter or member 'skc_v6_rcv_saddr' not described in 'sock_common'
include/net/sock.h:233: warning: Function parameter or member 'skc_cookie' not described in 'sock_common'
include/net/sock.h:233: warning: Function parameter or member 'skc_listener' not described in 'sock_common'
include/net/sock.h:233: warning: Function parameter or member 'skc_tw_dr' not described in 'sock_common'
include/net/sock.h:233: warning: Function parameter or member 'skc_rcv_wnd' not described in 'sock_common'
include/net/sock.h:233: warning: Function parameter or member 'skc_tw_rcv_nxt' not described in 'sock_common'
include/net/sock.h:515: warning: Function parameter or member 'sk_rx_skb_cache' not described in 'sock'
include/net/sock.h:515: warning: Function parameter or member 'sk_wq_raw' not described in 'sock'
include/net/sock.h:515: warning: Function parameter or member 'tcp_rtx_queue' not described in 'sock'
include/net/sock.h:515: warning: Function parameter or member 'sk_tx_skb_cache' not described in 'sock'
include/net/sock.h:515: warning: Function parameter or member 'sk_route_forced_caps' not described in 'sock'
include/net/sock.h:515: warning: Function parameter or member 'sk_txtime_report_errors' not described in 'sock'
include/net/sock.h:515: warning: Function parameter or member 'sk_validate_xmit_skb' not described in 'sock'
include/net/sock.h:515: warning: Function parameter or member 'sk_bpf_storage' not described in 'sock'
include/net/sock.h:2450: warning: Function parameter or member 'tcp_rx_skb_cache_key' not described in 'DECLARE_STATIC_KEY_FALSE'
include/net/sock.h:2450: warning: Excess function parameter 'sk' description in 'DECLARE_STATIC_KEY_FALSE'
include/net/sock.h:2450: warning: Excess function parameter 'skb' description in 'DECLARE_STATIC_KEY_FALSE'
include/linux/netdevice.h:2053: warning: Function parameter or member 'gso_partial_features' not described in 'net_device'
include/linux/netdevice.h:2053: warning: Function parameter or member 'l3mdev_ops' not described in 'net_device'
include/linux/netdevice.h:2053: warning: Function parameter or member 'xfrmdev_ops' not described in 'net_device'
include/linux/netdevice.h:2053: warning: Function parameter or member 'tlsdev_ops' not described in 'net_device'
include/linux/netdevice.h:2053: warning: Function parameter or member 'name_assign_type' not described in 'net_device'
include/linux/netdevice.h:2053: warning: Function parameter or member 'ieee802154_ptr' not described in 'net_device'
include/linux/netdevice.h:2053: warning: Function parameter or member 'mpls_ptr' not described in 'net_device'
include/linux/netdevice.h:2053: warning: Function parameter or member 'xdp_prog' not described in 'net_device'
include/linux/netdevice.h:2053: warning: Function parameter or member 'gro_flush_timeout' not described in 'net_device'
include/linux/netdevice.h:2053: warning: Function parameter or member 'nf_hooks_ingress' not described in 'net_device'
include/linux/netdevice.h:2053: warning: Function parameter or member '____cacheline_aligned_in_smp' not described in 'net_device'
include/linux/netdevice.h:2053: warning: Function parameter or member 'qdisc_hash' not described in 'net_device'
include/linux/netdevice.h:2053: warning: Function parameter or member 'xps_cpus_map' not described in 'net_device'
include/linux/netdevice.h:2053: warning: Function parameter or member 'xps_rxqs_map' not described in 'net_device'
include/linux/phylink.h:56: warning: Function parameter or member '__ETHTOOL_DECLARE_LINK_MODE_MASK(advertising' not described in 'phylink_link_state'
include/linux/phylink.h:56: warning: Function parameter or member '__ETHTOOL_DECLARE_LINK_MODE_MASK(lp_advertising' not described in 'phylink_link_state'
include/linux/rculist.h:374: warning: Excess function parameter 'cond' description in 'list_for_each_entry_rcu'
include/linux/rculist.h:651: warning: Excess function parameter 'cond' description in 'hlist_for_each_entry_rcu'
mm/util.c:1: warning: 'get_user_pages_fast' not found
drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c:335: warning: Excess function parameter 'dev' description in 'amdgpu_gem_prime_export'
drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c:336: warning: Excess function parameter 'dev' description in 'amdgpu_gem_prime_export'
drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:142: warning: Function parameter or member 'blockable' not described in 'amdgpu_mn_read_lock'
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:347: warning: cannot understand function prototype: 'struct amdgpu_vm_pt_cursor '
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:348: warning: cannot understand function prototype: 'struct amdgpu_vm_pt_cursor '
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:494: warning: Function parameter or member 'start' not described in 'amdgpu_vm_pt_first_dfs'
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:546: warning: Function parameter or member 'adev' not described in 'for_each_amdgpu_vm_pt_dfs_safe'
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:546: warning: Function parameter or member 'vm' not described in 'for_each_amdgpu_vm_pt_dfs_safe'
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:546: warning: Function parameter or member 'start' not described in 'for_each_amdgpu_vm_pt_dfs_safe'
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:546: warning: Function parameter or member 'cursor' not described in 'for_each_amdgpu_vm_pt_dfs_safe'
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:546: warning: Function parameter or member 'entry' not described in 'for_each_amdgpu_vm_pt_dfs_safe'
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:821: warning: Function parameter or member 'level' not described in 'amdgpu_vm_bo_param'
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1283: warning: Function parameter or member 'params' not described in 'amdgpu_vm_update_flags'
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1283: warning: Function parameter or member 'bo' not described in 'amdgpu_vm_update_flags'
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1283: warning: Function parameter or member 'level' not described in 'amdgpu_vm_update_flags'
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1283: warning: Function parameter or member 'pe' not described in 'amdgpu_vm_update_flags'
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1283: warning: Function parameter or member 'addr' not described in 'amdgpu_vm_update_flags'
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1283: warning: Function parameter or member 'count' not described in 'amdgpu_vm_update_flags'
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:1283: warning: Function parameter or member 'incr' not described in 'amdgpu_vm_update_flags'
vim +1145 include/linux/mtd/rawnand.h
^1da177e4c3f41 include/linux/mtd/nand.h Linus Torvalds 2005-04-16 @1145
:::::: The code at line 1145 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2
:::::: TO: Linus Torvalds <torvalds(a)ppc970.osdl.org>
:::::: CC: Linus Torvalds <torvalds(a)ppc970.osdl.org>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
1 year, 5 months
Re: [PATCH v6 1/2] soc: samsung: Add Exynos Adaptive Supply Voltage driver
by kbuild test robot
Hi Sylwester,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v5.4-rc5]
[cannot apply to next-20191029]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Sylwester-Nawrocki/soc-samsung-A...
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 23fdb198ae81f47a574296dab5167c5e136a02ba
config: sparc64-allmodconfig (attached as .config)
compiler: sparc64-linux-gcc (GCC) 7.4.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=sparc64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
drivers/soc/samsung/exynos-asv.c: In function 'exynos_asv_update_cpu_opps':
>> drivers/soc/samsung/exynos-asv.c:67:9: error: implicit declaration of function 'dev_pm_opp_adjust_voltage'; did you mean 'dev_pm_opp_get_voltage'? [-Werror=implicit-function-declaration]
ret = dev_pm_opp_adjust_voltage(cpu, opp_freq * MHZ,
^~~~~~~~~~~~~~~~~~~~~~~~~
dev_pm_opp_get_voltage
cc1: some warnings being treated as errors
vim +67 drivers/soc/samsung/exynos-asv.c
27
28 static int exynos_asv_update_cpu_opps(struct exynos_asv *asv,
29 struct device *cpu)
30 {
31 struct exynos_asv_subsys *subsys = NULL;
32 struct dev_pm_opp *opp;
33 unsigned int opp_freq;
34 int i;
35
36 for (i = 0; i < ARRAY_SIZE(asv->subsys); i++) {
37 if (of_device_is_compatible(cpu->of_node,
38 asv->subsys[i].cpu_dt_compat)) {
39 subsys = &asv->subsys[i];
40 break;
41 }
42 }
43 if (!subsys)
44 return -EINVAL;
45
46 for (i = 0; i < subsys->table.num_rows; i++) {
47 unsigned int new_volt, volt;
48 int ret;
49
50 opp_freq = exynos_asv_opp_get_frequency(subsys, i);
51
52 opp = dev_pm_opp_find_freq_exact(cpu, opp_freq * MHZ, true);
53 if (IS_ERR(opp)) {
54 dev_info(asv->dev, "cpu%d opp%d, freq: %u missing\n",
55 cpu->id, i, opp_freq);
56
57 continue;
58 }
59
60 volt = dev_pm_opp_get_voltage(opp);
61 new_volt = asv->opp_get_voltage(subsys, i, volt);
62 dev_pm_opp_put(opp);
63
64 if (new_volt == volt)
65 continue;
66
> 67 ret = dev_pm_opp_adjust_voltage(cpu, opp_freq * MHZ,
68 new_volt, new_volt, new_volt);
69 if (ret < 0)
70 dev_err(asv->dev,
71 "Failed to adjust OPP %u Hz/%u uV for cpu%d\n",
72 opp_freq, new_volt, cpu->id);
73 else
74 dev_dbg(asv->dev,
75 "Adjusted OPP %u Hz/%u -> %u uV, cpu%d\n",
76 opp_freq, volt, new_volt, cpu->id);
77 }
78
79 return 0;
80 }
81
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
1 year, 5 months