[RFC PATCH] ext4: __ext4_fc_track_range() can be static
by kbuild test robot
Fixes: 9b03f2f7eee6 ("ext4: add generic diff tracking routines and range tracking")
Signed-off-by: kbuild test robot <lkp(a)intel.com>
---
ext4_jbd2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ext4/ext4_jbd2.c b/fs/ext4/ext4_jbd2.c
index 0907b1b913013..b65625bbe7146 100644
--- a/fs/ext4/ext4_jbd2.c
+++ b/fs/ext4/ext4_jbd2.c
@@ -414,7 +414,7 @@ struct __ext4_fc_track_range_args {
#define MIN(__a, __b) ((__a) < (__b) ? (__a) : (__b))
#define MAX(__a, __b) ((__a) > (__b) ? (__a) : (__b))
-int __ext4_fc_track_range(struct inode *inode, void *arg, bool update)
+static int __ext4_fc_track_range(struct inode *inode, void *arg, bool update)
{
struct ext4_inode_info *ei = EXT4_I(inode);
struct __ext4_fc_track_range_args *__arg =
2 years
Re: [RFC PATCH] PCI, kdump: Clear bus master bit upon shutdown in kdump kernel
by kbuild test robot
Hi Kairui,
[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on pci/next]
[also build test WARNING on linux/master linus/master v5.5-rc3 next-20191220]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Kairui-Song/PCI-kdump-Clear-bus-...
base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-129-g341daf20-dirty
make ARCH=x86_64 allmodconfig
make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
sparse warnings: (new ones prefixed by >>)
>> drivers/pci/quirks.c:210:36: sparse: sparse: incorrect type in assignment (different base types)
>> drivers/pci/quirks.c:210:36: sparse: expected restricted pci_power_t [usertype] current_state
>> drivers/pci/quirks.c:210:36: sparse: got int
drivers/pci/quirks.c:2241:57: sparse: sparse: restricted pci_power_t degrades to integer
vim +210 drivers/pci/quirks.c
195
196 /*
197 * Read the device state even if it's not enabled. The device could be
198 * activated by previous crashed kernel, this will read and correct the
199 * cached state.
200 */
201 static void quirk_read_pm_state_in_kdump(struct pci_dev *dev)
202 {
203 u16 pmcsr;
204
205 if (!is_kdump_kernel())
206 return;
207
208 if (dev->pm_cap) {
209 pci_read_config_word(dev, dev->pm_cap + PCI_PM_CTRL, &pmcsr);
> 210 dev->current_state = (pmcsr & PCI_PM_CTRL_STATE_MASK);
211 }
212 }
213 DECLARE_PCI_FIXUP_FINAL(PCI_ANY_ID, PCI_ANY_ID, quirk_read_pm_state_in_kdump);
214
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
2 years
Re: [Intel-gfx] [PATCH 1/3] drm/i915: Introduce remap_io_sg() to prefault discontiguous objects
by kbuild test robot
Hi Abdiel,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on drm-tip/drm-tip v5.5-rc3 next-20191220]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Abdiel-Janulgue/drm-i915-Introdu...
base: git://anongit.freedesktop.org/drm-intel for-linux-next
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-129-g341daf20-dirty
make ARCH=x86_64 allmodconfig
make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
sparse warnings: (new ones prefixed by >>)
>> drivers/gpu/drm/i915/i915_mm.c:130:32: sparse: sparse: Using plain integer as NULL pointer
vim +130 drivers/gpu/drm/i915/i915_mm.c
114
115 /**
116 * remap_io_sg - remap an IO mapping to userspace
117 * @vma: user vma to map to
118 * @addr: target user address to start at
119 * @io_start: IO start
120 * @sgl: Start sg entry
121 * @size: size of map area
122 * @iomap: the source io_mapping
123 *
124 * Note: this is only safe if the mm semaphore is held when called.
125 */
126 int remap_io_sg(struct vm_area_struct *vma,
127 unsigned long addr, resource_size_t io_start, struct scatterlist *sgl,
128 unsigned long size, struct io_mapping *iomap)
129 {
> 130 struct remap_pfn r = { 0 };
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
2 years
[sashal-linux-stable:queue-4.9 1/94] fs/btrfs/tree-log.c:5718:71: sparse: sparse: incorrect type in argument 1 (different base types)
by kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git queue-4.9
head: 6796cb2db8075fdda99996f1b37724d6fb9c9704
commit: eed59e28a608af780cd49d5578fe70ab1313485b [1/94] btrfs: skip log replay on orphaned roots
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-129-g341daf20-dirty
git checkout eed59e28a608af780cd49d5578fe70ab1313485b
make ARCH=x86_64 allmodconfig
make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
sparse warnings: (new ones prefixed by >>)
>> fs/btrfs/tree-log.c:5718:71: sparse: sparse: incorrect type in argument 1 (different base types)
>> fs/btrfs/tree-log.c:5718:71: sparse: expected struct btrfs_root *root
>> fs/btrfs/tree-log.c:5718:71: sparse: got struct btrfs_fs_info *fs_info
arch/x86/include/asm/bitops.h:115:37: sparse: sparse: cast truncates bits from constant value (ffffff7f becomes 7f)
arch/x86/include/asm/bitops.h:115:37: sparse: sparse: cast truncates bits from constant value (ffffff7f becomes 7f)
arch/x86/include/asm/bitops.h:115:37: sparse: sparse: cast truncates bits from constant value (ffffff7f becomes 7f)
fs/btrfs/tree-log.c: In function 'btrfs_recover_log_trees':
fs/btrfs/tree-log.c:5718:43: error: passing argument 1 of 'btrfs_pin_extent_for_log_replay' from incompatible pointer type [-Werror=incompatible-pointer-types]
ret = btrfs_pin_extent_for_log_replay(fs_info,
^~~~~~~
In file included from fs/btrfs/tree-log.h:22:0,
from fs/btrfs/tree-log.c:23:
fs/btrfs/ctree.h:2578:5: note: expected 'struct btrfs_root *' but argument is of type 'struct btrfs_fs_info *'
int btrfs_pin_extent_for_log_replay(struct btrfs_root *root,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +5718 fs/btrfs/tree-log.c
5624
5625 /*
5626 * should be called during mount to recover any replay any log trees
5627 * from the FS
5628 */
5629 int btrfs_recover_log_trees(struct btrfs_root *log_root_tree)
5630 {
5631 int ret;
5632 struct btrfs_path *path;
5633 struct btrfs_trans_handle *trans;
5634 struct btrfs_key key;
5635 struct btrfs_key found_key;
5636 struct btrfs_key tmp_key;
5637 struct btrfs_root *log;
5638 struct btrfs_fs_info *fs_info = log_root_tree->fs_info;
5639 struct walk_control wc = {
5640 .process_func = process_one_buffer,
5641 .stage = 0,
5642 };
5643
5644 path = btrfs_alloc_path();
5645 if (!path)
5646 return -ENOMEM;
5647
5648 set_bit(BTRFS_FS_LOG_RECOVERING, &fs_info->flags);
5649
5650 trans = btrfs_start_transaction(fs_info->tree_root, 0);
5651 if (IS_ERR(trans)) {
5652 ret = PTR_ERR(trans);
5653 goto error;
5654 }
5655
5656 wc.trans = trans;
5657 wc.pin = 1;
5658
5659 ret = walk_log_tree(trans, log_root_tree, &wc);
5660 if (ret) {
5661 btrfs_handle_fs_error(fs_info, ret,
5662 "Failed to pin buffers while recovering log root tree.");
5663 goto error;
5664 }
5665
5666 again:
5667 key.objectid = BTRFS_TREE_LOG_OBJECTID;
5668 key.offset = (u64)-1;
5669 key.type = BTRFS_ROOT_ITEM_KEY;
5670
5671 while (1) {
5672 ret = btrfs_search_slot(NULL, log_root_tree, &key, path, 0, 0);
5673
5674 if (ret < 0) {
5675 btrfs_handle_fs_error(fs_info, ret,
5676 "Couldn't find tree log root.");
5677 goto error;
5678 }
5679 if (ret > 0) {
5680 if (path->slots[0] == 0)
5681 break;
5682 path->slots[0]--;
5683 }
5684 btrfs_item_key_to_cpu(path->nodes[0], &found_key,
5685 path->slots[0]);
5686 btrfs_release_path(path);
5687 if (found_key.objectid != BTRFS_TREE_LOG_OBJECTID)
5688 break;
5689
5690 log = btrfs_read_fs_root(log_root_tree, &found_key);
5691 if (IS_ERR(log)) {
5692 ret = PTR_ERR(log);
5693 btrfs_handle_fs_error(fs_info, ret,
5694 "Couldn't read tree log root.");
5695 goto error;
5696 }
5697
5698 tmp_key.objectid = found_key.offset;
5699 tmp_key.type = BTRFS_ROOT_ITEM_KEY;
5700 tmp_key.offset = (u64)-1;
5701
5702 wc.replay_dest = btrfs_read_fs_root_no_name(fs_info, &tmp_key);
5703 if (IS_ERR(wc.replay_dest)) {
5704 ret = PTR_ERR(wc.replay_dest);
5705
5706 /*
5707 * We didn't find the subvol, likely because it was
5708 * deleted. This is ok, simply skip this log and go to
5709 * the next one.
5710 *
5711 * We need to exclude the root because we can't have
5712 * other log replays overwriting this log as we'll read
5713 * it back in a few more times. This will keep our
5714 * block from being modified, and we'll just bail for
5715 * each subsequent pass.
5716 */
5717 if (ret == -ENOENT)
> 5718 ret = btrfs_pin_extent_for_log_replay(fs_info,
5719 log->node->start,
5720 log->node->len);
5721 free_extent_buffer(log->node);
5722 free_extent_buffer(log->commit_root);
5723 kfree(log);
5724
5725 if (!ret)
5726 goto next;
5727 btrfs_handle_fs_error(fs_info, ret,
5728 "Couldn't read target root for tree log recovery.");
5729 goto error;
5730 }
5731
5732 wc.replay_dest->log_root = log;
5733 btrfs_record_root_in_trans(trans, wc.replay_dest);
5734 ret = walk_log_tree(trans, log, &wc);
5735
5736 if (!ret && wc.stage == LOG_WALK_REPLAY_ALL) {
5737 ret = fixup_inode_link_counts(trans, wc.replay_dest,
5738 path);
5739 }
5740
5741 if (!ret && wc.stage == LOG_WALK_REPLAY_ALL) {
5742 struct btrfs_root *root = wc.replay_dest;
5743
5744 btrfs_release_path(path);
5745
5746 /*
5747 * We have just replayed everything, and the highest
5748 * objectid of fs roots probably has changed in case
5749 * some inode_item's got replayed.
5750 *
5751 * root->objectid_mutex is not acquired as log replay
5752 * could only happen during mount.
5753 */
5754 ret = btrfs_find_highest_objectid(root,
5755 &root->highest_objectid);
5756 }
5757
5758 wc.replay_dest->log_root = NULL;
5759 free_extent_buffer(log->node);
5760 free_extent_buffer(log->commit_root);
5761 kfree(log);
5762
5763 if (ret)
5764 goto error;
5765 next:
5766 if (found_key.offset == 0)
5767 break;
5768 key.offset = found_key.offset - 1;
5769 }
5770 btrfs_release_path(path);
5771
5772 /* step one is to pin it all, step two is to replay just inodes */
5773 if (wc.pin) {
5774 wc.pin = 0;
5775 wc.process_func = replay_one_buffer;
5776 wc.stage = LOG_WALK_REPLAY_INODES;
5777 goto again;
5778 }
5779 /* step three is to replay everything */
5780 if (wc.stage < LOG_WALK_REPLAY_ALL) {
5781 wc.stage++;
5782 goto again;
5783 }
5784
5785 btrfs_free_path(path);
5786
5787 /* step 4: commit the transaction, which also unpins the blocks */
5788 ret = btrfs_commit_transaction(trans, fs_info->tree_root);
5789 if (ret)
5790 return ret;
5791
5792 free_extent_buffer(log_root_tree->node);
5793 log_root_tree->log_root = NULL;
5794 clear_bit(BTRFS_FS_LOG_RECOVERING, &fs_info->flags);
5795 kfree(log_root_tree);
5796
5797 return 0;
5798 error:
5799 if (wc.trans)
5800 btrfs_end_transaction(wc.trans, fs_info->tree_root);
5801 btrfs_free_path(path);
5802 return ret;
5803 }
5804
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
2 years
Re: [PATCH v2 5/6] KVM: arm64: Add interface to support VCPU preempted check
by kbuild test robot
Hi Zengruan,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on kvmarm/next]
[also build test ERROR on kvm/linux-next linus/master v5.5-rc3 next-20191220]
[cannot apply to arm64/for-next/core]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Zengruan-Ye/KVM-arm64-VCPU-preem...
base: https://git.kernel.org/pub/scm/linux/kernel/git/kvmarm/kvmarm.git next
config: arm64-alldefconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 7.5.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.5.0 make.cross ARCH=arm64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
In file included from include/linux/spinlock.h:89:0,
from include/linux/radix-tree.h:16,
from include/linux/idr.h:15,
from include/linux/kernfs.h:13,
from include/linux/sysfs.h:16,
from include/linux/kobject.h:20,
from include/linux/of.h:17,
from include/linux/irqdomain.h:35,
from include/linux/acpi.h:13,
from include/acpi/apei.h:9,
from include/acpi/ghes.h:5,
from include/linux/arm_sdei.h:8,
from arch/arm64/kernel/asm-offsets.c:10:
arch/arm64/include/asm/spinlock.h: In function 'vcpu_is_preempted':
>> arch/arm64/include/asm/spinlock.h:18:9: error: implicit declaration of function 'pv_vcpu_is_preempted'; did you mean 'vcpu_is_preempted'? [-Werror=implicit-function-declaration]
return pv_vcpu_is_preempted(cpu);
^~~~~~~~~~~~~~~~~~~~
vcpu_is_preempted
cc1: some warnings being treated as errors
make[2]: *** [arch/arm64/kernel/asm-offsets.s] Error 1
make[2]: Target '__build' not remade because of errors.
make[1]: *** [prepare0] Error 2
make[1]: Target 'prepare' not remade because of errors.
make: *** [sub-make] Error 2
27 real 5 user 7 sys 48.63% cpu make prepare
vim +18 arch/arm64/include/asm/spinlock.h
14
15 #define vcpu_is_preempted vcpu_is_preempted
16 static inline bool vcpu_is_preempted(long cpu)
17 {
> 18 return pv_vcpu_is_preempted(cpu);
19 }
20
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
2 years
[peterz-queue:mm/tlb 14/17] mm/memory.c:4750:0: error: unterminated argument list invoking macro "tlb_remove_table"
by kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git mm/tlb
head: e5369740466c339f1bf7e0c114bb7de63df268a1
commit: 6845c64eb090385695a595e3788f104e38666409 [14/17] ia64/tlb: Fix __p*_free_tlb()
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 7.5.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 6845c64eb090385695a595e3788f104e38666409
# save the attached .config to linux build tree
GCC_VERSION=7.5.0 make.cross ARCH=ia64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
mm/memory.c: In function 'free_pmd_range':
>> mm/memory.c:4750:0: error: unterminated argument list invoking macro "tlb_remove_table"
#endif
In file included from mm/memory.c:79:0:
>> arch/ia64/include/asm/pgalloc.h:75:2: error: 'tlb_remove_table' undeclared (first use in this function); did you mean 'tlb_remove_page'?
tlb_remove_table((tlb), virt_to_page(pmd)
^
include/asm-generic/tlb.h:591:3: note: in expansion of macro '__pmd_free_tlb'
__pmd_free_tlb(tlb, pmdp, address); \
^~~~~~~~~~~~~~
mm/memory.c:252:2: note: in expansion of macro 'pmd_free_tlb'
pmd_free_tlb(tlb, pmd, start);
^~~~~~~~~~~~
arch/ia64/include/asm/pgalloc.h:75:2: note: each undeclared identifier is reported only once for each function it appears in
tlb_remove_table((tlb), virt_to_page(pmd)
^
include/asm-generic/tlb.h:591:3: note: in expansion of macro '__pmd_free_tlb'
__pmd_free_tlb(tlb, pmdp, address); \
^~~~~~~~~~~~~~
mm/memory.c:252:2: note: in expansion of macro 'pmd_free_tlb'
pmd_free_tlb(tlb, pmd, start);
^~~~~~~~~~~~
>> mm/memory.c:252:2: error: expected ';' at end of input
>> mm/memory.c:252:2: error: expected declaration or statement at end of input
>> mm/memory.c:252:2: error: expected declaration or statement at end of input
At top level:
mm/memory.c:191:13: warning: 'check_sync_rss_stat' defined but not used [-Wunused-function]
static void check_sync_rss_stat(struct task_struct *task)
^~~~~~~~~~~~~~~~~~~
mm/memory.c:177:13: warning: 'add_mm_counter_fast' defined but not used [-Wunused-function]
static void add_mm_counter_fast(struct mm_struct *mm, int member, int val)
^~~~~~~~~~~~~~~~~~~
vim +/tlb_remove_table +4750 mm/memory.c
49076ec2ccaf68 Kirill A. Shutemov 2013-11-14 4745
539edb5846c740 Peter Zijlstra 2013-11-14 4746 void ptlock_free(struct page *page)
49076ec2ccaf68 Kirill A. Shutemov 2013-11-14 4747 {
b35f1819acd924 Kirill A. Shutemov 2014-01-21 4748 kmem_cache_free(page_ptl_cachep, page->ptl);
49076ec2ccaf68 Kirill A. Shutemov 2013-11-14 4749 }
49076ec2ccaf68 Kirill A. Shutemov 2013-11-14 @4750 #endif
:::::: The code at line 4750 was first introduced by commit
:::::: 49076ec2ccaf68610aa03d96bced9a6694b93ca1 mm: dynamically allocate page->ptl if it cannot be embedded to struct page
:::::: TO: Kirill A. Shutemov <kirill.shutemov(a)linux.intel.com>
:::::: CC: Linus Torvalds <torvalds(a)linux-foundation.org>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
2 years
Re: [PATCH net-next 2/3] net: dsa: sja1105: Use PTP core's dedicated kernel thread for RX timestamping
by kbuild test robot
Hi Vladimir,
I love your patch! Yet something to improve:
[auto build test ERROR on net-next/master]
[also build test ERROR on net/master linus/master v5.5-rc3 next-20191220]
[cannot apply to sparc-next/master]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Vladimir-Oltean/Improvements-to-...
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 0914d2bb11cc182039084ac3b961dc359b647468
config: sparc64-randconfig-a001-20191226 (attached as .config)
compiler: sparc64-linux-gcc (GCC) 7.5.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.5.0 make.cross ARCH=sparc64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
drivers/net/dsa/sja1105/sja1105_ptp.c: In function 'sja1105_change_rxtstamping':
drivers/net/dsa/sja1105/sja1105_ptp.c:86:27: warning: unused variable 'ptp_data' [-Wunused-variable]
struct sja1105_ptp_data *ptp_data = &priv->ptp_data;
^~~~~~~~
drivers/net/dsa/sja1105/sja1105_ptp.c: In function 'sja1105_ptp_clock_unregister':
>> drivers/net/dsa/sja1105/sja1105_ptp.c:654:2: error: implicit declaration of function 'ptp_cancel_worker_sync'; did you mean 'cancel_work_sync'? [-Werror=implicit-function-declaration]
ptp_cancel_worker_sync(ptp_data->clock);
^~~~~~~~~~~~~~~~~~~~~~
cancel_work_sync
cc1: some warnings being treated as errors
vim +654 drivers/net/dsa/sja1105/sja1105_ptp.c
645
646 void sja1105_ptp_clock_unregister(struct dsa_switch *ds)
647 {
648 struct sja1105_private *priv = ds->priv;
649 struct sja1105_ptp_data *ptp_data = &priv->ptp_data;
650
651 if (IS_ERR_OR_NULL(ptp_data->clock))
652 return;
653
> 654 ptp_cancel_worker_sync(ptp_data->clock);
655 skb_queue_purge(&ptp_data->skb_rxtstamp_queue);
656 ptp_clock_unregister(ptp_data->clock);
657 ptp_data->clock = NULL;
658 }
659
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
2 years
[RFC PATCH] perf/core: perf_event_cgroup() can be static
by kbuild test robot
Fixes: 2e314b0982ba ("perf/core: Add PERF_RECORD_CGROUP event")
Signed-off-by: kbuild test robot <lkp(a)intel.com>
---
core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/events/core.c b/kernel/events/core.c
index f8f796b80ffb2..dbc46b884505f 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -7615,7 +7615,7 @@ static void perf_event_cgroup_output(struct perf_event *event, void *data)
cgroup_event->event_id.header.size = header_size;
}
-void perf_event_cgroup(struct cgroup *cgrp)
+static void perf_event_cgroup(struct cgroup *cgrp)
{
struct perf_cgroup_event cgroup_event;
char path_enomem[16] = "//enomem";
2 years
Re: [PATCH 1/9] perf/core: Add PERF_RECORD_CGROUP event
by kbuild test robot
Hi Namhyung,
I love your patch! Perhaps something to improve:
[auto build test WARNING on tip/auto-latest]
[also build test WARNING on linux/master linus/master v5.5-rc3 next-20191219]
[cannot apply to tip/perf/core]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Namhyung-Kim/perf-Improve-cgroup...
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git ec7b10f2d023bd79cf067c60c194f72a6d672319
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-129-g341daf20-dirty
make ARCH=x86_64 allmodconfig
make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
sparse warnings: (new ones prefixed by >>)
kernel/events/core.c:572:26: sparse: sparse: function 'perf_pmu_name' with external linkage has definition
kernel/events/core.c:1385:15: sparse: sparse: incompatible types in comparison expression (different address spaces):
kernel/events/core.c:1385:15: sparse: struct perf_event_context [noderef] <asn:4> *
kernel/events/core.c:1385:15: sparse: struct perf_event_context *
kernel/events/core.c:1398:28: sparse: sparse: incompatible types in comparison expression (different address spaces):
kernel/events/core.c:1398:28: sparse: struct perf_event_context [noderef] <asn:4> *
kernel/events/core.c:1398:28: sparse: struct perf_event_context *
kernel/events/core.c:3222:18: sparse: sparse: incompatible types in comparison expression (different address spaces):
kernel/events/core.c:3222:18: sparse: struct perf_event_context [noderef] <asn:4> *
kernel/events/core.c:3222:18: sparse: struct perf_event_context *
kernel/events/core.c:3223:23: sparse: sparse: incompatible types in comparison expression (different address spaces):
kernel/events/core.c:3223:23: sparse: struct perf_event_context [noderef] <asn:4> *
kernel/events/core.c:3223:23: sparse: struct perf_event_context *
kernel/events/core.c:3265:25: sparse: sparse: incompatible types in comparison expression (different address spaces):
kernel/events/core.c:3265:25: sparse: struct perf_event_context [noderef] <asn:4> *
kernel/events/core.c:3265:25: sparse: struct perf_event_context *
kernel/events/core.c:3266:25: sparse: sparse: incompatible types in comparison expression (different address spaces):
kernel/events/core.c:3266:25: sparse: struct perf_event_context [noderef] <asn:4> *
kernel/events/core.c:3266:25: sparse: struct perf_event_context *
kernel/events/core.c:4341:25: sparse: sparse: incompatible types in comparison expression (different address spaces):
kernel/events/core.c:4341:25: sparse: struct perf_event_context [noderef] <asn:4> *
kernel/events/core.c:4341:25: sparse: struct perf_event_context *
kernel/events/core.c:5599:9: sparse: sparse: incompatible types in comparison expression (different address spaces):
kernel/events/core.c:5599:9: sparse: struct ring_buffer [noderef] <asn:4> *
kernel/events/core.c:5599:9: sparse: struct ring_buffer *
kernel/events/core.c:5075:24: sparse: sparse: incorrect type in assignment (different base types)
kernel/events/core.c:5075:24: sparse: expected restricted __poll_t [usertype] events
kernel/events/core.c:5075:24: sparse: got int
kernel/events/core.c:5305:22: sparse: sparse: incompatible types in comparison expression (different address spaces):
kernel/events/core.c:5305:22: sparse: struct ring_buffer [noderef] <asn:4> *
kernel/events/core.c:5305:22: sparse: struct ring_buffer *
kernel/events/core.c:5441:14: sparse: sparse: incompatible types in comparison expression (different address spaces):
kernel/events/core.c:5441:14: sparse: struct ring_buffer [noderef] <asn:4> *
kernel/events/core.c:5441:14: sparse: struct ring_buffer *
kernel/events/core.c:5474:14: sparse: sparse: incompatible types in comparison expression (different address spaces):
kernel/events/core.c:5474:14: sparse: struct ring_buffer [noderef] <asn:4> *
kernel/events/core.c:5474:14: sparse: struct ring_buffer *
kernel/events/core.c:5531:14: sparse: sparse: incompatible types in comparison expression (different address spaces):
kernel/events/core.c:5531:14: sparse: struct ring_buffer [noderef] <asn:4> *
kernel/events/core.c:5531:14: sparse: struct ring_buffer *
kernel/events/core.c:5617:14: sparse: sparse: incompatible types in comparison expression (different address spaces):
kernel/events/core.c:5617:14: sparse: struct ring_buffer [noderef] <asn:4> *
kernel/events/core.c:5617:14: sparse: struct ring_buffer *
kernel/events/core.c:5630:14: sparse: sparse: incompatible types in comparison expression (different address spaces):
kernel/events/core.c:5630:14: sparse: struct ring_buffer [noderef] <asn:4> *
kernel/events/core.c:5630:14: sparse: struct ring_buffer *
kernel/events/internal.h:204:1: sparse: sparse: incorrect type in argument 2 (different address spaces)
kernel/events/internal.h:204:1: sparse: expected void const [noderef] <asn:1> *from
kernel/events/internal.h:204:1: sparse: got void const *buf
kernel/events/core.c:6305:6: sparse: sparse: symbol 'perf_pmu_snapshot_aux' was not declared. Should it be static?
kernel/events/core.c:7094:23: sparse: sparse: incompatible types in comparison expression (different address spaces):
kernel/events/core.c:7094:23: sparse: struct perf_event_context [noderef] <asn:4> *
kernel/events/core.c:7094:23: sparse: struct perf_event_context *
kernel/events/core.c:7185:13: sparse: sparse: incompatible types in comparison expression (different address spaces):
kernel/events/core.c:7185:13: sparse: struct ring_buffer [noderef] <asn:4> *
kernel/events/core.c:7185:13: sparse: struct ring_buffer *
>> kernel/events/core.c:7618:6: sparse: sparse: symbol 'perf_event_cgroup' was not declared. Should it be static?
kernel/events/core.c:7972:23: sparse: sparse: incompatible types in comparison expression (different address spaces):
kernel/events/core.c:7972:23: sparse: struct perf_event_context [noderef] <asn:4> *
kernel/events/core.c:7972:23: sparse: struct perf_event_context *
kernel/events/core.c:8702:17: sparse: sparse: incompatible types in comparison expression (different address spaces):
kernel/events/core.c:8702:17: sparse: struct swevent_hlist [noderef] <asn:4> *
kernel/events/core.c:8702:17: sparse: struct swevent_hlist *
kernel/events/core.c:8722:17: sparse: sparse: incompatible types in comparison expression (different address spaces):
kernel/events/core.c:8722:17: sparse: struct swevent_hlist [noderef] <asn:4> *
kernel/events/core.c:8722:17: sparse: struct swevent_hlist *
kernel/events/core.c:8842:16: sparse: sparse: incompatible types in comparison expression (different address spaces):
kernel/events/core.c:8842:16: sparse: struct swevent_hlist [noderef] <asn:4> *
kernel/events/core.c:8842:16: sparse: struct swevent_hlist *
kernel/events/core.c:8853:9: sparse: sparse: incompatible types in comparison expression (different address spaces):
kernel/events/core.c:8853:9: sparse: struct swevent_hlist [noderef] <asn:4> *
kernel/events/core.c:8853:9: sparse: struct swevent_hlist *
kernel/events/core.c:8842:16: sparse: sparse: incompatible types in comparison expression (different address spaces):
kernel/events/core.c:8842:16: sparse: struct swevent_hlist [noderef] <asn:4> *
kernel/events/core.c:8842:16: sparse: struct swevent_hlist *
kernel/events/core.c:8892:17: sparse: sparse: incompatible types in comparison expression (different address spaces):
kernel/events/core.c:8892:17: sparse: struct swevent_hlist [noderef] <asn:4> *
kernel/events/core.c:8892:17: sparse: struct swevent_hlist *
kernel/events/core.c:9073:23: sparse: sparse: incompatible types in comparison expression (different address spaces):
kernel/events/core.c:9073:23: sparse: struct perf_event_context [noderef] <asn:4> *
kernel/events/core.c:9073:23: sparse: struct perf_event_context *
kernel/events/core.c:10244:1: sparse: sparse: symbol 'dev_attr_nr_addr_filters' was not declared. Should it be static?
kernel/events/core.c:11967:9: sparse: sparse: incompatible types in comparison expression (different address spaces):
kernel/events/core.c:11967:9: sparse: struct perf_event_context [noderef] <asn:4> *
kernel/events/core.c:11967:9: sparse: struct perf_event_context *
kernel/events/core.c:12077:17: sparse: sparse: incompatible types in comparison expression (different address spaces):
kernel/events/core.c:12077:17: sparse: struct perf_event_context [noderef] <asn:4> *
kernel/events/core.c:12077:17: sparse: struct perf_event_context *
kernel/events/core.c:8842:16: sparse: sparse: incompatible types in comparison expression (different address spaces):
kernel/events/core.c:8842:16: sparse: struct swevent_hlist [noderef] <asn:4> *
kernel/events/core.c:8842:16: sparse: struct swevent_hlist *
kernel/events/core.c:12501:17: sparse: sparse: incompatible types in comparison expression (different address spaces):
kernel/events/core.c:12501:17: sparse: struct swevent_hlist [noderef] <asn:4> *
kernel/events/core.c:12501:17: sparse: struct swevent_hlist *
kernel/events/core.c:155:9: sparse: sparse: context imbalance in 'perf_ctx_lock' - wrong count at exit
kernel/events/core.c:163:17: sparse: sparse: context imbalance in 'perf_ctx_unlock' - unexpected unlock
kernel/events/core.c:1405:17: sparse: sparse: context imbalance in 'perf_lock_task_context' - different lock contexts for basic block
kernel/events/core.c:1432:17: sparse: sparse: context imbalance in 'perf_pin_task_context' - unexpected unlock
kernel/events/core.c:2652:9: sparse: sparse: context imbalance in '__perf_install_in_context' - wrong count at exit
kernel/events/core.c:4313:17: sparse: sparse: context imbalance in 'find_get_context' - unexpected unlock
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
2 years