[mptcp:t/mptcp-Implement-path-manager-interface-commands 23/25] net/mptcp/pm.c:46:8: error: implicit declaration of function 'mptcp_subflow_connect'; did you mean 'mptcp_subflow_init'?
by kbuild test robot
tree: https://github.com/multipath-tcp/mptcp_net-next.git t/mptcp-Implement-path-manager-interface-commands
head: a28e79bf6de027fea5d0522a32a686aacf5658a7
commit: eba1df51e6151d1cc04a559911cf905992581b22 [23/25] tgupdate: merge t/mptcp-Implement-path-manager-interface-commands base into t/mptcp-Implement-path-manager-interface-commands
config: openrisc-randconfig-a001-20200228 (attached as .config)
compiler: or1k-linux-gcc (GCC) 9.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout eba1df51e6151d1cc04a559911cf905992581b22
# save the attached .config to linux build tree
GCC_VERSION=9.2.0 make.cross ARCH=openrisc
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
Note: the mptcp/t/mptcp-Implement-path-manager-interface-commands HEAD a28e79bf6de027fea5d0522a32a686aacf5658a7 builds fine.
It only hurts bisectibility.
All errors (new ones prefixed by >>):
net/mptcp/pm.c: In function 'mptcp_pm_announce_addr':
net/mptcp/pm.c:18:21: error: 'msk' redeclared as different kind of symbol
18 | struct mptcp_sock *msk = mptcp_token_get_sock(token);
| ^~~
net/mptcp/pm.c:15:47: note: previous definition of 'msk' was here
15 | int mptcp_pm_announce_addr(struct mptcp_sock *msk,
| ~~~~~~~~~~~~~~~~~~~^~~
net/mptcp/pm.c:18:48: error: 'token' undeclared (first use in this function); did you mean 'to_kset'?
18 | struct mptcp_sock *msk = mptcp_token_get_sock(token);
| ^~~~~
| to_kset
net/mptcp/pm.c:18:48: note: each undeclared identifier is reported only once for each function it appears in
net/mptcp/pm.c:30:14: error: 'struct mptcp_pm_data' has no member named 'remote_valid'
30 | if (!msk->pm.remote_valid || remote_id != msk->pm.remote_id) {
| ^
net/mptcp/pm.c:30:31: error: 'remote_id' undeclared (first use in this function); did you mean 'remote'?
30 | if (!msk->pm.remote_valid || remote_id != msk->pm.remote_id) {
| ^~~~~~~~~
| remote
net/mptcp/pm.c:30:52: error: 'struct mptcp_pm_data' has no member named 'remote_id'; did you mean 'remote'?
30 | if (!msk->pm.remote_valid || remote_id != msk->pm.remote_id) {
| ^~~~~~~~~
| remote
net/mptcp/pm.c:38:20: error: incompatible types when assigning to type 'struct in_addr' from type 'const struct mptcp_addr_info'
38 | local.sin_addr = *addr;
| ^
net/mptcp/pm.c:42:29: error: 'struct mptcp_pm_data' has no member named 'remote_family'
42 | remote.sin_family = msk->pm.remote_family;
| ^
net/mptcp/pm.c:44:27: error: 'struct mptcp_pm_data' has no member named 'remote_addr'
44 | remote.sin_addr = msk->pm.remote_addr;
| ^
>> net/mptcp/pm.c:46:8: error: implicit declaration of function 'mptcp_subflow_connect'; did you mean 'mptcp_subflow_init'? [-Werror=implicit-function-declaration]
46 | err = mptcp_subflow_connect(sk, (struct sockaddr *)&local,
| ^~~~~~~~~~~~~~~~~~~~~
| mptcp_subflow_init
net/mptcp/pm.c: In function 'mptcp_pm_remove_addr':
net/mptcp/pm.c:56:21: error: 'msk' redeclared as different kind of symbol
56 | struct mptcp_sock *msk = mptcp_token_get_sock(token);
| ^~~
net/mptcp/pm.c:54:45: note: previous definition of 'msk' was here
54 | int mptcp_pm_remove_addr(struct mptcp_sock *msk, u8 local_id)
| ~~~~~~~~~~~~~~~~~~~^~~
net/mptcp/pm.c:56:48: error: 'token' undeclared (first use in this function); did you mean 'to_kset'?
56 | struct mptcp_sock *msk = mptcp_token_get_sock(token);
| ^~~~~
| to_kset
net/mptcp/pm.c:68:14: error: 'struct mptcp_pm_data' has no member named 'remote_valid'
68 | if (!msk->pm.remote_valid || remote_id != msk->pm.remote_id) {
| ^
net/mptcp/pm.c:68:31: error: 'remote_id' undeclared (first use in this function); did you mean 'remote'?
68 | if (!msk->pm.remote_valid || remote_id != msk->pm.remote_id) {
| ^~~~~~~~~
| remote
net/mptcp/pm.c:68:52: error: 'struct mptcp_pm_data' has no member named 'remote_id'; did you mean 'remote'?
68 | if (!msk->pm.remote_valid || remote_id != msk->pm.remote_id) {
| ^~~~~~~~~
| remote
net/mptcp/pm.c:75:6: error: 'addr' undeclared (first use in this function)
75 | if (addr)
| ^~~~
net/mptcp/pm.c:80:30: error: 'struct mptcp_pm_data' has no member named 'remote_family'
80 | remote.sin6_family = msk->pm.remote_family;
| ^
net/mptcp/pm.c:82:28: error: 'struct mptcp_pm_data' has no member named 'remote_addr6'
82 | remote.sin6_addr = msk->pm.remote_addr6;
| ^
cc1: some warnings being treated as errors
vim +46 net/mptcp/pm.c
532e0037f0c3af Peter Krystad 2020-02-26 14
cb6c1764eb317d Paolo Abeni 2020-02-24 15 int mptcp_pm_announce_addr(struct mptcp_sock *msk,
cb6c1764eb317d Paolo Abeni 2020-02-24 16 const struct mptcp_addr_info *addr)
532e0037f0c3af Peter Krystad 2020-02-26 17 {
4b738110d9bfa5 Peter Krystad 2020-02-26 18 struct mptcp_sock *msk = mptcp_token_get_sock(token);
4b738110d9bfa5 Peter Krystad 2020-02-26 19 struct sockaddr_in remote;
4b738110d9bfa5 Peter Krystad 2020-02-26 20 struct sockaddr_in local;
4b738110d9bfa5 Peter Krystad 2020-02-26 21 struct sock *sk;
4b738110d9bfa5 Peter Krystad 2020-02-26 22 int err;
4b738110d9bfa5 Peter Krystad 2020-02-26 23
4b738110d9bfa5 Peter Krystad 2020-02-26 24 if (!msk)
4b738110d9bfa5 Peter Krystad 2020-02-26 25 return -EINVAL;
4b738110d9bfa5 Peter Krystad 2020-02-26 26
4b738110d9bfa5 Peter Krystad 2020-02-26 27 pr_debug("msk=%p", msk);
4b738110d9bfa5 Peter Krystad 2020-02-26 28
4b738110d9bfa5 Peter Krystad 2020-02-26 29 sk = (struct sock *)msk;
4b738110d9bfa5 Peter Krystad 2020-02-26 30 if (!msk->pm.remote_valid || remote_id != msk->pm.remote_id) {
4b738110d9bfa5 Peter Krystad 2020-02-26 31 err = -EBADR;
4b738110d9bfa5 Peter Krystad 2020-02-26 32 goto create_put;
4b738110d9bfa5 Peter Krystad 2020-02-26 33 }
4b738110d9bfa5 Peter Krystad 2020-02-26 34
4b738110d9bfa5 Peter Krystad 2020-02-26 35 local.sin_family = AF_INET;
4b738110d9bfa5 Peter Krystad 2020-02-26 36 local.sin_port = 0;
4b738110d9bfa5 Peter Krystad 2020-02-26 37 if (addr)
4b738110d9bfa5 Peter Krystad 2020-02-26 38 local.sin_addr = *addr;
4b738110d9bfa5 Peter Krystad 2020-02-26 39 else
4b738110d9bfa5 Peter Krystad 2020-02-26 40 local.sin_addr.s_addr = htonl(INADDR_ANY);
4b738110d9bfa5 Peter Krystad 2020-02-26 41
4b738110d9bfa5 Peter Krystad 2020-02-26 42 remote.sin_family = msk->pm.remote_family;
4b738110d9bfa5 Peter Krystad 2020-02-26 43 remote.sin_port = inet_sk(sk)->inet_dport;
4b738110d9bfa5 Peter Krystad 2020-02-26 44 remote.sin_addr = msk->pm.remote_addr;
4b738110d9bfa5 Peter Krystad 2020-02-26 45
4b738110d9bfa5 Peter Krystad 2020-02-26 @46 err = mptcp_subflow_connect(sk, (struct sockaddr *)&local,
4b738110d9bfa5 Peter Krystad 2020-02-26 47 (struct sockaddr *)&remote, remote_id);
4b738110d9bfa5 Peter Krystad 2020-02-26 48
4b738110d9bfa5 Peter Krystad 2020-02-26 49 create_put:
4b738110d9bfa5 Peter Krystad 2020-02-26 50 sock_put(sk);
4b738110d9bfa5 Peter Krystad 2020-02-26 51 return err;
532e0037f0c3af Peter Krystad 2020-02-26 52 }
532e0037f0c3af Peter Krystad 2020-02-26 53
:::::: The code at line 46 was first introduced by commit
:::::: 4b738110d9bfa5e1a763123e0ef6d0d2f5852782 mptcp: Implement path manager interface commands
:::::: TO: Peter Krystad <peter.krystad(a)linux.intel.com>
:::::: CC: Matthieu Baerts <matthieu.baerts(a)tessares.net>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 7 months
Re: [PATCH v3 3/7] kunit: test: create a single centralized executor for all tests
by kbuild test robot
Hi Brendan,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on a2f0b878c3ca531a1706cb2a8b079cea3b17bafc]
url: https://github.com/0day-ci/linux/commits/Brendan-Higgins/kunit-create-a-c...
base: a2f0b878c3ca531a1706cb2a8b079cea3b17bafc
config: microblaze-randconfig-a001-20200229 (attached as .config)
compiler: microblaze-linux-gcc (GCC) 7.5.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.5.0 make.cross ARCH=microblaze
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
In file included from lib/kunit/kunit-test.c:8:0:
lib/kunit/kunit-test.c: In function 'kunit_test_suites_init':
include/kunit/test.h:211:34: error: invalid initializer
struct kunit_suite *suites[] = (__suites); \
^
include/kunit/test.h:231:2: note: in expansion of macro 'kunit_test_suites_for_module'
kunit_test_suites_for_module(unique_array); \
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/kunit/test.h:254:2: note: in expansion of macro '__kunit_test_suites'
__kunit_test_suites(__UNIQUE_ID(array), \
^~~~~~~~~~~~~~~~~~~
>> lib/kunit/kunit-test.c:332:1: note: in expansion of macro 'kunit_test_suites'
kunit_test_suites(&kunit_try_catch_test_suite, &kunit_resource_test_suite);
^~~~~~~~~~~~~~~~~
vim +/kunit_test_suites +332 lib/kunit/kunit-test.c
73ba5aaf93b41e lib/kunit/test-test.c Avinash Kondareddy 2019-09-23 325
73ba5aaf93b41e lib/kunit/test-test.c Avinash Kondareddy 2019-09-23 326 static struct kunit_suite kunit_resource_test_suite = {
73ba5aaf93b41e lib/kunit/test-test.c Avinash Kondareddy 2019-09-23 327 .name = "kunit-resource-test",
73ba5aaf93b41e lib/kunit/test-test.c Avinash Kondareddy 2019-09-23 328 .init = kunit_resource_test_init,
73ba5aaf93b41e lib/kunit/test-test.c Avinash Kondareddy 2019-09-23 329 .exit = kunit_resource_test_exit,
73ba5aaf93b41e lib/kunit/test-test.c Avinash Kondareddy 2019-09-23 330 .test_cases = kunit_resource_test_cases,
73ba5aaf93b41e lib/kunit/test-test.c Avinash Kondareddy 2019-09-23 331 };
c475c77d5b5639 lib/kunit/kunit-test.c Alan Maguire 2020-01-06 @332 kunit_test_suites(&kunit_try_catch_test_suite, &kunit_resource_test_suite);
c475c77d5b5639 lib/kunit/kunit-test.c Alan Maguire 2020-01-06 333
:::::: The code at line 332 was first introduced by commit
:::::: c475c77d5b56398303e726969e81208196b3aab3 kunit: allow kunit tests to be loaded as a module
:::::: TO: Alan Maguire <alan.maguire(a)oracle.com>
:::::: CC: Shuah Khan <skhan(a)linuxfoundation.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 7 months
[mptcp:t/mptcp-Implement-path-manager-interface-commands 21/25] net/mptcp/pm.c:30:15: error: 'struct mptcp_pm_data' has no member named 'remote_valid'; did you mean 'remote'?
by kbuild test robot
tree: https://github.com/multipath-tcp/mptcp_net-next.git t/mptcp-Implement-path-manager-interface-commands
head: a28e79bf6de027fea5d0522a32a686aacf5658a7
commit: f8513e13c445c1804d044dae4b612ea986b491cb [21/25] tgupdate: merge t/mptcp-Implement-path-manager-interface-commands base into t/mptcp-Implement-path-manager-interface-commands
config: s390-randconfig-a001-20200228 (attached as .config)
compiler: s390-linux-gcc (GCC) 7.5.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout f8513e13c445c1804d044dae4b612ea986b491cb
# save the attached .config to linux build tree
GCC_VERSION=7.5.0 make.cross ARCH=s390
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
Note: the mptcp/t/mptcp-Implement-path-manager-interface-commands HEAD a28e79bf6de027fea5d0522a32a686aacf5658a7 builds fine.
It only hurts bisectibility.
All errors (new ones prefixed by >>):
net/mptcp/pm.c: In function 'mptcp_pm_announce_addr':
net/mptcp/pm.c:18:21: error: 'msk' redeclared as different kind of symbol
struct mptcp_sock *msk = mptcp_token_get_sock(token);
^~~
net/mptcp/pm.c:15:47: note: previous definition of 'msk' was here
int mptcp_pm_announce_addr(struct mptcp_sock *msk,
^~~
net/mptcp/pm.c:18:48: error: 'token' undeclared (first use in this function); did you mean 'to_kset'?
struct mptcp_sock *msk = mptcp_token_get_sock(token);
^~~~~
to_kset
net/mptcp/pm.c:18:48: note: each undeclared identifier is reported only once for each function it appears in
>> net/mptcp/pm.c:30:15: error: 'struct mptcp_pm_data' has no member named 'remote_valid'; did you mean 'remote'?
if (!msk->pm.remote_valid || remote_id != msk->pm.remote_id) {
^~~~~~~~~~~~
remote
net/mptcp/pm.c:30:31: error: 'remote_id' undeclared (first use in this function); did you mean 'remote'?
if (!msk->pm.remote_valid || remote_id != msk->pm.remote_id) {
^~~~~~~~~
remote
net/mptcp/pm.c:30:52: error: 'struct mptcp_pm_data' has no member named 'remote_id'; did you mean 'remote'?
if (!msk->pm.remote_valid || remote_id != msk->pm.remote_id) {
^~~~~~~~~
remote
net/mptcp/pm.c:38:18: error: incompatible types when assigning to type 'struct in_addr' from type 'const struct mptcp_addr_info'
local.sin_addr = *addr;
^
net/mptcp/pm.c:42:29: error: 'struct mptcp_pm_data' has no member named 'remote_family'
remote.sin_family = msk->pm.remote_family;
^
>> net/mptcp/pm.c:44:28: error: 'struct mptcp_pm_data' has no member named 'remote_addr'; did you mean 'remote'?
remote.sin_addr = msk->pm.remote_addr;
^~~~~~~~~~~
remote
net/mptcp/pm.c: In function 'mptcp_pm_remove_addr':
net/mptcp/pm.c:56:21: error: 'msk' redeclared as different kind of symbol
struct mptcp_sock *msk = mptcp_token_get_sock(token);
^~~
net/mptcp/pm.c:54:45: note: previous definition of 'msk' was here
int mptcp_pm_remove_addr(struct mptcp_sock *msk, u8 local_id)
^~~
net/mptcp/pm.c:56:48: error: 'token' undeclared (first use in this function); did you mean 'to_kset'?
struct mptcp_sock *msk = mptcp_token_get_sock(token);
^~~~~
to_kset
net/mptcp/pm.c:68:15: error: 'struct mptcp_pm_data' has no member named 'remote_valid'; did you mean 'remote'?
if (!msk->pm.remote_valid || remote_id != msk->pm.remote_id) {
^~~~~~~~~~~~
remote
net/mptcp/pm.c:68:31: error: 'remote_id' undeclared (first use in this function); did you mean 'remote'?
if (!msk->pm.remote_valid || remote_id != msk->pm.remote_id) {
^~~~~~~~~
remote
net/mptcp/pm.c:68:52: error: 'struct mptcp_pm_data' has no member named 'remote_id'; did you mean 'remote'?
if (!msk->pm.remote_valid || remote_id != msk->pm.remote_id) {
^~~~~~~~~
remote
>> net/mptcp/pm.c:75:6: error: 'addr' undeclared (first use in this function); did you mean 'idr'?
if (addr)
^~~~
idr
net/mptcp/pm.c:80:30: error: 'struct mptcp_pm_data' has no member named 'remote_family'
remote.sin6_family = msk->pm.remote_family;
^
>> net/mptcp/pm.c:82:29: error: 'struct mptcp_pm_data' has no member named 'remote_addr6'; did you mean 'remote'?
remote.sin6_addr = msk->pm.remote_addr6;
^~~~~~~~~~~~
remote
vim +30 net/mptcp/pm.c
532e0037f0c3af Peter Krystad 2020-02-26 14
cb6c1764eb317d Paolo Abeni 2020-02-24 15 int mptcp_pm_announce_addr(struct mptcp_sock *msk,
cb6c1764eb317d Paolo Abeni 2020-02-24 16 const struct mptcp_addr_info *addr)
532e0037f0c3af Peter Krystad 2020-02-26 17 {
4b738110d9bfa5 Peter Krystad 2020-02-26 18 struct mptcp_sock *msk = mptcp_token_get_sock(token);
4b738110d9bfa5 Peter Krystad 2020-02-26 19 struct sockaddr_in remote;
4b738110d9bfa5 Peter Krystad 2020-02-26 20 struct sockaddr_in local;
4b738110d9bfa5 Peter Krystad 2020-02-26 21 struct sock *sk;
4b738110d9bfa5 Peter Krystad 2020-02-26 22 int err;
4b738110d9bfa5 Peter Krystad 2020-02-26 23
4b738110d9bfa5 Peter Krystad 2020-02-26 24 if (!msk)
4b738110d9bfa5 Peter Krystad 2020-02-26 25 return -EINVAL;
4b738110d9bfa5 Peter Krystad 2020-02-26 26
4b738110d9bfa5 Peter Krystad 2020-02-26 27 pr_debug("msk=%p", msk);
4b738110d9bfa5 Peter Krystad 2020-02-26 28
4b738110d9bfa5 Peter Krystad 2020-02-26 29 sk = (struct sock *)msk;
4b738110d9bfa5 Peter Krystad 2020-02-26 @30 if (!msk->pm.remote_valid || remote_id != msk->pm.remote_id) {
4b738110d9bfa5 Peter Krystad 2020-02-26 31 err = -EBADR;
4b738110d9bfa5 Peter Krystad 2020-02-26 32 goto create_put;
4b738110d9bfa5 Peter Krystad 2020-02-26 33 }
4b738110d9bfa5 Peter Krystad 2020-02-26 34
4b738110d9bfa5 Peter Krystad 2020-02-26 35 local.sin_family = AF_INET;
4b738110d9bfa5 Peter Krystad 2020-02-26 36 local.sin_port = 0;
4b738110d9bfa5 Peter Krystad 2020-02-26 37 if (addr)
4b738110d9bfa5 Peter Krystad 2020-02-26 38 local.sin_addr = *addr;
4b738110d9bfa5 Peter Krystad 2020-02-26 39 else
4b738110d9bfa5 Peter Krystad 2020-02-26 40 local.sin_addr.s_addr = htonl(INADDR_ANY);
4b738110d9bfa5 Peter Krystad 2020-02-26 41
4b738110d9bfa5 Peter Krystad 2020-02-26 42 remote.sin_family = msk->pm.remote_family;
4b738110d9bfa5 Peter Krystad 2020-02-26 43 remote.sin_port = inet_sk(sk)->inet_dport;
4b738110d9bfa5 Peter Krystad 2020-02-26 @44 remote.sin_addr = msk->pm.remote_addr;
4b738110d9bfa5 Peter Krystad 2020-02-26 45
4b738110d9bfa5 Peter Krystad 2020-02-26 46 err = mptcp_subflow_connect(sk, (struct sockaddr *)&local,
4b738110d9bfa5 Peter Krystad 2020-02-26 47 (struct sockaddr *)&remote, remote_id);
4b738110d9bfa5 Peter Krystad 2020-02-26 48
4b738110d9bfa5 Peter Krystad 2020-02-26 49 create_put:
4b738110d9bfa5 Peter Krystad 2020-02-26 50 sock_put(sk);
4b738110d9bfa5 Peter Krystad 2020-02-26 51 return err;
532e0037f0c3af Peter Krystad 2020-02-26 52 }
532e0037f0c3af Peter Krystad 2020-02-26 53
cb6c1764eb317d Paolo Abeni 2020-02-24 54 int mptcp_pm_remove_addr(struct mptcp_sock *msk, u8 local_id)
532e0037f0c3af Peter Krystad 2020-02-26 55 {
4b738110d9bfa5 Peter Krystad 2020-02-26 56 struct mptcp_sock *msk = mptcp_token_get_sock(token);
4b738110d9bfa5 Peter Krystad 2020-02-26 57 struct sockaddr_in6 remote;
4b738110d9bfa5 Peter Krystad 2020-02-26 58 struct sockaddr_in6 local;
4b738110d9bfa5 Peter Krystad 2020-02-26 59 struct sock *sk;
4b738110d9bfa5 Peter Krystad 2020-02-26 60 int err;
4b738110d9bfa5 Peter Krystad 2020-02-26 61
4b738110d9bfa5 Peter Krystad 2020-02-26 62 if (!msk)
4b738110d9bfa5 Peter Krystad 2020-02-26 63 return -EINVAL;
4b738110d9bfa5 Peter Krystad 2020-02-26 64
4b738110d9bfa5 Peter Krystad 2020-02-26 65 pr_debug("msk=%p", msk);
4b738110d9bfa5 Peter Krystad 2020-02-26 66 sk = (struct sock *)msk;
4b738110d9bfa5 Peter Krystad 2020-02-26 67
4b738110d9bfa5 Peter Krystad 2020-02-26 68 if (!msk->pm.remote_valid || remote_id != msk->pm.remote_id) {
4b738110d9bfa5 Peter Krystad 2020-02-26 69 err = -EBADR;
4b738110d9bfa5 Peter Krystad 2020-02-26 70 goto create_put;
4b738110d9bfa5 Peter Krystad 2020-02-26 71 }
4b738110d9bfa5 Peter Krystad 2020-02-26 72
4b738110d9bfa5 Peter Krystad 2020-02-26 73 local.sin6_family = AF_INET6;
4b738110d9bfa5 Peter Krystad 2020-02-26 74 local.sin6_port = 0;
4b738110d9bfa5 Peter Krystad 2020-02-26 @75 if (addr)
4b738110d9bfa5 Peter Krystad 2020-02-26 76 local.sin6_addr = *addr;
4b738110d9bfa5 Peter Krystad 2020-02-26 77 else
4b738110d9bfa5 Peter Krystad 2020-02-26 78 local.sin6_addr = in6addr_any;
4b738110d9bfa5 Peter Krystad 2020-02-26 79
4b738110d9bfa5 Peter Krystad 2020-02-26 80 remote.sin6_family = msk->pm.remote_family;
4b738110d9bfa5 Peter Krystad 2020-02-26 81 remote.sin6_port = inet_sk(sk)->inet_dport;
4b738110d9bfa5 Peter Krystad 2020-02-26 @82 remote.sin6_addr = msk->pm.remote_addr6;
4b738110d9bfa5 Peter Krystad 2020-02-26 83
4b738110d9bfa5 Peter Krystad 2020-02-26 84 err = mptcp_subflow_connect(sk, (struct sockaddr *)&local,
4b738110d9bfa5 Peter Krystad 2020-02-26 85 (struct sockaddr *)&remote, remote_id);
4b738110d9bfa5 Peter Krystad 2020-02-26 86
4b738110d9bfa5 Peter Krystad 2020-02-26 87 create_put:
4b738110d9bfa5 Peter Krystad 2020-02-26 88 sock_put(sk);
4b738110d9bfa5 Peter Krystad 2020-02-26 89 return err;
532e0037f0c3af Peter Krystad 2020-02-26 90 }
532e0037f0c3af Peter Krystad 2020-02-26 91
:::::: The code at line 30 was first introduced by commit
:::::: 4b738110d9bfa5e1a763123e0ef6d0d2f5852782 mptcp: Implement path manager interface commands
:::::: TO: Peter Krystad <peter.krystad(a)linux.intel.com>
:::::: CC: Matthieu Baerts <matthieu.baerts(a)tessares.net>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 7 months
Re: [PATCH 37/51] drm/rockchip: Drop explicit drm_mode_config_cleanup call
by kbuild test robot
Hi Daniel,
I love your patch! Yet something to improve:
[auto build test ERROR on drm-tip/drm-tip]
[also build test ERROR on next-20200228]
[cannot apply to drm-intel/for-linux-next linus/master pinchartl-media/drm/du/next v5.6-rc3]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Daniel-Vetter/drm-managed-resour...
base: git://anongit.freedesktop.org/drm/drm-tip drm-tip
config: arm64-defconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 7.5.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.5.0 make.cross ARCH=arm64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
drivers/gpu/drm/rockchip/rockchip_drm_drv.c: In function 'rockchip_drm_bind':
>> drivers/gpu/drm/rockchip/rockchip_drm_drv.c:147:3: error: label 'err_mode_config_cleanup' used but not defined
goto err_mode_config_cleanup;
^~~~
vim +/err_mode_config_cleanup +147 drivers/gpu/drm/rockchip/rockchip_drm_drv.c
2048e3286f347db Mark Yao 2014-08-22 110
f706974a69b6e2b Tomeu Vizoso 2016-06-10 111 static int rockchip_drm_bind(struct device *dev)
2048e3286f347db Mark Yao 2014-08-22 112 {
f706974a69b6e2b Tomeu Vizoso 2016-06-10 113 struct drm_device *drm_dev;
2048e3286f347db Mark Yao 2014-08-22 114 struct rockchip_drm_private *private;
2048e3286f347db Mark Yao 2014-08-22 115 int ret;
2048e3286f347db Mark Yao 2014-08-22 116
f706974a69b6e2b Tomeu Vizoso 2016-06-10 117 drm_dev = drm_dev_alloc(&rockchip_drm_driver, dev);
0f2886057be322d Tom Gundersen 2016-09-21 118 if (IS_ERR(drm_dev))
0f2886057be322d Tom Gundersen 2016-09-21 119 return PTR_ERR(drm_dev);
2048e3286f347db Mark Yao 2014-08-22 120
f706974a69b6e2b Tomeu Vizoso 2016-06-10 121 dev_set_drvdata(dev, drm_dev);
f706974a69b6e2b Tomeu Vizoso 2016-06-10 122
f706974a69b6e2b Tomeu Vizoso 2016-06-10 123 private = devm_kzalloc(drm_dev->dev, sizeof(*private), GFP_KERNEL);
f706974a69b6e2b Tomeu Vizoso 2016-06-10 124 if (!private) {
f706974a69b6e2b Tomeu Vizoso 2016-06-10 125 ret = -ENOMEM;
9127f99c4801f32 Tomasz Figa 2016-06-21 126 goto err_free;
f706974a69b6e2b Tomeu Vizoso 2016-06-10 127 }
f706974a69b6e2b Tomeu Vizoso 2016-06-10 128
2048e3286f347db Mark Yao 2014-08-22 129 drm_dev->dev_private = private;
2048e3286f347db Mark Yao 2014-08-22 130
5182c1a556d7ff7 Yakir Yang 2016-07-24 131 INIT_LIST_HEAD(&private->psr_list);
60beeccc72cabef Sean Paul 2018-03-05 132 mutex_init(&private->psr_list_lock);
5182c1a556d7ff7 Yakir Yang 2016-07-24 133
ccea91998c8f140 Jeffy Chen 2017-04-06 134 ret = rockchip_drm_init_iommu(drm_dev);
ccea91998c8f140 Jeffy Chen 2017-04-06 135 if (ret)
ccea91998c8f140 Jeffy Chen 2017-04-06 136 goto err_free;
ccea91998c8f140 Jeffy Chen 2017-04-06 137
7db42e97bb41bd5 Daniel Vetter 2020-02-27 138 ret = drm_mode_config_init(drm_dev);
7db42e97bb41bd5 Daniel Vetter 2020-02-27 139 if (ret)
7db42e97bb41bd5 Daniel Vetter 2020-02-27 140 goto err_iommu_cleanup;
2048e3286f347db Mark Yao 2014-08-22 141
2048e3286f347db Mark Yao 2014-08-22 142 rockchip_drm_mode_config_init(drm_dev);
2048e3286f347db Mark Yao 2014-08-22 143
2048e3286f347db Mark Yao 2014-08-22 144 /* Try to bind all sub drivers. */
2048e3286f347db Mark Yao 2014-08-22 145 ret = component_bind_all(dev, drm_dev);
2048e3286f347db Mark Yao 2014-08-22 146 if (ret)
ccea91998c8f140 Jeffy Chen 2017-04-06 @147 goto err_mode_config_cleanup;
2048e3286f347db Mark Yao 2014-08-22 148
ccea91998c8f140 Jeffy Chen 2017-04-06 149 ret = drm_vblank_init(drm_dev, drm_dev->mode_config.num_crtc);
ccea91998c8f140 Jeffy Chen 2017-04-06 150 if (ret)
ccea91998c8f140 Jeffy Chen 2017-04-06 151 goto err_unbind_all;
ccea91998c8f140 Jeffy Chen 2017-04-06 152
ccea91998c8f140 Jeffy Chen 2017-04-06 153 drm_mode_config_reset(drm_dev);
2048e3286f347db Mark Yao 2014-08-22 154
2048e3286f347db Mark Yao 2014-08-22 155 /*
2048e3286f347db Mark Yao 2014-08-22 156 * enable drm irq mode.
2048e3286f347db Mark Yao 2014-08-22 157 * - with irq_enabled = true, we can use the vblank feature.
2048e3286f347db Mark Yao 2014-08-22 158 */
2048e3286f347db Mark Yao 2014-08-22 159 drm_dev->irq_enabled = true;
2048e3286f347db Mark Yao 2014-08-22 160
2048e3286f347db Mark Yao 2014-08-22 161 ret = rockchip_drm_fbdev_init(drm_dev);
2048e3286f347db Mark Yao 2014-08-22 162 if (ret)
8415ab565da966b Mark Yao 2017-08-01 163 goto err_unbind_all;
8415ab565da966b Mark Yao 2017-08-01 164
8415ab565da966b Mark Yao 2017-08-01 165 /* init kms poll for handling hpd */
8415ab565da966b Mark Yao 2017-08-01 166 drm_kms_helper_poll_init(drm_dev);
2048e3286f347db Mark Yao 2014-08-22 167
9127f99c4801f32 Tomasz Figa 2016-06-21 168 ret = drm_dev_register(drm_dev, 0);
9127f99c4801f32 Tomasz Figa 2016-06-21 169 if (ret)
8415ab565da966b Mark Yao 2017-08-01 170 goto err_kms_helper_poll_fini;
9127f99c4801f32 Tomasz Figa 2016-06-21 171
2048e3286f347db Mark Yao 2014-08-22 172 return 0;
2048e3286f347db Mark Yao 2014-08-22 173 err_kms_helper_poll_fini:
2048e3286f347db Mark Yao 2014-08-22 174 drm_kms_helper_poll_fini(drm_dev);
8415ab565da966b Mark Yao 2017-08-01 175 rockchip_drm_fbdev_fini(drm_dev);
ccea91998c8f140 Jeffy Chen 2017-04-06 176 err_unbind_all:
2048e3286f347db Mark Yao 2014-08-22 177 component_unbind_all(dev, drm_dev);
7db42e97bb41bd5 Daniel Vetter 2020-02-27 178 err_iommu_cleanup:
ccea91998c8f140 Jeffy Chen 2017-04-06 179 rockchip_iommu_cleanup(drm_dev);
f706974a69b6e2b Tomeu Vizoso 2016-06-10 180 err_free:
574e0fbfc95e7fc Thomas Zimmermann 2018-07-17 181 drm_dev_put(drm_dev);
2048e3286f347db Mark Yao 2014-08-22 182 return ret;
2048e3286f347db Mark Yao 2014-08-22 183 }
2048e3286f347db Mark Yao 2014-08-22 184
:::::: The code at line 147 was first introduced by commit
:::::: ccea91998c8f140bc3e324bbb3c3fb7148e72d31 drm/rockchip: Reorder drm bind/unbind sequence
:::::: TO: Jeffy Chen <jeffy.chen(a)rock-chips.com>
:::::: CC: Sean Paul <seanpaul(a)chromium.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 7 months
Re: [PATCH v7 29/38] sg: add 8 byte SCSI LUN to sg_scsi_id
by kbuild test robot
Hi Douglas,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on mkp-scsi/for-next]
[also build test WARNING on scsi/for-next linus/master v5.6-rc3 next-20200228]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Douglas-Gilbert/sg-add-v4-interf...
base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
config: i386-allyesconfig (attached as .config)
compiler: gcc-7 (Debian 7.5.0-5) 7.5.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
drivers//scsi/sg.c: In function 'sg_receive_v4':
drivers//scsi/sg.c:1234:18: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
h4p->response = (u64)srp->s_hdr4.sbp;
^
drivers//scsi/sg.c: In function 'sg_ioctl_common':
>> drivers//scsi/sg.c:2074:1: warning: the frame size of 2056 bytes is larger than 2048 bytes [-Wframe-larger-than=]
}
^
vim +2074 drivers//scsi/sg.c
e9a6fc36629575 Douglas Gilbert 2020-02-27 1863
37b9d1e0017b2d Jörn Engel 2012-04-12 1864 static long
2e69ea3df607a4 Douglas Gilbert 2020-02-27 1865 sg_ioctl_common(struct file *filp, struct sg_device *sdp, struct sg_fd *sfp,
d320a9551e394c Arnd Bergmann 2019-03-15 1866 unsigned int cmd_in, void __user *p)
^1da177e4c3f41 Linus Torvalds 2005-04-16 1867 {
e9a6fc36629575 Douglas Gilbert 2020-02-27 1868 bool read_only = O_RDWR != (filp->f_flags & O_ACCMODE);
e9a6fc36629575 Douglas Gilbert 2020-02-27 1869 int val;
e9a6fc36629575 Douglas Gilbert 2020-02-27 1870 int result = 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1871 int __user *ip = p;
2e69ea3df607a4 Douglas Gilbert 2020-02-27 1872 struct sg_request *srp;
e9a6fc36629575 Douglas Gilbert 2020-02-27 1873 struct scsi_device *sdev;
f6652476691f24 Douglas Gilbert 2020-02-27 1874 unsigned long idx;
e9a6fc36629575 Douglas Gilbert 2020-02-27 1875 __maybe_unused const char *pmlp = ", pass to mid-level";
^1da177e4c3f41 Linus Torvalds 2005-04-16 1876
d92b69363fbad1 Douglas Gilbert 2020-02-27 1877 SG_LOG(6, sfp, "%s: cmd=0x%x, O_NONBLOCK=%d\n", __func__, cmd_in,
d92b69363fbad1 Douglas Gilbert 2020-02-27 1878 !!(filp->f_flags & O_NONBLOCK));
e9a6fc36629575 Douglas Gilbert 2020-02-27 1879 if (unlikely(SG_IS_DETACHING(sdp)))
e9a6fc36629575 Douglas Gilbert 2020-02-27 1880 return -ENODEV;
e9a6fc36629575 Douglas Gilbert 2020-02-27 1881 sdev = sdp->device;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1882
^1da177e4c3f41 Linus Torvalds 2005-04-16 1883 switch (cmd_in) {
^1da177e4c3f41 Linus Torvalds 2005-04-16 1884 case SG_IO:
e9a6fc36629575 Douglas Gilbert 2020-02-27 1885 return sg_ctl_sg_io(filp, sdp, sfp, p);
164fadf16aae69 Douglas Gilbert 2020-02-27 1886 case SG_IOSUBMIT:
164fadf16aae69 Douglas Gilbert 2020-02-27 1887 SG_LOG(3, sfp, "%s: SG_IOSUBMIT\n", __func__);
164fadf16aae69 Douglas Gilbert 2020-02-27 1888 return sg_ctl_iosubmit(filp, sfp, p);
164fadf16aae69 Douglas Gilbert 2020-02-27 1889 case SG_IORECEIVE:
164fadf16aae69 Douglas Gilbert 2020-02-27 1890 SG_LOG(3, sfp, "%s: SG_IORECEIVE\n", __func__);
164fadf16aae69 Douglas Gilbert 2020-02-27 1891 return sg_ctl_ioreceive(filp, sfp, p);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1892 case SG_GET_SCSI_ID:
e9a6fc36629575 Douglas Gilbert 2020-02-27 1893 return sg_ctl_scsi_id(sdev, sfp, p);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1894 case SG_SET_FORCE_PACK_ID:
e9a6fc36629575 Douglas Gilbert 2020-02-27 1895 SG_LOG(3, sfp, "%s: SG_SET_FORCE_PACK_ID\n", __func__);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1896 result = get_user(val, ip);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1897 if (result)
^1da177e4c3f41 Linus Torvalds 2005-04-16 1898 return result;
20d8ebcd78db48 Douglas Gilbert 2020-02-27 1899 assign_bit(SG_FFD_FORCE_PACKID, sfp->ffd_bm, !!val);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1900 return 0;
5c0a9d591daedc Douglas Gilbert 2020-02-27 1901 case SG_GET_PACK_ID: /* or tag of oldest "read"-able, -1 if none */
e9a6fc36629575 Douglas Gilbert 2020-02-27 1902 val = -1;
f6652476691f24 Douglas Gilbert 2020-02-27 1903 xa_for_each_marked(&sfp->srp_arr, idx, srp, SG_XA_RQ_AWAIT) {
f6652476691f24 Douglas Gilbert 2020-02-27 1904 if (!srp)
f6652476691f24 Douglas Gilbert 2020-02-27 1905 continue;
20d8ebcd78db48 Douglas Gilbert 2020-02-27 1906 val = srp->pack_id;
e9a6fc36629575 Douglas Gilbert 2020-02-27 1907 break;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1908 }
e9a6fc36629575 Douglas Gilbert 2020-02-27 1909 SG_LOG(3, sfp, "%s: SG_GET_PACK_ID=%d\n", __func__, val);
e9a6fc36629575 Douglas Gilbert 2020-02-27 1910 return put_user(val, ip);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1911 case SG_GET_NUM_WAITING:
dafd31b0fcfdc9 Douglas Gilbert 2020-02-27 1912 return put_user(atomic_read(&sfp->waiting), ip);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1913 case SG_GET_SG_TABLESIZE:
e9a6fc36629575 Douglas Gilbert 2020-02-27 1914 SG_LOG(3, sfp, "%s: SG_GET_SG_TABLESIZE=%d\n", __func__,
e9a6fc36629575 Douglas Gilbert 2020-02-27 1915 sdp->max_sgat_sz);
1ee385d070dc3b Douglas Gilbert 2020-02-27 1916 return put_user(sdp->max_sgat_sz, ip);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1917 case SG_SET_RESERVED_SIZE:
e9a6fc36629575 Douglas Gilbert 2020-02-27 1918 result = get_user(val, ip);
e9a6fc36629575 Douglas Gilbert 2020-02-27 1919 if (!result) {
e9a6fc36629575 Douglas Gilbert 2020-02-27 1920 if (val >= 0 && val <= (1024 * 1024 * 1024)) {
20d8ebcd78db48 Douglas Gilbert 2020-02-27 1921 mutex_lock(&sfp->f_mutex);
e9a6fc36629575 Douglas Gilbert 2020-02-27 1922 result = sg_set_reserved_sz(sfp, val);
20d8ebcd78db48 Douglas Gilbert 2020-02-27 1923 mutex_unlock(&sfp->f_mutex);
e9a6fc36629575 Douglas Gilbert 2020-02-27 1924 } else {
e9a6fc36629575 Douglas Gilbert 2020-02-27 1925 SG_LOG(3, sfp, "%s: invalid size\n", __func__);
e9a6fc36629575 Douglas Gilbert 2020-02-27 1926 result = -EINVAL;
1bc0eb0446158c Hannes Reinecke 2017-04-07 1927 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 1928 }
e9a6fc36629575 Douglas Gilbert 2020-02-27 1929 return result;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1930 case SG_GET_RESERVED_SIZE:
20d8ebcd78db48 Douglas Gilbert 2020-02-27 1931 mutex_lock(&sfp->f_mutex);
20d8ebcd78db48 Douglas Gilbert 2020-02-27 1932 val = min_t(int, sfp->rsv_srp->sgat_h.buflen,
20d8ebcd78db48 Douglas Gilbert 2020-02-27 1933 sdp->max_sgat_sz);
20d8ebcd78db48 Douglas Gilbert 2020-02-27 1934 mutex_unlock(&sfp->f_mutex);
e9a6fc36629575 Douglas Gilbert 2020-02-27 1935 SG_LOG(3, sfp, "%s: SG_GET_RESERVED_SIZE=%d\n",
e9a6fc36629575 Douglas Gilbert 2020-02-27 1936 __func__, val);
20d8ebcd78db48 Douglas Gilbert 2020-02-27 1937 result = put_user(val, ip);
20d8ebcd78db48 Douglas Gilbert 2020-02-27 1938 return result;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1939 case SG_SET_COMMAND_Q:
e9a6fc36629575 Douglas Gilbert 2020-02-27 1940 SG_LOG(3, sfp, "%s: SG_SET_COMMAND_Q\n", __func__);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1941 result = get_user(val, ip);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1942 if (result)
^1da177e4c3f41 Linus Torvalds 2005-04-16 1943 return result;
20d8ebcd78db48 Douglas Gilbert 2020-02-27 1944 assign_bit(SG_FFD_CMD_Q, sfp->ffd_bm, !!val);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1945 return 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1946 case SG_GET_COMMAND_Q:
e9a6fc36629575 Douglas Gilbert 2020-02-27 1947 SG_LOG(3, sfp, "%s: SG_GET_COMMAND_Q\n", __func__);
20d8ebcd78db48 Douglas Gilbert 2020-02-27 1948 return put_user(test_bit(SG_FFD_CMD_Q, sfp->ffd_bm), ip);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1949 case SG_SET_KEEP_ORPHAN:
e9a6fc36629575 Douglas Gilbert 2020-02-27 1950 SG_LOG(3, sfp, "%s: SG_SET_KEEP_ORPHAN\n", __func__);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1951 result = get_user(val, ip);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1952 if (result)
^1da177e4c3f41 Linus Torvalds 2005-04-16 1953 return result;
20d8ebcd78db48 Douglas Gilbert 2020-02-27 1954 assign_bit(SG_FFD_KEEP_ORPHAN, sfp->ffd_bm, !!val);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1955 return 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16 1956 case SG_GET_KEEP_ORPHAN:
e9a6fc36629575 Douglas Gilbert 2020-02-27 1957 SG_LOG(3, sfp, "%s: SG_GET_KEEP_ORPHAN\n", __func__);
20d8ebcd78db48 Douglas Gilbert 2020-02-27 1958 return put_user(test_bit(SG_FFD_KEEP_ORPHAN, sfp->ffd_bm),
20d8ebcd78db48 Douglas Gilbert 2020-02-27 1959 ip);
e9a6fc36629575 Douglas Gilbert 2020-02-27 1960 case SG_GET_VERSION_NUM:
e9a6fc36629575 Douglas Gilbert 2020-02-27 1961 SG_LOG(3, sfp, "%s: SG_GET_VERSION_NUM\n", __func__);
e9a6fc36629575 Douglas Gilbert 2020-02-27 1962 return put_user(sg_version_num, ip);
e9a6fc36629575 Douglas Gilbert 2020-02-27 1963 case SG_GET_REQUEST_TABLE:
e9a6fc36629575 Douglas Gilbert 2020-02-27 1964 return sg_ctl_req_tbl(sfp, p);
e9a6fc36629575 Douglas Gilbert 2020-02-27 1965 case SG_SCSI_RESET:
e9a6fc36629575 Douglas Gilbert 2020-02-27 1966 SG_LOG(3, sfp, "%s: SG_SCSI_RESET\n", __func__);
e9a6fc36629575 Douglas Gilbert 2020-02-27 1967 break;
e9a6fc36629575 Douglas Gilbert 2020-02-27 1968 case SG_SET_TIMEOUT:
e9a6fc36629575 Douglas Gilbert 2020-02-27 1969 SG_LOG(3, sfp, "%s: SG_SET_TIMEOUT\n", __func__);
e9a6fc36629575 Douglas Gilbert 2020-02-27 1970 result = get_user(val, ip);
e9a6fc36629575 Douglas Gilbert 2020-02-27 1971 if (result)
e9a6fc36629575 Douglas Gilbert 2020-02-27 1972 return result;
e9a6fc36629575 Douglas Gilbert 2020-02-27 1973 if (val < 0)
e9a6fc36629575 Douglas Gilbert 2020-02-27 1974 return -EIO;
e9a6fc36629575 Douglas Gilbert 2020-02-27 1975 if (val >= mult_frac((s64)INT_MAX, USER_HZ, HZ))
e9a6fc36629575 Douglas Gilbert 2020-02-27 1976 val = min_t(s64, mult_frac((s64)INT_MAX, USER_HZ, HZ),
e9a6fc36629575 Douglas Gilbert 2020-02-27 1977 INT_MAX);
e9a6fc36629575 Douglas Gilbert 2020-02-27 1978 sfp->timeout_user = val;
e9a6fc36629575 Douglas Gilbert 2020-02-27 1979 sfp->timeout = mult_frac(val, HZ, USER_HZ);
e9a6fc36629575 Douglas Gilbert 2020-02-27 1980 return 0;
e9a6fc36629575 Douglas Gilbert 2020-02-27 1981 case SG_GET_TIMEOUT: /* N.B. User receives timeout as return value */
e9a6fc36629575 Douglas Gilbert 2020-02-27 1982 /* strange ..., for backward compatibility */
e9a6fc36629575 Douglas Gilbert 2020-02-27 1983 SG_LOG(3, sfp, "%s: SG_GET_TIMEOUT\n", __func__);
e9a6fc36629575 Douglas Gilbert 2020-02-27 1984 return sfp->timeout_user;
e9a6fc36629575 Douglas Gilbert 2020-02-27 1985 case SG_SET_FORCE_LOW_DMA:
e9a6fc36629575 Douglas Gilbert 2020-02-27 1986 /*
e9a6fc36629575 Douglas Gilbert 2020-02-27 1987 * N.B. This ioctl never worked properly, but failed to
e9a6fc36629575 Douglas Gilbert 2020-02-27 1988 * return an error value. So returning '0' to keep
e9a6fc36629575 Douglas Gilbert 2020-02-27 1989 * compatibility with legacy applications.
e9a6fc36629575 Douglas Gilbert 2020-02-27 1990 */
e9a6fc36629575 Douglas Gilbert 2020-02-27 1991 SG_LOG(3, sfp, "%s: SG_SET_FORCE_LOW_DMA\n", __func__);
e9a6fc36629575 Douglas Gilbert 2020-02-27 1992 return 0;
e9a6fc36629575 Douglas Gilbert 2020-02-27 1993 case SG_GET_LOW_DMA:
e9a6fc36629575 Douglas Gilbert 2020-02-27 1994 SG_LOG(3, sfp, "%s: SG_GET_LOW_DMA\n", __func__);
e9a6fc36629575 Douglas Gilbert 2020-02-27 1995 return put_user((int)sdev->host->unchecked_isa_dma, ip);
b2b2e4df0305e7 Douglas Gilbert 2020-02-27 1996 case SG_NEXT_CMD_LEN: /* active only in v2 interface */
e9a6fc36629575 Douglas Gilbert 2020-02-27 1997 SG_LOG(3, sfp, "%s: SG_NEXT_CMD_LEN\n", __func__);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1998 result = get_user(val, ip);
^1da177e4c3f41 Linus Torvalds 2005-04-16 1999 if (result)
^1da177e4c3f41 Linus Torvalds 2005-04-16 2000 return result;
bf33f87dd04c37 peter chang 2017-02-15 2001 if (val > SG_MAX_CDB_SIZE)
bf33f87dd04c37 peter chang 2017-02-15 2002 return -ENOMEM;
671c65317016c2 Douglas Gilbert 2020-02-27 2003 mutex_lock(&sfp->f_mutex);
671c65317016c2 Douglas Gilbert 2020-02-27 2004 sfp->next_cmd_len = max_t(int, val, 0);
671c65317016c2 Douglas Gilbert 2020-02-27 2005 mutex_unlock(&sfp->f_mutex);
^1da177e4c3f41 Linus Torvalds 2005-04-16 2006 return 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16 2007 case SG_GET_ACCESS_COUNT:
e9a6fc36629575 Douglas Gilbert 2020-02-27 2008 SG_LOG(3, sfp, "%s: SG_GET_ACCESS_COUNT\n", __func__);
^1da177e4c3f41 Linus Torvalds 2005-04-16 2009 /* faked - we don't have a real access count anymore */
e9a6fc36629575 Douglas Gilbert 2020-02-27 2010 val = (sdev ? 1 : 0);
^1da177e4c3f41 Linus Torvalds 2005-04-16 2011 return put_user(val, ip);
^1da177e4c3f41 Linus Torvalds 2005-04-16 2012 case SG_EMULATED_HOST:
e9a6fc36629575 Douglas Gilbert 2020-02-27 2013 SG_LOG(3, sfp, "%s: SG_EMULATED_HOST\n", __func__);
20d8ebcd78db48 Douglas Gilbert 2020-02-27 2014 if (unlikely(SG_IS_DETACHING(sdp)))
20d8ebcd78db48 Douglas Gilbert 2020-02-27 2015 return -ENODEV;
e9a6fc36629575 Douglas Gilbert 2020-02-27 2016 return put_user(sdev->host->hostt->emulated, ip);
^1da177e4c3f41 Linus Torvalds 2005-04-16 2017 case SCSI_IOCTL_SEND_COMMAND:
e9a6fc36629575 Douglas Gilbert 2020-02-27 2018 SG_LOG(3, sfp, "%s: SCSI_IOCTL_SEND_COMMAND\n", __func__);
e9a6fc36629575 Douglas Gilbert 2020-02-27 2019 return sg_scsi_ioctl(sdev->request_queue, NULL, filp->f_mode,
e9a6fc36629575 Douglas Gilbert 2020-02-27 2020 p);
^1da177e4c3f41 Linus Torvalds 2005-04-16 2021 case SG_SET_DEBUG:
e9a6fc36629575 Douglas Gilbert 2020-02-27 2022 SG_LOG(3, sfp, "%s: SG_SET_DEBUG\n", __func__);
^1da177e4c3f41 Linus Torvalds 2005-04-16 2023 result = get_user(val, ip);
^1da177e4c3f41 Linus Torvalds 2005-04-16 2024 if (result)
^1da177e4c3f41 Linus Torvalds 2005-04-16 2025 return result;
20d8ebcd78db48 Douglas Gilbert 2020-02-27 2026 assign_bit(SG_FDEV_LOG_SENSE, sdp->fdev_bm, !!val);
0b192c5441f451 Douglas Gilbert 2020-02-27 2027 if (val == 0) /* user can force recalculation */
0b192c5441f451 Douglas Gilbert 2020-02-27 2028 sg_calc_sgat_param(sdp);
^1da177e4c3f41 Linus Torvalds 2005-04-16 2029 return 0;
44ec95425c1d9d Alan Stern 2007-02-20 2030 case BLKSECTGET:
e9a6fc36629575 Douglas Gilbert 2020-02-27 2031 SG_LOG(3, sfp, "%s: BLKSECTGET\n", __func__);
e9a6fc36629575 Douglas Gilbert 2020-02-27 2032 return put_user(max_sectors_bytes(sdev->request_queue), ip);
6da127ad0918f9 Christof Schmitt 2008-01-11 2033 case BLKTRACESETUP:
e9a6fc36629575 Douglas Gilbert 2020-02-27 2034 SG_LOG(3, sfp, "%s: BLKTRACESETUP\n", __func__);
e9a6fc36629575 Douglas Gilbert 2020-02-27 2035 return blk_trace_setup(sdev->request_queue,
6da127ad0918f9 Christof Schmitt 2008-01-11 2036 sdp->disk->disk_name,
76e3a19d0691bb Martin Peschke 2009-01-30 2037 MKDEV(SCSI_GENERIC_MAJOR, sdp->index),
7475c8ae1b7bfc Bart Van Assche 2017-08-25 2038 NULL, p);
6da127ad0918f9 Christof Schmitt 2008-01-11 2039 case BLKTRACESTART:
e9a6fc36629575 Douglas Gilbert 2020-02-27 2040 SG_LOG(3, sfp, "%s: BLKTRACESTART\n", __func__);
e9a6fc36629575 Douglas Gilbert 2020-02-27 2041 return blk_trace_startstop(sdev->request_queue, 1);
6da127ad0918f9 Christof Schmitt 2008-01-11 2042 case BLKTRACESTOP:
e9a6fc36629575 Douglas Gilbert 2020-02-27 2043 SG_LOG(3, sfp, "%s: BLKTRACESTOP\n", __func__);
e9a6fc36629575 Douglas Gilbert 2020-02-27 2044 return blk_trace_startstop(sdev->request_queue, 0);
6da127ad0918f9 Christof Schmitt 2008-01-11 2045 case BLKTRACETEARDOWN:
e9a6fc36629575 Douglas Gilbert 2020-02-27 2046 SG_LOG(3, sfp, "%s: BLKTRACETEARDOWN\n", __func__);
e9a6fc36629575 Douglas Gilbert 2020-02-27 2047 return blk_trace_remove(sdev->request_queue);
906d15fbd23c12 Christoph Hellwig 2014-10-11 2048 case SCSI_IOCTL_GET_IDLUN:
e9a6fc36629575 Douglas Gilbert 2020-02-27 2049 SG_LOG(3, sfp, "%s: SCSI_IOCTL_GET_IDLUN %s\n", __func__,
e9a6fc36629575 Douglas Gilbert 2020-02-27 2050 pmlp);
e9a6fc36629575 Douglas Gilbert 2020-02-27 2051 break;
906d15fbd23c12 Christoph Hellwig 2014-10-11 2052 case SCSI_IOCTL_GET_BUS_NUMBER:
e9a6fc36629575 Douglas Gilbert 2020-02-27 2053 SG_LOG(3, sfp, "%s: SCSI_IOCTL_GET_BUS_NUMBER%s\n",
e9a6fc36629575 Douglas Gilbert 2020-02-27 2054 __func__, pmlp);
e9a6fc36629575 Douglas Gilbert 2020-02-27 2055 break;
906d15fbd23c12 Christoph Hellwig 2014-10-11 2056 case SCSI_IOCTL_PROBE_HOST:
e9a6fc36629575 Douglas Gilbert 2020-02-27 2057 SG_LOG(3, sfp, "%s: SCSI_IOCTL_PROBE_HOST%s",
e9a6fc36629575 Douglas Gilbert 2020-02-27 2058 __func__, pmlp);
e9a6fc36629575 Douglas Gilbert 2020-02-27 2059 break;
906d15fbd23c12 Christoph Hellwig 2014-10-11 2060 case SG_GET_TRANSFORM:
e9a6fc36629575 Douglas Gilbert 2020-02-27 2061 SG_LOG(3, sfp, "%s: SG_GET_TRANSFORM%s\n", __func__, pmlp);
906d15fbd23c12 Christoph Hellwig 2014-10-11 2062 break;
^1da177e4c3f41 Linus Torvalds 2005-04-16 2063 default:
e9a6fc36629575 Douglas Gilbert 2020-02-27 2064 SG_LOG(3, sfp, "%s: unrecognized ioctl [0x%x]%s\n",
e9a6fc36629575 Douglas Gilbert 2020-02-27 2065 __func__, cmd_in, pmlp);
^1da177e4c3f41 Linus Torvalds 2005-04-16 2066 if (read_only)
e9a6fc36629575 Douglas Gilbert 2020-02-27 2067 return -EPERM; /* don't know, so take safer approach */
906d15fbd23c12 Christoph Hellwig 2014-10-11 2068 break;
^1da177e4c3f41 Linus Torvalds 2005-04-16 2069 }
98dd8630b9e9cb Douglas Gilbert 2020-02-27 2070 result = sg_allow_if_err_recovery(sdp, filp->f_flags & O_NDELAY);
20d8ebcd78db48 Douglas Gilbert 2020-02-27 2071 if (unlikely(result))
906d15fbd23c12 Christoph Hellwig 2014-10-11 2072 return result;
d320a9551e394c Arnd Bergmann 2019-03-15 2073 return -ENOIOCTLCMD;
^1da177e4c3f41 Linus Torvalds 2005-04-16 @2074 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 2075
:::::: The code at line 2074 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2
:::::: TO: Linus Torvalds <torvalds(a)ppc970.osdl.org>
:::::: CC: Linus Torvalds <torvalds(a)ppc970.osdl.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 7 months
[mptcp:t/mptcp-Implement-path-manager-interface-commands 21/25] net/mptcp/pm.c:18:21: error: 'msk' redeclared as different kind of symbol
by kbuild test robot
tree: https://github.com/multipath-tcp/mptcp_net-next.git t/mptcp-Implement-path-manager-interface-commands
head: a28e79bf6de027fea5d0522a32a686aacf5658a7
commit: f8513e13c445c1804d044dae4b612ea986b491cb [21/25] tgupdate: merge t/mptcp-Implement-path-manager-interface-commands base into t/mptcp-Implement-path-manager-interface-commands
config: openrisc-randconfig-a001-20200228 (attached as .config)
compiler: or1k-linux-gcc (GCC) 9.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout f8513e13c445c1804d044dae4b612ea986b491cb
# save the attached .config to linux build tree
GCC_VERSION=9.2.0 make.cross ARCH=openrisc
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
Note: the mptcp/t/mptcp-Implement-path-manager-interface-commands HEAD a28e79bf6de027fea5d0522a32a686aacf5658a7 builds fine.
It only hurts bisectibility.
All errors (new ones prefixed by >>):
net/mptcp/pm.c: In function 'mptcp_pm_announce_addr':
>> net/mptcp/pm.c:18:21: error: 'msk' redeclared as different kind of symbol
18 | struct mptcp_sock *msk = mptcp_token_get_sock(token);
| ^~~
net/mptcp/pm.c:15:47: note: previous definition of 'msk' was here
15 | int mptcp_pm_announce_addr(struct mptcp_sock *msk,
| ~~~~~~~~~~~~~~~~~~~^~~
>> net/mptcp/pm.c:18:48: error: 'token' undeclared (first use in this function); did you mean 'to_kset'?
18 | struct mptcp_sock *msk = mptcp_token_get_sock(token);
| ^~~~~
| to_kset
net/mptcp/pm.c:18:48: note: each undeclared identifier is reported only once for each function it appears in
>> net/mptcp/pm.c:30:14: error: 'struct mptcp_pm_data' has no member named 'remote_valid'
30 | if (!msk->pm.remote_valid || remote_id != msk->pm.remote_id) {
| ^
>> net/mptcp/pm.c:30:31: error: 'remote_id' undeclared (first use in this function); did you mean 'remote'?
30 | if (!msk->pm.remote_valid || remote_id != msk->pm.remote_id) {
| ^~~~~~~~~
| remote
>> net/mptcp/pm.c:30:52: error: 'struct mptcp_pm_data' has no member named 'remote_id'; did you mean 'remote'?
30 | if (!msk->pm.remote_valid || remote_id != msk->pm.remote_id) {
| ^~~~~~~~~
| remote
>> net/mptcp/pm.c:38:20: error: incompatible types when assigning to type 'struct in_addr' from type 'const struct mptcp_addr_info'
38 | local.sin_addr = *addr;
| ^
>> net/mptcp/pm.c:42:29: error: 'struct mptcp_pm_data' has no member named 'remote_family'
42 | remote.sin_family = msk->pm.remote_family;
| ^
>> net/mptcp/pm.c:44:27: error: 'struct mptcp_pm_data' has no member named 'remote_addr'
44 | remote.sin_addr = msk->pm.remote_addr;
| ^
net/mptcp/pm.c: In function 'mptcp_pm_remove_addr':
net/mptcp/pm.c:56:21: error: 'msk' redeclared as different kind of symbol
56 | struct mptcp_sock *msk = mptcp_token_get_sock(token);
| ^~~
net/mptcp/pm.c:54:45: note: previous definition of 'msk' was here
54 | int mptcp_pm_remove_addr(struct mptcp_sock *msk, u8 local_id)
| ~~~~~~~~~~~~~~~~~~~^~~
net/mptcp/pm.c:56:48: error: 'token' undeclared (first use in this function); did you mean 'to_kset'?
56 | struct mptcp_sock *msk = mptcp_token_get_sock(token);
| ^~~~~
| to_kset
net/mptcp/pm.c:68:14: error: 'struct mptcp_pm_data' has no member named 'remote_valid'
68 | if (!msk->pm.remote_valid || remote_id != msk->pm.remote_id) {
| ^
net/mptcp/pm.c:68:31: error: 'remote_id' undeclared (first use in this function); did you mean 'remote'?
68 | if (!msk->pm.remote_valid || remote_id != msk->pm.remote_id) {
| ^~~~~~~~~
| remote
net/mptcp/pm.c:68:52: error: 'struct mptcp_pm_data' has no member named 'remote_id'; did you mean 'remote'?
68 | if (!msk->pm.remote_valid || remote_id != msk->pm.remote_id) {
| ^~~~~~~~~
| remote
>> net/mptcp/pm.c:75:6: error: 'addr' undeclared (first use in this function)
75 | if (addr)
| ^~~~
net/mptcp/pm.c:80:30: error: 'struct mptcp_pm_data' has no member named 'remote_family'
80 | remote.sin6_family = msk->pm.remote_family;
| ^
>> net/mptcp/pm.c:82:28: error: 'struct mptcp_pm_data' has no member named 'remote_addr6'
82 | remote.sin6_addr = msk->pm.remote_addr6;
| ^
vim +/msk +18 net/mptcp/pm.c
532e0037f0c3af Peter Krystad 2020-02-26 14
cb6c1764eb317d Paolo Abeni 2020-02-24 15 int mptcp_pm_announce_addr(struct mptcp_sock *msk,
cb6c1764eb317d Paolo Abeni 2020-02-24 16 const struct mptcp_addr_info *addr)
532e0037f0c3af Peter Krystad 2020-02-26 17 {
4b738110d9bfa5 Peter Krystad 2020-02-26 @18 struct mptcp_sock *msk = mptcp_token_get_sock(token);
4b738110d9bfa5 Peter Krystad 2020-02-26 19 struct sockaddr_in remote;
4b738110d9bfa5 Peter Krystad 2020-02-26 20 struct sockaddr_in local;
4b738110d9bfa5 Peter Krystad 2020-02-26 21 struct sock *sk;
4b738110d9bfa5 Peter Krystad 2020-02-26 22 int err;
4b738110d9bfa5 Peter Krystad 2020-02-26 23
4b738110d9bfa5 Peter Krystad 2020-02-26 24 if (!msk)
4b738110d9bfa5 Peter Krystad 2020-02-26 25 return -EINVAL;
4b738110d9bfa5 Peter Krystad 2020-02-26 26
4b738110d9bfa5 Peter Krystad 2020-02-26 27 pr_debug("msk=%p", msk);
4b738110d9bfa5 Peter Krystad 2020-02-26 28
4b738110d9bfa5 Peter Krystad 2020-02-26 29 sk = (struct sock *)msk;
4b738110d9bfa5 Peter Krystad 2020-02-26 @30 if (!msk->pm.remote_valid || remote_id != msk->pm.remote_id) {
4b738110d9bfa5 Peter Krystad 2020-02-26 31 err = -EBADR;
4b738110d9bfa5 Peter Krystad 2020-02-26 32 goto create_put;
4b738110d9bfa5 Peter Krystad 2020-02-26 33 }
4b738110d9bfa5 Peter Krystad 2020-02-26 34
4b738110d9bfa5 Peter Krystad 2020-02-26 35 local.sin_family = AF_INET;
4b738110d9bfa5 Peter Krystad 2020-02-26 36 local.sin_port = 0;
4b738110d9bfa5 Peter Krystad 2020-02-26 37 if (addr)
4b738110d9bfa5 Peter Krystad 2020-02-26 @38 local.sin_addr = *addr;
4b738110d9bfa5 Peter Krystad 2020-02-26 39 else
4b738110d9bfa5 Peter Krystad 2020-02-26 40 local.sin_addr.s_addr = htonl(INADDR_ANY);
4b738110d9bfa5 Peter Krystad 2020-02-26 41
4b738110d9bfa5 Peter Krystad 2020-02-26 @42 remote.sin_family = msk->pm.remote_family;
4b738110d9bfa5 Peter Krystad 2020-02-26 43 remote.sin_port = inet_sk(sk)->inet_dport;
4b738110d9bfa5 Peter Krystad 2020-02-26 @44 remote.sin_addr = msk->pm.remote_addr;
4b738110d9bfa5 Peter Krystad 2020-02-26 45
4b738110d9bfa5 Peter Krystad 2020-02-26 46 err = mptcp_subflow_connect(sk, (struct sockaddr *)&local,
4b738110d9bfa5 Peter Krystad 2020-02-26 47 (struct sockaddr *)&remote, remote_id);
4b738110d9bfa5 Peter Krystad 2020-02-26 48
4b738110d9bfa5 Peter Krystad 2020-02-26 49 create_put:
4b738110d9bfa5 Peter Krystad 2020-02-26 50 sock_put(sk);
4b738110d9bfa5 Peter Krystad 2020-02-26 51 return err;
532e0037f0c3af Peter Krystad 2020-02-26 52 }
532e0037f0c3af Peter Krystad 2020-02-26 53
cb6c1764eb317d Paolo Abeni 2020-02-24 54 int mptcp_pm_remove_addr(struct mptcp_sock *msk, u8 local_id)
532e0037f0c3af Peter Krystad 2020-02-26 55 {
4b738110d9bfa5 Peter Krystad 2020-02-26 56 struct mptcp_sock *msk = mptcp_token_get_sock(token);
4b738110d9bfa5 Peter Krystad 2020-02-26 57 struct sockaddr_in6 remote;
4b738110d9bfa5 Peter Krystad 2020-02-26 58 struct sockaddr_in6 local;
4b738110d9bfa5 Peter Krystad 2020-02-26 59 struct sock *sk;
4b738110d9bfa5 Peter Krystad 2020-02-26 60 int err;
4b738110d9bfa5 Peter Krystad 2020-02-26 61
4b738110d9bfa5 Peter Krystad 2020-02-26 62 if (!msk)
4b738110d9bfa5 Peter Krystad 2020-02-26 63 return -EINVAL;
4b738110d9bfa5 Peter Krystad 2020-02-26 64
4b738110d9bfa5 Peter Krystad 2020-02-26 65 pr_debug("msk=%p", msk);
4b738110d9bfa5 Peter Krystad 2020-02-26 66 sk = (struct sock *)msk;
4b738110d9bfa5 Peter Krystad 2020-02-26 67
4b738110d9bfa5 Peter Krystad 2020-02-26 68 if (!msk->pm.remote_valid || remote_id != msk->pm.remote_id) {
4b738110d9bfa5 Peter Krystad 2020-02-26 69 err = -EBADR;
4b738110d9bfa5 Peter Krystad 2020-02-26 70 goto create_put;
4b738110d9bfa5 Peter Krystad 2020-02-26 71 }
4b738110d9bfa5 Peter Krystad 2020-02-26 72
4b738110d9bfa5 Peter Krystad 2020-02-26 73 local.sin6_family = AF_INET6;
4b738110d9bfa5 Peter Krystad 2020-02-26 74 local.sin6_port = 0;
4b738110d9bfa5 Peter Krystad 2020-02-26 @75 if (addr)
4b738110d9bfa5 Peter Krystad 2020-02-26 76 local.sin6_addr = *addr;
4b738110d9bfa5 Peter Krystad 2020-02-26 77 else
4b738110d9bfa5 Peter Krystad 2020-02-26 78 local.sin6_addr = in6addr_any;
4b738110d9bfa5 Peter Krystad 2020-02-26 79
4b738110d9bfa5 Peter Krystad 2020-02-26 80 remote.sin6_family = msk->pm.remote_family;
4b738110d9bfa5 Peter Krystad 2020-02-26 81 remote.sin6_port = inet_sk(sk)->inet_dport;
4b738110d9bfa5 Peter Krystad 2020-02-26 @82 remote.sin6_addr = msk->pm.remote_addr6;
4b738110d9bfa5 Peter Krystad 2020-02-26 83
4b738110d9bfa5 Peter Krystad 2020-02-26 84 err = mptcp_subflow_connect(sk, (struct sockaddr *)&local,
4b738110d9bfa5 Peter Krystad 2020-02-26 85 (struct sockaddr *)&remote, remote_id);
4b738110d9bfa5 Peter Krystad 2020-02-26 86
4b738110d9bfa5 Peter Krystad 2020-02-26 87 create_put:
4b738110d9bfa5 Peter Krystad 2020-02-26 88 sock_put(sk);
4b738110d9bfa5 Peter Krystad 2020-02-26 89 return err;
532e0037f0c3af Peter Krystad 2020-02-26 90 }
532e0037f0c3af Peter Krystad 2020-02-26 91
:::::: The code at line 18 was first introduced by commit
:::::: 4b738110d9bfa5e1a763123e0ef6d0d2f5852782 mptcp: Implement path manager interface commands
:::::: TO: Peter Krystad <peter.krystad(a)linux.intel.com>
:::::: CC: Matthieu Baerts <matthieu.baerts(a)tessares.net>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 7 months
drivers/staging/comedi/comedi_fops.c:2380:8: error: 'PAGE_SHARED' undeclared; did you mean 'VM_SHARED'?
by kbuild test robot
Hi Paul,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 45d0b75b98bf1de4b3a5b09188c75f3bfa3152b0
commit: 5ba9aa56e6d3e8fddb954c2f818d1ce0525235bb Merge branch 'next/nommu' into for-next
date: 3 months ago
config: riscv-randconfig-a001-20200229 (attached as .config)
compiler: riscv64-linux-gcc (GCC) 7.5.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 5ba9aa56e6d3e8fddb954c2f818d1ce0525235bb
# save the attached .config to linux build tree
GCC_VERSION=7.5.0 make.cross ARCH=riscv
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
drivers/staging/comedi/comedi_fops.c: In function 'comedi_mmap':
>> drivers/staging/comedi/comedi_fops.c:2380:8: error: 'PAGE_SHARED' undeclared (first use in this function); did you mean 'VM_SHARED'?
PAGE_SHARED);
^~~~~~~~~~~
VM_SHARED
drivers/staging/comedi/comedi_fops.c:2380:8: note: each undeclared identifier is reported only once for each function it appears in
vim +2380 drivers/staging/comedi/comedi_fops.c
ed9eccbe8970f6 David Schleef 2008-11-04 2296
ed9eccbe8970f6 David Schleef 2008-11-04 2297 static int comedi_mmap(struct file *file, struct vm_area_struct *vma)
ed9eccbe8970f6 David Schleef 2008-11-04 2298 {
20f083c07565cb Ian Abbott 2014-11-04 2299 struct comedi_file *cfp = file->private_data;
20f083c07565cb Ian Abbott 2014-11-04 2300 struct comedi_device *dev = cfp->dev;
a52840a98bbb50 H Hartley Sweeten 2012-12-19 2301 struct comedi_subdevice *s;
a52840a98bbb50 H Hartley Sweeten 2012-12-19 2302 struct comedi_async *async;
b34aa86f12e884 Ian Abbott 2014-04-10 2303 struct comedi_buf_map *bm = NULL;
e36472145aa706 Ian Abbott 2019-06-25 2304 struct comedi_buf_page *buf;
ed9eccbe8970f6 David Schleef 2008-11-04 2305 unsigned long start = vma->vm_start;
ed9eccbe8970f6 David Schleef 2008-11-04 2306 unsigned long size;
ed9eccbe8970f6 David Schleef 2008-11-04 2307 int n_pages;
ed9eccbe8970f6 David Schleef 2008-11-04 2308 int i;
e36472145aa706 Ian Abbott 2019-06-25 2309 int retval = 0;
3ffab428f40849 Bernd Porr 2011-11-08 2310
b34aa86f12e884 Ian Abbott 2014-04-10 2311 /*
b34aa86f12e884 Ian Abbott 2014-04-10 2312 * 'trylock' avoids circular dependency with current->mm->mmap_sem
b34aa86f12e884 Ian Abbott 2014-04-10 2313 * and down-reading &dev->attach_lock should normally succeed without
b34aa86f12e884 Ian Abbott 2014-04-10 2314 * contention unless the device is in the process of being attached
b34aa86f12e884 Ian Abbott 2014-04-10 2315 * or detached.
b34aa86f12e884 Ian Abbott 2014-04-10 2316 */
b34aa86f12e884 Ian Abbott 2014-04-10 2317 if (!down_read_trylock(&dev->attach_lock))
b34aa86f12e884 Ian Abbott 2014-04-10 2318 return -EAGAIN;
a52840a98bbb50 H Hartley Sweeten 2012-12-19 2319
ed9eccbe8970f6 David Schleef 2008-11-04 2320 if (!dev->attached) {
272850f07c47ab H Hartley Sweeten 2013-11-26 2321 dev_dbg(dev->class_dev, "no driver attached\n");
ed9eccbe8970f6 David Schleef 2008-11-04 2322 retval = -ENODEV;
ed9eccbe8970f6 David Schleef 2008-11-04 2323 goto done;
ed9eccbe8970f6 David Schleef 2008-11-04 2324 }
a52840a98bbb50 H Hartley Sweeten 2012-12-19 2325
476b847733636c Greg Kroah-Hartman 2008-11-13 2326 if (vma->vm_flags & VM_WRITE)
20f083c07565cb Ian Abbott 2014-11-04 2327 s = comedi_file_write_subdevice(file);
476b847733636c Greg Kroah-Hartman 2008-11-13 2328 else
20f083c07565cb Ian Abbott 2014-11-04 2329 s = comedi_file_read_subdevice(file);
a52840a98bbb50 H Hartley Sweeten 2012-12-19 2330 if (!s) {
ed9eccbe8970f6 David Schleef 2008-11-04 2331 retval = -EINVAL;
ed9eccbe8970f6 David Schleef 2008-11-04 2332 goto done;
ed9eccbe8970f6 David Schleef 2008-11-04 2333 }
a52840a98bbb50 H Hartley Sweeten 2012-12-19 2334
ed9eccbe8970f6 David Schleef 2008-11-04 2335 async = s->async;
a52840a98bbb50 H Hartley Sweeten 2012-12-19 2336 if (!async) {
ed9eccbe8970f6 David Schleef 2008-11-04 2337 retval = -EINVAL;
ed9eccbe8970f6 David Schleef 2008-11-04 2338 goto done;
ed9eccbe8970f6 David Schleef 2008-11-04 2339 }
ed9eccbe8970f6 David Schleef 2008-11-04 2340
ed9eccbe8970f6 David Schleef 2008-11-04 2341 if (vma->vm_pgoff != 0) {
272850f07c47ab H Hartley Sweeten 2013-11-26 2342 dev_dbg(dev->class_dev, "mmap() offset must be 0.\n");
ed9eccbe8970f6 David Schleef 2008-11-04 2343 retval = -EINVAL;
ed9eccbe8970f6 David Schleef 2008-11-04 2344 goto done;
ed9eccbe8970f6 David Schleef 2008-11-04 2345 }
ed9eccbe8970f6 David Schleef 2008-11-04 2346
ed9eccbe8970f6 David Schleef 2008-11-04 2347 size = vma->vm_end - vma->vm_start;
ed9eccbe8970f6 David Schleef 2008-11-04 2348 if (size > async->prealloc_bufsz) {
ed9eccbe8970f6 David Schleef 2008-11-04 2349 retval = -EFAULT;
ed9eccbe8970f6 David Schleef 2008-11-04 2350 goto done;
ed9eccbe8970f6 David Schleef 2008-11-04 2351 }
44b8c793fc0d63 Sandhya Bankar 2016-03-06 2352 if (offset_in_page(size)) {
ed9eccbe8970f6 David Schleef 2008-11-04 2353 retval = -EFAULT;
ed9eccbe8970f6 David Schleef 2008-11-04 2354 goto done;
ed9eccbe8970f6 David Schleef 2008-11-04 2355 }
ed9eccbe8970f6 David Schleef 2008-11-04 2356
ec9d0754e0c640 sayli karnik 2016-09-20 2357 n_pages = vma_pages(vma);
b34aa86f12e884 Ian Abbott 2014-04-10 2358
b34aa86f12e884 Ian Abbott 2014-04-10 2359 /* get reference to current buf map (if any) */
b34aa86f12e884 Ian Abbott 2014-04-10 2360 bm = comedi_buf_map_from_subdev_get(s);
af93da31634d6d Ian Abbott 2013-11-08 2361 if (!bm || n_pages > bm->n_pages) {
af93da31634d6d Ian Abbott 2013-11-08 2362 retval = -EINVAL;
af93da31634d6d Ian Abbott 2013-11-08 2363 goto done;
af93da31634d6d Ian Abbott 2013-11-08 2364 }
e36472145aa706 Ian Abbott 2019-06-25 2365 if (bm->dma_dir != DMA_NONE) {
e36472145aa706 Ian Abbott 2019-06-25 2366 /*
e36472145aa706 Ian Abbott 2019-06-25 2367 * DMA buffer was allocated as a single block.
e36472145aa706 Ian Abbott 2019-06-25 2368 * Address is in page_list[0].
e36472145aa706 Ian Abbott 2019-06-25 2369 */
e36472145aa706 Ian Abbott 2019-06-25 2370 buf = &bm->page_list[0];
e36472145aa706 Ian Abbott 2019-06-25 2371 retval = dma_mmap_coherent(bm->dma_hw_dev, vma, buf->virt_addr,
e36472145aa706 Ian Abbott 2019-06-25 2372 buf->dma_addr, n_pages * PAGE_SIZE);
e36472145aa706 Ian Abbott 2019-06-25 2373 } else {
ed9eccbe8970f6 David Schleef 2008-11-04 2374 for (i = 0; i < n_pages; ++i) {
e36472145aa706 Ian Abbott 2019-06-25 2375 unsigned long pfn;
e36472145aa706 Ian Abbott 2019-06-25 2376
e36472145aa706 Ian Abbott 2019-06-25 2377 buf = &bm->page_list[i];
e36472145aa706 Ian Abbott 2019-06-25 2378 pfn = page_to_pfn(virt_to_page(buf->virt_addr));
e36472145aa706 Ian Abbott 2019-06-25 2379 retval = remap_pfn_range(vma, start, pfn, PAGE_SIZE,
e36472145aa706 Ian Abbott 2019-06-25 @2380 PAGE_SHARED);
e36472145aa706 Ian Abbott 2019-06-25 2381 if (retval)
e36472145aa706 Ian Abbott 2019-06-25 2382 break;
a52840a98bbb50 H Hartley Sweeten 2012-12-19 2383
ed9eccbe8970f6 David Schleef 2008-11-04 2384 start += PAGE_SIZE;
ed9eccbe8970f6 David Schleef 2008-11-04 2385 }
e36472145aa706 Ian Abbott 2019-06-25 2386 }
ed9eccbe8970f6 David Schleef 2008-11-04 2387
e36472145aa706 Ian Abbott 2019-06-25 2388 if (retval == 0) {
ed9eccbe8970f6 David Schleef 2008-11-04 2389 vma->vm_ops = &comedi_vm_ops;
af93da31634d6d Ian Abbott 2013-11-08 2390 vma->vm_private_data = bm;
ed9eccbe8970f6 David Schleef 2008-11-04 2391
af93da31634d6d Ian Abbott 2013-11-08 2392 vma->vm_ops->open(vma);
e36472145aa706 Ian Abbott 2019-06-25 2393 }
ed9eccbe8970f6 David Schleef 2008-11-04 2394
ed9eccbe8970f6 David Schleef 2008-11-04 2395 done:
b34aa86f12e884 Ian Abbott 2014-04-10 2396 up_read(&dev->attach_lock);
b34aa86f12e884 Ian Abbott 2014-04-10 2397 comedi_buf_map_put(bm); /* put reference to buf map - okay if NULL */
ed9eccbe8970f6 David Schleef 2008-11-04 2398 return retval;
ed9eccbe8970f6 David Schleef 2008-11-04 2399 }
ed9eccbe8970f6 David Schleef 2008-11-04 2400
:::::: The code at line 2380 was first introduced by commit
:::::: e36472145aa706c186a6bb4f6419c613b0b1305c staging: comedi: use dma_mmap_coherent for DMA-able buffer mmap
:::::: TO: Ian Abbott <abbotti(a)mev.co.uk>
:::::: CC: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 7 months
[peterz-queue:locking/task_work 18/38] include/linux/rcupdate.h:197:3: error: implicit declaration of function 'rcu_irq_enter_irqsave'
by kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git locking/task_work
head: b9a78907dfb92b903d4d52402fc69a051cafa716
commit: a6377699039712759e256b989ffee5da7a50f791 [18/38] rcu,tracing: Create trace_rcu_{enter,exit}()
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (git://gitmirror/llvm_project 949134e2fefd34a38ed71de90dffe2300e2e1139)
reproduce:
# FIXME the reproduce steps for clang is not ready yet
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
In file included from arch/x86/kernel/asm-offsets.c:9:
In file included from include/linux/crypto.h:19:
In file included from include/linux/slab.h:15:
In file included from include/linux/gfp.h:6:
In file included from include/linux/mmzone.h:21:
In file included from include/linux/mm_types.h:10:
In file included from include/linux/rbtree.h:22:
>> include/linux/rcupdate.h:197:3: error: implicit declaration of function 'rcu_irq_enter_irqsave' [-Werror,-Wimplicit-function-declaration]
rcu_irq_enter_irqsave();
^
include/linux/rcupdate.h:197:3: note: did you mean 'rcu_irq_enter_irqsafe'?
include/linux/rcutree.h:49:6: note: 'rcu_irq_enter_irqsafe' declared here
void rcu_irq_enter_irqsafe(void);
^
In file included from arch/x86/kernel/asm-offsets.c:9:
In file included from include/linux/crypto.h:19:
In file included from include/linux/slab.h:15:
In file included from include/linux/gfp.h:6:
In file included from include/linux/mmzone.h:21:
In file included from include/linux/mm_types.h:10:
In file included from include/linux/rbtree.h:22:
>> include/linux/rcupdate.h:204:3: error: implicit declaration of function 'rcu_irq_exit_irqsave' [-Werror,-Wimplicit-function-declaration]
rcu_irq_exit_irqsave();
^
include/linux/rcupdate.h:204:3: note: did you mean 'rcu_irq_exit_irqsafe'?
include/linux/rcutree.h:50:6: note: 'rcu_irq_exit_irqsafe' declared here
void rcu_irq_exit_irqsafe(void);
^
2 errors generated.
make[2]: *** [scripts/Makefile.build:101: arch/x86/kernel/asm-offsets.s] Error 1
make[2]: Target '__build' not remade because of errors.
make[1]: *** [Makefile:1112: prepare0] Error 2
make[1]: Target 'prepare' not remade because of errors.
make: *** [Makefile:179: sub-make] Error 2
149 real 14 user 19 sys 22.93% cpu make prepare
vim +/rcu_irq_enter_irqsave +197 include/linux/rcupdate.h
177
178 /**
179 * trace_rcu_enter - Force RCU to be active, for code that needs RCU readers
180 *
181 * Very similar to RCU_NONIDLE() above.
182 *
183 * Tracing can happen while RCU isn't active yet, for instance in the idle loop
184 * between rcu_idle_enter() and rcu_idle_exit(), or early in exception entry.
185 * RCU will happily ignore any read-side critical sections in this case.
186 *
187 * This function ensures that RCU is aware hereafter and the code can readily
188 * rely on RCU read-side critical sections working as expected.
189 *
190 * This function is NMI safe -- provided in_nmi() is correct and will nest up-to
191 * INT_MAX/2 times.
192 */
193 static inline int trace_rcu_enter(void)
194 {
195 int state = !rcu_is_watching();
196 if (state)
> 197 rcu_irq_enter_irqsave();
198 return state;
199 }
200
201 static inline void trace_rcu_exit(int state)
202 {
203 if (state)
> 204 rcu_irq_exit_irqsave();
205 }
206
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 7 months
Re: [PATCH v3 08/14] powerpc: add support for folded p4d page tables
by kbuild test robot
Hi Mike,
I love your patch! Yet something to improve:
[auto build test ERROR on powerpc/next]
[also build test ERROR on arm/for-next arm64/for-next/core linus/master v5.6-rc3 next-20200228]
[cannot apply to mmotm/master]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Mike-Rapoport/mm-remove-__ARCH_H...
base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc-ppc64_defconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 7.5.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.5.0 make.cross ARCH=powerpc
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
arch/powerpc/kvm/book3s_64_mmu_radix.c: In function 'debugfs_radix_read':
>> arch/powerpc/kvm/book3s_64_mmu_radix.c:1226:8: error: unused variable 'pgd' [-Werror=unused-variable]
pgd_t pgd, *pgdp;
^~~
cc1: all warnings being treated as errors
vim +/pgd +1226 arch/powerpc/kvm/book3s_64_mmu_radix.c
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1215
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1216 static ssize_t debugfs_radix_read(struct file *file, char __user *buf,
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1217 size_t len, loff_t *ppos)
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1218 {
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1219 struct debugfs_radix_state *p = file->private_data;
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1220 ssize_t ret, r;
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1221 unsigned long n;
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1222 struct kvm *kvm;
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1223 unsigned long gpa;
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1224 pgd_t *pgt;
83a055104eaf89 Paul Mackerras 2018-10-08 1225 struct kvm_nested_guest *nested;
9a94d3ee2d1599 Paul Mackerras 2018-10-08 @1226 pgd_t pgd, *pgdp;
f97ba1f7bf6bd7 Mike Rapoport 2020-02-27 1227 p4d_t p4d, *p4dp;
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1228 pud_t pud, *pudp;
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1229 pmd_t pmd, *pmdp;
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1230 pte_t *ptep;
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1231 int shift;
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1232 unsigned long pte;
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1233
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1234 kvm = p->kvm;
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1235 if (!kvm_is_radix(kvm))
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1236 return 0;
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1237
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1238 ret = mutex_lock_interruptible(&p->mutex);
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1239 if (ret)
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1240 return ret;
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1241
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1242 if (p->chars_left) {
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1243 n = p->chars_left;
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1244 if (n > len)
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1245 n = len;
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1246 r = copy_to_user(buf, p->buf + p->buf_index, n);
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1247 n -= r;
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1248 p->chars_left -= n;
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1249 p->buf_index += n;
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1250 buf += n;
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1251 len -= n;
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1252 ret = n;
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1253 if (r) {
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1254 if (!n)
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1255 ret = -EFAULT;
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1256 goto out;
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1257 }
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1258 }
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1259
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1260 gpa = p->gpa;
83a055104eaf89 Paul Mackerras 2018-10-08 1261 nested = NULL;
83a055104eaf89 Paul Mackerras 2018-10-08 1262 pgt = NULL;
83a055104eaf89 Paul Mackerras 2018-10-08 1263 while (len != 0 && p->lpid >= 0) {
83a055104eaf89 Paul Mackerras 2018-10-08 1264 if (gpa >= RADIX_PGTABLE_RANGE) {
83a055104eaf89 Paul Mackerras 2018-10-08 1265 gpa = 0;
83a055104eaf89 Paul Mackerras 2018-10-08 1266 pgt = NULL;
83a055104eaf89 Paul Mackerras 2018-10-08 1267 if (nested) {
83a055104eaf89 Paul Mackerras 2018-10-08 1268 kvmhv_put_nested(nested);
83a055104eaf89 Paul Mackerras 2018-10-08 1269 nested = NULL;
83a055104eaf89 Paul Mackerras 2018-10-08 1270 }
83a055104eaf89 Paul Mackerras 2018-10-08 1271 p->lpid = kvmhv_nested_next_lpid(kvm, p->lpid);
83a055104eaf89 Paul Mackerras 2018-10-08 1272 p->hdr = 0;
83a055104eaf89 Paul Mackerras 2018-10-08 1273 if (p->lpid < 0)
83a055104eaf89 Paul Mackerras 2018-10-08 1274 break;
83a055104eaf89 Paul Mackerras 2018-10-08 1275 }
83a055104eaf89 Paul Mackerras 2018-10-08 1276 if (!pgt) {
83a055104eaf89 Paul Mackerras 2018-10-08 1277 if (p->lpid == 0) {
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1278 pgt = kvm->arch.pgtable;
83a055104eaf89 Paul Mackerras 2018-10-08 1279 } else {
83a055104eaf89 Paul Mackerras 2018-10-08 1280 nested = kvmhv_get_nested(kvm, p->lpid, false);
83a055104eaf89 Paul Mackerras 2018-10-08 1281 if (!nested) {
83a055104eaf89 Paul Mackerras 2018-10-08 1282 gpa = RADIX_PGTABLE_RANGE;
83a055104eaf89 Paul Mackerras 2018-10-08 1283 continue;
83a055104eaf89 Paul Mackerras 2018-10-08 1284 }
83a055104eaf89 Paul Mackerras 2018-10-08 1285 pgt = nested->shadow_pgtable;
83a055104eaf89 Paul Mackerras 2018-10-08 1286 }
83a055104eaf89 Paul Mackerras 2018-10-08 1287 }
83a055104eaf89 Paul Mackerras 2018-10-08 1288 n = 0;
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1289 if (!p->hdr) {
83a055104eaf89 Paul Mackerras 2018-10-08 1290 if (p->lpid > 0)
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1291 n = scnprintf(p->buf, sizeof(p->buf),
83a055104eaf89 Paul Mackerras 2018-10-08 1292 "\nNested LPID %d: ", p->lpid);
83a055104eaf89 Paul Mackerras 2018-10-08 1293 n += scnprintf(p->buf + n, sizeof(p->buf) - n,
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1294 "pgdir: %lx\n", (unsigned long)pgt);
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1295 p->hdr = 1;
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1296 goto copy;
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1297 }
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1298
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1299 pgdp = pgt + pgd_index(gpa);
f97ba1f7bf6bd7 Mike Rapoport 2020-02-27 1300 p4dp = p4d_offset(pgdp, gpa);
f97ba1f7bf6bd7 Mike Rapoport 2020-02-27 1301 p4d = READ_ONCE(*p4dp);
f97ba1f7bf6bd7 Mike Rapoport 2020-02-27 1302 if (!(p4d_val(p4d) & _PAGE_PRESENT)) {
f97ba1f7bf6bd7 Mike Rapoport 2020-02-27 1303 gpa = (gpa & P4D_MASK) + P4D_SIZE;
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1304 continue;
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1305 }
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1306
f97ba1f7bf6bd7 Mike Rapoport 2020-02-27 1307 pudp = pud_offset(&p4d, gpa);
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1308 pud = READ_ONCE(*pudp);
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1309 if (!(pud_val(pud) & _PAGE_PRESENT)) {
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1310 gpa = (gpa & PUD_MASK) + PUD_SIZE;
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1311 continue;
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1312 }
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1313 if (pud_val(pud) & _PAGE_PTE) {
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1314 pte = pud_val(pud);
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1315 shift = PUD_SHIFT;
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1316 goto leaf;
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1317 }
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1318
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1319 pmdp = pmd_offset(&pud, gpa);
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1320 pmd = READ_ONCE(*pmdp);
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1321 if (!(pmd_val(pmd) & _PAGE_PRESENT)) {
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1322 gpa = (gpa & PMD_MASK) + PMD_SIZE;
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1323 continue;
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1324 }
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1325 if (pmd_val(pmd) & _PAGE_PTE) {
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1326 pte = pmd_val(pmd);
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1327 shift = PMD_SHIFT;
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1328 goto leaf;
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1329 }
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1330
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1331 ptep = pte_offset_kernel(&pmd, gpa);
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1332 pte = pte_val(READ_ONCE(*ptep));
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1333 if (!(pte & _PAGE_PRESENT)) {
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1334 gpa += PAGE_SIZE;
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1335 continue;
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1336 }
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1337 shift = PAGE_SHIFT;
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1338 leaf:
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1339 n = scnprintf(p->buf, sizeof(p->buf),
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1340 " %lx: %lx %d\n", gpa, pte, shift);
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1341 gpa += 1ul << shift;
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1342 copy:
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1343 p->chars_left = n;
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1344 if (n > len)
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1345 n = len;
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1346 r = copy_to_user(buf, p->buf, n);
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1347 n -= r;
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1348 p->chars_left -= n;
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1349 p->buf_index = n;
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1350 buf += n;
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1351 len -= n;
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1352 ret += n;
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1353 if (r) {
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1354 if (!ret)
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1355 ret = -EFAULT;
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1356 break;
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1357 }
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1358 }
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1359 p->gpa = gpa;
83a055104eaf89 Paul Mackerras 2018-10-08 1360 if (nested)
83a055104eaf89 Paul Mackerras 2018-10-08 1361 kvmhv_put_nested(nested);
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1362
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1363 out:
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1364 mutex_unlock(&p->mutex);
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1365 return ret;
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1366 }
9a94d3ee2d1599 Paul Mackerras 2018-10-08 1367
:::::: The code at line 1226 was first introduced by commit
:::::: 9a94d3ee2d159927c0f8e5078228eadbce8dda43 KVM: PPC: Book3S HV: Add a debugfs file to dump radix mappings
:::::: TO: Paul Mackerras <paulus(a)ozlabs.org>
:::::: CC: Michael Ellerman <mpe(a)ellerman.id.au>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 7 months
[mptcp:t/mptcp-Implement-path-manager-interface-commands 20/20] net/mptcp/pm.c:31:5: error: 'struct mptcp_sock' has no member named 'addr_signal'
by kbuild test robot
tree: https://github.com/multipath-tcp/mptcp_net-next.git t/mptcp-Implement-path-manager-interface-commands
head: 781d512532236fdeb2038457060aa4a470e01f7e
commit: 781d512532236fdeb2038457060aa4a470e01f7e [20/20] tgupdate: merge t/mptcp-Implement-path-manager-interface-commands base into t/mptcp-Implement-path-manager-interface-commands
config: c6x-allyesconfig (attached as .config)
compiler: c6x-elf-gcc (GCC) 7.5.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 781d512532236fdeb2038457060aa4a470e01f7e
# save the attached .config to linux build tree
GCC_VERSION=7.5.0 make.cross ARCH=c6x
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
net/mptcp/pm.c: In function 'mptcp_pm_announce_addr':
>> net/mptcp/pm.c:31:5: error: 'struct mptcp_sock' has no member named 'addr_signal'
msk->addr_signal = 1;
^~
net/mptcp/pm.c: In function 'mptcp_pm_announce_addr6':
net/mptcp/pm.c:57:5: error: 'struct mptcp_sock' has no member named 'addr_signal'
msk->addr_signal = 1;
^~
vim +31 net/mptcp/pm.c
532e0037f0c3af Peter Krystad 2020-02-26 12
532e0037f0c3af Peter Krystad 2020-02-26 13 int mptcp_pm_announce_addr(u32 token, u8 local_id, struct in_addr *addr)
532e0037f0c3af Peter Krystad 2020-02-26 14 {
4b738110d9bfa5 Peter Krystad 2020-02-26 15 struct mptcp_sock *msk = mptcp_token_get_sock(token);
4b738110d9bfa5 Peter Krystad 2020-02-26 16 int err = 0;
4b738110d9bfa5 Peter Krystad 2020-02-26 17
4b738110d9bfa5 Peter Krystad 2020-02-26 18 if (!msk)
4b738110d9bfa5 Peter Krystad 2020-02-26 19 return -EINVAL;
4b738110d9bfa5 Peter Krystad 2020-02-26 20
4b738110d9bfa5 Peter Krystad 2020-02-26 21 if (msk->pm.local_valid) {
4b738110d9bfa5 Peter Krystad 2020-02-26 22 err = -EBADR;
4b738110d9bfa5 Peter Krystad 2020-02-26 23 goto announce_put;
4b738110d9bfa5 Peter Krystad 2020-02-26 24 }
4b738110d9bfa5 Peter Krystad 2020-02-26 25
4b738110d9bfa5 Peter Krystad 2020-02-26 26 pr_debug("msk=%p, local_id=%d", msk, local_id);
4b738110d9bfa5 Peter Krystad 2020-02-26 27 msk->pm.local_valid = 1;
4b738110d9bfa5 Peter Krystad 2020-02-26 28 msk->pm.local_id = local_id;
4b738110d9bfa5 Peter Krystad 2020-02-26 29 msk->pm.local_family = AF_INET;
4b738110d9bfa5 Peter Krystad 2020-02-26 30 msk->pm.local_addr = *addr;
4b738110d9bfa5 Peter Krystad 2020-02-26 @31 msk->addr_signal = 1;
4b738110d9bfa5 Peter Krystad 2020-02-26 32
4b738110d9bfa5 Peter Krystad 2020-02-26 33 announce_put:
4b738110d9bfa5 Peter Krystad 2020-02-26 34 sock_put((struct sock *)msk);
4b738110d9bfa5 Peter Krystad 2020-02-26 35 return err;
532e0037f0c3af Peter Krystad 2020-02-26 36 }
532e0037f0c3af Peter Krystad 2020-02-26 37
:::::: The code at line 31 was first introduced by commit
:::::: 4b738110d9bfa5e1a763123e0ef6d0d2f5852782 mptcp: Implement path manager interface commands
:::::: TO: Peter Krystad <peter.krystad(a)linux.intel.com>
:::::: CC: Matthieu Baerts <matthieu.baerts(a)tessares.net>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 7 months