[peterz-queue:sched/core-sched 29/29] kernel/sched/core.c:9490:50: error: use of undeclared identifier 'GROUP_COOKIE'
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git sched/core-sched
head: 491d689ecb4f0997949741220d6f468bd3a682a4
commit: 491d689ecb4f0997949741220d6f468bd3a682a4 [29/29] sched: prctl() and cgroup interaction
config: mips-randconfig-r013-20210401 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 1c268a8ff4e90a85d0e634350b1104080614cf2b)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install mips cross compiling tool for clang build
# apt-get install binutils-mips-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git/commit/?...
git remote add peterz-queue https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git
git fetch --no-tags peterz-queue sched/core-sched
git checkout 491d689ecb4f0997949741220d6f468bd3a682a4
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=mips
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
kernel/sched/core.c:9396:35: error: passing 'struct task_group *' to parameter of incompatible type 'struct task_group'; dereference with *
sched_core_cgroup_online(parent, tg);
^~
*
kernel/sched/core.c:5731:90: note: passing argument to parameter 'tg' here
static inline void sched_core_cgroup_online(struct task_group *parent, struct task_group tg) { }
^
kernel/sched/core.c:9489:11: error: implicit declaration of function 'sched_core_cgroup_cookie' [-Werror,-Wimplicit-function-declaration]
cookie = sched_core_cgroup_cookie(tsk->sched_task_group);
^
kernel/sched/core.c:9489:11: note: did you mean 'sched_core_cgroup_online'?
kernel/sched/core.c:5731:20: note: 'sched_core_cgroup_online' declared here
static inline void sched_core_cgroup_online(struct task_group *parent, struct task_group tg) { }
^
kernel/sched/core.c:9490:11: error: implicit declaration of function 'sched_core_update_cookie' [-Werror,-Wimplicit-function-declaration]
cookie = sched_core_update_cookie(tsk, cookie | GROUP_COOKIE);
^
kernel/sched/core.c:9490:11: note: did you mean 'sched_core_cgroup_cookie'?
kernel/sched/core.c:9489:11: note: 'sched_core_cgroup_cookie' declared here
cookie = sched_core_cgroup_cookie(tsk->sched_task_group);
^
>> kernel/sched/core.c:9490:50: error: use of undeclared identifier 'GROUP_COOKIE'
cookie = sched_core_update_cookie(tsk, cookie | GROUP_COOKIE);
^
kernel/sched/core.c:9491:2: error: implicit declaration of function 'sched_core_put_cookie' [-Werror,-Wimplicit-function-declaration]
sched_core_put_cookie(cookie);
^
kernel/sched/core.c:9491:2: note: did you mean 'sched_core_update_cookie'?
kernel/sched/core.c:9490:11: note: 'sched_core_update_cookie' declared here
cookie = sched_core_update_cookie(tsk, cookie | GROUP_COOKIE);
^
5 errors generated.
vim +/GROUP_COOKIE +9490 kernel/sched/core.c
9446
9447 /*
9448 * Change task's runqueue when it moves between groups.
9449 *
9450 * The caller of this function should have put the task in its new group by
9451 * now. This function just updates tsk->se.cfs_rq and tsk->se.parent to reflect
9452 * its new group.
9453 */
9454 void sched_move_task(struct task_struct *tsk)
9455 {
9456 int queued, running, queue_flags =
9457 DEQUEUE_SAVE | DEQUEUE_MOVE | DEQUEUE_NOCLOCK;
9458 unsigned long cookie;
9459 struct rq_flags rf;
9460 struct rq *rq;
9461
9462 rq = task_rq_lock(tsk, &rf);
9463 update_rq_clock(rq);
9464
9465 running = task_current(rq, tsk);
9466 queued = task_on_rq_queued(tsk);
9467
9468 if (queued)
9469 dequeue_task(rq, tsk, queue_flags);
9470 if (running)
9471 put_prev_task(rq, tsk);
9472
9473 sched_change_group(tsk, TASK_MOVE_GROUP);
9474
9475 if (queued)
9476 enqueue_task(rq, tsk, queue_flags);
9477 if (running) {
9478 set_next_task(rq, tsk);
9479 /*
9480 * After changing group, the running task may have joined a
9481 * throttled one but it's still the running task. Trigger a
9482 * resched to make sure that task can still run.
9483 */
9484 resched_curr(rq);
9485 }
9486
9487 task_rq_unlock(rq, tsk, &rf);
9488
9489 cookie = sched_core_cgroup_cookie(tsk->sched_task_group);
> 9490 cookie = sched_core_update_cookie(tsk, cookie | GROUP_COOKIE);
9491 sched_core_put_cookie(cookie);
9492 }
9493
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 4 months
Re: [PATCH nf-next 1/2] netfilter: flowtable: add vlan match offload support
by kernel test robot
Hi,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on nf-next/master]
url: https://github.com/0day-ci/linux/commits/wenxu-ucloud-cn/netfilter-flowta...
base: https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git master
config: x86_64-randconfig-s021-20210401 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.3-279-g6d5d9b42-dirty
# https://github.com/0day-ci/linux/commit/346de57353f34fbf24607af6786266221...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review wenxu-ucloud-cn/netfilter-flowtable-add-vlan-match-offload-support/20210401-155259
git checkout 346de57353f34fbf24607af67862662212333f95
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
sparse warnings: (new ones prefixed by >>)
net/netfilter/nf_flow_table_offload.c:46:32: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __be32 [usertype] keyid @@ got unsigned int @@
net/netfilter/nf_flow_table_offload.c:46:32: sparse: expected restricted __be32 [usertype] keyid
net/netfilter/nf_flow_table_offload.c:46:32: sparse: got unsigned int
net/netfilter/nf_flow_table_offload.c:56:44: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __be32 [usertype] src @@ got unsigned int @@
net/netfilter/nf_flow_table_offload.c:56:44: sparse: expected restricted __be32 [usertype] src
net/netfilter/nf_flow_table_offload.c:56:44: sparse: got unsigned int
net/netfilter/nf_flow_table_offload.c:58:44: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __be32 [usertype] dst @@ got unsigned int @@
net/netfilter/nf_flow_table_offload.c:58:44: sparse: expected restricted __be32 [usertype] dst
net/netfilter/nf_flow_table_offload.c:58:44: sparse: got unsigned int
>> net/netfilter/nf_flow_table_offload.c:90:25: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __be16 [usertype] vlan_tpid @@ got int @@
net/netfilter/nf_flow_table_offload.c:90:25: sparse: expected restricted __be16 [usertype] vlan_tpid
net/netfilter/nf_flow_table_offload.c:90:25: sparse: got int
net/netfilter/nf_flow_table_offload.c:123:32: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __be32 [usertype] src @@ got unsigned int @@
net/netfilter/nf_flow_table_offload.c:123:32: sparse: expected restricted __be32 [usertype] src
net/netfilter/nf_flow_table_offload.c:123:32: sparse: got unsigned int
net/netfilter/nf_flow_table_offload.c:125:32: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __be32 [usertype] dst @@ got unsigned int @@
net/netfilter/nf_flow_table_offload.c:125:32: sparse: expected restricted __be32 [usertype] dst
net/netfilter/nf_flow_table_offload.c:125:32: sparse: got unsigned int
net/netfilter/nf_flow_table_offload.c:140:29: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __be16 [usertype] n_proto @@ got int @@
net/netfilter/nf_flow_table_offload.c:140:29: sparse: expected restricted __be16 [usertype] n_proto
net/netfilter/nf_flow_table_offload.c:140:29: sparse: got int
net/netfilter/nf_flow_table_offload.c:184:22: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __be16 [usertype] src @@ got int @@
net/netfilter/nf_flow_table_offload.c:184:22: sparse: expected restricted __be16 [usertype] src
net/netfilter/nf_flow_table_offload.c:184:22: sparse: got int
net/netfilter/nf_flow_table_offload.c:186:22: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __be16 [usertype] dst @@ got int @@
net/netfilter/nf_flow_table_offload.c:186:22: sparse: expected restricted __be16 [usertype] dst
net/netfilter/nf_flow_table_offload.c:186:22: sparse: got int
net/netfilter/nf_flow_table_offload.c:249:30: sparse: sparse: incorrect type in argument 4 (different base types) @@ expected restricted __be32 const [usertype] *value @@ got unsigned int * @@
net/netfilter/nf_flow_table_offload.c:249:30: sparse: expected restricted __be32 const [usertype] *value
net/netfilter/nf_flow_table_offload.c:249:30: sparse: got unsigned int *
net/netfilter/nf_flow_table_offload.c:249:36: sparse: sparse: incorrect type in argument 5 (different base types) @@ expected restricted __be32 const [usertype] *mask @@ got unsigned int * @@
net/netfilter/nf_flow_table_offload.c:249:36: sparse: expected restricted __be32 const [usertype] *mask
net/netfilter/nf_flow_table_offload.c:249:36: sparse: got unsigned int *
net/netfilter/nf_flow_table_offload.c:254:30: sparse: sparse: incorrect type in argument 4 (different base types) @@ expected restricted __be32 const [usertype] *value @@ got unsigned int * @@
net/netfilter/nf_flow_table_offload.c:254:30: sparse: expected restricted __be32 const [usertype] *value
net/netfilter/nf_flow_table_offload.c:254:30: sparse: got unsigned int *
net/netfilter/nf_flow_table_offload.c:254:36: sparse: sparse: incorrect type in argument 5 (different base types) @@ expected restricted __be32 const [usertype] *mask @@ got unsigned int * @@
net/netfilter/nf_flow_table_offload.c:254:36: sparse: expected restricted __be32 const [usertype] *mask
net/netfilter/nf_flow_table_offload.c:254:36: sparse: got unsigned int *
net/netfilter/nf_flow_table_offload.c:308:30: sparse: sparse: incorrect type in argument 4 (different base types) @@ expected restricted __be32 const [usertype] *value @@ got unsigned int * @@
net/netfilter/nf_flow_table_offload.c:308:30: sparse: expected restricted __be32 const [usertype] *value
net/netfilter/nf_flow_table_offload.c:308:30: sparse: got unsigned int *
net/netfilter/nf_flow_table_offload.c:308:36: sparse: sparse: incorrect type in argument 5 (different base types) @@ expected restricted __be32 const [usertype] *mask @@ got unsigned int * @@
net/netfilter/nf_flow_table_offload.c:308:36: sparse: expected restricted __be32 const [usertype] *mask
net/netfilter/nf_flow_table_offload.c:308:36: sparse: got unsigned int *
net/netfilter/nf_flow_table_offload.c:314:30: sparse: sparse: incorrect type in argument 4 (different base types) @@ expected restricted __be32 const [usertype] *value @@ got unsigned int * @@
net/netfilter/nf_flow_table_offload.c:314:30: sparse: expected restricted __be32 const [usertype] *value
net/netfilter/nf_flow_table_offload.c:314:30: sparse: got unsigned int *
net/netfilter/nf_flow_table_offload.c:314:36: sparse: sparse: incorrect type in argument 5 (different base types) @@ expected restricted __be32 const [usertype] *mask @@ got unsigned int * @@
net/netfilter/nf_flow_table_offload.c:314:36: sparse: expected restricted __be32 const [usertype] *mask
net/netfilter/nf_flow_table_offload.c:314:36: sparse: got unsigned int *
net/netfilter/nf_flow_table_offload.c:325:20: sparse: sparse: incorrect type in initializer (different base types) @@ expected unsigned int [usertype] mask @@ got restricted __be32 @@
net/netfilter/nf_flow_table_offload.c:325:20: sparse: expected unsigned int [usertype] mask
net/netfilter/nf_flow_table_offload.c:325:20: sparse: got restricted __be32
net/netfilter/nf_flow_table_offload.c:343:37: sparse: sparse: incorrect type in argument 5 (different base types) @@ expected restricted __be32 const [usertype] *mask @@ got unsigned int * @@
net/netfilter/nf_flow_table_offload.c:343:37: sparse: expected restricted __be32 const [usertype] *mask
net/netfilter/nf_flow_table_offload.c:343:37: sparse: got unsigned int *
net/netfilter/nf_flow_table_offload.c:352:20: sparse: sparse: incorrect type in initializer (different base types) @@ expected unsigned int [usertype] mask @@ got restricted __be32 @@
net/netfilter/nf_flow_table_offload.c:352:20: sparse: expected unsigned int [usertype] mask
net/netfilter/nf_flow_table_offload.c:352:20: sparse: got restricted __be32
net/netfilter/nf_flow_table_offload.c:370:37: sparse: sparse: incorrect type in argument 5 (different base types) @@ expected restricted __be32 const [usertype] *mask @@ got unsigned int * @@
net/netfilter/nf_flow_table_offload.c:370:37: sparse: expected restricted __be32 const [usertype] *mask
net/netfilter/nf_flow_table_offload.c:370:37: sparse: got unsigned int *
net/netfilter/nf_flow_table_offload.c:392:20: sparse: sparse: incorrect type in initializer (different base types) @@ expected unsigned int [usertype] mask @@ got restricted __be32 @@
net/netfilter/nf_flow_table_offload.c:392:20: sparse: expected unsigned int [usertype] mask
net/netfilter/nf_flow_table_offload.c:392:20: sparse: got restricted __be32
net/netfilter/nf_flow_table_offload.c:409:60: sparse: sparse: incorrect type in argument 4 (different base types) @@ expected restricted __be32 const [usertype] *mask @@ got unsigned int * @@
net/netfilter/nf_flow_table_offload.c:409:60: sparse: expected restricted __be32 const [usertype] *mask
net/netfilter/nf_flow_table_offload.c:409:60: sparse: got unsigned int *
net/netfilter/nf_flow_table_offload.c:417:20: sparse: sparse: incorrect type in initializer (different base types) @@ expected unsigned int [usertype] mask @@ got restricted __be32 @@
net/netfilter/nf_flow_table_offload.c:417:20: sparse: expected unsigned int [usertype] mask
net/netfilter/nf_flow_table_offload.c:417:20: sparse: got restricted __be32
net/netfilter/nf_flow_table_offload.c:434:60: sparse: sparse: incorrect type in argument 4 (different base types) @@ expected restricted __be32 const [usertype] *mask @@ got unsigned int * @@
net/netfilter/nf_flow_table_offload.c:434:60: sparse: expected restricted __be32 const [usertype] *mask
net/netfilter/nf_flow_table_offload.c:434:60: sparse: got unsigned int *
net/netfilter/nf_flow_table_offload.c:469:22: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [assigned] [usertype] port @@ got restricted __be32 [usertype] @@
net/netfilter/nf_flow_table_offload.c:469:22: sparse: expected unsigned int [assigned] [usertype] port
net/netfilter/nf_flow_table_offload.c:469:22: sparse: got restricted __be32 [usertype]
net/netfilter/nf_flow_table_offload.c:470:22: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] mask @@ got restricted __be32 @@
net/netfilter/nf_flow_table_offload.c:470:22: sparse: expected unsigned int [usertype] mask
net/netfilter/nf_flow_table_offload.c:470:22: sparse: got restricted __be32
net/netfilter/nf_flow_table_offload.c:475:22: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [assigned] [usertype] port @@ got restricted __be32 [usertype] @@
net/netfilter/nf_flow_table_offload.c:475:22: sparse: expected unsigned int [assigned] [usertype] port
net/netfilter/nf_flow_table_offload.c:475:22: sparse: got restricted __be32 [usertype]
net/netfilter/nf_flow_table_offload.c:476:22: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] mask @@ got restricted __be32 @@
net/netfilter/nf_flow_table_offload.c:476:22: sparse: expected unsigned int [usertype] mask
net/netfilter/nf_flow_table_offload.c:476:22: sparse: got restricted __be32
net/netfilter/nf_flow_table_offload.c:483:30: sparse: sparse: incorrect type in argument 4 (different base types) @@ expected restricted __be32 const [usertype] *value @@ got unsigned int * @@
net/netfilter/nf_flow_table_offload.c:483:30: sparse: expected restricted __be32 const [usertype] *value
net/netfilter/nf_flow_table_offload.c:483:30: sparse: got unsigned int *
net/netfilter/nf_flow_table_offload.c:483:37: sparse: sparse: incorrect type in argument 5 (different base types) @@ expected restricted __be32 const [usertype] *mask @@ got unsigned int * @@
net/netfilter/nf_flow_table_offload.c:483:37: sparse: expected restricted __be32 const [usertype] *mask
net/netfilter/nf_flow_table_offload.c:483:37: sparse: got unsigned int *
net/netfilter/nf_flow_table_offload.c:499:22: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [assigned] [usertype] port @@ got restricted __be32 [usertype] @@
net/netfilter/nf_flow_table_offload.c:499:22: sparse: expected unsigned int [assigned] [usertype] port
net/netfilter/nf_flow_table_offload.c:499:22: sparse: got restricted __be32 [usertype]
net/netfilter/nf_flow_table_offload.c:500:22: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] mask @@ got restricted __be32 @@
net/netfilter/nf_flow_table_offload.c:500:22: sparse: expected unsigned int [usertype] mask
net/netfilter/nf_flow_table_offload.c:500:22: sparse: got restricted __be32
net/netfilter/nf_flow_table_offload.c:505:22: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [assigned] [usertype] port @@ got restricted __be32 [usertype] @@
net/netfilter/nf_flow_table_offload.c:505:22: sparse: expected unsigned int [assigned] [usertype] port
net/netfilter/nf_flow_table_offload.c:505:22: sparse: got restricted __be32 [usertype]
net/netfilter/nf_flow_table_offload.c:506:22: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] mask @@ got restricted __be32 @@
net/netfilter/nf_flow_table_offload.c:506:22: sparse: expected unsigned int [usertype] mask
net/netfilter/nf_flow_table_offload.c:506:22: sparse: got restricted __be32
net/netfilter/nf_flow_table_offload.c:513:30: sparse: sparse: incorrect type in argument 4 (different base types) @@ expected restricted __be32 const [usertype] *value @@ got unsigned int * @@
net/netfilter/nf_flow_table_offload.c:513:30: sparse: expected restricted __be32 const [usertype] *value
net/netfilter/nf_flow_table_offload.c:513:30: sparse: got unsigned int *
net/netfilter/nf_flow_table_offload.c:513:37: sparse: sparse: incorrect type in argument 5 (different base types) @@ expected restricted __be32 const [usertype] *mask @@ got unsigned int * @@
net/netfilter/nf_flow_table_offload.c:513:37: sparse: expected restricted __be32 const [usertype] *mask
vim +90 net/netfilter/nf_flow_table_offload.c
80
81 static void nf_flow_rule_vlan_match(struct flow_dissector_key_vlan *key,
82 struct flow_dissector_key_vlan *mask,
83 u16 vlan_id, __be16 n_proto)
84 {
85 key->vlan_id = vlan_id & VLAN_VID_MASK;
86 mask->vlan_id = VLAN_VID_MASK;
87 key->vlan_priority = (vlan_id & VLAN_PRIO_MASK) >> VLAN_PRIO_SHIFT;
88 mask->vlan_priority = 0x7;
89 key->vlan_tpid = n_proto;
> 90 mask->vlan_tpid = 0xffff;
91 }
92
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 4 months
[linux-next:master 8404/9190] drivers/phy/cadence/phy-cadence-sierra.c:500 cdns_sierra_pll_mux_register() warn: passing zero to 'PTR_ERR'
by Dan Carpenter
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 454c576c3f5e51d60f00a4ac0dde07f4f9d70e9d
commit: 28081b72859f0fa3d5b56cfd84b2f5ba578765d2 [8404/9190] phy: cadence: Sierra: Model PLL_CMNLC and PLL_CMNLC1 as clocks (mux clocks)
config: i386-randconfig-m021-20210401 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com>
smatch warnings:
drivers/phy/cadence/phy-cadence-sierra.c:500 cdns_sierra_pll_mux_register() warn: passing zero to 'PTR_ERR'
vim +/PTR_ERR +500 drivers/phy/cadence/phy-cadence-sierra.c
28081b72859f0f Kishon Vijay Abraham I 2021-03-19 472 static int cdns_sierra_pll_mux_register(struct cdns_sierra_phy *sp,
28081b72859f0f Kishon Vijay Abraham I 2021-03-19 473 struct regmap_field *pfdclk1_sel_field,
28081b72859f0f Kishon Vijay Abraham I 2021-03-19 474 struct regmap_field *plllc1en_field,
28081b72859f0f Kishon Vijay Abraham I 2021-03-19 475 struct regmap_field *termen_field,
28081b72859f0f Kishon Vijay Abraham I 2021-03-19 476 int clk_index)
28081b72859f0f Kishon Vijay Abraham I 2021-03-19 477 {
28081b72859f0f Kishon Vijay Abraham I 2021-03-19 478 struct cdns_sierra_pll_mux *mux;
28081b72859f0f Kishon Vijay Abraham I 2021-03-19 479 struct device *dev = sp->dev;
28081b72859f0f Kishon Vijay Abraham I 2021-03-19 480 struct clk_init_data *init;
28081b72859f0f Kishon Vijay Abraham I 2021-03-19 481 const char **parent_names;
28081b72859f0f Kishon Vijay Abraham I 2021-03-19 482 unsigned int num_parents;
28081b72859f0f Kishon Vijay Abraham I 2021-03-19 483 char clk_name[100];
28081b72859f0f Kishon Vijay Abraham I 2021-03-19 484 struct clk *clk;
28081b72859f0f Kishon Vijay Abraham I 2021-03-19 485 int i;
28081b72859f0f Kishon Vijay Abraham I 2021-03-19 486
28081b72859f0f Kishon Vijay Abraham I 2021-03-19 487 mux = devm_kzalloc(dev, sizeof(*mux), GFP_KERNEL);
28081b72859f0f Kishon Vijay Abraham I 2021-03-19 488 if (!mux)
28081b72859f0f Kishon Vijay Abraham I 2021-03-19 489 return -ENOMEM;
28081b72859f0f Kishon Vijay Abraham I 2021-03-19 490
28081b72859f0f Kishon Vijay Abraham I 2021-03-19 491 num_parents = SIERRA_NUM_CMN_PLLC_PARENTS;
28081b72859f0f Kishon Vijay Abraham I 2021-03-19 492 parent_names = devm_kzalloc(dev, (sizeof(char *) * num_parents), GFP_KERNEL);
28081b72859f0f Kishon Vijay Abraham I 2021-03-19 493 if (!parent_names)
28081b72859f0f Kishon Vijay Abraham I 2021-03-19 494 return -ENOMEM;
28081b72859f0f Kishon Vijay Abraham I 2021-03-19 495
28081b72859f0f Kishon Vijay Abraham I 2021-03-19 496 for (i = 0; i < num_parents; i++) {
28081b72859f0f Kishon Vijay Abraham I 2021-03-19 497 clk = sp->input_clks[pll_mux_parent_index[clk_index][i]];
28081b72859f0f Kishon Vijay Abraham I 2021-03-19 498 if (IS_ERR_OR_NULL(clk)) {
^^^^^^^^^^^^^^^^^^^
28081b72859f0f Kishon Vijay Abraham I 2021-03-19 499 dev_err(dev, "No parent clock for derived_refclk\n");
28081b72859f0f Kishon Vijay Abraham I 2021-03-19 @500 return PTR_ERR(clk);
^^^^^^^^^^^^
Can "clk" really be NULL, and if it is then do we really want to return
PTR_ERR(NULL) (which is zero/success)?
28081b72859f0f Kishon Vijay Abraham I 2021-03-19 501 }
28081b72859f0f Kishon Vijay Abraham I 2021-03-19 502 parent_names[i] = __clk_get_name(clk);
28081b72859f0f Kishon Vijay Abraham I 2021-03-19 503 }
28081b72859f0f Kishon Vijay Abraham I 2021-03-19 504
28081b72859f0f Kishon Vijay Abraham I 2021-03-19 505 snprintf(clk_name, sizeof(clk_name), "%s_%s", dev_name(dev), clk_names[clk_index]);
28081b72859f0f Kishon Vijay Abraham I 2021-03-19 506
28081b72859f0f Kishon Vijay Abraham I 2021-03-19 507 init = &mux->clk_data;
28081b72859f0f Kishon Vijay Abraham I 2021-03-19 508
28081b72859f0f Kishon Vijay Abraham I 2021-03-19 509 init->ops = &cdns_sierra_pll_mux_ops;
28081b72859f0f Kishon Vijay Abraham I 2021-03-19 510 init->flags = CLK_SET_RATE_NO_REPARENT;
28081b72859f0f Kishon Vijay Abraham I 2021-03-19 511 init->parent_names = parent_names;
28081b72859f0f Kishon Vijay Abraham I 2021-03-19 512 init->num_parents = num_parents;
28081b72859f0f Kishon Vijay Abraham I 2021-03-19 513 init->name = clk_name;
28081b72859f0f Kishon Vijay Abraham I 2021-03-19 514
28081b72859f0f Kishon Vijay Abraham I 2021-03-19 515 mux->pfdclk_sel_preg = pfdclk1_sel_field;
28081b72859f0f Kishon Vijay Abraham I 2021-03-19 516 mux->plllc1en_field = plllc1en_field;
28081b72859f0f Kishon Vijay Abraham I 2021-03-19 517 mux->termen_field = termen_field;
28081b72859f0f Kishon Vijay Abraham I 2021-03-19 518 mux->hw.init = init;
28081b72859f0f Kishon Vijay Abraham I 2021-03-19 519
28081b72859f0f Kishon Vijay Abraham I 2021-03-19 520 clk = devm_clk_register(dev, &mux->hw);
28081b72859f0f Kishon Vijay Abraham I 2021-03-19 521 if (IS_ERR(clk))
28081b72859f0f Kishon Vijay Abraham I 2021-03-19 522 return PTR_ERR(clk);
28081b72859f0f Kishon Vijay Abraham I 2021-03-19 523
28081b72859f0f Kishon Vijay Abraham I 2021-03-19 524 sp->output_clks[clk_index] = clk;
28081b72859f0f Kishon Vijay Abraham I 2021-03-19 525
28081b72859f0f Kishon Vijay Abraham I 2021-03-19 526 return 0;
28081b72859f0f Kishon Vijay Abraham I 2021-03-19 527 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 4 months
Re: [PATCH 09/34] drm/amdkfd: map svm range to GPUs
by kernel test robot
Hi Felix,
I love your patch! Perhaps something to improve:
[auto build test WARNING on next-20210331]
[cannot apply to drm-intel/for-linux-next drm-tip/drm-tip drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next linus/master drm/drm-next v5.12-rc5 v5.12-rc4 v5.12-rc3 v5.12-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Felix-Kuehling/Add-HMM-based-SVM...
base: 7a43c78d0573e0bbbb0456b033e2b9a895b89464
config: x86_64-randconfig-a011-20210401 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/bb9c90022dd6afd456d4b40a20d007e57...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Felix-Kuehling/Add-HMM-based-SVM-memory-manager-to-KFD-v3/20210401-122712
git checkout bb9c90022dd6afd456d4b40a20d007e57efc35ed
# save the attached .config to linux build tree
make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_svm.c:167:6: warning: no previous prototype for 'svm_range_dma_unmap' [-Wmissing-prototypes]
167 | void svm_range_dma_unmap(struct device *dev, dma_addr_t *dma_addr,
| ^~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_svm.c:599:6: warning: no previous prototype for 'svm_range_add_child' [-Wmissing-prototypes]
599 | void svm_range_add_child(struct svm_range *prange, struct mm_struct *mm,
| ^~~~~~~~~~~~~~~~~~~
>> drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_svm.c:795:5: warning: no previous prototype for 'svm_range_reserve_bos' [-Wmissing-prototypes]
795 | int svm_range_reserve_bos(struct svm_validate_context *ctx)
| ^~~~~~~~~~~~~~~~~~~~~
>> drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_svm.c:849:6: warning: no previous prototype for 'svm_range_unreserve_bos' [-Wmissing-prototypes]
849 | void svm_range_unreserve_bos(struct svm_validate_context *ctx)
| ^~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_svm.c:967:19: warning: no previous prototype for 'svm_range_clone' [-Wmissing-prototypes]
967 | struct svm_range *svm_range_clone(struct svm_range *old)
| ^~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_svm.c:1222:1: warning: no previous prototype for 'svm_range_add_list_work' [-Wmissing-prototypes]
1222 | svm_range_add_list_work(struct svm_range_list *svms, struct svm_range *prange,
| ^~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_svm.c:1244:6: warning: no previous prototype for 'schedule_deferred_list_work' [-Wmissing-prototypes]
1244 | void schedule_deferred_list_work(struct svm_range_list *svms)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/svm_range_reserve_bos +795 drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_svm.c
794
> 795 int svm_range_reserve_bos(struct svm_validate_context *ctx)
796 {
797 struct kfd_process_device *pdd;
798 struct amdgpu_device *adev;
799 struct amdgpu_vm *vm;
800 uint32_t gpuidx;
801 int r;
802
803 INIT_LIST_HEAD(&ctx->validate_list);
804 for_each_set_bit(gpuidx, ctx->bitmap, MAX_GPU_INSTANCE) {
805 pdd = kfd_process_device_from_gpuidx(ctx->process, gpuidx);
806 if (!pdd) {
807 pr_debug("failed to find device idx %d\n", gpuidx);
808 return -EINVAL;
809 }
810 adev = (struct amdgpu_device *)pdd->dev->kgd;
811 vm = pdd->vm;
812
813 ctx->tv[gpuidx].bo = &vm->root.base.bo->tbo;
814 ctx->tv[gpuidx].num_shared = 4;
815 list_add(&ctx->tv[gpuidx].head, &ctx->validate_list);
816 }
817
818 r = ttm_eu_reserve_buffers(&ctx->ticket, &ctx->validate_list,
819 ctx->intr, NULL);
820 if (r) {
821 pr_debug("failed %d to reserve bo\n", r);
822 return r;
823 }
824
825 for_each_set_bit(gpuidx, ctx->bitmap, MAX_GPU_INSTANCE) {
826 pdd = kfd_process_device_from_gpuidx(ctx->process, gpuidx);
827 if (!pdd) {
828 pr_debug("failed to find device idx %d\n", gpuidx);
829 r = -EINVAL;
830 goto unreserve_out;
831 }
832 adev = (struct amdgpu_device *)pdd->dev->kgd;
833
834 r = amdgpu_vm_validate_pt_bos(adev, pdd->vm,
835 svm_range_bo_validate, NULL);
836 if (r) {
837 pr_debug("failed %d validate pt bos\n", r);
838 goto unreserve_out;
839 }
840 }
841
842 return 0;
843
844 unreserve_out:
845 ttm_eu_backoff_reservation(&ctx->ticket, &ctx->validate_list);
846 return r;
847 }
848
> 849 void svm_range_unreserve_bos(struct svm_validate_context *ctx)
850 {
851 ttm_eu_backoff_reservation(&ctx->ticket, &ctx->validate_list);
852 }
853
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 4 months
[xlnx:xlnx_rebase_v5.4 1296/1701] drivers/usb/dwc3/core.h:1462: multiple definition of `dwc3_simple_wakeup_capable'; drivers/usb/dwc3/core.o:drivers/usb/dwc3/core.h:1462: first defined here
by kernel test robot
Hi Vishal,
FYI, the error/warning still remains.
tree: https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.4
head: 8540825db3d5519ef205a710515b7819b95eeb4f
commit: 0b197959bbbdb68e1da974bd013339f08704b178 [1296/1701] staging: xlnxsync: Fix the uapi header license
config: i386-randconfig-a013-20210401 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/Xilinx/linux-xlnx/commit/0b197959bbbdb68e1da974bd01333...
git remote add xlnx https://github.com/Xilinx/linux-xlnx
git fetch --no-tags xlnx xlnx_rebase_v5.4
git checkout 0b197959bbbdb68e1da974bd013339f08704b178
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
ld: drivers/usb/dwc3/trace.o: in function `dwc3_simple_wakeup_capable':
>> drivers/usb/dwc3/core.h:1462: multiple definition of `dwc3_simple_wakeup_capable'; drivers/usb/dwc3/core.o:drivers/usb/dwc3/core.h:1462: first defined here
ld: drivers/usb/dwc3/trace.o: in function `dwc3_set_simple_data':
>> drivers/usb/dwc3/core.h:1464: multiple definition of `dwc3_set_simple_data'; drivers/usb/dwc3/core.o:drivers/usb/dwc3/core.h:1464: first defined here
ld: drivers/usb/dwc3/trace.o: in function `dwc3_simple_check_quirks':
>> drivers/usb/dwc3/core.h:1464: multiple definition of `dwc3_simple_check_quirks'; drivers/usb/dwc3/core.o:drivers/usb/dwc3/core.h:1464: first defined here
ld: drivers/usb/dwc3/trace.o: in function `dwc3_set_usb_core_power':
>> drivers/usb/dwc3/core.h:1468: multiple definition of `dwc3_set_usb_core_power'; drivers/usb/dwc3/core.o:drivers/usb/dwc3/core.h:1468: first defined here
ld: drivers/usb/dwc3/trace.o: in function `dwc3_mask_phy_reset':
>> drivers/usb/dwc3/core.h:1468: multiple definition of `dwc3_mask_phy_reset'; drivers/usb/dwc3/core.o:drivers/usb/dwc3/core.h:1468: first defined here
ld: drivers/usb/dwc3/host.o: in function `dwc3_simple_wakeup_capable':
drivers/usb/dwc3/host.c:19: multiple definition of `dwc3_simple_wakeup_capable'; drivers/usb/dwc3/core.o:drivers/usb/dwc3/core.h:1462: first defined here
ld: drivers/usb/dwc3/host.o: in function `dwc3_set_simple_data':
>> drivers/usb/dwc3/core.h:1464: multiple definition of `dwc3_set_simple_data'; drivers/usb/dwc3/core.o:drivers/usb/dwc3/core.h:1464: first defined here
ld: drivers/usb/dwc3/host.o: in function `dwc3_simple_check_quirks':
>> drivers/usb/dwc3/core.h:1464: multiple definition of `dwc3_simple_check_quirks'; drivers/usb/dwc3/core.o:drivers/usb/dwc3/core.h:1464: first defined here
ld: drivers/usb/dwc3/host.o: in function `dwc3_set_usb_core_power':
>> drivers/usb/dwc3/core.h:1468: multiple definition of `dwc3_set_usb_core_power'; drivers/usb/dwc3/core.o:drivers/usb/dwc3/core.h:1468: first defined here
ld: drivers/usb/dwc3/host.o: in function `dwc3_mask_phy_reset':
>> drivers/usb/dwc3/core.h:1468: multiple definition of `dwc3_mask_phy_reset'; drivers/usb/dwc3/core.o:drivers/usb/dwc3/core.h:1468: first defined here
ld: drivers/usb/dwc3/debugfs.o: in function `dwc3_simple_wakeup_capable':
>> drivers/usb/dwc3/core.h:1462: multiple definition of `dwc3_simple_wakeup_capable'; drivers/usb/dwc3/core.o:drivers/usb/dwc3/core.h:1462: first defined here
ld: drivers/usb/dwc3/debugfs.o: in function `dwc3_set_simple_data':
>> drivers/usb/dwc3/core.h:1464: multiple definition of `dwc3_set_simple_data'; drivers/usb/dwc3/core.o:drivers/usb/dwc3/core.h:1464: first defined here
ld: drivers/usb/dwc3/debugfs.o: in function `dwc3_simple_check_quirks':
>> drivers/usb/dwc3/core.h:1464: multiple definition of `dwc3_simple_check_quirks'; drivers/usb/dwc3/core.o:drivers/usb/dwc3/core.h:1464: first defined here
ld: drivers/usb/dwc3/debugfs.o: in function `dwc3_set_usb_core_power':
>> drivers/usb/dwc3/core.h:1468: multiple definition of `dwc3_set_usb_core_power'; drivers/usb/dwc3/core.o:drivers/usb/dwc3/core.h:1468: first defined here
ld: drivers/usb/dwc3/debugfs.o: in function `dwc3_mask_phy_reset':
>> drivers/usb/dwc3/core.h:1468: multiple definition of `dwc3_mask_phy_reset'; drivers/usb/dwc3/core.o:drivers/usb/dwc3/core.h:1468: first defined here
vim +1462 drivers/usb/dwc3/core.h
c4137a9c841ec7 John Youn 2016-02-05 1450
6d0468b837bc2b Michal Simek 2020-03-16 1451 #if IS_ENABLED(CONFIG_USB_DWC3_OF_SIMPLE)
8110b9b0dcabf1 Michal Simek 2020-03-16 1452 int dwc3_enable_hw_coherency(struct device *dev);
6d0468b837bc2b Michal Simek 2020-03-16 1453 void dwc3_simple_wakeup_capable(struct device *dev, bool wakeup);
3d600fd776cbda Michal Simek 2020-03-16 1454 void dwc3_set_simple_data(struct dwc3 *dwc);
782658c51bbcd8 Piyush Mehta 2020-01-23 1455 void dwc3_simple_check_quirks(struct dwc3 *dwc);
68a922ded3cde2 Piyush Mehta 2020-01-23 1456 int dwc3_set_usb_core_power(struct dwc3 *dwc, bool on);
128feece434d1c Piyush Mehta 2020-01-23 1457 void dwc3_mask_phy_reset(struct device *dev, bool mask);
6d0468b837bc2b Michal Simek 2020-03-16 1458 #else
8110b9b0dcabf1 Michal Simek 2020-03-16 1459 static inline int dwc3_enable_hw_coherency(struct device *dev)
8110b9b0dcabf1 Michal Simek 2020-03-16 1460 { return 1; }
6d0468b837bc2b Michal Simek 2020-03-16 1461 void dwc3_simple_wakeup_capable(struct device *dev, bool wakeup)
6d0468b837bc2b Michal Simek 2020-03-16 @1462 { ; }
3d600fd776cbda Michal Simek 2020-03-16 1463 void dwc3_set_simple_data(struct dwc3 *dwc)
3d600fd776cbda Michal Simek 2020-03-16 @1464 { ; }
782658c51bbcd8 Piyush Mehta 2020-01-23 1465 void dwc3_simple_check_quirks(struct dwc3 *dwc)
782658c51bbcd8 Piyush Mehta 2020-01-23 1466 { ; }
68a922ded3cde2 Piyush Mehta 2020-01-23 1467 int dwc3_set_usb_core_power(struct dwc3 *dwc, bool on)
68a922ded3cde2 Piyush Mehta 2020-01-23 @1468 { ; }
128feece434d1c Piyush Mehta 2020-01-23 1469 void dwc3_mask_phy_reset(struct device *dev, bool mask)
128feece434d1c Piyush Mehta 2020-01-23 1470 { ; }
6d0468b837bc2b Michal Simek 2020-03-16 1471 #endif
6d0468b837bc2b Michal Simek 2020-03-16 1472
:::::: The code at line 1462 was first introduced by commit
:::::: 6d0468b837bc2b3cce625f59904d137e63637b5d usb: dwc3: Add support for clock disabling during suspend
:::::: TO: Michal Simek <michal.simek(a)xilinx.com>
:::::: CC: Michal Simek <michal.simek(a)xilinx.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 4 months
Re: [RFC 1/2] KVM:PPC: Add new hcall to provide hint if a vcpu task will be scheduled instantly.
by kernel test robot
Hi Parth,
[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on tip/sched/core]
[also build test ERROR on powerpc/next kvm/queue v5.12-rc5 next-20210401]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Parth-Shah/Define-a-new-apporach...
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 0a2b65c03e9b47493e1442bf9c84badc60d9bffb
config: i386-tinyconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/1f6313245d9d724b76ea1d47c94b165c0...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Parth-Shah/Define-a-new-apporach-to-determine-if-an-idle-vCPU-will-be-scheduled-instantly-or-not/20210401-200216
git checkout 1f6313245d9d724b76ea1d47c94b165c07fa9541
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
kernel/sched/fair.c:5393:6: warning: no previous prototype for 'init_cfs_bandwidth' [-Wmissing-prototypes]
5393 | void init_cfs_bandwidth(struct cfs_bandwidth *cfs_b) {}
| ^~~~~~~~~~~~~~~~~~
kernel/sched/fair.c: In function 'get_idle_hint_fair':
>> kernel/sched/fair.c:7257:38: error: implicit declaration of function 'sched_idle_cpu'; did you mean 'sched_idle_rq'? [-Werror=implicit-function-declaration]
7257 | if (available_idle_cpu(prev_cpu) || sched_idle_cpu(prev_cpu))
| ^~~~~~~~~~~~~~
| sched_idle_rq
kernel/sched/fair.c: At top level:
kernel/sched/fair.c:11211:6: warning: no previous prototype for 'free_fair_sched_group' [-Wmissing-prototypes]
11211 | void free_fair_sched_group(struct task_group *tg) { }
| ^~~~~~~~~~~~~~~~~~~~~
kernel/sched/fair.c:11213:5: warning: no previous prototype for 'alloc_fair_sched_group' [-Wmissing-prototypes]
11213 | int alloc_fair_sched_group(struct task_group *tg, struct task_group *parent)
| ^~~~~~~~~~~~~~~~~~~~~~
kernel/sched/fair.c:11218:6: warning: no previous prototype for 'online_fair_sched_group' [-Wmissing-prototypes]
11218 | void online_fair_sched_group(struct task_group *tg) { }
| ^~~~~~~~~~~~~~~~~~~~~~~
kernel/sched/fair.c:11220:6: warning: no previous prototype for 'unregister_fair_sched_group' [-Wmissing-prototypes]
11220 | void unregister_fair_sched_group(struct task_group *tg) { }
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +7257 kernel/sched/fair.c
7252
7253 static unsigned long get_idle_hint_fair(struct task_struct *p)
7254 {
7255 unsigned int prev_cpu = task_cpu(p);
7256
> 7257 if (available_idle_cpu(prev_cpu) || sched_idle_cpu(prev_cpu))
7258 return 1;
7259
7260 return 0;
7261 }
7262
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 4 months
[xlnx:xlnx_rebase_v5.4 903/1701] include/linux/usb/xhci_pdriver.h:22:6: warning: no previous prototype for 'dwc3_host_wakeup_capable'
by kernel test robot
Hi Michal,
FYI, the error/warning still remains.
tree: https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.4
head: 8540825db3d5519ef205a710515b7819b95eeb4f
commit: 6d0468b837bc2b3cce625f59904d137e63637b5d [903/1701] usb: dwc3: Add support for clock disabling during suspend
config: xtensa-randconfig-r036-20210401 (attached as .config)
compiler: xtensa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/Xilinx/linux-xlnx/commit/6d0468b837bc2b3cce625f59904d1...
git remote add xlnx https://github.com/Xilinx/linux-xlnx
git fetch --no-tags xlnx xlnx_rebase_v5.4
git checkout 6d0468b837bc2b3cce625f59904d137e63637b5d
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=xtensa
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
In file included from ./arch/xtensa/include/generated/asm/bug.h:1,
from include/linux/bug.h:5,
from include/linux/thread_info.h:12,
from arch/xtensa/include/asm/current.h:18,
from include/linux/mutex.h:14,
from include/linux/notifier.h:14,
from include/linux/clk.h:14,
from drivers/usb/host/xhci-plat.c:11:
include/linux/dma-mapping.h: In function 'dma_map_resource':
arch/xtensa/include/asm/page.h:182:9: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
182 | ((pfn) >= ARCH_PFN_OFFSET && ((pfn) - ARCH_PFN_OFFSET) < max_mapnr)
| ^~
include/asm-generic/bug.h:139:27: note: in definition of macro 'WARN_ON_ONCE'
139 | int __ret_warn_once = !!(condition); \
| ^~~~~~~~~
include/linux/dma-mapping.h:355:19: note: in expansion of macro 'pfn_valid'
355 | if (WARN_ON_ONCE(pfn_valid(PHYS_PFN(phys_addr))))
| ^~~~~~~~~
In file included from drivers/usb/host/xhci-plat.c:23:
include/linux/usb/xhci_pdriver.h: At top level:
>> include/linux/usb/xhci_pdriver.h:22:6: warning: no previous prototype for 'dwc3_host_wakeup_capable' [-Wmissing-prototypes]
22 | void dwc3_host_wakeup_capable(struct device *dev, bool wakeup)
| ^~~~~~~~~~~~~~~~~~~~~~~~
vim +/dwc3_host_wakeup_capable +22 include/linux/usb/xhci_pdriver.h
20
21 #else
> 22 void dwc3_host_wakeup_capable(struct device *dev, bool wakeup)
23 { ; }
24 #endif
25
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 4 months
[xlnx:xlnx_rebase_v5.4 942/1701] drivers/mtd/spi-nor/spi-nor.c:5196:14: error: implicit declaration of function 'of_get_next_parent'; did you mean 'of_get_parent'?
by kernel test robot
Hi Amit,
FYI, the error/warning still remains.
tree: https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.4
head: 8540825db3d5519ef205a710515b7819b95eeb4f
commit: 24bcc7359bdd609cedf0a715d77dc39e4ad782db [942/1701] mtd: spi-nor: Added axi-qspi support in spi-nor framework
config: alpha-randconfig-r034-20210401 (attached as .config)
compiler: alpha-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/Xilinx/linux-xlnx/commit/24bcc7359bdd609cedf0a715d77dc...
git remote add xlnx https://github.com/Xilinx/linux-xlnx
git fetch --no-tags xlnx xlnx_rebase_v5.4
git checkout 24bcc7359bdd609cedf0a715d77dc39e4ad782db
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=alpha
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All error/warnings (new ones prefixed by >>):
drivers/mtd/spi-nor/spi-nor.c: In function 'spi_nor_write_ear':
drivers/mtd/spi-nor/spi-nor.c:691:5: warning: variable 'code' set but not used [-Wunused-but-set-variable]
691 | u8 code;
| ^~~~
drivers/mtd/spi-nor/spi-nor.c: In function 'spi_nor_read':
drivers/mtd/spi-nor/spi-nor.c:2741:9: warning: variable 'addr' set but not used [-Wunused-but-set-variable]
2741 | loff_t addr = 0;
| ^~~~
drivers/mtd/spi-nor/spi-nor.c: In function 'spi_nor_set_addr_width':
>> drivers/mtd/spi-nor/spi-nor.c:5196:14: error: implicit declaration of function 'of_get_next_parent'; did you mean 'of_get_parent'? [-Werror=implicit-function-declaration]
5196 | np_spi = of_get_next_parent(np);
| ^~~~~~~~~~~~~~~~~~
| of_get_parent
>> drivers/mtd/spi-nor/spi-nor.c:5196:12: warning: assignment to 'struct device_node *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
5196 | np_spi = of_get_next_parent(np);
| ^
drivers/mtd/spi-nor/spi-nor.c: In function 'spi_nor_get_flash_info':
drivers/mtd/spi-nor/spi-nor.c:5266:11: warning: return discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
5266 | return jinfo;
| ^~~~~
drivers/mtd/spi-nor/spi-nor.c:5281:9: warning: return discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
5281 | return info;
| ^~~~
drivers/mtd/spi-nor/spi-nor.c: In function 'spi_nor_scan':
drivers/mtd/spi-nor/spi-nor.c:5295:6: warning: unused variable 'is_dual' [-Wunused-variable]
5295 | u32 is_dual;
| ^~~~~~~
drivers/mtd/spi-nor/spi-nor.c:5294:22: warning: unused variable 'np_spi' [-Wunused-variable]
5294 | struct device_node *np_spi;
| ^~~~~~
At top level:
drivers/mtd/spi-nor/spi-nor.c:781:12: warning: 'read_ear' defined but not used [-Wunused-function]
781 | static int read_ear(struct spi_nor *nor, struct flash_info *info)
| ^~~~~~~~
cc1: some warnings being treated as errors
vim +5196 drivers/mtd/spi-nor/spi-nor.c
5162
5163 static int spi_nor_set_addr_width(struct spi_nor *nor)
5164 {
5165 struct device_node *np = spi_nor_get_flash_node(nor);
5166 struct device_node *np_spi;
5167 if (nor->addr_width) {
5168 /* already configured from SFDP */
5169 } else if (nor->info->addr_width) {
5170 nor->addr_width = nor->info->addr_width;
5171 } else if (nor->mtd.size > 0x1000000) {
5172 #ifdef CONFIG_OF
5173 np_spi = of_get_next_parent(np);
5174 if (of_property_match_string(np_spi, "compatible",
5175 "xlnx,zynq-qspi-1.0") >= 0) {
5176 int status;
5177
5178 nor->addr_width = 3;
5179 nor->params.set_4byte(nor, false);
5180 status = read_ear(nor, (struct flash_info *)nor->info);
5181 if (status < 0)
5182 dev_warn(nor->dev, "failed to read ear reg\n");
5183 else
5184 nor->curbank = status & EAR_SEGMENT_MASK;
5185 } else {
5186 #endif
5187 /*
5188 * enable 4-byte addressing if the
5189 * device exceeds 16MiB
5190 */
5191 nor->addr_width = 4;
5192 if (JEDEC_MFR(nor->info) == SNOR_MFR_SPANSION ||
5193 nor->info->flags & SPI_NOR_4B_OPCODES) {
5194 spi_nor_set_4byte_opcodes(nor);
5195 } else {
> 5196 np_spi = of_get_next_parent(np);
5197 if (of_property_match_string(np_spi,
5198 "compatible",
5199 "xlnx,xps-spi-2.00.a") >= 0) {
5200 nor->addr_width = 3;
5201 nor->params.set_4byte(nor, false);
5202 } else {
5203 nor->params.set_4byte(nor, true);
5204 if (nor->isstacked) {
5205 nor->spi->master->flags |=
5206 SPI_MASTER_U_PAGE;
5207 nor->params.set_4byte(nor, true);
5208 nor->spi->master->flags &=
5209 ~SPI_MASTER_U_PAGE;
5210 }
5211 }
5212 }
5213 #ifdef CONFIG_OF
5214 }
5215 #endif
5216 } else {
5217 nor->addr_width = 3;
5218 }
5219
5220 if (nor->addr_width > SPI_NOR_MAX_ADDR_WIDTH) {
5221 dev_err(nor->dev, "address width is too large: %u\n",
5222 nor->addr_width);
5223 return -EINVAL;
5224 }
5225
5226 /* Set 4byte opcodes when possible. */
5227 if (nor->addr_width == 4 && nor->flags & SNOR_F_4B_OPCODES &&
5228 !(nor->flags & SNOR_F_HAS_4BAIT))
5229 spi_nor_set_4byte_opcodes(nor);
5230
5231 return 0;
5232 }
5233
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 4 months
Re: [PATCH 07/34] drm/amdkfd: deregister svm range
by kernel test robot
Hi Felix,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on next-20210331]
[cannot apply to drm-intel/for-linux-next drm-tip/drm-tip drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next linus/master drm/drm-next v5.12-rc5 v5.12-rc4 v5.12-rc3 v5.12-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Felix-Kuehling/Add-HMM-based-SVM...
base: 7a43c78d0573e0bbbb0456b033e2b9a895b89464
config: x86_64-randconfig-a011-20210401 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/545d8003c8da8397f0fa9657f97ed6744...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Felix-Kuehling/Add-HMM-based-SVM-memory-manager-to-KFD-v3/20210401-122712
git checkout 545d8003c8da8397f0fa9657f97ed67441dd1087
# save the attached .config to linux build tree
make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_svm.c:417:6: warning: no previous prototype for 'svm_range_add_child' [-Wmissing-prototypes]
417 | void svm_range_add_child(struct svm_range *prange, struct mm_struct *mm,
| ^~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_svm.c:511:19: warning: no previous prototype for 'svm_range_clone' [-Wmissing-prototypes]
511 | struct svm_range *svm_range_clone(struct svm_range *old)
| ^~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_svm.c:766:1: warning: no previous prototype for 'svm_range_add_list_work' [-Wmissing-prototypes]
766 | svm_range_add_list_work(struct svm_range_list *svms, struct svm_range *prange,
| ^~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_svm.c:788:6: warning: no previous prototype for 'schedule_deferred_list_work' [-Wmissing-prototypes]
788 | void schedule_deferred_list_work(struct svm_range_list *svms)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/svm_range_add_child +417 drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_svm.c
416
> 417 void svm_range_add_child(struct svm_range *prange, struct mm_struct *mm,
418 struct svm_range *pchild, enum svm_work_list_ops op)
419 {
420 pr_debug("add child 0x%p [0x%lx 0x%lx] to prange 0x%p child list %d\n",
421 pchild, pchild->start, pchild->last, prange, op);
422
423 pchild->work_item.mm = mm;
424 pchild->work_item.op = op;
425 list_add_tail(&pchild->child_list, &prange->child_list);
426 }
427
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 4 months
