Re: [RFC net-next] openvswitch: Introduce per-cpu upcall dispatch
by Dan Carpenter
Hi Mark,
url: https://github.com/0day-ci/linux/commits/Mark-Gray/openvswitch-Introduce-...
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 4a52dd8fefb45626dace70a63c0738dbd83b7edb
config: i386-randconfig-m021-20210430 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com>
smatch warnings:
net/openvswitch/datapath.c:1612 ovs_dp_set_upcall_portids() warn: variable dereferenced before check 'dp' (see line 1608)
net/openvswitch/datapath.c:1613 ovs_dp_set_upcall_portids() warn: possible memory leak of 'dp_portids'
vim +/dp +1612 net/openvswitch/datapath.c
96349cd061e4c2 Mark Gray 2021-04-30 1600 static int ovs_dp_set_upcall_portids(struct datapath *dp,
96349cd061e4c2 Mark Gray 2021-04-30 1601 const struct nlattr *ids)
96349cd061e4c2 Mark Gray 2021-04-30 1602 {
96349cd061e4c2 Mark Gray 2021-04-30 1603 struct dp_portids *old, *dp_portids;
96349cd061e4c2 Mark Gray 2021-04-30 1604
96349cd061e4c2 Mark Gray 2021-04-30 1605 if (!nla_len(ids) || nla_len(ids) % sizeof(u32))
96349cd061e4c2 Mark Gray 2021-04-30 1606 return -EINVAL;
96349cd061e4c2 Mark Gray 2021-04-30 1607
96349cd061e4c2 Mark Gray 2021-04-30 @1608 old = ovsl_dereference(dp->upcall_portids);
96349cd061e4c2 Mark Gray 2021-04-30 1609
96349cd061e4c2 Mark Gray 2021-04-30 1610 dp_portids = kmalloc(sizeof(*dp_portids) + nla_len(ids),
96349cd061e4c2 Mark Gray 2021-04-30 1611 GFP_KERNEL);
96349cd061e4c2 Mark Gray 2021-04-30 @1612 if (!dp)
^^
This should have been "if (!dp_portids)"
96349cd061e4c2 Mark Gray 2021-04-30 @1613 return -ENOMEM;
96349cd061e4c2 Mark Gray 2021-04-30 1614
96349cd061e4c2 Mark Gray 2021-04-30 1615 dp_portids->n_ids = nla_len(ids) / sizeof(u32);
96349cd061e4c2 Mark Gray 2021-04-30 1616 nla_memcpy(dp_portids->ids, ids, nla_len(ids));
96349cd061e4c2 Mark Gray 2021-04-30 1617
96349cd061e4c2 Mark Gray 2021-04-30 1618 rcu_assign_pointer(dp->upcall_portids, dp_portids);
96349cd061e4c2 Mark Gray 2021-04-30 1619
96349cd061e4c2 Mark Gray 2021-04-30 1620 if (old)
96349cd061e4c2 Mark Gray 2021-04-30 1621 kfree_rcu(old, rcu);
96349cd061e4c2 Mark Gray 2021-04-30 1622 return 0;
96349cd061e4c2 Mark Gray 2021-04-30 1623 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
3 months
arch/powerpc/kvm/book3s_hv_nested.c:264:6: error: stack frame size of 2304 bytes in function 'kvmhv_enter_nested_guest'
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: d93a0d43e3d0ba9e19387be4dae4a8d5b175a8d7
commit: 97e4910232fa1f81e806aa60c25a0450276d99a2 linux/compiler-clang.h: define HAVE_BUILTIN_BSWAP*
date: 3 weeks ago
config: powerpc64-randconfig-r006-20210403 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 0fe8af94688aa03c01913c2001d6a1a911f42ce6)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install powerpc64 cross compiling tool for clang build
# apt-get install binutils-powerpc64-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit...
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 97e4910232fa1f81e806aa60c25a0450276d99a2
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> arch/powerpc/kvm/book3s_hv_nested.c:264:6: error: stack frame size of 2304 bytes in function 'kvmhv_enter_nested_guest' [-Werror,-Wframe-larger-than=]
long kvmhv_enter_nested_guest(struct kvm_vcpu *vcpu)
^
1 error generated.
vim +/kvmhv_enter_nested_guest +264 arch/powerpc/kvm/book3s_hv_nested.c
afe75049303f75 Ravi Bangoria 2020-12-16 263
360cae313702cd Paul Mackerras 2018-10-08 @264 long kvmhv_enter_nested_guest(struct kvm_vcpu *vcpu)
360cae313702cd Paul Mackerras 2018-10-08 265 {
360cae313702cd Paul Mackerras 2018-10-08 266 long int err, r;
360cae313702cd Paul Mackerras 2018-10-08 267 struct kvm_nested_guest *l2;
360cae313702cd Paul Mackerras 2018-10-08 268 struct pt_regs l2_regs, saved_l1_regs;
afe75049303f75 Ravi Bangoria 2020-12-16 269 struct hv_guest_state l2_hv = {0}, saved_l1_hv;
360cae313702cd Paul Mackerras 2018-10-08 270 struct kvmppc_vcore *vc = vcpu->arch.vcore;
360cae313702cd Paul Mackerras 2018-10-08 271 u64 hv_ptr, regs_ptr;
360cae313702cd Paul Mackerras 2018-10-08 272 u64 hdec_exp;
360cae313702cd Paul Mackerras 2018-10-08 273 s64 delta_purr, delta_spurr, delta_ic, delta_vtb;
360cae313702cd Paul Mackerras 2018-10-08 274 u64 mask;
360cae313702cd Paul Mackerras 2018-10-08 275 unsigned long lpcr;
360cae313702cd Paul Mackerras 2018-10-08 276
360cae313702cd Paul Mackerras 2018-10-08 277 if (vcpu->kvm->arch.l1_ptcr == 0)
360cae313702cd Paul Mackerras 2018-10-08 278 return H_NOT_AVAILABLE;
360cae313702cd Paul Mackerras 2018-10-08 279
360cae313702cd Paul Mackerras 2018-10-08 280 /* copy parameters in */
360cae313702cd Paul Mackerras 2018-10-08 281 hv_ptr = kvmppc_get_gpr(vcpu, 4);
1508c22f112ce1 Alexey Kardashevskiy 2020-06-09 282 regs_ptr = kvmppc_get_gpr(vcpu, 5);
1508c22f112ce1 Alexey Kardashevskiy 2020-06-09 283 vcpu->srcu_idx = srcu_read_lock(&vcpu->kvm->srcu);
afe75049303f75 Ravi Bangoria 2020-12-16 284 err = kvmhv_read_guest_state_and_regs(vcpu, &l2_hv, &l2_regs,
afe75049303f75 Ravi Bangoria 2020-12-16 285 hv_ptr, regs_ptr);
1508c22f112ce1 Alexey Kardashevskiy 2020-06-09 286 srcu_read_unlock(&vcpu->kvm->srcu, vcpu->srcu_idx);
360cae313702cd Paul Mackerras 2018-10-08 287 if (err)
360cae313702cd Paul Mackerras 2018-10-08 288 return H_PARAMETER;
1508c22f112ce1 Alexey Kardashevskiy 2020-06-09 289
10b5022db7861a Suraj Jitindar Singh 2018-10-08 290 if (kvmppc_need_byteswap(vcpu))
10b5022db7861a Suraj Jitindar Singh 2018-10-08 291 byteswap_hv_regs(&l2_hv);
afe75049303f75 Ravi Bangoria 2020-12-16 292 if (l2_hv.version > HV_GUEST_STATE_VERSION)
360cae313702cd Paul Mackerras 2018-10-08 293 return H_P2;
360cae313702cd Paul Mackerras 2018-10-08 294
10b5022db7861a Suraj Jitindar Singh 2018-10-08 295 if (kvmppc_need_byteswap(vcpu))
10b5022db7861a Suraj Jitindar Singh 2018-10-08 296 byteswap_pt_regs(&l2_regs);
9d0b048da788c1 Suraj Jitindar Singh 2018-10-08 297 if (l2_hv.vcpu_token >= NR_CPUS)
9d0b048da788c1 Suraj Jitindar Singh 2018-10-08 298 return H_PARAMETER;
9d0b048da788c1 Suraj Jitindar Singh 2018-10-08 299
360cae313702cd Paul Mackerras 2018-10-08 300 /* translate lpid */
360cae313702cd Paul Mackerras 2018-10-08 301 l2 = kvmhv_get_nested(vcpu->kvm, l2_hv.lpid, true);
360cae313702cd Paul Mackerras 2018-10-08 302 if (!l2)
360cae313702cd Paul Mackerras 2018-10-08 303 return H_PARAMETER;
360cae313702cd Paul Mackerras 2018-10-08 304 if (!l2->l1_gr_to_hr) {
360cae313702cd Paul Mackerras 2018-10-08 305 mutex_lock(&l2->tlb_lock);
360cae313702cd Paul Mackerras 2018-10-08 306 kvmhv_update_ptbl_cache(l2);
360cae313702cd Paul Mackerras 2018-10-08 307 mutex_unlock(&l2->tlb_lock);
360cae313702cd Paul Mackerras 2018-10-08 308 }
360cae313702cd Paul Mackerras 2018-10-08 309
360cae313702cd Paul Mackerras 2018-10-08 310 /* save l1 values of things */
360cae313702cd Paul Mackerras 2018-10-08 311 vcpu->arch.regs.msr = vcpu->arch.shregs.msr;
360cae313702cd Paul Mackerras 2018-10-08 312 saved_l1_regs = vcpu->arch.regs;
360cae313702cd Paul Mackerras 2018-10-08 313 kvmhv_save_hv_regs(vcpu, &saved_l1_hv);
360cae313702cd Paul Mackerras 2018-10-08 314
360cae313702cd Paul Mackerras 2018-10-08 315 /* convert TB values/offsets to host (L0) values */
360cae313702cd Paul Mackerras 2018-10-08 316 hdec_exp = l2_hv.hdec_expiry - vc->tb_offset;
360cae313702cd Paul Mackerras 2018-10-08 317 vc->tb_offset += l2_hv.tb_offset;
360cae313702cd Paul Mackerras 2018-10-08 318
360cae313702cd Paul Mackerras 2018-10-08 319 /* set L1 state to L2 state */
360cae313702cd Paul Mackerras 2018-10-08 320 vcpu->arch.nested = l2;
360cae313702cd Paul Mackerras 2018-10-08 321 vcpu->arch.nested_vcpu_id = l2_hv.vcpu_token;
360cae313702cd Paul Mackerras 2018-10-08 322 vcpu->arch.regs = l2_regs;
360cae313702cd Paul Mackerras 2018-10-08 323 vcpu->arch.shregs.msr = vcpu->arch.regs.msr;
360cae313702cd Paul Mackerras 2018-10-08 324 mask = LPCR_DPFD | LPCR_ILE | LPCR_TC | LPCR_AIL | LPCR_LD |
360cae313702cd Paul Mackerras 2018-10-08 325 LPCR_LPES | LPCR_MER;
360cae313702cd Paul Mackerras 2018-10-08 326 lpcr = (vc->lpcr & ~mask) | (l2_hv.lpcr & mask);
73937deb4b2d7f Suraj Jitindar Singh 2018-10-08 327 sanitise_hv_regs(vcpu, &l2_hv);
360cae313702cd Paul Mackerras 2018-10-08 328 restore_hv_regs(vcpu, &l2_hv);
360cae313702cd Paul Mackerras 2018-10-08 329
360cae313702cd Paul Mackerras 2018-10-08 330 vcpu->arch.ret = RESUME_GUEST;
360cae313702cd Paul Mackerras 2018-10-08 331 vcpu->arch.trap = 0;
360cae313702cd Paul Mackerras 2018-10-08 332 do {
360cae313702cd Paul Mackerras 2018-10-08 333 if (mftb() >= hdec_exp) {
360cae313702cd Paul Mackerras 2018-10-08 334 vcpu->arch.trap = BOOK3S_INTERRUPT_HV_DECREMENTER;
360cae313702cd Paul Mackerras 2018-10-08 335 r = RESUME_HOST;
360cae313702cd Paul Mackerras 2018-10-08 336 break;
360cae313702cd Paul Mackerras 2018-10-08 337 }
8c99d34578628b Tianjia Zhang 2020-04-27 338 r = kvmhv_run_single_vcpu(vcpu, hdec_exp, lpcr);
360cae313702cd Paul Mackerras 2018-10-08 339 } while (is_kvmppc_resume_guest(r));
360cae313702cd Paul Mackerras 2018-10-08 340
360cae313702cd Paul Mackerras 2018-10-08 341 /* save L2 state for return */
360cae313702cd Paul Mackerras 2018-10-08 342 l2_regs = vcpu->arch.regs;
360cae313702cd Paul Mackerras 2018-10-08 343 l2_regs.msr = vcpu->arch.shregs.msr;
360cae313702cd Paul Mackerras 2018-10-08 344 delta_purr = vcpu->arch.purr - l2_hv.purr;
360cae313702cd Paul Mackerras 2018-10-08 345 delta_spurr = vcpu->arch.spurr - l2_hv.spurr;
360cae313702cd Paul Mackerras 2018-10-08 346 delta_ic = vcpu->arch.ic - l2_hv.ic;
360cae313702cd Paul Mackerras 2018-10-08 347 delta_vtb = vc->vtb - l2_hv.vtb;
360cae313702cd Paul Mackerras 2018-10-08 348 save_hv_return_state(vcpu, vcpu->arch.trap, &l2_hv);
360cae313702cd Paul Mackerras 2018-10-08 349
360cae313702cd Paul Mackerras 2018-10-08 350 /* restore L1 state */
360cae313702cd Paul Mackerras 2018-10-08 351 vcpu->arch.nested = NULL;
360cae313702cd Paul Mackerras 2018-10-08 352 vcpu->arch.regs = saved_l1_regs;
360cae313702cd Paul Mackerras 2018-10-08 353 vcpu->arch.shregs.msr = saved_l1_regs.msr & ~MSR_TS_MASK;
360cae313702cd Paul Mackerras 2018-10-08 354 /* set L1 MSR TS field according to L2 transaction state */
360cae313702cd Paul Mackerras 2018-10-08 355 if (l2_regs.msr & MSR_TS_MASK)
360cae313702cd Paul Mackerras 2018-10-08 356 vcpu->arch.shregs.msr |= MSR_TS_S;
360cae313702cd Paul Mackerras 2018-10-08 357 vc->tb_offset = saved_l1_hv.tb_offset;
360cae313702cd Paul Mackerras 2018-10-08 358 restore_hv_regs(vcpu, &saved_l1_hv);
360cae313702cd Paul Mackerras 2018-10-08 359 vcpu->arch.purr += delta_purr;
360cae313702cd Paul Mackerras 2018-10-08 360 vcpu->arch.spurr += delta_spurr;
360cae313702cd Paul Mackerras 2018-10-08 361 vcpu->arch.ic += delta_ic;
360cae313702cd Paul Mackerras 2018-10-08 362 vc->vtb += delta_vtb;
360cae313702cd Paul Mackerras 2018-10-08 363
360cae313702cd Paul Mackerras 2018-10-08 364 kvmhv_put_nested(l2);
360cae313702cd Paul Mackerras 2018-10-08 365
360cae313702cd Paul Mackerras 2018-10-08 366 /* copy l2_hv_state and regs back to guest */
10b5022db7861a Suraj Jitindar Singh 2018-10-08 367 if (kvmppc_need_byteswap(vcpu)) {
10b5022db7861a Suraj Jitindar Singh 2018-10-08 368 byteswap_hv_regs(&l2_hv);
10b5022db7861a Suraj Jitindar Singh 2018-10-08 369 byteswap_pt_regs(&l2_regs);
10b5022db7861a Suraj Jitindar Singh 2018-10-08 370 }
1508c22f112ce1 Alexey Kardashevskiy 2020-06-09 371 vcpu->srcu_idx = srcu_read_lock(&vcpu->kvm->srcu);
afe75049303f75 Ravi Bangoria 2020-12-16 372 err = kvmhv_write_guest_state_and_regs(vcpu, &l2_hv, &l2_regs,
afe75049303f75 Ravi Bangoria 2020-12-16 373 hv_ptr, regs_ptr);
1508c22f112ce1 Alexey Kardashevskiy 2020-06-09 374 srcu_read_unlock(&vcpu->kvm->srcu, vcpu->srcu_idx);
360cae313702cd Paul Mackerras 2018-10-08 375 if (err)
360cae313702cd Paul Mackerras 2018-10-08 376 return H_AUTHORITY;
360cae313702cd Paul Mackerras 2018-10-08 377
360cae313702cd Paul Mackerras 2018-10-08 378 if (r == -EINTR)
360cae313702cd Paul Mackerras 2018-10-08 379 return H_INTERRUPT;
360cae313702cd Paul Mackerras 2018-10-08 380
873db2cd9a6d7f Suraj Jitindar Singh 2018-12-14 381 if (vcpu->mmio_needed) {
873db2cd9a6d7f Suraj Jitindar Singh 2018-12-14 382 kvmhv_nested_mmio_needed(vcpu, regs_ptr);
873db2cd9a6d7f Suraj Jitindar Singh 2018-12-14 383 return H_TOO_HARD;
873db2cd9a6d7f Suraj Jitindar Singh 2018-12-14 384 }
873db2cd9a6d7f Suraj Jitindar Singh 2018-12-14 385
360cae313702cd Paul Mackerras 2018-10-08 386 return vcpu->arch.trap;
360cae313702cd Paul Mackerras 2018-10-08 387 }
360cae313702cd Paul Mackerras 2018-10-08 388
:::::: The code at line 264 was first introduced by commit
:::::: 360cae313702cdd0b90f82c261a8302fecef030a KVM: PPC: Book3S HV: Nested guest entry via hypercall
:::::: TO: Paul Mackerras <paulus(a)ozlabs.org>
:::::: CC: Michael Ellerman <mpe(a)ellerman.id.au>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
3 months, 1 week
[linux-next:master 5116/5396] mm/memory.c:710:25: sparse: sparse: cast to non-scalar
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: f6b46ef27317b3441138b902689bd89e4f82c6f4
commit: ce50e82c1d69532fc05721ed7951480c8525e7fd [5116/5396] mm: device exclusive memory access
config: alpha-randconfig-s032-20210526 (attached as .config)
compiler: alpha-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.3-341-g8af24329-dirty
# https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commi...
git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git fetch --no-tags linux-next master
git checkout ce50e82c1d69532fc05721ed7951480c8525e7fd
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=alpha
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
sparse warnings: (new ones prefixed by >>)
>> mm/memory.c:710:25: sparse: sparse: cast to non-scalar
>> mm/memory.c:710:25: sparse: sparse: cast from non-scalar
mm/memory.c:1024:17: sparse: sparse: context imbalance in 'copy_pte_range' - different lock contexts for basic block
mm/memory.c:1721:16: sparse: sparse: context imbalance in '__get_locked_pte' - different lock contexts for basic block
mm/memory.c:1770:9: sparse: sparse: context imbalance in 'insert_page' - different lock contexts for basic block
mm/memory.c:2272:17: sparse: sparse: context imbalance in 'remap_pte_range' - different lock contexts for basic block
mm/memory.c:2528:17: sparse: sparse: context imbalance in 'apply_to_pte_range' - unexpected unlock
mm/memory.c:2816:17: sparse: sparse: context imbalance in 'wp_page_copy' - unexpected unlock
mm/memory.c:3162:17: sparse: sparse: context imbalance in 'wp_pfn_shared' - unexpected unlock
mm/memory.c:3225:19: sparse: sparse: context imbalance in 'do_wp_page' - different lock contexts for basic block
mm/memory.c: note: in included file (through include/linux/mm.h, arch/alpha/include/asm/io.h, include/linux/io.h, include/linux/irq.h, ...):
include/linux/pgtable.h:257:16: sparse: sparse: cast to non-scalar
include/linux/pgtable.h:257:16: sparse: sparse: cast from non-scalar
mm/memory.c:4823:5: sparse: sparse: context imbalance in 'follow_invalidate_pte' - different lock contexts for basic block
mm/memory.c:4944:9: sparse: sparse: context imbalance in 'follow_pfn' - unexpected unlock
vim +710 mm/memory.c
702
703 static void restore_exclusive_pte(struct vm_area_struct *vma,
704 struct page *page, unsigned long address,
705 pte_t *ptep)
706 {
707 pte_t pte;
708 swp_entry_t entry;
709
> 710 pte = pte_mkold(mk_pte(page, READ_ONCE(vma->vm_page_prot)));
711 if (pte_swp_soft_dirty(*ptep))
712 pte = pte_mksoft_dirty(pte);
713
714 entry = pte_to_swp_entry(*ptep);
715 if (pte_swp_uffd_wp(*ptep))
716 pte = pte_mkuffd_wp(pte);
717 else if (is_writable_device_exclusive_entry(entry))
718 pte = maybe_mkwrite(pte_mkdirty(pte), vma);
719
720 set_pte_at(vma->vm_mm, address, ptep, pte);
721
722 /*
723 * No need to take a page reference as one was already
724 * created when the swap entry was made.
725 */
726 if (PageAnon(page))
727 page_add_anon_rmap(page, vma, address, false);
728 else
729 /*
730 * Currently device exclusive access only supports anonymous
731 * memory so the entry shouldn't point to a filebacked page.
732 */
733 WARN_ON_ONCE(!PageAnon(page));
734
735 if (vma->vm_flags & VM_LOCKED)
736 mlock_vma_page(page);
737
738 /*
739 * No need to invalidate - it was non-present before. However
740 * secondary CPUs may have mappings that need invalidating.
741 */
742 update_mmu_cache(vma, address, ptep);
743 }
744
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
3 months, 2 weeks
Re: [PATCH v1 2/3] scsi: ufs: Optimize host lock on transfer requests send/compl paths
by kernel test robot
Hi Can,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on mkp-scsi/for-next]
[also build test WARNING on next-20210524]
[cannot apply to scsi/for-next v5.13-rc3]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Can-Guo/Optimize-host-lock-on-TR...
base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
config: arm64-randconfig-r011-20210524 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 93d1e5822ed64abd777eb94ea9899e96c4c39fbe)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/0day-ci/linux/commit/efe94162bf7973be4ed6496871b9bc9ea...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Can-Guo/Optimize-host-lock-on-TR-send-compl-paths-and-utilize-UTRLCNR/20210524-163847
git checkout efe94162bf7973be4ed6496871b9bc9ea54e2819
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> drivers/scsi/ufs/ufshcd.c:2959:6: warning: variable 'lrbp' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
if (unlikely(test_bit(tag, &hba->outstanding_reqs))) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/compiler.h:78:22: note: expanded from macro 'unlikely'
# define unlikely(x) __builtin_expect(!!(x), 0)
^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/ufs/ufshcd.c:2981:32: note: uninitialized use occurs here
(struct utp_upiu_req *)lrbp->ucd_rsp_ptr);
^~~~
drivers/scsi/ufs/ufshcd.c:2959:2: note: remove the 'if' if its condition is always false
if (unlikely(test_bit(tag, &hba->outstanding_reqs))) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/ufs/ufshcd.c:2939:25: note: initialize the variable 'lrbp' to silence this warning
struct ufshcd_lrb *lrbp;
^
= NULL
1 warning generated.
vim +2959 drivers/scsi/ufs/ufshcd.c
2924
2925 /**
2926 * ufshcd_exec_dev_cmd - API for sending device management requests
2927 * @hba: UFS hba
2928 * @cmd_type: specifies the type (NOP, Query...)
2929 * @timeout: time in seconds
2930 *
2931 * NOTE: Since there is only one available tag for device management commands,
2932 * it is expected you hold the hba->dev_cmd.lock mutex.
2933 */
2934 static int ufshcd_exec_dev_cmd(struct ufs_hba *hba,
2935 enum dev_cmd_type cmd_type, int timeout)
2936 {
2937 struct request_queue *q = hba->cmd_queue;
2938 struct request *req;
2939 struct ufshcd_lrb *lrbp;
2940 int err;
2941 int tag;
2942 struct completion wait;
2943
2944 down_read(&hba->clk_scaling_lock);
2945
2946 /*
2947 * Get free slot, sleep if slots are unavailable.
2948 * Even though we use wait_event() which sleeps indefinitely,
2949 * the maximum wait time is bounded by SCSI request timeout.
2950 */
2951 req = blk_get_request(q, REQ_OP_DRV_OUT, 0);
2952 if (IS_ERR(req)) {
2953 err = PTR_ERR(req);
2954 goto out_unlock;
2955 }
2956 tag = req->tag;
2957 WARN_ON_ONCE(!ufshcd_valid_tag(hba, tag));
2958
> 2959 if (unlikely(test_bit(tag, &hba->outstanding_reqs))) {
2960 err = -EBUSY;
2961 goto out;
2962 }
2963
2964 init_completion(&wait);
2965 lrbp = &hba->lrb[tag];
2966 WARN_ON(lrbp->cmd);
2967 err = ufshcd_compose_dev_cmd(hba, lrbp, cmd_type, tag);
2968 if (unlikely(err))
2969 goto out_put_tag;
2970
2971 hba->dev_cmd.complete = &wait;
2972
2973 ufshcd_add_query_upiu_trace(hba, UFS_QUERY_SEND, lrbp->ucd_req_ptr);
2974 /* Make sure descriptors are ready before ringing the doorbell */
2975 wmb();
2976
2977 ufshcd_send_command(hba, tag);
2978 err = ufshcd_wait_for_dev_cmd(hba, lrbp, timeout);
2979 out:
2980 ufshcd_add_query_upiu_trace(hba, err ? UFS_QUERY_ERR : UFS_QUERY_COMP,
2981 (struct utp_upiu_req *)lrbp->ucd_rsp_ptr);
2982
2983 out_put_tag:
2984 blk_put_request(req);
2985 out_unlock:
2986 up_read(&hba->clk_scaling_lock);
2987 return err;
2988 }
2989
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
3 months, 3 weeks
[mtd:nand/next 6/7] drivers/mtd/nand/raw/qcom_nandc.c:765:7: error: 'nandc' undeclared
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next
head: 612a421079a7fa3042fd713eb62b455aac1a0e88
commit: 4ea7f88f173804f344988f580fb41ba96f7666da [6/7] mtd: rawnand: qcom: avoid writing to obsolete register
config: arc-randconfig-p001-20210510 (attached as .config)
compiler: arceb-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git/commit/?id=...
git remote add mtd https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git
git fetch --no-tags mtd nand/next
git checkout 4ea7f88f173804f344988f580fb41ba96f7666da
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=arc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
drivers/mtd/nand/raw/qcom_nandc.c: In function 'update_rw_regs':
>> drivers/mtd/nand/raw/qcom_nandc.c:765:7: error: 'nandc' undeclared (first use in this function)
765 | if (!nandc->props->qpic_v2)
| ^~~~~
drivers/mtd/nand/raw/qcom_nandc.c:765:7: note: each undeclared identifier is reported only once for each function it appears in
vim +/nandc +765 drivers/mtd/nand/raw/qcom_nandc.c
724
725 /*
726 * update_rw_regs: set up read/write register values, these will be
727 * written to the NAND controller registers via DMA
728 *
729 * @num_cw: number of steps for the read/write operation
730 * @read: read or write operation
731 * @cw : which code word
732 */
733 static void update_rw_regs(struct qcom_nand_host *host, int num_cw, bool read, int cw)
734 {
735 struct nand_chip *chip = &host->chip;
736 u32 cmd, cfg0, cfg1, ecc_bch_cfg;
737
738 if (read) {
739 if (host->use_ecc)
740 cmd = OP_PAGE_READ_WITH_ECC | PAGE_ACC | LAST_PAGE;
741 else
742 cmd = OP_PAGE_READ | PAGE_ACC | LAST_PAGE;
743 } else {
744 cmd = OP_PROGRAM_PAGE | PAGE_ACC | LAST_PAGE;
745 }
746
747 if (host->use_ecc) {
748 cfg0 = (host->cfg0 & ~(7U << CW_PER_PAGE)) |
749 (num_cw - 1) << CW_PER_PAGE;
750
751 cfg1 = host->cfg1;
752 ecc_bch_cfg = host->ecc_bch_cfg;
753 } else {
754 cfg0 = (host->cfg0_raw & ~(7U << CW_PER_PAGE)) |
755 (num_cw - 1) << CW_PER_PAGE;
756
757 cfg1 = host->cfg1_raw;
758 ecc_bch_cfg = 1 << ECC_CFG_ECC_DISABLE;
759 }
760
761 nandc_set_reg(chip, NAND_FLASH_CMD, cmd);
762 nandc_set_reg(chip, NAND_DEV0_CFG0, cfg0);
763 nandc_set_reg(chip, NAND_DEV0_CFG1, cfg1);
764 nandc_set_reg(chip, NAND_DEV0_ECC_CFG, ecc_bch_cfg);
> 765 if (!nandc->props->qpic_v2)
766 nandc_set_reg(chip, NAND_EBI2_ECC_BUF_CFG, host->ecc_buf_cfg);
767 nandc_set_reg(chip, NAND_FLASH_STATUS, host->clrflashstatus);
768 nandc_set_reg(chip, NAND_READ_STATUS, host->clrreadstatus);
769 nandc_set_reg(chip, NAND_EXEC_CMD, 1);
770
771 if (read)
772 nandc_set_read_loc(chip, cw, 0, 0, host->use_ecc ?
773 host->cw_data : host->cw_size, 1);
774 }
775
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
3 months, 3 weeks
mm/migrate.c:1406:5: warning: stack frame size of 2096 bytes in function 'migrate_pages'
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: b90e90f40b4ff23c753126008bf4713a42353af6
commit: dd4ae78a21fc05d91d841e499dddd057ad64a4df mm: migrate: simplify the logic for handling permanent failure
date: 6 months ago
config: powerpc-randconfig-r034-20210530 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project bc6799f2f79f0ae87e9f1ebf9d25ba799fbd25a9)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install powerpc cross compiling tool for clang build
# apt-get install binutils-powerpc-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit...
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout dd4ae78a21fc05d91d841e499dddd057ad64a4df
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
In file included from mm/migrate.c:16:
In file included from include/linux/migrate.h:5:
In file included from include/linux/mm.h:9:
In file included from include/linux/mmdebug.h:5:
In file included from include/linux/bug.h:5:
In file included from arch/powerpc/include/asm/bug.h:109:
In file included from include/asm-generic/bug.h:20:
In file included from include/linux/kernel.h:12:
In file included from include/linux/bitops.h:29:
In file included from arch/powerpc/include/asm/bitops.h:62:
arch/powerpc/include/asm/barrier.h:49:9: warning: '__lwsync' macro redefined [-Wmacro-redefined]
#define __lwsync() __asm__ __volatile__ (stringify_in_c(LWSYNC) : : :"memory")
^
<built-in>:309:9: note: previous definition is here
#define __lwsync __builtin_ppc_lwsync
^
>> mm/migrate.c:1406:5: warning: stack frame size of 2096 bytes in function 'migrate_pages' [-Wframe-larger-than=]
int migrate_pages(struct list_head *from, new_page_t get_new_page,
^
2 warnings generated.
vim +/migrate_pages +1406 mm/migrate.c
290408d4a25002 Naoya Horiguchi 2010-09-08 1384
e24f0b8f76cc3d Christoph Lameter 2006-06-23 1385 /*
c73e5c9c59a0f7 Srivatsa S. Bhat 2013-04-29 1386 * migrate_pages - migrate the pages specified in a list, to the free pages
c73e5c9c59a0f7 Srivatsa S. Bhat 2013-04-29 1387 * supplied as the target for the page migration
e24f0b8f76cc3d Christoph Lameter 2006-06-23 1388 *
c73e5c9c59a0f7 Srivatsa S. Bhat 2013-04-29 1389 * @from: The list of pages to be migrated.
c73e5c9c59a0f7 Srivatsa S. Bhat 2013-04-29 1390 * @get_new_page: The function used to allocate free pages to be used
c73e5c9c59a0f7 Srivatsa S. Bhat 2013-04-29 1391 * as the target of the page migration.
68711a746345c4 David Rientjes 2014-06-04 1392 * @put_new_page: The function used to free target pages if migration
68711a746345c4 David Rientjes 2014-06-04 1393 * fails, or NULL if no special handling is necessary.
c73e5c9c59a0f7 Srivatsa S. Bhat 2013-04-29 1394 * @private: Private data to be passed on to get_new_page()
c73e5c9c59a0f7 Srivatsa S. Bhat 2013-04-29 1395 * @mode: The migration mode that specifies the constraints for
c73e5c9c59a0f7 Srivatsa S. Bhat 2013-04-29 1396 * page migration, if any.
c73e5c9c59a0f7 Srivatsa S. Bhat 2013-04-29 1397 * @reason: The reason for page migration.
e24f0b8f76cc3d Christoph Lameter 2006-06-23 1398 *
c73e5c9c59a0f7 Srivatsa S. Bhat 2013-04-29 1399 * The function returns after 10 attempts or if no pages are movable any more
c73e5c9c59a0f7 Srivatsa S. Bhat 2013-04-29 1400 * because the list has become empty or no retryable pages exist any more.
dd4ae78a21fc05 Yang Shi 2020-12-14 1401 * It is caller's responsibility to call putback_movable_pages() to return pages
dd4ae78a21fc05 Yang Shi 2020-12-14 1402 * to the LRU or free list only if ret != 0.
e24f0b8f76cc3d Christoph Lameter 2006-06-23 1403 *
c73e5c9c59a0f7 Srivatsa S. Bhat 2013-04-29 1404 * Returns the number of pages that were not migrated, or an error code.
e24f0b8f76cc3d Christoph Lameter 2006-06-23 1405 */
9c620e2bc5aa42 Hugh Dickins 2013-02-22 @1406 int migrate_pages(struct list_head *from, new_page_t get_new_page,
68711a746345c4 David Rientjes 2014-06-04 1407 free_page_t put_new_page, unsigned long private,
68711a746345c4 David Rientjes 2014-06-04 1408 enum migrate_mode mode, int reason)
e24f0b8f76cc3d Christoph Lameter 2006-06-23 1409 {
e24f0b8f76cc3d Christoph Lameter 2006-06-23 1410 int retry = 1;
1a5bae25e3cf95 Anshuman Khandual 2020-08-11 1411 int thp_retry = 1;
e24f0b8f76cc3d Christoph Lameter 2006-06-23 1412 int nr_failed = 0;
5647bc293ab15f Mel Gorman 2012-10-19 1413 int nr_succeeded = 0;
1a5bae25e3cf95 Anshuman Khandual 2020-08-11 1414 int nr_thp_succeeded = 0;
1a5bae25e3cf95 Anshuman Khandual 2020-08-11 1415 int nr_thp_failed = 0;
1a5bae25e3cf95 Anshuman Khandual 2020-08-11 1416 int nr_thp_split = 0;
e24f0b8f76cc3d Christoph Lameter 2006-06-23 1417 int pass = 0;
1a5bae25e3cf95 Anshuman Khandual 2020-08-11 1418 bool is_thp = false;
e24f0b8f76cc3d Christoph Lameter 2006-06-23 1419 struct page *page;
e24f0b8f76cc3d Christoph Lameter 2006-06-23 1420 struct page *page2;
e24f0b8f76cc3d Christoph Lameter 2006-06-23 1421 int swapwrite = current->flags & PF_SWAPWRITE;
1a5bae25e3cf95 Anshuman Khandual 2020-08-11 1422 int rc, nr_subpages;
dd4ae78a21fc05 Yang Shi 2020-12-14 1423 LIST_HEAD(ret_pages);
e24f0b8f76cc3d Christoph Lameter 2006-06-23 1424
e24f0b8f76cc3d Christoph Lameter 2006-06-23 1425 if (!swapwrite)
e24f0b8f76cc3d Christoph Lameter 2006-06-23 1426 current->flags |= PF_SWAPWRITE;
e24f0b8f76cc3d Christoph Lameter 2006-06-23 1427
1a5bae25e3cf95 Anshuman Khandual 2020-08-11 1428 for (pass = 0; pass < 10 && (retry || thp_retry); pass++) {
e24f0b8f76cc3d Christoph Lameter 2006-06-23 1429 retry = 0;
1a5bae25e3cf95 Anshuman Khandual 2020-08-11 1430 thp_retry = 0;
e24f0b8f76cc3d Christoph Lameter 2006-06-23 1431
e24f0b8f76cc3d Christoph Lameter 2006-06-23 1432 list_for_each_entry_safe(page, page2, from, lru) {
94723aafb9e764 Michal Hocko 2018-04-10 1433 retry:
1a5bae25e3cf95 Anshuman Khandual 2020-08-11 1434 /*
1a5bae25e3cf95 Anshuman Khandual 2020-08-11 1435 * THP statistics is based on the source huge page.
1a5bae25e3cf95 Anshuman Khandual 2020-08-11 1436 * Capture required information that might get lost
1a5bae25e3cf95 Anshuman Khandual 2020-08-11 1437 * during migration.
1a5bae25e3cf95 Anshuman Khandual 2020-08-11 1438 */
6c5c7b9f335272 Zi Yan 2020-09-25 1439 is_thp = PageTransHuge(page) && !PageHuge(page);
6c357848b44b40 Matthew Wilcox (Oracle 2020-08-14 1440) nr_subpages = thp_nr_pages(page);
e24f0b8f76cc3d Christoph Lameter 2006-06-23 1441 cond_resched();
e24f0b8f76cc3d Christoph Lameter 2006-06-23 1442
31caf665e666b5 Naoya Horiguchi 2013-09-11 1443 if (PageHuge(page))
31caf665e666b5 Naoya Horiguchi 2013-09-11 1444 rc = unmap_and_move_huge_page(get_new_page,
68711a746345c4 David Rientjes 2014-06-04 1445 put_new_page, private, page,
dd4ae78a21fc05 Yang Shi 2020-12-14 1446 pass > 2, mode, reason,
dd4ae78a21fc05 Yang Shi 2020-12-14 1447 &ret_pages);
31caf665e666b5 Naoya Horiguchi 2013-09-11 1448 else
68711a746345c4 David Rientjes 2014-06-04 1449 rc = unmap_and_move(get_new_page, put_new_page,
add05cecef803f Naoya Horiguchi 2015-06-24 1450 private, page, pass > 2, mode,
dd4ae78a21fc05 Yang Shi 2020-12-14 1451 reason, &ret_pages);
dd4ae78a21fc05 Yang Shi 2020-12-14 1452 /*
dd4ae78a21fc05 Yang Shi 2020-12-14 1453 * The rules are:
dd4ae78a21fc05 Yang Shi 2020-12-14 1454 * Success: non hugetlb page will be freed, hugetlb
dd4ae78a21fc05 Yang Shi 2020-12-14 1455 * page will be put back
dd4ae78a21fc05 Yang Shi 2020-12-14 1456 * -EAGAIN: stay on the from list
dd4ae78a21fc05 Yang Shi 2020-12-14 1457 * -ENOMEM: stay on the from list
dd4ae78a21fc05 Yang Shi 2020-12-14 1458 * Other errno: put on ret_pages list then splice to
dd4ae78a21fc05 Yang Shi 2020-12-14 1459 * from list
dd4ae78a21fc05 Yang Shi 2020-12-14 1460 */
e24f0b8f76cc3d Christoph Lameter 2006-06-23 1461 switch(rc) {
95a402c3847cc1 Christoph Lameter 2006-06-23 1462 case -ENOMEM:
94723aafb9e764 Michal Hocko 2018-04-10 1463 /*
94723aafb9e764 Michal Hocko 2018-04-10 1464 * THP migration might be unsupported or the
94723aafb9e764 Michal Hocko 2018-04-10 1465 * allocation could've failed so we should
94723aafb9e764 Michal Hocko 2018-04-10 1466 * retry on the same page with the THP split
94723aafb9e764 Michal Hocko 2018-04-10 1467 * to base pages.
94723aafb9e764 Michal Hocko 2018-04-10 1468 *
94723aafb9e764 Michal Hocko 2018-04-10 1469 * Head page is retried immediately and tail
94723aafb9e764 Michal Hocko 2018-04-10 1470 * pages are added to the tail of the list so
94723aafb9e764 Michal Hocko 2018-04-10 1471 * we encounter them after the rest of the list
94723aafb9e764 Michal Hocko 2018-04-10 1472 * is processed.
94723aafb9e764 Michal Hocko 2018-04-10 1473 */
6c5c7b9f335272 Zi Yan 2020-09-25 1474 if (is_thp) {
94723aafb9e764 Michal Hocko 2018-04-10 1475 lock_page(page);
94723aafb9e764 Michal Hocko 2018-04-10 1476 rc = split_huge_page_to_list(page, from);
94723aafb9e764 Michal Hocko 2018-04-10 1477 unlock_page(page);
94723aafb9e764 Michal Hocko 2018-04-10 1478 if (!rc) {
94723aafb9e764 Michal Hocko 2018-04-10 1479 list_safe_reset_next(page, page2, lru);
1a5bae25e3cf95 Anshuman Khandual 2020-08-11 1480 nr_thp_split++;
94723aafb9e764 Michal Hocko 2018-04-10 1481 goto retry;
94723aafb9e764 Michal Hocko 2018-04-10 1482 }
6c5c7b9f335272 Zi Yan 2020-09-25 1483
1a5bae25e3cf95 Anshuman Khandual 2020-08-11 1484 nr_thp_failed++;
1a5bae25e3cf95 Anshuman Khandual 2020-08-11 1485 nr_failed += nr_subpages;
1a5bae25e3cf95 Anshuman Khandual 2020-08-11 1486 goto out;
1a5bae25e3cf95 Anshuman Khandual 2020-08-11 1487 }
dfef2ef4027b13 David Rientjes 2016-05-20 1488 nr_failed++;
95a402c3847cc1 Christoph Lameter 2006-06-23 1489 goto out;
e24f0b8f76cc3d Christoph Lameter 2006-06-23 1490 case -EAGAIN:
1a5bae25e3cf95 Anshuman Khandual 2020-08-11 1491 if (is_thp) {
1a5bae25e3cf95 Anshuman Khandual 2020-08-11 1492 thp_retry++;
1a5bae25e3cf95 Anshuman Khandual 2020-08-11 1493 break;
1a5bae25e3cf95 Anshuman Khandual 2020-08-11 1494 }
b20a35035f983f Christoph Lameter 2006-03-22 1495 retry++;
e24f0b8f76cc3d Christoph Lameter 2006-06-23 1496 break;
78bd52097d0420 Rafael Aquini 2012-12-11 1497 case MIGRATEPAGE_SUCCESS:
1a5bae25e3cf95 Anshuman Khandual 2020-08-11 1498 if (is_thp) {
1a5bae25e3cf95 Anshuman Khandual 2020-08-11 1499 nr_thp_succeeded++;
1a5bae25e3cf95 Anshuman Khandual 2020-08-11 1500 nr_succeeded += nr_subpages;
1a5bae25e3cf95 Anshuman Khandual 2020-08-11 1501 break;
1a5bae25e3cf95 Anshuman Khandual 2020-08-11 1502 }
5647bc293ab15f Mel Gorman 2012-10-19 1503 nr_succeeded++;
e24f0b8f76cc3d Christoph Lameter 2006-06-23 1504 break;
e24f0b8f76cc3d Christoph Lameter 2006-06-23 1505 default:
354a3363363724 Naoya Horiguchi 2014-01-21 1506 /*
354a3363363724 Naoya Horiguchi 2014-01-21 1507 * Permanent failure (-EBUSY, -ENOSYS, etc.):
354a3363363724 Naoya Horiguchi 2014-01-21 1508 * unlike -EAGAIN case, the failed page is
354a3363363724 Naoya Horiguchi 2014-01-21 1509 * removed from migration page list and not
354a3363363724 Naoya Horiguchi 2014-01-21 1510 * retried in the next outer loop.
354a3363363724 Naoya Horiguchi 2014-01-21 1511 */
1a5bae25e3cf95 Anshuman Khandual 2020-08-11 1512 if (is_thp) {
1a5bae25e3cf95 Anshuman Khandual 2020-08-11 1513 nr_thp_failed++;
1a5bae25e3cf95 Anshuman Khandual 2020-08-11 1514 nr_failed += nr_subpages;
1a5bae25e3cf95 Anshuman Khandual 2020-08-11 1515 break;
1a5bae25e3cf95 Anshuman Khandual 2020-08-11 1516 }
b20a35035f983f Christoph Lameter 2006-03-22 1517 nr_failed++;
e24f0b8f76cc3d Christoph Lameter 2006-06-23 1518 break;
2d1db3b1170db4 Christoph Lameter 2006-06-23 1519 }
b20a35035f983f Christoph Lameter 2006-03-22 1520 }
b20a35035f983f Christoph Lameter 2006-03-22 1521 }
1a5bae25e3cf95 Anshuman Khandual 2020-08-11 1522 nr_failed += retry + thp_retry;
1a5bae25e3cf95 Anshuman Khandual 2020-08-11 1523 nr_thp_failed += thp_retry;
f2f81fb2b72b83 Vlastimil Babka 2015-11-05 1524 rc = nr_failed;
95a402c3847cc1 Christoph Lameter 2006-06-23 1525 out:
dd4ae78a21fc05 Yang Shi 2020-12-14 1526 /*
dd4ae78a21fc05 Yang Shi 2020-12-14 1527 * Put the permanent failure page back to migration list, they
dd4ae78a21fc05 Yang Shi 2020-12-14 1528 * will be put back to the right list by the caller.
dd4ae78a21fc05 Yang Shi 2020-12-14 1529 */
dd4ae78a21fc05 Yang Shi 2020-12-14 1530 list_splice(&ret_pages, from);
dd4ae78a21fc05 Yang Shi 2020-12-14 1531
5647bc293ab15f Mel Gorman 2012-10-19 1532 count_vm_events(PGMIGRATE_SUCCESS, nr_succeeded);
5647bc293ab15f Mel Gorman 2012-10-19 1533 count_vm_events(PGMIGRATE_FAIL, nr_failed);
1a5bae25e3cf95 Anshuman Khandual 2020-08-11 1534 count_vm_events(THP_MIGRATION_SUCCESS, nr_thp_succeeded);
1a5bae25e3cf95 Anshuman Khandual 2020-08-11 1535 count_vm_events(THP_MIGRATION_FAIL, nr_thp_failed);
1a5bae25e3cf95 Anshuman Khandual 2020-08-11 1536 count_vm_events(THP_MIGRATION_SPLIT, nr_thp_split);
1a5bae25e3cf95 Anshuman Khandual 2020-08-11 1537 trace_mm_migrate_pages(nr_succeeded, nr_failed, nr_thp_succeeded,
1a5bae25e3cf95 Anshuman Khandual 2020-08-11 1538 nr_thp_failed, nr_thp_split, mode, reason);
7b2a2d4a18fffa Mel Gorman 2012-10-19 1539
b20a35035f983f Christoph Lameter 2006-03-22 1540 if (!swapwrite)
b20a35035f983f Christoph Lameter 2006-03-22 1541 current->flags &= ~PF_SWAPWRITE;
b20a35035f983f Christoph Lameter 2006-03-22 1542
95a402c3847cc1 Christoph Lameter 2006-06-23 1543 return rc;
b20a35035f983f Christoph Lameter 2006-03-22 1544 }
b20a35035f983f Christoph Lameter 2006-03-22 1545
:::::: The code at line 1406 was first introduced by commit
:::::: 9c620e2bc5aa4256c102ada34e6c76204ed5898b mm: remove offlining arg to migrate_pages
:::::: TO: Hugh Dickins <hughd(a)google.com>
:::::: CC: Linus Torvalds <torvalds(a)linux-foundation.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
3 months, 4 weeks
[input:next 2732/2735] drivers/input/touchscreen/resistive-adc-touch.c:84 grts_cb() error: uninitialized symbol 'z2'.
by Dan Carpenter
tree: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next
head: 6cf3b3abbf0b3b778138c0f8936aa7820af62cfc
commit: fb082cd59afa7fbd3a610e9835050675040b1b99 [2732/2735] Input: resistive-adc-touch - add support for z1 and z2 channels
config: x86_64-randconfig-m001-20210526 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com>
New smatch warnings:
drivers/input/touchscreen/resistive-adc-touch.c:84 grts_cb() error: uninitialized symbol 'z2'.
drivers/input/touchscreen/resistive-adc-touch.c:88 grts_cb() error: uninitialized symbol 'x'.
drivers/input/touchscreen/resistive-adc-touch.c:101 grts_cb() error: uninitialized symbol 'y'.
Old smatch warnings:
drivers/input/touchscreen/resistive-adc-touch.c:101 grts_cb() error: uninitialized symbol 'x'.
drivers/input/touchscreen/resistive-adc-touch.c:109 grts_cb() error: uninitialized symbol 'y'.
vim +/z2 +84 drivers/input/touchscreen/resistive-adc-touch.c
aa132ffb6b0a18 Eugen Hristev 2018-05-22 56 static int grts_cb(const void *data, void *private)
aa132ffb6b0a18 Eugen Hristev 2018-05-22 57 {
aa132ffb6b0a18 Eugen Hristev 2018-05-22 58 const u16 *touch_info = data;
aa132ffb6b0a18 Eugen Hristev 2018-05-22 59 struct grts_state *st = private;
fb082cd59afa7f Oleksij Rempel 2021-05-25 60 unsigned int x, y, press = 0, z1 = 0, z2;
fb082cd59afa7f Oleksij Rempel 2021-05-25 61 unsigned int Rt, i;
aa132ffb6b0a18 Eugen Hristev 2018-05-22 62
fb082cd59afa7f Oleksij Rempel 2021-05-25 63 for (i = 0; i < ARRAY_SIZE(st->ch) && st->ch[i] != GRTS_CH_NONE; i++) {
fb082cd59afa7f Oleksij Rempel 2021-05-25 64 switch (st->ch[i]) {
fb082cd59afa7f Oleksij Rempel 2021-05-25 65 case GRTS_CH_X:
fb082cd59afa7f Oleksij Rempel 2021-05-25 66 x = touch_info[i];
fb082cd59afa7f Oleksij Rempel 2021-05-25 67 break;
fb082cd59afa7f Oleksij Rempel 2021-05-25 68 case GRTS_CH_Y:
fb082cd59afa7f Oleksij Rempel 2021-05-25 69 y = touch_info[i];
fb082cd59afa7f Oleksij Rempel 2021-05-25 70 break;
fb082cd59afa7f Oleksij Rempel 2021-05-25 71 case GRTS_CH_PRESSURE:
fb082cd59afa7f Oleksij Rempel 2021-05-25 72 press = touch_info[i];
fb082cd59afa7f Oleksij Rempel 2021-05-25 73 break;
fb082cd59afa7f Oleksij Rempel 2021-05-25 74 case GRTS_CH_Z1:
fb082cd59afa7f Oleksij Rempel 2021-05-25 75 z1 = touch_info[i];
fb082cd59afa7f Oleksij Rempel 2021-05-25 76 break;
fb082cd59afa7f Oleksij Rempel 2021-05-25 77 case GRTS_CH_Z2:
fb082cd59afa7f Oleksij Rempel 2021-05-25 78 z2 = touch_info[i];
fb082cd59afa7f Oleksij Rempel 2021-05-25 79 break;
fb082cd59afa7f Oleksij Rempel 2021-05-25 80 }
fb082cd59afa7f Oleksij Rempel 2021-05-25 81 }
fb082cd59afa7f Oleksij Rempel 2021-05-25 82
fb082cd59afa7f Oleksij Rempel 2021-05-25 83 if (z1) {
fb082cd59afa7f Oleksij Rempel 2021-05-25 @84 Rt = z2;
It's likely this is a false positive, but we can see why the static
checker would complain.
fb082cd59afa7f Oleksij Rempel 2021-05-25 85 Rt -= z1;
fb082cd59afa7f Oleksij Rempel 2021-05-25 86 Rt *= st->x_plate_ohms;
fb082cd59afa7f Oleksij Rempel 2021-05-25 87 Rt = DIV_ROUND_CLOSEST(Rt, 16);
fb082cd59afa7f Oleksij Rempel 2021-05-25 @88 Rt *= x;
fb082cd59afa7f Oleksij Rempel 2021-05-25 89 Rt /= z1;
fb082cd59afa7f Oleksij Rempel 2021-05-25 90 Rt = DIV_ROUND_CLOSEST(Rt, 256);
fb082cd59afa7f Oleksij Rempel 2021-05-25 91 /*
fb082cd59afa7f Oleksij Rempel 2021-05-25 92 * On increased pressure the resistance (Rt) is decreasing
fb082cd59afa7f Oleksij Rempel 2021-05-25 93 * so, convert values to make it looks as real pressure.
fb082cd59afa7f Oleksij Rempel 2021-05-25 94 */
fb082cd59afa7f Oleksij Rempel 2021-05-25 95 if (Rt < GRTS_DEFAULT_PRESSURE_MAX)
fb082cd59afa7f Oleksij Rempel 2021-05-25 96 press = GRTS_DEFAULT_PRESSURE_MAX - Rt;
fb082cd59afa7f Oleksij Rempel 2021-05-25 97 else
fb082cd59afa7f Oleksij Rempel 2021-05-25 98 press = 0;
fb082cd59afa7f Oleksij Rempel 2021-05-25 99 }
aa132ffb6b0a18 Eugen Hristev 2018-05-22 100
aa132ffb6b0a18 Eugen Hristev 2018-05-22 @101 if ((!x && !y) || (st->pressure && (press < st->pressure_min))) {
aa132ffb6b0a18 Eugen Hristev 2018-05-22 102 /* report end of touch */
aa132ffb6b0a18 Eugen Hristev 2018-05-22 103 input_report_key(st->input, BTN_TOUCH, 0);
aa132ffb6b0a18 Eugen Hristev 2018-05-22 104 input_sync(st->input);
aa132ffb6b0a18 Eugen Hristev 2018-05-22 105 return 0;
aa132ffb6b0a18 Eugen Hristev 2018-05-22 106 }
aa132ffb6b0a18 Eugen Hristev 2018-05-22 107
aa132ffb6b0a18 Eugen Hristev 2018-05-22 108 /* report proper touch to subsystem*/
aa132ffb6b0a18 Eugen Hristev 2018-05-22 109 touchscreen_report_pos(st->input, &st->prop, x, y, false);
aa132ffb6b0a18 Eugen Hristev 2018-05-22 110 if (st->pressure)
aa132ffb6b0a18 Eugen Hristev 2018-05-22 111 input_report_abs(st->input, ABS_PRESSURE, press);
aa132ffb6b0a18 Eugen Hristev 2018-05-22 112 input_report_key(st->input, BTN_TOUCH, 1);
aa132ffb6b0a18 Eugen Hristev 2018-05-22 113 input_sync(st->input);
aa132ffb6b0a18 Eugen Hristev 2018-05-22 114
aa132ffb6b0a18 Eugen Hristev 2018-05-22 115 return 0;
aa132ffb6b0a18 Eugen Hristev 2018-05-22 116 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
3 months, 4 weeks