Re: [PATCH] drm/vmwgfx: remove redundant ret variable
by kernel test robot
Hi,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on drm/drm-next]
[also build test WARNING on next-20220112]
[cannot apply to v5.16]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/cgel-zte-gmail-com/drm-vmwgfx-re...
base: git://anongit.freedesktop.org/drm/drm drm-next
config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20220113/202201130145.eexFh3na-lk...)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/3542ac844ea28aaa8528f5deb3ee52d16...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review cgel-zte-gmail-com/drm-vmwgfx-remove-redundant-ret-variable/20220112-162527
git checkout 3542ac844ea28aaa8528f5deb3ee52d1690f1f8a
# save the config file to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/gpu/drm/vmwgfx/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
drivers/gpu/drm/vmwgfx/vmwgfx_bo.c: In function 'vmw_dumb_create':
>> drivers/gpu/drm/vmwgfx/vmwgfx_bo.c:794:1: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
794 | void vmw_bo_swap_notify(struct ttm_buffer_object *bo)
| ^~~~
drivers/gpu/drm/vmwgfx/vmwgfx_bo.c:860:1: error: expected declaration or statement at end of input
860 | }
| ^
At top level:
drivers/gpu/drm/vmwgfx/vmwgfx_bo.c:853:6: warning: 'vmw_bo_is_vmw_bo' defined but not used [-Wunused-function]
853 | bool vmw_bo_is_vmw_bo(struct ttm_buffer_object *bo)
| ^~~~~~~~~~~~~~~~
drivers/gpu/drm/vmwgfx/vmwgfx_bo.c:815:6: warning: 'vmw_bo_move_notify' defined but not used [-Wunused-function]
815 | void vmw_bo_move_notify(struct ttm_buffer_object *bo,
| ^~~~~~~~~~~~~~~~~~
drivers/gpu/drm/vmwgfx/vmwgfx_bo.c:794:6: warning: 'vmw_bo_swap_notify' defined but not used [-Wunused-function]
794 | void vmw_bo_swap_notify(struct ttm_buffer_object *bo)
| ^~~~~~~~~~~~~~~~~~
vim +794 drivers/gpu/drm/vmwgfx/vmwgfx_bo.c
e9431ea5076a91 Thomas Hellstrom 2018-06-19 761
e9431ea5076a91 Thomas Hellstrom 2018-06-19 762
e9431ea5076a91 Thomas Hellstrom 2018-06-19 763 /**
e9431ea5076a91 Thomas Hellstrom 2018-06-19 764 * vmw_dumb_create - Create a dumb kms buffer
e9431ea5076a91 Thomas Hellstrom 2018-06-19 765 *
e9431ea5076a91 Thomas Hellstrom 2018-06-19 766 * @file_priv: Pointer to a struct drm_file identifying the caller.
e9431ea5076a91 Thomas Hellstrom 2018-06-19 767 * @dev: Pointer to the drm device.
e9431ea5076a91 Thomas Hellstrom 2018-06-19 768 * @args: Pointer to a struct drm_mode_create_dumb structure
e9431ea5076a91 Thomas Hellstrom 2018-06-19 769 * Return: Zero on success, negative error code on failure.
e9431ea5076a91 Thomas Hellstrom 2018-06-19 770 *
e9431ea5076a91 Thomas Hellstrom 2018-06-19 771 * This is a driver callback for the core drm create_dumb functionality.
e9431ea5076a91 Thomas Hellstrom 2018-06-19 772 * Note that this is very similar to the vmw_bo_alloc ioctl, except
e9431ea5076a91 Thomas Hellstrom 2018-06-19 773 * that the arguments have a different format.
e9431ea5076a91 Thomas Hellstrom 2018-06-19 774 */
e9431ea5076a91 Thomas Hellstrom 2018-06-19 775 int vmw_dumb_create(struct drm_file *file_priv,
e9431ea5076a91 Thomas Hellstrom 2018-06-19 776 struct drm_device *dev,
e9431ea5076a91 Thomas Hellstrom 2018-06-19 777 struct drm_mode_create_dumb *args)
e9431ea5076a91 Thomas Hellstrom 2018-06-19 778 {
e9431ea5076a91 Thomas Hellstrom 2018-06-19 779 struct vmw_private *dev_priv = vmw_priv(dev);
e9431ea5076a91 Thomas Hellstrom 2018-06-19 780 struct vmw_buffer_object *vbo;
e9431ea5076a91 Thomas Hellstrom 2018-06-19 781
e9431ea5076a91 Thomas Hellstrom 2018-06-19 782 args->pitch = args->width * ((args->bpp + 7) / 8);
8afa13a0583f94 Zack Rusin 2021-12-06 783 args->size = ALIGN(args->pitch * args->height, PAGE_SIZE);
e9431ea5076a91 Thomas Hellstrom 2018-06-19 784
3542ac844ea28a Minghao Chi 2022-01-12 785 return vmw_gem_object_create_with_handle(dev_priv, file_priv,
8afa13a0583f94 Zack Rusin 2021-12-06 786 args->size, &args->handle,
8afa13a0583f94 Zack Rusin 2021-12-06 787 &vbo);
e9431ea5076a91 Thomas Hellstrom 2018-06-19 788
e9431ea5076a91 Thomas Hellstrom 2018-06-19 789 /**
e9431ea5076a91 Thomas Hellstrom 2018-06-19 790 * vmw_bo_swap_notify - swapout notify callback.
e9431ea5076a91 Thomas Hellstrom 2018-06-19 791 *
e9431ea5076a91 Thomas Hellstrom 2018-06-19 792 * @bo: The buffer object to be swapped out.
e9431ea5076a91 Thomas Hellstrom 2018-06-19 793 */
e9431ea5076a91 Thomas Hellstrom 2018-06-19 @794 void vmw_bo_swap_notify(struct ttm_buffer_object *bo)
e9431ea5076a91 Thomas Hellstrom 2018-06-19 795 {
e9431ea5076a91 Thomas Hellstrom 2018-06-19 796 /* Is @bo embedded in a struct vmw_buffer_object? */
8afa13a0583f94 Zack Rusin 2021-12-06 797 if (vmw_bo_is_vmw_bo(bo))
e9431ea5076a91 Thomas Hellstrom 2018-06-19 798 return;
e9431ea5076a91 Thomas Hellstrom 2018-06-19 799
e9431ea5076a91 Thomas Hellstrom 2018-06-19 800 /* Kill any cached kernel maps before swapout */
e9431ea5076a91 Thomas Hellstrom 2018-06-19 801 vmw_bo_unmap(vmw_buffer_object(bo));
e9431ea5076a91 Thomas Hellstrom 2018-06-19 802 }
e9431ea5076a91 Thomas Hellstrom 2018-06-19 803
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
2 months, 2 weeks
/bin/bash: line 1: 45878 Segmentation fault sparse -D__linux__ -Dlinux -D__STDC__ -Dunix -D__unix__ -Wbitwise -Wno-return-void -Wno-unknown-attribute -fdiagnostic-prefix -D__CHECK_ENDIAN__ -D__NDS32_EL__ --arch=nds32 -mlittle-endian -m32 -Wp,-MMD,ker...
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 66f4beaa6c1d28161f534471484b2daa2de1dce0
commit: 60f2415e19d3948641149ac6aca137a7be1d1952 sched: Make schedstats helpers independent of fair sched class
date: 6 weeks ago
config: nds32-randconfig-s031-20211015 (attached as .config)
compiler: nds32le-linux-gcc (GCC) 11.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.4-dirty
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit...
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 60f2415e19d3948641149ac6aca137a7be1d1952
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=nds32
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
include/linux/rtmutex.h:68:58: sparse: sparse: got $
kernel/sched/fair.c: note: in included file (through include/linux/sched.h, kernel/sched/sched.h):
include/linux/seccomp.h:96:63: sparse: sparse: Expected ) in function declarator
include/linux/seccomp.h:96:63: sparse: sparse: got $
include/linux/seccomp.h:99:1: sparse: sparse: Expected ; at the end of type declaration
include/linux/seccomp.h:99:1: sparse: sparse: got }
include/linux/seccomp.h:103:1: sparse: sparse: Expected ; at the end of type declaration
include/linux/seccomp.h:103:1: sparse: sparse: got }
include/linux/seccomp.h:116:1: sparse: sparse: Expected ; at the end of type declaration
include/linux/seccomp.h:116:1: sparse: sparse: got }
include/linux/seccomp.h:122:1: sparse: sparse: Expected ; at the end of type declaration
include/linux/seccomp.h:122:1: sparse: sparse: got }
kernel/sched/fair.c: note: in included file (through include/linux/nodemask.h, include/linux/sched.h, kernel/sched/sched.h):
include/linux/numa.h:50:1: sparse: sparse: Expected ; at the end of type declaration
include/linux/numa.h:50:1: sparse: sparse: got }
include/linux/numa.h:54:1: sparse: sparse: Expected ; at the end of type declaration
include/linux/numa.h:54:1: sparse: sparse: got }
include/linux/numa.h:58:1: sparse: sparse: Expected ; at the end of type declaration
include/linux/numa.h:58:1: sparse: sparse: got }
kernel/sched/fair.c: note: in included file (through include/linux/sched.h, kernel/sched/sched.h):
include/linux/nodemask.h:98:54: sparse: sparse: Expected ; at the end of type declaration
include/linux/nodemask.h:98:54: sparse: sparse: got }
include/linux/nodemask.h:99:19: sparse: sparse: Expected ; at end of declaration
include/linux/nodemask.h:99:19: sparse: sparse: got _unused_nodemask_arg_
include/linux/nodemask.h:109:68: sparse: sparse: Expected ) in function declarator
include/linux/nodemask.h:109:68: sparse: sparse: got *
include/linux/nodemask.h:112:1: sparse: sparse: Expected ; at the end of type declaration
include/linux/nodemask.h:112:1: sparse: sparse: got }
include/linux/nodemask.h:116:1: sparse: sparse: Expected ; at the end of type declaration
include/linux/nodemask.h:116:1: sparse: sparse: got }
include/linux/nodemask.h:131:1: sparse: sparse: Expected ; at the end of type declaration
include/linux/nodemask.h:131:1: sparse: sparse: got }
include/linux/nodemask.h:137:1: sparse: sparse: Expected ; at the end of type declaration
include/linux/nodemask.h:137:1: sparse: sparse: got }
include/linux/nodemask.h:143:1: sparse: sparse: Expected ; at the end of type declaration
include/linux/nodemask.h:143:1: sparse: sparse: got }
include/linux/nodemask.h:149:1: sparse: sparse: Expected ; at the end of type declaration
include/linux/nodemask.h:149:1: sparse: sparse: got }
include/linux/nodemask.h:159:1: sparse: sparse: Expected ; at the end of type declaration
include/linux/nodemask.h:159:1: sparse: sparse: got }
include/linux/nodemask.h:167:1: sparse: sparse: Expected ; at the end of type declaration
include/linux/nodemask.h:167:1: sparse: sparse: got }
include/linux/nodemask.h:175:1: sparse: sparse: Expected ; at the end of type declaration
include/linux/nodemask.h:175:1: sparse: sparse: got }
include/linux/nodemask.h:183:1: sparse: sparse: Expected ; at the end of type declaration
include/linux/nodemask.h:183:1: sparse: sparse: got }
include/linux/nodemask.h:191:1: sparse: sparse: Expected ; at the end of type declaration
include/linux/nodemask.h:191:1: sparse: sparse: got }
include/linux/nodemask.h:199:1: sparse: sparse: Expected ; at the end of type declaration
include/linux/nodemask.h:199:1: sparse: sparse: got }
include/linux/nodemask.h:207:1: sparse: sparse: Expected ; at the end of type declaration
include/linux/nodemask.h:207:1: sparse: sparse: got }
include/linux/nodemask.h:215:1: sparse: sparse: Expected ; at the end of type declaration
include/linux/nodemask.h:215:1: sparse: sparse: got }
include/linux/nodemask.h:223:1: sparse: sparse: Expected ; at the end of type declaration
include/linux/nodemask.h:223:1: sparse: sparse: got }
include/linux/nodemask.h:229:1: sparse: sparse: Expected ; at the end of type declaration
include/linux/nodemask.h:229:1: sparse: sparse: got }
include/linux/nodemask.h:235:1: sparse: sparse: Expected ; at the end of type declaration
include/linux/nodemask.h:235:1: sparse: sparse: got }
include/linux/nodemask.h:241:1: sparse: sparse: Expected ; at the end of type declaration
include/linux/nodemask.h:241:1: sparse: sparse: got }
include/linux/nodemask.h:249:1: sparse: sparse: Expected ; at the end of type declaration
include/linux/nodemask.h:249:1: sparse: sparse: got }
include/linux/nodemask.h:257:1: sparse: sparse: Expected ; at the end of type declaration
include/linux/nodemask.h:257:1: sparse: sparse: got }
include/linux/nodemask.h:265:16: sparse: sparse: Expected ) in nested declarator
include/linux/nodemask.h:265:16: sparse: sparse: got <
include/linux/nodemask.h:265:16: sparse: sparse: Expected ; at the end of type declaration
include/linux/nodemask.h:265:16: sparse: sparse: got }
include/linux/nodemask.h:266:1: sparse: sparse: Expected ; at the end of type declaration
include/linux/nodemask.h:266:1: sparse: sparse: got }
include/linux/nodemask.h:271:16: sparse: sparse: Expected ) in nested declarator
include/linux/nodemask.h:271:16: sparse: sparse: got <
include/linux/nodemask.h:271:16: sparse: sparse: Expected ; at the end of type declaration
include/linux/nodemask.h:271:16: sparse: sparse: got }
include/linux/nodemask.h:272:1: sparse: sparse: Expected ; at the end of type declaration
include/linux/nodemask.h:272:1: sparse: sparse: got }
include/linux/nodemask.h:281:53: sparse: sparse: Expected ) in function declarator
include/linux/nodemask.h:281:53: sparse: sparse: got *
include/linux/nodemask.h:284:9: sparse: sparse: Expected ) in function declarator
include/linux/nodemask.h:284:9: sparse: sparse: got (
include/linux/nodemask.h:285:1: sparse: sparse: Expected ; at the end of type declaration
include/linux/nodemask.h:285:1: sparse: sparse: got }
include/linux/nodemask.h:301:16: sparse: sparse: Expected ) in nested declarator
include/linux/nodemask.h:301:16: sparse: sparse: got <
include/linux/nodemask.h:301:16: sparse: sparse: Expected ; at the end of type declaration
include/linux/nodemask.h:301:16: sparse: sparse: got }
include/linux/nodemask.h:303:1: sparse: sparse: Expected ; at the end of type declaration
include/linux/nodemask.h:303:1: sparse: sparse: got }
include/linux/nodemask.h:337:1: sparse: sparse: Expected ; at the end of type declaration
include/linux/nodemask.h:337:1: sparse: sparse: got }
include/linux/nodemask.h:343:1: sparse: sparse: Expected ; at the end of type declaration
include/linux/nodemask.h:343:1: sparse: sparse: got }
include/linux/nodemask.h:351:1: sparse: sparse: Expected ; at the end of type declaration
include/linux/nodemask.h:351:1: sparse: sparse: got }
include/linux/nodemask.h:359:1: sparse: sparse: Expected ; at the end of type declaration
include/linux/nodemask.h:359:1: sparse: sparse: got }
include/linux/nodemask.h:367:1: sparse: sparse: Expected ; at the end of type declaration
include/linux/nodemask.h:367:1: sparse: sparse: too many errors
>> /bin/bash: line 1: 45878 Segmentation fault sparse -D__linux__ -Dlinux -D__STDC__ -Dunix -D__unix__ -Wbitwise -Wno-return-void -Wno-unknown-attribute -fdiagnostic-prefix -D__CHECK_ENDIAN__ -D__NDS32_EL__ --arch=nds32 -mlittle-endian -m32 -Wp,-MMD,kernel/sched/.fair.o.d -nostdinc -isystem /opt/cross/gcc-11.2.0-nolibc/nds32le-linux/bin/../lib/gcc/nds32le-linux/11.2.0/include -Iarch/nds32/include -I./arch/nds32/include/generated -Iinclude -I./include -Iarch/nds32/include/uapi -I./arch/nds32/include/generated/uapi -Iinclude/uapi -I./include/generated/uapi -include include/linux/compiler-version.h -include include/linux/kconfig.h -include include/linux/compiler_types.h -D__KERNEL__ -fmacro-prefix-map== -DKBUILD_EXTRA_WARN1 -Wall -Wundef -Werror=strict-prototypes -Wno-trigraphs -fno-strict-aliasing -fno-common -fshort-wchar -fno-PIE -Werror=implicit-function-declaration -Werror=implicit-int -Werror=return-type -Wno-format-security -std=gnu89 -mno-sched-prolog-epilog -mcmodel=large -mno-ext-fpu-sp -mno-ext-fpu-dp -mfloat-abi=soft -EL -fno-delete-null-pointer-checks -Wno-frame-address -Wno-format-truncation -Wno-format-overflow -Wno-address-of-packed-member -O2 -fno-allow-store-data-races -Wframe-larger-than=1024 -fno-stack-protector -Wimplicit-fallthrough=5 -Wno-main -Wno-unused-but-set-variable -Wno-unused-const-variable -fno-omit-frame-pointer -fno-optimize-sibling-calls -fno-stack-clash-protection -fno-inline-functions-called-once -falign-functions=64 -Wdeclaration-after-statement -Wvla -Wno-pointer-sign -Wno-stringop-truncation -Wno-zero-length-bounds -Wno-array-bounds -Wno-stringop-overflow -Wno-restrict -Wno-maybe-uninitialized -fno-strict-overflow -fno-stack-check -fconserve-stack -Werror=date-time -Werror=incompatible-pointer-types -Werror=designated-init -Wno-packed-not-aligned -Wextra -Wunused -Wno-unused-parameter -Wmissing-declarations -Wmissing-format-attribute -Wmissing-prototypes -Wold-style-definition -Wmissing-include-dirs -Wunused-but-set-variable -Wunused-const-variable -Wpacked-not-aligned -Wstringop-truncation -Wno-missing-field-initializers -Wno-sign-compare -Wno-type-limits -I kernel/sched -I ./kernel/sched -DKBUILD_MODFILE='"kernel/sched/fair"' -DKBUILD_BASENAME='"fair"' -DKBUILD_MODNAME='"fair"' -D__KBUILD_MODNAME=kmod_fair kernel/sched/fair.c
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
3 months, 3 weeks
Re: [PATCH v3 4/4] mtd: phram: Allow cached mappings
by Vincent Whitchurch
On Wed, Apr 13, 2022 at 08:45:59AM +0200, kernel test robot wrote:
> All errors (new ones prefixed by >>):
>
> In file included from include/linux/io.h:13,
> from drivers/mtd/devices/phram.c:21:
> drivers/mtd/devices/phram.c: In function 'register_device':
> >> arch/sh/include/asm/io.h:274:33: error: expected expression before 'do'
> 274 | #define iounmap(addr) do { } while (0)
> | ^~
> drivers/mtd/devices/phram.c:150:44: note: in expansion of macro 'iounmap'
> 150 | cached ? memunmap(new->mtd.priv) : iounmap(new->mtd.priv);
> | ^~~~~~~
> drivers/mtd/devices/phram.c: In function 'phram_remove':
> >> arch/sh/include/asm/io.h:274:33: error: expected expression before 'do'
> 274 | #define iounmap(addr) do { } while (0)
> | ^~
> drivers/mtd/devices/phram.c:372:53: note: in expansion of macro 'iounmap'
> 372 | phram->cached ? memunmap(phram->mtd.priv) : iounmap(phram->mtd.priv);
> | ^~~~~~~
>
>
> vim +/do +274 arch/sh/include/asm/io.h
>
> d57d64080ddc0f Paul Mundt 2010-01-19 272
> 13f1fc870dd747 Christoph Hellwig 2020-07-14 273 #else /* CONFIG_MMU */
> 13f1fc870dd747 Christoph Hellwig 2020-07-14 @274 #define iounmap(addr) do { } while (0)
> 13f1fc870dd747 Christoph Hellwig 2020-07-14 275 #define ioremap(offset, size) ((void __iomem *)(unsigned long)(offset))
> 13f1fc870dd747 Christoph Hellwig 2020-07-14 276 #endif /* CONFIG_MMU */
> d627a2ebd1a303 Paul Mundt 2010-01-28 277
Thank you for the report. This patch could certainly be changed to work
around this, but ISTM that the right fix is in the SH header file, since
the problem could hit in other cases too. I've posted a fix here now:
https://lore.kernel.org/lkml/20220414081257.1487499-1-vincent.whitchurch@...
4 months, 3 weeks
[Patch v3 0/9] CBB driver for Tegra194, Tegra234 & Tegra-Grace
by Sumit Gupta
The patch series adds Control BackBone(CBB) error handling
driver for Tegra194, Tegra234 and Tegra-Grace SOC's.
Tegra194 is using CBB version 1.0. Tegra234 and Tegra-Grace
are using CBB version 2.0. Both CBB1.0 and CBB2.0 have
different internal architecture. So, separate drivers are
required.
Tegra194 and Tegra234 are using Device Tree. Tegra-Grace is
using ACPI.
---
v2 -> v3:
- fixed warnings with GCC 11.2 and W=1 reported by kernel test robot.
- changed some function names to make consistent with tegra_cbb_*.
v1 -> v2:
- moved err-notifier-base and off-mask-erd from DT to driver.
- yaml fixes by Thierry.
Sumit Gupta (9):
soc: tegra: set ERD bit to mask inband errors
dt-bindings: arm: tegra: Add NVIDIA Tegra194 CBB1.0 binding
dt-bindings: arm: tegra: Add NVIDIA Tegra194 axi2apb binding
arm64: tegra: Add node for CBB1.0 in Tegra194 SOC
soc: tegra: cbb: Add CBB1.0 driver for Tegra194
dt-bindings: arm: tegra: Add NVIDIA Tegra234 CBB2.0 binding
arm64: tegra: Add node for CBB2.0 in Tegra234 SOC
soc: tegra: cbb: Add driver for Tegra234 CBB2.0
soc: tegra: cbb: Add support for tegra-grace SOC
.../arm/tegra/nvidia,tegra194-axi2apb.yaml | 40 +
.../arm/tegra/nvidia,tegra194-cbb.yaml | 93 +
.../arm/tegra/nvidia,tegra234-cbb.yaml | 70 +
arch/arm64/boot/dts/nvidia/tegra194.dtsi | 62 +-
arch/arm64/boot/dts/nvidia/tegra234.dtsi | 42 +
drivers/soc/tegra/Kconfig | 9 +
drivers/soc/tegra/Makefile | 1 +
drivers/soc/tegra/cbb/Makefile | 9 +
drivers/soc/tegra/cbb/tegra-cbb.c | 198 ++
drivers/soc/tegra/cbb/tegra194-cbb.c | 2261 +++++++++++++++++
drivers/soc/tegra/cbb/tegra234-cbb.c | 829 ++++++
drivers/soc/tegra/fuse/tegra-apbmisc.c | 29 +-
include/soc/tegra/fuse.h | 6 +
include/soc/tegra/tegra-cbb.h | 43 +
include/soc/tegra/tegra-grace-cbb.h | 219 ++
include/soc/tegra/tegra194-cbb.h | 158 ++
include/soc/tegra/tegra234-cbb.h | 342 +++
17 files changed, 4408 insertions(+), 3 deletions(-)
create mode 100644 Documentation/devicetree/bindings/arm/tegra/nvidia,tegra194-axi2apb.yaml
create mode 100644 Documentation/devicetree/bindings/arm/tegra/nvidia,tegra194-cbb.yaml
create mode 100644 Documentation/devicetree/bindings/arm/tegra/nvidia,tegra234-cbb.yaml
create mode 100644 drivers/soc/tegra/cbb/Makefile
create mode 100644 drivers/soc/tegra/cbb/tegra-cbb.c
create mode 100644 drivers/soc/tegra/cbb/tegra194-cbb.c
create mode 100644 drivers/soc/tegra/cbb/tegra234-cbb.c
create mode 100644 include/soc/tegra/tegra-cbb.h
create mode 100644 include/soc/tegra/tegra-grace-cbb.h
create mode 100644 include/soc/tegra/tegra194-cbb.h
create mode 100644 include/soc/tegra/tegra234-cbb.h
--
2.17.1
5 months
Re: [External] [mark:arm64/ftrace/per-callsite-ops 1/6] kernel/trace/fgraph.c:37:12: warning: no previous prototype for 'ftrace_enable_ftrace_graph_caller'
by Chengming Zhou
On 2022/4/30 07:56, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/mark/linux.git arm64/ftrace/per-callsite-ops
> head: 2aaba224d039a36f7eca5ad68c77686d3546e4fa
> commit: 718b0fd1ccf6f04340cb3ad48b667ca05bb7a31c [1/6] ftrace: cleanup ftrace_graph_caller enable and disable
> config: sh-buildonly-randconfig-r002-20220428 (https://download.01.org/0day-ci/archive/20220430/202204300758.ces9aD6G-lk...)
> compiler: sh4-linux-gcc (GCC) 11.3.0
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://git.kernel.org/pub/scm/linux/kernel/git/mark/linux.git/commit/?id...
> git remote add mark https://git.kernel.org/pub/scm/linux/kernel/git/mark/linux.git
> git fetch --no-tags mark arm64/ftrace/per-callsite-ops
> git checkout 718b0fd1ccf6f04340cb3ad48b667ca05bb7a31c
> # save the config file
> mkdir build_dir && cp config build_dir/.config
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=sh SHELL=/bin/bash kernel/trace/
>
Thanks for the report.
BTW, there are so many "-Wmissing-prototypes" warnings if build kernel with "W=1"...
I can't reproduce this warning on x86_64 because the declarations in <linux/ftrace.h>
#ifdef CONFIG_DYNAMIC_FTRACE
...
#ifdef CONFIG_FUNCTION_GRAPH_TRACER
extern void ftrace_graph_caller(void);
extern int ftrace_enable_ftrace_graph_caller(void);
extern int ftrace_disable_ftrace_graph_caller(void);
#else
static inline int ftrace_enable_ftrace_graph_caller(void) { return 0; }
static inline int ftrace_disable_ftrace_graph_caller(void) { return 0; }
#endif
...
#endif
Since x86_64 select HAVE_FUNCTION_GRAPH_TRACER only when DYNAMIC_FTRACE,
so these declarations can be seen by fgraph.c
But on ARCH=sh, HAVE_FUNCTION_GRAPH_TRACER can be selected when !DYNAMIC_FTRACE,
so these declarations can't be seen by fgraph.c. But in this case, these
functions are not used anywhere. So there are no real problems exist.
Maybe it's better to put ftrace_[enable,disable]_ftrace_graph_caller definitions
in "#ifdef CONFIG_DYNAMIC_FTRACE" in fgraph.c, to suppress this warning.
Thanks.
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp(a)intel.com>
>
> All warnings (new ones prefixed by >>):
>
>>> kernel/trace/fgraph.c:37:12: warning: no previous prototype for 'ftrace_enable_ftrace_graph_caller' [-Wmissing-prototypes]
> 37 | int __weak ftrace_enable_ftrace_graph_caller(void)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>> kernel/trace/fgraph.c:46:12: warning: no previous prototype for 'ftrace_disable_ftrace_graph_caller' [-Wmissing-prototypes]
> 46 | int __weak ftrace_disable_ftrace_graph_caller(void)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> kernel/trace/fgraph.c:241:15: warning: no previous prototype for 'ftrace_return_to_handler' [-Wmissing-prototypes]
> 241 | unsigned long ftrace_return_to_handler(unsigned long frame_pointer)
> | ^~~~~~~~~~~~~~~~~~~~~~~~
> kernel/trace/fgraph.c:356:6: warning: no previous prototype for 'ftrace_graph_sleep_time_control' [-Wmissing-prototypes]
> 356 | void ftrace_graph_sleep_time_control(bool enable)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
>
> vim +/ftrace_enable_ftrace_graph_caller +37 kernel/trace/fgraph.c
>
> 32
> 33 /*
> 34 * archs can override this function if they must do something
> 35 * to enable hook for graph tracer.
> 36 */
> > 37 int __weak ftrace_enable_ftrace_graph_caller(void)
> 38 {
> 39 return 0;
> 40 }
> 41
> 42 /*
> 43 * archs can override this function if they must do something
> 44 * to disable hook for graph tracer.
> 45 */
> > 46 int __weak ftrace_disable_ftrace_graph_caller(void)
> 47 {
> 48 return 0;
> 49 }
> 50
>
5 months
