I see the CI robot complains. There are two issues to be addressed.
One is about "No prototype for kvm_ptp_arch_xxx". As all of the prototype of
these functions lie in "driver/ptp/ptp_kvm.h" for now. we can include the
header file in the source code file where define these functions to cancel that issue.
But the " kvm_arch_ptp_get_crosststamp" lies in
"driver/clocksource/arm_arch_timer.c" which is also need include
"ptp_kvm.h". so what about move "ptp_kvm.h" to other place under
"linux/include", eg. "include/kvm/".
Another problem shows in the end of this page. It derives from the patch 1/9. Will
introduces " kvm_init_hyp_services" in arch/arm64/kernel/setup.c and I moved its
definition into "driver/firmware/smccc/smccc.c" to let both arm and arm64 can
use it. But it is also called in "setup.c", so it seems that setup.c depends on
smccc.c. However, I find that it's difficult to add the dependency for setup.c , so
what about adding a macro switch for "kvm_init_hyp_services" in setup.c like:
Also it seems "arm_arch_timer.c" depends on "smccc.c" as
kvm_arch_ptp_get_crosststamp is defined in it. Therefore, can "
HAVE_ARM_SMCCC_DISCOVERY' be added to the dependency of "ARM_ARCH_TIMER"?
From: kernel test robot <lkp(a)intel.com>
Sent: Wednesday, November 11, 2020 9:44 PM
To: Jianyong Wu <Jianyong.Wu(a)arm.com>; netdev(a)vger.kernel.org;
yangbo.lu(a)nxp.com; john.stultz(a)linaro.org; tglx(a)linutronix.de;
pbonzini(a)redhat.com; sean.j.christopherson(a)intel.com; maz(a)kernel.org;
richardcochran(a)gmail.com; Mark Rutland <Mark.Rutland(a)arm.com>;
Subject: Re: [PATCH v15 7/9] ptp: arm/arm64: Enable ptp_kvm for
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v5.10-rc3 next-20201111] [cannot apply to
tip/timers/core kvmarm/next kvm/linux-next] [If your patch is applied to the
wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
config: arm-milbeaut_m10v_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0 reproduce (this is a W=1 build):
tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Jianyong-Wu/Enable-ptp_kvm-for-arm-
git checkout 94d44d1bc7bec0d91d4c4851dd935a752bffe07d
# save the attached .config to linux build tree
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
arch/arm/vfp/vfphw.o: in function `vfp_support_entry':
(.text+0xa): relocation truncated to fit: R_ARM_THM_JUMP19 against
symbol `vfp_kmode_exception' defined in .text.unlikely section in
arm-linux-gnueabi-ld: arch/arm/kernel/setup.o: in function `setup_arch':
setup.c:(.init.text+0xaa2): undefined reference to `kvm_init_hyp_services'
arm-linux-gnueabi-ld: drivers/clocksource/arm_arch_timer.o: in function
>> arm_arch_timer.c:(.text+0x202): undefined reference to
0-DAY CI Kernel Test Service, Intel Corporation
IMPORTANT NOTICE: The
contents of this email and any attachments are confidential and may also be privileged. If
you are not the intended recipient, please notify the sender immediately and do not
disclose the contents to any other person, use it for any purpose, or store or copy the
information in any medium. Thank you.