WARNING: CPU: 0 PID: 61 at kernel/sched/core.c:7312 __might_sleep()
by Fengguang Wu
Greetings,
0day kernel testing robot got the below dmesg and the first bad commit is
git://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git sched/wait
commit 245747099820df3007f60128b1264fef9d2a69d2
Author: Peter Zijlstra <peterz(a)infradead.org>
AuthorDate: Wed Sep 24 10:18:55 2014 +0200
Commit: Peter Zijlstra <peterz(a)infradead.org>
CommitDate: Mon Oct 27 10:42:51 2014 +0100
sched: Debug nested sleeps
Validate we call might_sleep() with TASK_RUNNING, which catches places
where we nest blocking primitives, eg. mutex usage in a wait loop.
Since all blocking is arranged through task_struct::state, nesting
this will cause the inner primitive to set TASK_RUNNING and the outer
will thus not block.
Another observed problem is calling a blocking function from
schedule()->sched_submit_work()->blk_schedule_flush_plug() which will
then destroy the task state for the actual __schedule() call that
comes after it.
Cc: torvalds(a)linux-foundation.org
Cc: tglx(a)linutronix.de
Cc: ilya.dryomov(a)inktank.com
Cc: umgwanakikbuti(a)gmail.com
Cc: mingo(a)kernel.org
Cc: oleg(a)redhat.com
Signed-off-by: Peter Zijlstra (Intel) <peterz(a)infradead.org>
Link: http://lkml.kernel.org/r/20140924082242.591637616@infradead.org
===================================================
PARENT COMMIT NOT CLEAN. LOOK OUT FOR WRONG BISECT!
===================================================
120 /kernel/i386-randconfig-r2-1027/592ed717ef33150f6888c333c28021283cc9aabc
To bisect errors in parent:
/c/kernel-tests/queue-reproduce /kernel/i386-randconfig-r2-1027/592ed717ef33150f6888c333c28021283cc9aabc/dmesg-quantal-kbuild-20:20141027231410:i386-randconfig-r2-1027:3.18.0-rc2-00036-g592ed71:139 BUG: kernel test crashed
Attached dmesg for the parent commit, too, to help confirm whether it is a noise error.
+---------------------------------------------------+------------+------------+------------+
| | 592ed717ef | 2457470998 | 2d55520314 |
+---------------------------------------------------+------------+------------+------------+
| boot_successes | 1080 | 267 | 110 |
| boot_failures | 120 | 33 | 21 |
| BUG:kernel_test_crashed | 110 | 30 | 16 |
| WARNING:at_kernel/locking/lockdep.c:check_flags() | 10 | 0 | 3 |
| backtrace:might_fault | 2 | | |
| backtrace:SyS_perf_event_open | 3 | 0 | 1 |
| backtrace:mutex_lock_nested | 1 | | |
| WARNING:at_kernel/sched/core.c:__might_sleep() | 0 | 3 | 2 |
| backtrace:cleanup_net | 0 | 3 | 2 |
| backtrace:register_perf_hw_breakpoint | 0 | 0 | 1 |
| backtrace:hw_breakpoint_event_init | 0 | 0 | 1 |
| backtrace:perf_init_event | 0 | 0 | 1 |
| backtrace:perf_event_alloc | 0 | 0 | 1 |
+---------------------------------------------------+------------+------------+------------+
[ 122.133640] Fix your initscripts?
[ 122.133905] trinity-c0 (23733) uses deprecated remap_file_pages() syscall. See Documentation/vm/remap_file_pages.txt.
[ 122.247299] ------------[ cut here ]------------
[ 122.247328] WARNING: CPU: 0 PID: 61 at kernel/sched/core.c:7312 __might_sleep+0x50/0x249()
[ 122.247334] do not call blocking ops when !TASK_RUNNING; state=2 set at [<c106ffd9>] prepare_to_wait+0x3c/0x5f
[ 122.247339] Modules linked in:
[ 122.247349] CPU: 0 PID: 61 Comm: kworker/u2:1 Not tainted 3.18.0-rc2-00037-g24574709 #136
[ 122.247350] Hardware name: Bochs Bochs, BIOS Bochs 01/01/2011
[ 122.247368] Workqueue: netns cleanup_net
[ 122.247377] c1071d83 d2b83dd8 d2b83dac c15887b1 d2b83dc8 c104c4c6 00001c90 c1068ebf
[ 122.247383] 00000000 c17b67e3 0000026d d2b83de0 c104c508 00000009 d2b83dd8 c17b5d4b
[ 122.247388] d2b83df4 d2b83e0c c1068ebf c17b5cec 00001c90 c17b5d4b 00000002 c106ffd9
[ 122.247389] Call Trace:
[ 122.247393] [<c1071d83>] ? down_trylock+0x23/0x2c
[ 122.247402] [<c15887b1>] dump_stack+0x16/0x18
[ 122.247413] [<c104c4c6>] warn_slowpath_common+0x66/0x7d
[ 122.247416] [<c1068ebf>] ? __might_sleep+0x50/0x249
[ 122.247419] [<c104c508>] warn_slowpath_fmt+0x2b/0x2f
[ 122.247422] [<c1068ebf>] __might_sleep+0x50/0x249
[ 122.247424] [<c106ffd9>] ? prepare_to_wait+0x3c/0x5f
[ 122.247426] [<c106ffd9>] ? prepare_to_wait+0x3c/0x5f
[ 122.247432] [<c158c364>] mutex_lock_nested+0x23/0x347
[ 122.247436] [<c1075105>] ? trace_hardirqs_on+0xb/0xd
[ 122.247439] [<c158eb0c>] ? _raw_spin_unlock_irqrestore+0x66/0x78
[ 122.247445] [<c1570e10>] rtnl_lock+0x14/0x16
[ 122.247449] [<c156516b>] default_device_exit_batch+0x54/0xf3
[ 122.247452] [<c1570e1f>] ? rtnl_unlock+0xd/0xf
[ 122.247454] [<c1070233>] ? __wake_up_sync+0x12/0x12
[ 122.247461] [<c155e35d>] ops_exit_list+0x20/0x40
[ 122.247464] [<c155ec96>] cleanup_net+0xbe/0x140
[ 122.247473] [<c105ffe4>] process_one_work+0x29e/0x643
[ 122.247479] [<c1061215>] worker_thread+0x23a/0x311
[ 122.247482] [<c1060fdb>] ? rescuer_thread+0x204/0x204
[ 122.247486] [<c10648cc>] kthread+0xbe/0xc3
[ 122.247490] [<c158f4c0>] ret_from_kernel_thread+0x20/0x30
[ 122.247492] [<c106480e>] ? kthread_stop+0x364/0x364
[ 122.247495] ---[ end trace 2073c37ae3c8b3b4 ]---
[ 157.390879] Unregister pv shared memory for cpu 0
git bisect start 2d55520314eb5603b855ac1b994705dc6a352d9e 522e980064c24d3dd9859e9375e17417496567cf --
git bisect good c3f9b6ec744e12ff09677c4c0cb3164ad5b62702 # 19:25 300+ 36 Merge branch 'sched/core'
git bisect good 344c57c17c7f857f9c92317e0d5cbb5c59f8d6e0 # 19:49 300+ 62 Merge branch 'perf/urgent'
git bisect good 54de76b06a8098c11f15857a57e23c6e630a34b6 # 20:19 300+ 66 Merge branch 'perf/core'
git bisect good 126b6dbcbedb5c0defe5c39e0310feed061569bf # 20:51 300+ 50 exit: Deal with nested sleeps
git bisect good 8641f9cba8ce5f3bfc5da47861180617cbfc6e7f # 22:02 300+ 68 module: Fix nested sleep
git bisect bad 245747099820df3007f60128b1264fef9d2a69d2 # 22:25 142- 18 sched: Debug nested sleeps
git bisect good 592ed717ef33150f6888c333c28021283cc9aabc # 22:59 300+ 27 net: Clean up sk_wait_event() vs might_sleep()
# first bad commit: [245747099820df3007f60128b1264fef9d2a69d2] sched: Debug nested sleeps
git bisect good 592ed717ef33150f6888c333c28021283cc9aabc # 00:15 900+ 120 net: Clean up sk_wait_event() vs might_sleep()
git bisect bad 2d55520314eb5603b855ac1b994705dc6a352d9e # 00:19 0- 21 Merge branch 'sched/wait'
git bisect good cac7f2429872d3733dc3f9915857b1691da2eb2f # 01:33 900+ 66 Linux 3.18-rc2
git bisect good 7a891e6323e963f3301e44bdeee734028e34d390 # 02:26 900+ 93 Add linux-next specific files for 20141027
This script may reproduce the error.
----------------------------------------------------------------------------
#!/bin/bash
kernel=$1
initrd=yocto-minimal-i386.cgz
wget --no-clobber https://github.com/fengguang/reproduce-kernel-bug/raw/master/initrd/$initrd
kvm=(
qemu-system-x86_64
-cpu kvm64
-enable-kvm
-kernel $kernel
-initrd $initrd
-m 320
-smp 1
-net nic,vlan=1,model=e1000
-net user,vlan=1
-boot order=nc
-no-reboot
-watchdog i6300esb
-rtc base=localtime
-serial stdio
-display none
-monitor null
)
append=(
hung_task_panic=1
earlyprintk=ttyS0,115200
debug
apic=debug
sysrq_always_enabled
rcupdate.rcu_cpu_stall_timeout=100
panic=-1
softlockup_panic=1
nmi_watchdog=panic
oops=panic
load_ramdisk=2
prompt_ramdisk=0
console=ttyS0,115200
console=tty0
vga=normal
root=/dev/ram0
rw
drbd.minor_count=8
)
"${kvm[@]}" --append "${append[*]}"
----------------------------------------------------------------------------
Thanks,
Fengguang
_______________________________________________
LKP mailing list
LKP(a)linux.intel.com
5 years, 7 months
[vfs] kernel BUG at fs/namei.c:1066!
by Fengguang Wu
Greetings,
0day kernel testing robot got the below dmesg and the first bad commit is
git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs file-pin
commit 1bdc0d05755a7b261658f4d7b9d5e5a66773fa72
Author: David Howells <dhowells(a)redhat.com>
AuthorDate: Wed Jan 28 11:56:45 2015 +0000
Commit: David Howells <dhowells(a)redhat.com>
CommitDate: Wed Jan 28 12:06:23 2015 +0000
VFS: Split DCACHE_FILE_TYPE into regular and special types
Split DCACHE_FILE_TYPE into DCACHE_REGULAR_TYPE (dentries representing regular
files) and DCACHE_SPECIAL_TYPE (representing blockdev, chardev, FIFO and
socket files).
d_is_reg() and d_is_special() are added to detect these subtypes and
d_is_file() is left as the union of the two.
This allows a number of places that use S_ISREG(dentry->d_inode->i_mode) to
use d_is_reg(dentry) instead.
Signed-off-by: David Howells <dhowells(a)redhat.com>
+----------------------------------------------------------------------------+------------+------------+------------+
| | d0d43c410c | 1bdc0d0575 | 9db15cd36c |
+----------------------------------------------------------------------------+------------+------------+------------+
| boot_successes | 653 | 0 | 0 |
| boot_failures | 487 | 300 | 12 |
| Out_of_memory:Kill_process | 486 | | |
| Kernel_panic-not_syncing:Out_of_memory_and_no_killable_processes | 7 | | |
| backtrace:vfs_fstatat | 4 | | |
| backtrace:SyS_newfstatat | 4 | | |
| WARNING:at_net/netlink/genetlink.c:#genl_unbind() | 1 | | |
| backtrace:do_group_exit | 1 | | |
| backtrace:SyS_exit_group | 1 | | |
| backtrace:iterate_dir | 2 | | |
| backtrace:SyS_getdents | 2 | | |
| Kernel_panic-not_syncing:VFS:Unable_to_mount_root_fs_on_unknown-block(#,#) | 0 | 14 | 7 |
| backtrace:prepare_namespace | 0 | 4 | 7 |
| backtrace:kernel_init_freeable | 0 | 167 | 7 |
| BUG:unable_to_handle_kernel | 0 | 188 | |
| Oops | 0 | 188 | |
| Kernel_panic-not_syncing:Fatal_exception | 0 | 163 | 2 |
| backtrace:user_path_at | 0 | 163 | |
| backtrace:SyS_fchownat | 0 | 163 | |
| backtrace:SyS_chown | 0 | 163 | |
| backtrace:populate_rootfs | 0 | 163 | |
| WARNING:at_fs/dcache.c:#dput() | 0 | 15 | |
| kernel_BUG_at_fs/namei.c | 0 | 98 | 5 |
| invalid_opcode | 0 | 98 | 5 |
| RIP:follow_managed | 0 | 83 | 5 |
| backtrace:vfs_stat | 0 | 16 | 2 |
| backtrace:SyS_newstat | 0 | 16 | 2 |
| backtrace:do_sys_open | 0 | 0 | 1 |
| backtrace:SyS_open | 0 | 0 | 1 |
+----------------------------------------------------------------------------+------------+------------+------------+
[ 773.211462] EDD information not available.
[ 774.839766] debug: unmapping init [mem 0xffffffff82329000-0xffffffff82417fff]
[ 778.114489] ------------[ cut here ]------------
[ 778.116386] kernel BUG at fs/namei.c:1066!
[ 778.116386] invalid opcode: 0000 [#1] DEBUG_PAGEALLOC
[ 778.116386] Modules linked in:
[ 778.116386] CPU: 0 PID: 904 Comm: grep Not tainted 3.19.0-rc3-g1bdc0d0 #181
[ 778.116386] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.7.5-20140531_083030-gandalf 04/01/2014
[ 778.116386] task: ffff88000b4dce90 ti: ffff88000b4e0000 task.ti: ffff88000b4e0000
[ 778.116386] RIP: 0010:[<ffffffff8117196f>] [<ffffffff8117196f>] follow_managed+0x3ef/0x410
Elapsed time: 755
qemu-system-x86_64 -cpu kvm64 -enable-kvm -kernel /kernel/x86_64-randconfig-s1-01260504/1bdc0d05755a7b261658f4d7b9d5e5a66773fa72/vmlinuz-3.19.0-rc3-g1bdc0d0 -append 'hung_task_panic=1 earlyprintk=ttyS0,115200 debug apic=debug sysrq_always_enabled rcupdate.rcu_cpu_stall_timeout=100 panic=-1 softlockup_panic=1 nmi_watchdog=panic oops=panic load_ramdisk=2 prompt_ramdisk=0 console=ttyS0,115200 console=tty0 vga=normal root=/dev/ram0 rw link=/kbuild-tests/run-queue/kvm/x86_64-randconfig-s1-01260504/linux-devel:devel-snb-smoke-201501290306:1bdc0d05755a7b261658f4d7b9d5e5a66773fa72:bisect-linux-7/.vmlinuz-1bdc0d05755a7b261658f4d7b9d5e5a66773fa72-20150129094102-141-ivb41 branch=linux-devel/devel-snb-smoke-201501290306 BOOT_IMAGE=/kernel/x86_64-randconfig-s1-01260504/1bdc0d05755a7b261658f4d7b9d5e5a66773fa72/vmlinuz-3.19.0-rc3-g1bdc0d0 drbd.minor_count=8' -initrd /kernel-tests/initrd/yocto-minimal-x86_64.cgz -m 320 -smp 1 -net nic,vlan=1,model=e1000 -net user,vlan=1 -boot order=nc -no-reboot -watchdog i6300esb -rtc base=localtime -pidfile /dev/shm/kboot/pid-yocto-ivb41-1 -serial file:/dev/shm/kboot/serial-yocto-ivb41-1 -daemonize -display none -monitor null
git bisect start 9db15cd36c0640c61809774ccf0c3fe3a6fff9f4 26bc420b59a38e4e6685a73345a0def461136dce --
git bisect good 326c3294b747bb6c6cc6df185fdffe518d859ba3 # 04:17 20+ 0 Merge 'arm-soc/at91/cleanup3' into devel-snb-smoke-201501290306
git bisect good 482b9fa512d33c0c07792a547ce83e6d6c231df4 # 04:32 20+ 12 Merge 'drm-intel/drm-intel-nightly' into devel-snb-smoke-201501290306
git bisect good f90772a3bee3a482c1f31dcd931796bb1340d68b # 05:05 20+ 0 Merge 'soc-thermal/fixes' into devel-snb-smoke-201501290306
git bisect good 968376a77da823fbf465b7f69e052e5810ab691e # 06:01 20+ 14 Merge 'mvebu/mvebu/fixes-5' into devel-snb-smoke-201501290306
git bisect bad 82cd423b4864f6f3351e1d3cc218d0458249aea3 # 06:42 0- 6 Merge 'dhowells-fs/file-pin-devel' into devel-snb-smoke-201501290306
git bisect good 756b237af0f1ce838e6a3697c71505d25b5180e4 # 07:04 20+ 18 VFS: Introduce inode-getting helpers for layered/unioned fs environments
git bisect bad b62488d2fffcaffba029cf685b4f5841bc66a896 # 07:45 7- 10 Smack: Use d_is_positive() rather than testing dentry->d_inode
git bisect bad 27fdb8024f22410e209e4b19d8faa8b84fcae884 # 07:57 22- 23 Overlayfs: Use dentry layer pinning
git bisect good d0d43c410c279cbd9505afcbcc48b396d1e5e3b9 # 08:46 240+ 161 VFS: Add lower layer pinning in dcache
git bisect bad 107f1c40a47dcdf054c925317f786aaaf20ee6e1 # 09:33 67- 69 Overlayfs: Use DCACHE_WHITEOUT_TYPE
git bisect bad 1bdc0d05755a7b261658f4d7b9d5e5a66773fa72 # 09:46 163- 164 VFS: Split DCACHE_FILE_TYPE into regular and special types
# first bad commit: [1bdc0d05755a7b261658f4d7b9d5e5a66773fa72] VFS: Split DCACHE_FILE_TYPE into regular and special types
git bisect good d0d43c410c279cbd9505afcbcc48b396d1e5e3b9 # 10:32 900+ 487 VFS: Add lower layer pinning in dcache
# extra tests with DEBUG_INFO
# extra tests on HEAD of linux-devel/devel-snb-smoke-201501290306
git bisect bad 9db15cd36c0640c61809774ccf0c3fe3a6fff9f4 # 10:41 0- 12 0day head guard for 'devel-snb-smoke-201501290306'
# extra tests on tree/branch dhowells-fs/file-pin
# extra tests on tree/branch linus/master
git bisect good c59c961ca511dc7ee2f4f7e9c224d16f5c76ca6e # 12:32 900+ 367 Merge branch 'drm-fixes' of git://people.freedesktop.org/~airlied/linux
# extra tests on tree/branch next/master
git bisect good 30720bbeca0d197b639bb2b347f31238d829aa90 # 13:22 900+ 340 Add linux-next specific files for 20150128
This script may reproduce the error.
----------------------------------------------------------------------------
#!/bin/bash
kernel=$1
initrd=yocto-minimal-x86_64.cgz
wget --no-clobber https://github.com/fengguang/reproduce-kernel-bug/raw/master/initrd/$initrd
kvm=(
qemu-system-x86_64
-cpu kvm64
-enable-kvm
-kernel $kernel
-initrd $initrd
-m 320
-smp 1
-net nic,vlan=1,model=e1000
-net user,vlan=1
-boot order=nc
-no-reboot
-watchdog i6300esb
-rtc base=localtime
-serial stdio
-display none
-monitor null
)
append=(
hung_task_panic=1
earlyprintk=ttyS0,115200
debug
apic=debug
sysrq_always_enabled
rcupdate.rcu_cpu_stall_timeout=100
panic=-1
softlockup_panic=1
nmi_watchdog=panic
oops=panic
load_ramdisk=2
prompt_ramdisk=0
console=ttyS0,115200
console=tty0
vga=normal
root=/dev/ram0
rw
drbd.minor_count=8
)
"${kvm[@]}" --append "${append[*]}"
----------------------------------------------------------------------------
Thanks,
Fengguang
_______________________________________________
LKP mailing list
LKP(a)linux.intel.com
5 years, 7 months
[perf] WARNING: CPU: 0 PID: 1457 at kernel/events/core.c:890 add_event_to_ctx()
by Fengguang Wu
Greetings,
0day kernel testing robot got the below dmesg and the first bad commit is
git://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git perf/core
commit d26bb7f73a2881f2412c340a27438b185f0cc3dc
Author: Mark Rutland <mark.rutland(a)arm.com>
AuthorDate: Wed Jan 7 15:01:54 2015 +0000
Commit: Peter Zijlstra <peterz(a)infradead.org>
CommitDate: Fri Jan 23 15:17:56 2015 +0100
perf: decouple unthrottling and rotating
Currently the adjusments made as part of perf_event_task_tick use the
percpu rotation lists to iterate over any active PMU contexts, but these
are not used by the context rotation code, having been replaced by
separate (per-context) hrtimer callbacks. However, some manipulation of
the rotation lists (i.e. removal of contexts) has remained in
perf_rotate_context. This leads to the following issues:
* Contexts are not always removed from the rotation lists. Removal of
PMUs which have been placed in rotation lists, but have not been
removed by a hrtimer callback can result in corruption of the rotation
lists (when memory backing the context is freed).
This has been observed to result in hangs when PMU drivers built as
modules are inserted and removed around the creation of events for
said PMUs.
* Contexts which do not require rotation may be removed from the
rotation lists as a result of a hrtimer, and will not be considered by
the unthrottling code in perf_event_task_tick.
This patch solves these issues by moving any and all removal of contexts
from rotation lists to only occur when the final event is removed from a
context, mirroring the addition which only occurs when the first event
is added to a context. The vestigal manipulation of the rotation lists
is removed from perf_event_rotate_context.
As the rotation_list variables are not used for rotation, these are
renamed to active_ctx_list, which better matches their current function.
perf_pmu_rotate_{start,stop} are renamed to
perf_pmu_ctx_{activate,deactivate}.
Cc: Will Deacon <will.deacon(a)arm.com>
Cc: Paul Mackerras <paulus(a)samba.org>
Cc: Ingo Molnar <mingo(a)redhat.com>
Cc: Arnaldo Carvalho de Melo <acme(a)kernel.org>
Cc: Will Deacon <will.deacon(a)arm.com>
Cc: Paul Mackerras <paulus(a)samba.org>
Cc: Ingo Molnar <mingo(a)redhat.com>
Cc: Arnaldo Carvalho de Melo <acme(a)kernel.org>
Cc: Mark Rutland <mark.rutland(a)arm.com>
Signed-off-by: Mark Rutland <mark.rutland(a)arm.com>
Reported-by: Johannes Jensen <johannes.jensen(a)arm.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz(a)infradead.org>
Link: http://lkml.kernel.org/r/1420642914-22760-1-git-send-email-mark.rutland@a...
===================================================
PARENT COMMIT NOT CLEAN. LOOK OUT FOR WRONG BISECT!
===================================================
Attached dmesg for the parent commit, too, to help confirm whether it is a noise error.
Fengguang: the old OOM errors look like independent noises.
+------------------------------------------------------------------+------------+------------+------------+
| | 2e67200461 | d26bb7f73a | b0f9997908 |
+------------------------------------------------------------------+------------+------------+------------+
| boot_successes | 0 | 0 | 0 |
| boot_failures | 1900 | 900 | 22 |
| page_allocation_failure:order:#,mode | 1040 | 567 | 10 |
| Kernel_panic-not_syncing:Out_of_memory_and_no_killable_processes | 1040 | 567 | 10 |
| backtrace:ring_buffer_consumer_thread | 1040 | 567 | 10 |
| backtrace:lock_torture_stats | 1040 | 567 | 10 |
| WARNING:at_net/netlink/genetlink.c:#genl_unbind() | 860 | 54 | |
| backtrace:do_group_exit | 860 | 5 | |
| backtrace:SyS_exit_group | 860 | 5 | |
| backtrace:netlink_setsockopt | 236 | 49 | |
| backtrace:SyS_setsockopt | 236 | 49 | |
| backtrace:SyS_socketcall | 236 | 49 | |
| WARNING:at_kernel/events/core.c:#add_event_to_ctx() | 0 | 333 | 12 |
| BUG:kernel_test_hang | 0 | 333 | 12 |
| backtrace:inherit_group | 0 | 328 | 12 |
| backtrace:perf_event_init_task | 0 | 328 | 12 |
| backtrace:do_fork | 0 | 328 | 12 |
| backtrace:SyS_clone | 0 | 328 | 12 |
| backtrace:perf_install_in_context | 0 | 5 | |
| backtrace:SyS_perf_event_open | 0 | 5 | |
+------------------------------------------------------------------+------------+------------+------------+
[main] Setsockopt(1 8 80d1000 4) on fd 86 [1:1:1]
[main] Setsockopt(1 2a 80d1000 4) on fd 87 [1:1:1]
[ 34.700861] ------------[ cut here ]------------
[ 34.701372] WARNING: CPU: 0 PID: 1457 at kernel/events/core.c:890 add_event_to_ctx+0x253/0x270()
[ 34.702515] CPU: 0 PID: 1457 Comm: trinity-main Not tainted 3.19.0-rc4-gd26bb7f #2
[ 34.702931] 00000000 00000000 c0911e2c cd8a61df c0911e48 cd052cfa 0000037a cd0d32f3
[ 34.702931] c0c206d0 c0c20590 d3c9e0a0 c0911e58 cd052dd4 00000009 00000000 c0911e78
[ 34.702931] cd0d32f3 d3c9e214 00000000 00000000 c0c20598 00000246 c0c50990 c0911e90
[ 34.702931] Call Trace:
[ 34.702931] [<cd8a61df>] dump_stack+0x16/0x18
[ 34.702931] [<cd052cfa>] warn_slowpath_common+0x6a/0xa0
[ 34.702931] [<cd0d32f3>] ? add_event_to_ctx+0x253/0x270
[ 34.702931] [<cd052dd4>] warn_slowpath_null+0x14/0x20
[ 34.702931] [<cd0d32f3>] add_event_to_ctx+0x253/0x270
[ 34.702931] [<cd0da60f>] inherit_event+0xef/0x240
[ 34.702931] [<cd0da778>] inherit_group+0x18/0x70
[ 34.702931] [<cd0d2884>] ? alloc_perf_context+0x24/0x50
[ 34.702931] [<cd0db927>] perf_event_init_task+0x117/0x310
[ 34.702931] [<cd050c67>] copy_process+0x477/0x14f0
[ 34.702931] [<cd052063>] do_fork+0xb3/0x430
[ 34.702931] [<cd0923fd>] ? do_setitimer+0x13d/0x220
[ 34.702931] [<cd09251a>] ? alarm_setitimer+0x3a/0x60
[ 34.702931] [<cd05246b>] SyS_clone+0x1b/0x20
[ 34.702931] [<cd8ad3bd>] syscall_call+0x7/0x7
[ 34.702931] [<cd8a0000>] ? xen_chk_extra_mem+0x10/0x70
[ 34.702931] ---[ end trace 19d6cac21f26a758 ]---
git bisect start b0f99979082f6aafe6f2d4342e44907a4bb6b710 ec6f34e5b552fb0a52e6aae1a5afbbb1605cc6cc --
git bisect bad 7c4e3ef2ae4f008776d1d2d13c862179146bbb07 # 08:44 0- 28 Merge 'arm-platforms/irq/die-gic-arch-extn-die-die-die' into devel-roam-rand-201501240027
git bisect bad 5dcbd81bc253c6fb786a3c4d0c2304d00353cc83 # 08:45 0- 928 Merge 'peterz-queue/perf/urgent' into devel-roam-rand-201501240027
git bisect good bd0e15d797d00b7115e1950ee13fec7ce001f064 # 09:09 900+ 900 Merge 'peterz-queue/locking/core' into devel-roam-rand-201501240027
git bisect bad d8c008a82490f75ca16101567e167213486288aa # 10:14 351- 358 Merge 'peterz-queue/perf/core' into devel-roam-rand-201501240027
git bisect bad 18966e0b34261132be50b8624be368db80b529cf # 11:19 291- 293 perf, x86: use context switch callback to flush LBR stack
git bisect good 44b4c3b252ffefe36900df247d528e9550ee20c4 # 12:31 900+ 900 perf: Add pmu callbacks to track event mapping and unmapping
git bisect bad d26bb7f73a2881f2412c340a27438b185f0cc3dc # 13:34 509- 510 perf: decouple unthrottling and rotating
git bisect good e8923a02fab8e3a2e74cebace2ae73cbf1f0dd09 # 14:00 900+ 900 x86, perf: Only allow rdpmc if a perf_event is mapped
git bisect good 2e67200461d1eec17062de4947d07f3e6afd0848 # 14:26 900+ 900 x86, perf: Add /sys/devices/cpu/rdpmc=2 to allow rdpmc for all tasks
# first bad commit: [d26bb7f73a2881f2412c340a27438b185f0cc3dc] perf: decouple unthrottling and rotating
git bisect good 2e67200461d1eec17062de4947d07f3e6afd0848 # 14:44 1000+ 1900 x86, perf: Add /sys/devices/cpu/rdpmc=2 to allow rdpmc for all tasks
# extra tests with DEBUG_INFO
# extra tests on HEAD of linux-devel/devel-roam-rand-201501240027
git bisect bad b0f99979082f6aafe6f2d4342e44907a4bb6b710 # 14:48 0- 22 0day head guard for 'devel-roam-rand-201501240027'
# extra tests on tree/branch peterz-queue/perf/core
git bisect bad 6f637dfc22bc3e963c6936cdf1bb6550a9d3e955 # 16:02 274- 278 perf,powerpc: Fix up flush_branch_stack users
# extra tests on tree/branch linus/master
git bisect good c4e00f1d31c4c83d15162782491689229bd92527 # 17:12 1000+ 644 Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs
# extra tests on tree/branch next/master
git bisect good de3d2c5b941c632685ab58613f981bf14a42676f # 17:23 1000+ 528 Add linux-next specific files for 20150123
This script may reproduce the error.
----------------------------------------------------------------------------
#!/bin/bash
kernel=$1
initrd=yocto-minimal-i386.cgz
wget --no-clobber https://github.com/fengguang/reproduce-kernel-bug/raw/master/initrd/$initrd
kvm=(
qemu-system-x86_64
-cpu kvm64
-enable-kvm
-kernel $kernel
-initrd $initrd
-m 320
-smp 1
-net nic,vlan=1,model=e1000
-net user,vlan=1
-boot order=nc
-no-reboot
-watchdog i6300esb
-rtc base=localtime
-serial stdio
-display none
-monitor null
)
append=(
hung_task_panic=1
earlyprintk=ttyS0,115200
debug
apic=debug
sysrq_always_enabled
rcupdate.rcu_cpu_stall_timeout=100
panic=-1
softlockup_panic=1
nmi_watchdog=panic
oops=panic
load_ramdisk=2
prompt_ramdisk=0
console=ttyS0,115200
console=tty0
vga=normal
root=/dev/ram0
rw
drbd.minor_count=8
)
"${kvm[@]}" --append "${append[*]}"
----------------------------------------------------------------------------
Thanks,
Fengguang
_______________________________________________
LKP mailing list
LKP(a)linux.intel.com
5 years, 7 months
[VFS] BUG: unable to handle kernel NULL pointer dereference at (null)
by Huang Ying
FYI, we noticed the below changes on
git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs file-pin
commit 1bdc0d05755a7b261658f4d7b9d5e5a66773fa72 ("VFS: Split DCACHE_FILE_TYPE into regular and special types")
+----------------------------------------------------------------------------+------------+------------+
| | d0d43c410c | 1bdc0d0575 |
+----------------------------------------------------------------------------+------------+------------+
| boot_successes | 19 | 0 |
| boot_failures | 11 | 30 |
| Kernel_panic-not_syncing:VFS:Unable_to_mount_root_fs_on_unknown-block(#,#) | 1 | |
| backtrace:prepare_namespace | 1 | |
| backtrace:kernel_init_freeable | 1 | 30 |
| Out_of_memory:Kill_process | 10 | |
| Kernel_panic-not_syncing:Out_of_memory_and_no_killable_processes | 8 | |
| backtrace:vfs_mknod | 2 | |
| backtrace:SyS_mknodat | 2 | |
| backtrace:SyS_mknod | 2 | |
| backtrace:do_fork | 10 | |
| backtrace:__call_usermodehelper | 8 | |
| backtrace:do_execveat_common | 6 | |
| backtrace:compat_SyS_execve | 6 | |
| backtrace:SyS_clone | 8 | |
| backtrace:link_path_walk | 3 | |
| backtrace:path_init | 3 | |
| backtrace:pgd_alloc | 2 | |
| backtrace:mm_init | 2 | |
| BUG:unable_to_handle_kernel | 0 | 30 |
| Oops | 0 | 30 |
| Kernel_panic-not_syncing:Fatal_exception | 0 | 30 |
| backtrace:user_path_at | 0 | 30 |
| backtrace:SyS_fchownat | 0 | 30 |
| backtrace:SyS_chown | 0 | 30 |
| backtrace:populate_rootfs | 0 | 30 |
+----------------------------------------------------------------------------+------------+------------+
[ 1.697632] pci 0000:00:01.0: Activating ISA DMA hang workarounds
[ 1.699483] pci 0000:00:02.0: Video device with shadowed ROM
[ 1.701265] PCI: CLS 0 bytes, default 64
[ 1.704035] BUG: unable to handle kernel NULL pointer dereference at (null)
[ 1.704562] IP: [< (null)>] (null)
[ 1.704562] PGD 0
[ 1.704562] Oops: 0010 [#1] SMP
[ 1.704562] Modules linked in:
[ 1.704562] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 3.19.0-rc6-gb6c48b1 #1457
[ 1.704562] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.7.5-20140531_083030-gandalf 04/01/2014
[ 1.704562] task: ffff880006400000 ti: ffff880006408000 task.ti: ffff880006408000
[ 1.704562] RIP: 0010:[<0000000000000000>] [< (null)>] (null)
[ 1.704562] RSP: 0000:ffff88000640baf0 EFLAGS: 00010246
[ 1.704562] RAX: ffffffff83440080 RBX: ffff88000640bbe8 RCX: 0000000000800000
[ 1.704562] RDX: 000000001bfd6df1 RSI: ffff88000640bbe8 RDI: ffff8800053db9a0
[ 1.704562] RBP: ffff88000640bb88 R08: 0000000000000004 R09: 0000000000000001
[ 1.704562] R10: ffff88000640bab4 R11: 0000000000000000 R12: ffff8800053db9a0
[ 1.704562] R13: ffff88000640bbe8 R14: 0000000000000001 R15: ffff880006400000
[ 1.704562] FS: 0000000000000000(0000) GS:ffff880007a00000(0000) knlGS:0000000000000000
[ 1.704562] CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b
[ 1.704562] CR2: 0000000000000000 CR3: 0000000002189000 CR4: 00000000000006f0
[ 1.704562] Stack:
[ 1.704562] ffffffff811aff40 0000000000000246 0000000000000246 ffff88000640bb38
[ 1.704562] ffff880006400000 ffff880006400000 ffff880006400000 ffff880006dcc000
[ 1.704562] 0000000000000000 ffff880006f06020 ffff8800053db9a0 ffff880006f06020
[ 1.704562] Call Trace:
[ 1.704562] [<ffffffff811aff40>] ? path_lookupat+0x2e4/0x657
[ 1.704562] [<ffffffff811b02dd>] filename_lookup+0x2a/0x9c
[ 1.704562] [<ffffffff811b18fb>] user_path_at_empty+0x5a/0x98
[ 1.704562] [<ffffffff810aa827>] ? local_clock+0x19/0x22
[ 1.704562] [<ffffffff811bf1cd>] ? mntput_no_expire+0x63/0x1db
[ 1.704562] [<ffffffff811bf372>] ? mntput+0x2d/0x2f
[ 1.704562] [<ffffffff811ab800>] ? path_put+0x1f/0x23
[ 1.704562] [<ffffffff811b194a>] user_path_at+0x11/0x13
[ 1.704562] [<ffffffff811a23b8>] SyS_fchownat+0x60/0xc5
[ 1.704562] [<ffffffff824deb06>] ? md_run_setup+0x9c/0x9c
[ 1.704562] [<ffffffff811a243a>] SyS_chown+0x1d/0x1f
[ 1.704562] [<ffffffff824dfaf2>] do_name+0x244/0x27f
[ 1.704562] [<ffffffff824dec3c>] write_buffer+0x24/0x36
[ 1.704562] [<ffffffff824dec7a>] flush_buffer+0x2c/0x87
[ 1.704562] [<ffffffff8251fe13>] gunzip+0x261/0x2fb
[ 1.704562] [<ffffffff8251fba8>] ? decompress_method+0x58/0x58
[ 1.704562] [<ffffffff824dec4e>] ? write_buffer+0x36/0x36
[ 1.704562] [<ffffffff824df6aa>] unpack_to_rootfs+0x149/0x247
[ 1.704562] [<ffffffff824deb06>] ? md_run_setup+0x9c/0x9c
[ 1.704562] [<ffffffff810002bd>] ? do_one_initcall+0x90/0x17f
[ 1.704562] [<ffffffff824df7a8>] ? unpack_to_rootfs+0x247/0x247
[ 1.704562] [<ffffffff824df7c1>] populate_rootfs+0x19/0x106
[ 1.704562] [<ffffffff8100031a>] do_one_initcall+0xed/0x17f
[ 1.704562] [<ffffffff824dd0e2>] kernel_init_freeable+0x1f0/0x278
[ 1.704562] [<ffffffff81b6bad8>] ? rest_init+0xca/0xca
[ 1.704562] [<ffffffff81b6bae6>] kernel_init+0xe/0xda
[ 1.704562] [<ffffffff81b881fc>] ret_from_fork+0x7c/0xb0
[ 1.704562] [<ffffffff81b6bad8>] ? rest_init+0xca/0xca
[ 1.704562] Code: Bad RIP value.
[ 1.704562] RIP [< (null)>] (null)
[ 1.704562] RSP <ffff88000640baf0>
[ 1.704562] CR2: 0000000000000000
[ 1.704562] ---[ end trace ca633ac8ec2a95d9 ]---
[ 1.704562] Kernel panic - not syncing: Fatal exception
Thanks,
Huang, Ying
_______________________________________________
LKP mailing list
LKP(a)linux.intel.com
5 years, 8 months
[PATCH 3.13.y-ckt 139/139] tick/powerclamp: Remove tick_nohz_idle abuse
by Kamal Mostafa
3.13.11-ckt15 -stable review patch. If anyone has any objections, please let me know.
------------------
From: Thomas Gleixner <tglx(a)linutronix.de>
commit a5fd9733a30d18d7ac23f17080e7e07bb3205b69 upstream.
commit 4dbd27711cd9 "tick: export nohz tick idle symbols for module
use" was merged via the thermal tree without an explicit ack from the
relevant maintainers.
The exports are abused by the intel powerclamp driver which implements
a fake idle state from a sched FIFO task. This causes all kinds of
wreckage in the NOHZ core code which rightfully assumes that
tick_nohz_idle_enter/exit() are only called from the idle task itself.
Recent changes in the NOHZ core lead to a failure of the powerclamp
driver and now people try to hack completely broken and backwards
workarounds into the NOHZ core code. This is completely unacceptable
and just papers over the real problem. There are way more subtle
issues lurking around the corner.
The real solution is to fix the powerclamp driver by rewriting it with
a sane concept, but that's beyond the scope of this.
So the only solution for now is to remove the calls into the core NOHZ
code from the powerclamp trainwreck along with the exports.
Fixes: d6d71ee4a14a "PM: Introduce Intel PowerClamp Driver"
Signed-off-by: Thomas Gleixner <tglx(a)linutronix.de>
Cc: Preeti U Murthy <preeti(a)linux.vnet.ibm.com>
Cc: Viresh Kumar <viresh.kumar(a)linaro.org>
Cc: Frederic Weisbecker <fweisbec(a)gmail.com>
Cc: Fengguang Wu <fengguang.wu(a)intel.com>
Cc: Frederic Weisbecker <frederic(a)kernel.org>
Cc: Pan Jacob jun <jacob.jun.pan(a)intel.com>
Cc: LKP <lkp(a)01.org>
Cc: Peter Zijlstra <peterz(a)infradead.org>
Cc: Zhang Rui <rui.zhang(a)intel.com>
Link: http://lkml.kernel.org/r/alpine.DEB.2.11.1412181110110.17382@nanos
Signed-off-by: Thomas Gleixner <tglx(a)linutronix.de>
Signed-off-by: Kamal Mostafa <kamal(a)canonical.com>
---
drivers/thermal/intel_powerclamp.c | 2 --
kernel/time/tick-sched.c | 2 --
2 files changed, 4 deletions(-)
diff --git a/drivers/thermal/intel_powerclamp.c b/drivers/thermal/intel_powerclamp.c
index 8f181b3..cde9cff 100644
--- a/drivers/thermal/intel_powerclamp.c
+++ b/drivers/thermal/intel_powerclamp.c
@@ -426,7 +426,6 @@ static int clamp_thread(void *arg)
* allowed. thus jiffies are updated properly.
*/
preempt_disable();
- tick_nohz_idle_enter();
/* mwait until target jiffies is reached */
while (time_before(jiffies, target_jiffies)) {
unsigned long ecx = 1;
@@ -444,7 +443,6 @@ static int clamp_thread(void *arg)
start_critical_timings();
atomic_inc(&idle_wakeup_counter);
}
- tick_nohz_idle_exit();
preempt_enable_no_resched();
}
del_timer_sync(&wakeup_timer);
diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
index 29b063b..67673ca 100644
--- a/kernel/time/tick-sched.c
+++ b/kernel/time/tick-sched.c
@@ -806,7 +806,6 @@ void tick_nohz_idle_enter(void)
local_irq_enable();
}
-EXPORT_SYMBOL_GPL(tick_nohz_idle_enter);
/**
* tick_nohz_irq_exit - update next tick event from interrupt exit
@@ -934,7 +933,6 @@ void tick_nohz_idle_exit(void)
local_irq_enable();
}
-EXPORT_SYMBOL_GPL(tick_nohz_idle_exit);
static int tick_nohz_reprogram(struct tick_sched *ts, ktime_t now)
{
--
1.9.1
5 years, 8 months
[3.13.y-ckt stable] Patch "tick/powerclamp: Remove tick_nohz_idle abuse" has been added to staging queue
by Kamal Mostafa
This is a note to let you know that I have just added a patch titled
tick/powerclamp: Remove tick_nohz_idle abuse
to the linux-3.13.y-queue branch of the 3.13.y-ckt extended stable tree
which can be found at:
http://kernel.ubuntu.com/git?p=ubuntu/linux.git;a=shortlog;h=refs/heads/l...
This patch is scheduled to be released in version 3.13.11-ckt15.
If you, or anyone else, feels it should not be added to this tree, please
reply to this email.
For more information about the 3.13.y-ckt tree, see
https://wiki.ubuntu.com/Kernel/Dev/ExtendedStable
Thanks.
-Kamal
------
>From f9ab87de3b27dc729b9a0cfc9dc5612dda04c995 Mon Sep 17 00:00:00 2001
From: Thomas Gleixner <tglx(a)linutronix.de>
Date: Thu, 18 Dec 2014 11:51:01 +0100
Subject: tick/powerclamp: Remove tick_nohz_idle abuse
commit a5fd9733a30d18d7ac23f17080e7e07bb3205b69 upstream.
commit 4dbd27711cd9 "tick: export nohz tick idle symbols for module
use" was merged via the thermal tree without an explicit ack from the
relevant maintainers.
The exports are abused by the intel powerclamp driver which implements
a fake idle state from a sched FIFO task. This causes all kinds of
wreckage in the NOHZ core code which rightfully assumes that
tick_nohz_idle_enter/exit() are only called from the idle task itself.
Recent changes in the NOHZ core lead to a failure of the powerclamp
driver and now people try to hack completely broken and backwards
workarounds into the NOHZ core code. This is completely unacceptable
and just papers over the real problem. There are way more subtle
issues lurking around the corner.
The real solution is to fix the powerclamp driver by rewriting it with
a sane concept, but that's beyond the scope of this.
So the only solution for now is to remove the calls into the core NOHZ
code from the powerclamp trainwreck along with the exports.
Fixes: d6d71ee4a14a "PM: Introduce Intel PowerClamp Driver"
Signed-off-by: Thomas Gleixner <tglx(a)linutronix.de>
Cc: Preeti U Murthy <preeti(a)linux.vnet.ibm.com>
Cc: Viresh Kumar <viresh.kumar(a)linaro.org>
Cc: Frederic Weisbecker <fweisbec(a)gmail.com>
Cc: Fengguang Wu <fengguang.wu(a)intel.com>
Cc: Frederic Weisbecker <frederic(a)kernel.org>
Cc: Pan Jacob jun <jacob.jun.pan(a)intel.com>
Cc: LKP <lkp(a)01.org>
Cc: Peter Zijlstra <peterz(a)infradead.org>
Cc: Zhang Rui <rui.zhang(a)intel.com>
Link: http://lkml.kernel.org/r/alpine.DEB.2.11.1412181110110.17382@nanos
Signed-off-by: Thomas Gleixner <tglx(a)linutronix.de>
Signed-off-by: Kamal Mostafa <kamal(a)canonical.com>
---
drivers/thermal/intel_powerclamp.c | 2 --
kernel/time/tick-sched.c | 2 --
2 files changed, 4 deletions(-)
diff --git a/drivers/thermal/intel_powerclamp.c b/drivers/thermal/intel_powerclamp.c
index 8f181b3..cde9cff 100644
--- a/drivers/thermal/intel_powerclamp.c
+++ b/drivers/thermal/intel_powerclamp.c
@@ -426,7 +426,6 @@ static int clamp_thread(void *arg)
* allowed. thus jiffies are updated properly.
*/
preempt_disable();
- tick_nohz_idle_enter();
/* mwait until target jiffies is reached */
while (time_before(jiffies, target_jiffies)) {
unsigned long ecx = 1;
@@ -444,7 +443,6 @@ static int clamp_thread(void *arg)
start_critical_timings();
atomic_inc(&idle_wakeup_counter);
}
- tick_nohz_idle_exit();
preempt_enable_no_resched();
}
del_timer_sync(&wakeup_timer);
diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
index 29b063b..67673ca 100644
--- a/kernel/time/tick-sched.c
+++ b/kernel/time/tick-sched.c
@@ -806,7 +806,6 @@ void tick_nohz_idle_enter(void)
local_irq_enable();
}
-EXPORT_SYMBOL_GPL(tick_nohz_idle_enter);
/**
* tick_nohz_irq_exit - update next tick event from interrupt exit
@@ -934,7 +933,6 @@ void tick_nohz_idle_exit(void)
local_irq_enable();
}
-EXPORT_SYMBOL_GPL(tick_nohz_idle_exit);
static int tick_nohz_reprogram(struct tick_sched *ts, ktime_t now)
{
--
1.9.1
5 years, 8 months
[PATCH 3.12 082/176] tick/powerclamp: Remove tick_nohz_idle abuse
by Jiri Slaby
From: Thomas Gleixner <tglx(a)linutronix.de>
3.12-stable review patch. If anyone has any objections, please let me know.
===============
commit a5fd9733a30d18d7ac23f17080e7e07bb3205b69 upstream.
commit 4dbd27711cd9 "tick: export nohz tick idle symbols for module
use" was merged via the thermal tree without an explicit ack from the
relevant maintainers.
The exports are abused by the intel powerclamp driver which implements
a fake idle state from a sched FIFO task. This causes all kinds of
wreckage in the NOHZ core code which rightfully assumes that
tick_nohz_idle_enter/exit() are only called from the idle task itself.
Recent changes in the NOHZ core lead to a failure of the powerclamp
driver and now people try to hack completely broken and backwards
workarounds into the NOHZ core code. This is completely unacceptable
and just papers over the real problem. There are way more subtle
issues lurking around the corner.
The real solution is to fix the powerclamp driver by rewriting it with
a sane concept, but that's beyond the scope of this.
So the only solution for now is to remove the calls into the core NOHZ
code from the powerclamp trainwreck along with the exports.
Fixes: d6d71ee4a14a "PM: Introduce Intel PowerClamp Driver"
Signed-off-by: Thomas Gleixner <tglx(a)linutronix.de>
Cc: Preeti U Murthy <preeti(a)linux.vnet.ibm.com>
Cc: Viresh Kumar <viresh.kumar(a)linaro.org>
Cc: Frederic Weisbecker <fweisbec(a)gmail.com>
Cc: Fengguang Wu <fengguang.wu(a)intel.com>
Cc: Frederic Weisbecker <frederic(a)kernel.org>
Cc: Pan Jacob jun <jacob.jun.pan(a)intel.com>
Cc: LKP <lkp(a)01.org>
Cc: Peter Zijlstra <peterz(a)infradead.org>
Cc: Zhang Rui <rui.zhang(a)intel.com>
Link: http://lkml.kernel.org/r/alpine.DEB.2.11.1412181110110.17382@nanos
Signed-off-by: Thomas Gleixner <tglx(a)linutronix.de>
Signed-off-by: Jiri Slaby <jslaby(a)suse.cz>
---
drivers/thermal/intel_powerclamp.c | 2 --
kernel/time/tick-sched.c | 2 --
2 files changed, 4 deletions(-)
diff --git a/drivers/thermal/intel_powerclamp.c b/drivers/thermal/intel_powerclamp.c
index b40b37cd25e0..d54388a53637 100644
--- a/drivers/thermal/intel_powerclamp.c
+++ b/drivers/thermal/intel_powerclamp.c
@@ -426,7 +426,6 @@ static int clamp_thread(void *arg)
* allowed. thus jiffies are updated properly.
*/
preempt_disable();
- tick_nohz_idle_enter();
/* mwait until target jiffies is reached */
while (time_before(jiffies, target_jiffies)) {
unsigned long ecx = 1;
@@ -444,7 +443,6 @@ static int clamp_thread(void *arg)
start_critical_timings();
atomic_inc(&idle_wakeup_counter);
}
- tick_nohz_idle_exit();
preempt_enable_no_resched();
}
del_timer_sync(&wakeup_timer);
diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
index 29b063b32ff0..67673ca12a19 100644
--- a/kernel/time/tick-sched.c
+++ b/kernel/time/tick-sched.c
@@ -806,7 +806,6 @@ void tick_nohz_idle_enter(void)
local_irq_enable();
}
-EXPORT_SYMBOL_GPL(tick_nohz_idle_enter);
/**
* tick_nohz_irq_exit - update next tick event from interrupt exit
@@ -934,7 +933,6 @@ void tick_nohz_idle_exit(void)
local_irq_enable();
}
-EXPORT_SYMBOL_GPL(tick_nohz_idle_exit);
static int tick_nohz_reprogram(struct tick_sched *ts, ktime_t now)
{
--
2.2.2
5 years, 8 months
