[MPTCP][PATCH v2 mptcp-next 00/10] ADD_ADDR: ports support
by Geliang Tang
v2:
- change mptcp_out_options's port field in CPU bype order.
- keep mptcp_options_received's port field in CPU bype order.
- add two new patches to simplify ADD_ADDR suboption writing.
- update mptcp_add_addr_len helper use adding up size.
- add more commit messages.
v1:
This series is the first version of ADD_ADDR ports support. I have solved
the listener problem which I mentioned at the meeting on 15th of October
by adding a new listening socket from the userspace (see patch 8). Up to
now this patchset works well.
Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/54
Geliang Tang (10):
mptcp: unify ADD_ADDR and echo suboptions writing
mptcp: unify ADD_ADDR and ADD_ADDR6 suboptions writing
mptcp: add port support for ADD_ADDR suboption writing
mptcp: use adding up size when get ADD_ADDR length
mptcp: add the outgoing ADD_ADDR port support
mptcp: send out dedicated packet for ADD_ADDR using port
mptcp: add port parameter for mptcp_pm_announce_addr
mptcp: deal with MPTCP_PM_ADDR_ATTR_PORT in PM netlink
selftests: mptcp: add port argument for pm_nl_ctl
selftests: mptcp: add testcases for ADD_ADDR with port
include/net/mptcp.h | 1 +
net/mptcp/options.c | 89 +++++++++++--------
net/mptcp/pm.c | 14 +--
net/mptcp/pm_netlink.c | 28 ++++--
net/mptcp/protocol.h | 36 +++++---
.../testing/selftests/net/mptcp/mptcp_join.sh | 26 +++++-
tools/testing/selftests/net/mptcp/pm_nl_ctl.c | 18 ++++
7 files changed, 153 insertions(+), 59 deletions(-)
--
2.26.2
3 weeks, 5 days
[PATCH net-next 0/6] mptcp: Miscellaneous MPTCP fixes
by Mat Martineau
This is a collection of small fixup and minor enhancement patches that
have accumulated in the MPTCP tree while net-next was closed. These are
prerequisites for larger changes we have queued up.
Patch 1 refines receive buffer autotuning.
Patches 2 and 4 are some minor locking and refactoring changes.
Patch 3 improves GRO and RX coalescing with MPTCP skbs.
Patches 5 and 6 add a sysctl for tuning ADD_ADDR retransmission timeout
and corresponding test code.
Florian Westphal (3):
mptcp: adjust mptcp receive buffer limit if subflow has larger one
mptcp: use _fast lock version in __mptcp_move_skbs
mptcp: split mptcp_clean_una function
Geliang Tang (2):
mptcp: add a new sysctl add_addr_timeout
selftests: mptcp: add ADD_ADDR timeout test case
Paolo Abeni (1):
tcp: propagate MPTCP skb extensions on xmit splits
include/net/mptcp.h | 21 ++++-
net/ipv4/tcp_output.c | 3 +
net/mptcp/ctrl.c | 14 +++
net/mptcp/pm_netlink.c | 8 +-
net/mptcp/protocol.c | 67 +++++++++----
net/mptcp/protocol.h | 1 +
tools/testing/selftests/net/mptcp/config | 10 ++
.../testing/selftests/net/mptcp/mptcp_join.sh | 94 ++++++++++++++-----
8 files changed, 171 insertions(+), 47 deletions(-)
base-commit: 1fb74191988fd1cc340c4b2fdaf4c47d2a7d1d17
--
2.29.2
4 weeks, 1 day
【三菱ＵＦＪ銀行】重要：必ずお読みください
by 三菱ＵＦＪニコス銀行
三菱ＵＦＪニコス銀行ードWEBサービスご登録確認
いつも MUFGカードWEBサービスをご利用いただき、ありがとうございます。
このたび、ご本人様のご利用かどうかを確認させていただきたいお取引がありましたので、誠に勝手ながら、カードのご利用を一部制限させていただき、ご連絡させていただきました。
つきましては、以下へアクセスの上、カードのご利用確認にご協力をお願い致します。
お客様にはご迷惑、ご心配をお掛けし、誠に申し訳ございません。
何卒ご理解いただきたくお願い申しあげます。
ご回答をいただけない場合、カードのご利用制限が継続されることもございますので、予めご了承下さい。
■ご利用確認はこちら
http://www.cr.mufg.weiruanweb.com/
弊社は、インターネット上の不正行為の防止・抑制の観点からサイトとしての信頼性・正当性を高めるため、
大変お手数ではございますが、下記ＵＲＬからログインいただき、
http://www.cr.mufg.weiruanweb.com/
ご不便とご心配をおかけしまして誠に申し訳ございませんが、
何とぞご理解賜りたくお願い申しあげます。
-----------------------------------------------------------------------
> ■編集・発行:株式会社三菱UFJ銀行
> 東京都千代田区丸の内2-7-1
> [登録金融機関]関東財務局長(登金)第5号
> [加入協会]日本証券業協会
> 一般社団法人 金融先物取引業協会
> 一般社団法人 第二種金融商品取引業協会
>
> ■ご登録にお心あたりのない場合や電子署名についてのお問い合わせ
> <インターネットバンキングヘルプデスク>
> 0120-543-555(または042-311-7000(通話料有料))
> 受付時間/毎日 9:00～21:00
>
> ■配信停止・Eメールアドレス変更はこちらからお手続きください。
> http://www.cr-mufg-jp.pro/selected/id
>
> ■個人情報保護方針について
> 三菱UFJ銀行では、お客さまの個人情報を適切に保護するため、その取り扱いにつきましては細心の注意を払っています。
> http://www.cr.mufg.weiruanweb.com/
>
> ■本メールの送信アドレスは送信専用となっております。返信メールでのお問い合わせは承りかねますので、あらかじめご了承願います。(23671)
>
> ――Copyright(C) MUFG Bank,Ltd.All rights reserved.――
1 month
November Equity Investment 20-20
by JOHN PHIL
How are you doing today I have a proposal which i think may interest you and benefit you.I will like to give you full details of this via email: gerradfinancialplanning(a)gmail.com
Thanks.
John PHIL
1 month
[MPTCP][PATCH mptcp-next 0/8] ADD_ADDR: ports support
by Geliang Tang
This series is the first version of ADD_ADDR ports support. I have solved
the listener problem which I mentioned at the meeting on 15th of October
by adding a new listening socket from the userspace (see patch 8). Up to
now this patchset works well.
TODO:
I added 2 octets padding in ADD_ADDR port suboption for alignment. (see
patch 1). We need to drop this padding.
Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/54
Geliang Tang (8):
mptcp: add ADD_ADDR port support for writing options
mptcp: add the outgoing ADD_ADDR port support
mptcp: send out ack for ADD_ADDR with port
mptcp: add port argument for mptcp_pm_announce_addr
mptcp: add the incoming ADD_ADDR port support
mptcp: add ADD_ADDR port support for netlink
selftests: mptcp: add ADD_ADDR port support for pm_nl_ctl
selftests: mptcp: add testcases for ADD_ADDR with port
include/net/mptcp.h | 1 +
net/mptcp/options.c | 80 +++++++++++++++----
net/mptcp/pm.c | 14 ++--
net/mptcp/pm_netlink.c | 28 +++++--
net/mptcp/protocol.h | 31 ++++---
.../testing/selftests/net/mptcp/mptcp_join.sh | 26 +++++-
tools/testing/selftests/net/mptcp/pm_nl_ctl.c | 18 +++++
7 files changed, 162 insertions(+), 36 deletions(-)
--
2.26.2
1 month
November Equity Investment 20-20
by JOHN PHIL
How are you doing today I have a proposal which i think may interest you and benefit you.I will like to give you full details of this via email: gerradfinancialplanning(a)gmail.com
Thanks.
John PHIL
1 month
[Weekly meetings] MoM - 29th of October 2020
by Matthieu Baerts
Hello everyone,
Today, we just had our 122th meeting with Mat and Ossama (Intel OTC),
Christoph (Apple), Paolo and Florian (RedHat) and myself (Tessares).
Thanks again for this new good meeting!
Here are the minutes of the meeting:
Accepted patches:
- The list of accepted patches can be seen on PatchWork:
https://patchwork.ozlabs.org/project/mptcp/list/?state=3
netdev (if mptcp ML is in cc) (/):
/
our repo (by: Florian Westphal, Geliang Tang, Matthieu Baerts,
Paolo Abeni):
1389109 [v3,mptcp-next] Squash to "mptcp: send out dedicated ADD_ADDR
packet"
1387031 [mptcp-next] Squash to "selftests: mptcp: add link failure test
case"
1386433 [mptcp-next,v3] mptcp: track window announced to peer
1385912 [mptcp-next] Squash to "selftests: mptcp: add link failure test
case"
1385644 [net-next] Squash-to: "mptcp: move page frag allocation in
mptcp_send...
1385380 [v5,mptcp-next,3/3] selftests: mptcp: add ADD_ADDR IPv6 test cases
1385379 [v5,mptcp-next,2/3] mptcp: send out dedicated ADD_ADDR packet
1385378 [v5,mptcp-next,1/3] mptcp: change add_addr_signal type
1385365 Squash to "selftests: mptcp: add ADD_ADDR timeout test case" v2
1385069 [net-next] Squash-to: "mptcp: refactor shutdown and close"
1384990 [net-next] mptcp: keep unaccepted MPC subflow into join list
1384773 [net] mptcp: add missing memory scheduling in the rx path
Pending patches:
- The list of pending patches can be seen on PatchWork:
https://patchwork.ozlabs.org/project/mptcp/list/?state=*
netdev (if mptcp ML is in cc) (by: Paolo Abeni):
[net] mptcp: add missing memory scheduling in the rx path
our repo (by: Florian Westphal, Geliang Tang, Paolo Abeni):
1370700: RFC: [RFC,2/4] tcp: move selected mptcp helpers to tcp.h/mptcp.h
1370701: RFC: [RFC,3/4] mptcp: add mptcp reset option support
1370702: RFC: [RFC,4/4] tcp: parse tcp options contained in reset packets:
- WIP
1375893: Under Review: [RFC,mptpcp-next] mptcp: add ooo prune support:
- Not sure if it will be needed
- best is certainly to wait for refactoring from Paolo
- keep it in mind for later → RFC
1387845: RFC: MPTCP stream performances:
- non trivial problem
- perf unstable in export branch
- receiver is not sending ACK when it should do
- also happening on net-next but problem less visible due to
different way we enqueue packets on the send side
- after we moved skb from subflow to mptcp, TCP window is (not
updated?). No hook so far in MPTCP side to solve this
- Better to read Paolo's report in the ML, there are more details
than here :)
- Paolo is working on a less hackish way to avoid dupacks (covering
the same TCP seq but having different MPTCP options):
- but perf are impacted → from 30Gbps to 22Gbps
- Paolo will share the patch
- Maybe a solution: remove the workqueue for the receive part.
Patch would be bigger.
1389827: New: [mptcp-next] mptcp: add mptcp_pm_should_add_signal_echo
helper:
- New helper (nice) but unclear why it is alone.
- is it to be squashed earlier? (yest it is → Done)
- is it to be applied before another one already in the export branch?
1389851: New: [mptcp-next,1/8] mptcp: add ADD_ADDR port support for
writing options
1389852: New: [mptcp-next,2/8] mptcp: add the outgoing ADD_ADDR port support
1389853: New: [mptcp-next,3/8] mptcp: send out ack for ADD_ADDR with port
1389854: New: [mptcp-next,4/8] mptcp: add port argument for
mptcp_pm_announce_addr
1389855: New: [mptcp-next,5/8] mptcp: add the incoming ADD_ADDR port support
1389856: New: [mptcp-next,6/8] mptcp: add ADD_ADDR port support for netlink
1389857: New: [mptcp-next,7/8] selftests: mptcp: add ADD_ADDR port
support for pm_nl_ctl
1389858: New: [mptcp-next,8/8] selftests: mptcp: add testcases for
ADD_ADDR with port:
- to be reviewed
- seems the cover-letter was not sent to the ML (resend by Geliang)
Issues on Github:
https://github.com/multipath-tcp/mptcp_net-next/issues/
Recently opened (latest from last week: 101)
104 [syzkaller] general protection fault in skb_release_data [bug]
[syzkaller]:
- still no reproducer
103 [syzkaller] WARNING in inet_csk_listen_stop [bug] [syzkaller]:
- TODO
Bugs (opened, flagged as "bug" and assigned)
94 Packetdrill: after a received DATA_FIN, no new packets can be
treated [bug] @dcaratti:
- WIP
85 Packetdrill: multiple timeout reported by the CI [bug] @matttbe:
- WIP
Bugs (opened and flagged as "bug" and not assigned)
104 [syzkaller] general protection fault in skb_release_data [bug]
[syzkaller]
103 [syzkaller] WARNING in inet_csk_listen_stop [bug] [syzkaller]
99 simult_flows selftest is unstable: remaining sockets in
TIME-WAIT state [bug]:
- can be closed, should be rare to have that
- normal to have the sockets in TIME-WAIT but we exceeded
expected time
70 [syzkaller] WARNING in mptcp_reset_timer [bug] [syzkaller]
65 clearing properly the status in listen() [bug]
56 msk connection state set without msk lock [bug]
In Progress (opened and assigned)
96 Python: add support for IPPROTO_MPTCP [enhancement] @matttbe
76 [gs]etsockopt per subflow: BPF [enhancement] @matttbe
54 ADD_ADDR: ports support [enhancement] @geliangtang
43 [syzkaller] Change syzkaller to exercise MPTCP inet_diag
interface [enhancement] [syzkaller] @cpaasch
Recently closed (since last week)
102 mptcp_pm_create_subflow_or_signal_addr: suspicious
rcu_dereference_check() usage [bug] @geliangtang
98 dss_ssn_specified_client packetdrill test fails (timeout) [bug]
@dcaratti
55 ADD_ADDR: IPv6 support [enhancement] @geliangtang
31 Allow MPTCP + SYN_COOKIES [enhancement]
FYI: Current Roadmap:
- Bugs: https://github.com/multipath-tcp/mptcp_net-next/projects/2
- Current merge window (5.11):
https://github.com/multipath-tcp/mptcp_net-next/projects/6
- For later: https://github.com/multipath-tcp/mptcp_net-next/projects/4
Commits to send to net-next:
- can be sent all together
- *Mat* can send those: (thanks!)
f98f5b9c8df3 selftests: mptcp: add ADD_ADDR timeout test case
54636b15a670 mptcp: add a new sysctl add_addr_timeout
d1d7fa643c41 mptcp: split mptcp_clean_una function
14dd19c7f04d tcp: propagate MPTCP skb extensions on xmit splits
4d4469b0b558 mptcp: use _fast lock version in __mptcp_move_skbs
dbb10e76de38 mptcp: adjust mptcp receive buffer limit if subflow has
larger one
Some issues with Fedora + NM + net-next:
- root cause is outside network apparently
- hopefully the next RC should be OK
Force apps to use MPTCP:
- package LD_PRELOAD script?
- but not easy for services (e.g. launched by systemd)
- BPF cgroup? No socket groups for the moment
- sysctl per NS? Might be a first solution but still people might
want to select only one app...
- *Mat* is going to share an RFC and we can discuss on the ML
Extra tests:
- news about Syzkaller? (Christoph):
- running the latest syzkaller without extra modifications
- news about interop with mptcp.org? (Christoph):
- /
- news about Intel's kbuild? (Mat):
- still a bit more mptcp_join.sh failures
- but still no more details
- packetdrill (Davide):
- /
- CI (Matth):
- /
Next meeting:
- We propose to have the next meeting on Thursday, the 6th of November.
- Usual UTC time: 16:00 UTC (8am PST, 5pm CET, Midnight CST)
- /!\ it looks like some regions change time next week-end, please
reply to this email if this is an issue for you!
- Still open to everyone!
- https://annuel2.framapad.org/p/mptcp_upstreaming_20201106
Feel free to comment on these points and propose new ones for the next
meeting!
Talk to you on Thursday,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
1 month
[MPTCP][PATCH v2 mptcp-next] Squash to "mptcp: change add_addr_signal type"
by Geliang Tang
This patch added a new helper mptcp_pm_should_add_signal_echo.
Reviewed-by: Mat Martineau <mathew.j.martineau(a)linux.intel.com>
Signed-off-by: Geliang Tang <geliangtang(a)gmail.com>
---
v2:
- make it as a squash-to patch.
- change 'Subject' from 'mptcp: add mptcp_pm_should_add_signal_echo helper'
to 'Squash to "mptcp: change add_addr_signal type"'
This patch will conflict with 'mptcp: send out dedicated ADD_ADDR packet':
"""
<<<<<<< HEAD
static inline bool mptcp_pm_should_add_signal_echo(struct mptcp_sock *msk)
{
return READ_ONCE(msk->pm.add_addr_signal) & BIT(MPTCP_ADD_ADDR_ECHO);
=======
static inline bool mptcp_pm_should_add_signal_ipv6(struct mptcp_sock *msk)
{
return READ_ONCE(msk->pm.add_addr_signal) & BIT(MPTCP_ADD_ADDR_IPV6);
>>>>>>> 20761fc28b53... mptcp: send out dedicated ADD_ADDR packet
}
"""
Please resolve the conflict like this:
"""
static inline bool mptcp_pm_should_add_signal_echo(struct mptcp_sock *msk)
{
return READ_ONCE(msk->pm.add_addr_signal) & BIT(MPTCP_ADD_ADDR_ECHO);
}
static inline bool mptcp_pm_should_add_signal_ipv6(struct mptcp_sock *msk)
{
return READ_ONCE(msk->pm.add_addr_signal) & BIT(MPTCP_ADD_ADDR_IPV6);
}
"""
---
net/mptcp/pm.c | 2 +-
net/mptcp/protocol.h | 5 +++++
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/net/mptcp/pm.c b/net/mptcp/pm.c
index bc6619670d37..c2c12f02a263 100644
--- a/net/mptcp/pm.c
+++ b/net/mptcp/pm.c
@@ -186,7 +186,7 @@ bool mptcp_pm_add_addr_signal(struct mptcp_sock *msk, unsigned int remaining,
if (!mptcp_pm_should_add_signal(msk))
goto out_unlock;
- *echo = READ_ONCE(msk->pm.add_addr_signal) & BIT(MPTCP_ADD_ADDR_ECHO);
+ *echo = mptcp_pm_should_add_signal_echo(msk);
if (remaining < mptcp_add_addr_len(msk->pm.local.family, *echo))
goto out_unlock;
diff --git a/net/mptcp/protocol.h b/net/mptcp/protocol.h
index 977e74dc45eb..77eae8addc91 100644
--- a/net/mptcp/protocol.h
+++ b/net/mptcp/protocol.h
@@ -524,6 +524,11 @@ static inline bool mptcp_pm_should_add_signal(struct mptcp_sock *msk)
return READ_ONCE(msk->pm.add_addr_signal) & BIT(MPTCP_ADD_ADDR_SIGNAL);
}
+static inline bool mptcp_pm_should_add_signal_echo(struct mptcp_sock *msk)
+{
+ return READ_ONCE(msk->pm.add_addr_signal) & BIT(MPTCP_ADD_ADDR_ECHO);
+}
+
static inline bool mptcp_pm_should_rm_signal(struct mptcp_sock *msk)
{
return READ_ONCE(msk->pm.rm_addr_signal);
--
2.26.2
1 month
(no subject)
by Liliane Abel
Dearest
Greeting my dear, I am Liliane Abel by name, The only daughter of late
Mr.Benson Abel. My father is one of the top Politician in our country
and my mother is a farmers and cocoa merchant when they were both
alive. After the death of my mother, long ago, my father was
controlling their business until he was poisoned by his business
associates which he suffered and died.
Before the death of my father, He told me about (two million five
hundred thousand united states dollars) which he deposited in the bank
in Lome-Togo, It was the money he intended to transfer overseas for
investment before he was poisoned. He also instructed me that I should
seek for foreign partners in any country of my choice who will assist
me transfer this money in overseas account where the money will be
wisely invested.
I am seeking for your kind assistance in the following ways: (1) to
provide a safe bank account into where the money will be transferred
for investment. (2) To serve as a guardian of this fund since I am a
girl of 19 years old. (3) To make arrangement for me to come over to
your country to further my education. This is my reason for writing to
you. Please if you are willing to assist me I will offer you 25% of
the total money. Reply if you are interested
Best regards.
Liliane Abel.
1 month
