On 10/29/19 11:58 AM, Jonah Brüchert wrote:
first of all, thanks for the review!
The current structure of the commits is purely for historical reasons,
since this is a collection of patches by different people that are all
required for the Qt5 port. The Signed-off-by exist for the same reason,
because the people who originally did the affected patches used them.
Right, but this is sort of irrelevant for phonesim repo itself. I'm
fine upgrading to Qt5, but lets structure the commits properly in a
If you want I can squash them together and group the changes into a
commit by content, not by author.
That would be preferred. And if you feel obliged to, feel free to make
use of Co-Authored-By tags. I'm fine accepting those.