[PATCH 1/3] pcie: Fix missing braces around feature_is_UAFU()
by Jia Zhang
This commit resolves the following build warning.
opae-intel-fpga-driver/drivers/fpga/intel/pcie.c: In function ‘parse_feature_afus’:
opae-intel-fpga-driver/drivers/fpga/intel/pcie.c:886:3: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
if (feature_is_UAFU(binfo))
^~
opae-intel-fpga-driver/drivers/fpga/intel/pcie.c:888:4: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
if (ret)
^~
Assuming a non-AFU feature is enumerated, it might be wrongly handled
and then causes parse_feature_afus() returns an error.
Signed-off-by: Jia Zhang <zhang.jia(a)linux.alibaba.com>
---
drivers/fpga/intel/pcie.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/fpga/intel/pcie.c b/drivers/fpga/intel/pcie.c
index f4f3d70..a84d8a0 100644
--- a/drivers/fpga/intel/pcie.c
+++ b/drivers/fpga/intel/pcie.c
@@ -883,10 +883,11 @@ static int parse_feature_afus(struct build_feature_devs_info *binfo,
afu_hdr = (struct feature_afu_header *) (hdr + 1);
header.csr = readq(&afu_hdr->csr);
- if (feature_is_UAFU(binfo))
+ if (feature_is_UAFU(binfo)) {
ret = parse_feature_port_uafu(binfo, hdr);
if (ret)
return ret;
+ }
if (!header.next_afu)
break;
--
2.12.2
3 years, 9 months