[PATCH] qmi: remove request when it timeouts

Christophe Ronco c.ronco at kerlink.fr
Thu Oct 26 05:44:33 PDT 2017


Patch proposed to solve problem seen by Eswaran Vinothkumar in thread: Ofono 1.21 crashes with Sierra MC7455.
Tested by Jonas Bonn on his setup.

On my side, I did that to solve an Ofono crash seen with this setup:
 - huawei E3372 USB key plugged
 - MC7304

I stop Ofono, power off and on both modems and restart Ofono immediately. Sometimes I see an Ofono crash.

Here is the result of the debug I made:
When sierra modem reappears, Ofono will ask Modem which service it supports. Usually modem answers quickly.

>From traces, here is what happened:
 - Sep 26 14:11:56: modem asks the list of supported services
 - Sep 26 14:12:01: no answer after 5s, modem asks the list of supported services again
 - Sep 26 14:12:03: modem replies to request sent at Sep 26 14:11:56. Ofono crashes during message treatment

Problem is that when a timeout occurs for this type of request, part of the data is released. When answer arrives, this data is used.

I still have the corresponding trace but I don't think it will be very useful.

Christophe

Christophe Ronco (1):
  qmi: remove request when it timeouts

 drivers/qmimodem/qmi.c | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

-- 
2.7.4



More information about the ofono mailing list